The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to max in gov.usgs.volcanoes.winston.Channel.toPV2String(int) | STYLE | DLS_DEAD_LOCAL_STORE | 348 | Medium |
| Dead store to min in gov.usgs.volcanoes.winston.Channel.toPV2String(int) | STYLE | DLS_DEAD_LOCAL_STORE | 347 | Medium |
| gov.usgs.volcanoes.winston.Channel defines compareTo(Channel) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 457-466 | Medium |
| gov.usgs.volcanoes.winston.Channel.getGroupString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 308 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.Instrument.NULL isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 21 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.PlotHelicorder.parseArgs() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 225 | Low |
| new gov.usgs.volcanoes.winston.PlotHelicorder(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 66 | Medium |
| gov.usgs.volcanoes.winston.PlotHelicorder.error(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 208 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.PlotHelicorder$Settings be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 174-197 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to lastWriteFuture in gov.usgs.volcanoes.winston.WWSClient.sendRequest(String, WWSCommandHandler) | STYLE | DLS_DEAD_LOCAL_STORE | 91 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.WWSClient.getChannels(boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 340 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.WWSClient.getHelicorder(Scnl, TimeSpan, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 221 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.WWSClient.getRSAMData(Scnl, TimeSpan, int, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 135 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.WWSClient.getWave(Scnl, TimeSpan, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 179 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.WWSClient$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 77-81 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newLine in gov.usgs.volcanoes.winston.client.ClientUtils.readResponseHeader(ByteBuf) | STYLE | DLS_DEAD_LOCAL_STORE | 23 | Medium |
| Found reliance on default encoding in gov.usgs.volcanoes.winston.client.ClientUtils.readResponseHeader(ByteBuf): java.io.ByteArrayOutputStream.toString() | I18N | DM_DEFAULT_ENCODING | 25 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ch in gov.usgs.volcanoes.winston.db.Admin.deleteChannels(String, long) | STYLE | DLS_DEAD_LOCAL_STORE | 284 | Medium |
| gov.usgs.volcanoes.winston.db.Admin.printUsage(int, String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 179 | Low |
| gov.usgs.volcanoes.winston.db.Admin.checkTable(String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 237 | Medium |
| gov.usgs.volcanoes.winston.db.Admin.repairChannel(String, String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 437 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Admin.deleteChannels(String, long) | STYLE | REC_CATCH_EXCEPTION | 286 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Admin.main(String[]) | STYLE | REC_CATCH_EXCEPTION | 105 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Admin.purgeChannels(String, int, long) | STYLE | REC_CATCH_EXCEPTION | 400 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Admin.repairChannel(String, String) | STYLE | REC_CATCH_EXCEPTION | 468 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Admin.repairTable(String, String) | STYLE | REC_CATCH_EXCEPTION | 500 | Low |
| gov.usgs.volcanoes.winston.db.Admin.doDeleteChannel(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 313 | High |
| gov.usgs.volcanoes.winston.db.Admin.checkTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 237 | Low |
| gov.usgs.volcanoes.winston.db.Admin.deleteWinston() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 300 | Low |
| gov.usgs.volcanoes.winston.db.Admin.repairChannel(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 437 | Low |
| gov.usgs.volcanoes.winston.db.Admin.repairTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 491 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Channels.updateInstrument(Instrument) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 370 | Medium |
| gov.usgs.volcanoes.winston.db.Channels.channelExists(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 285 | Medium |
| gov.usgs.volcanoes.winston.db.Channels.getChannelCode(int) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 261 | Medium |
| gov.usgs.volcanoes.winston.db.Channels.getChannelID(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 183 | Medium |
| gov.usgs.volcanoes.winston.db.Channels.getInstrumentId(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 235 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.channelExists(String) | STYLE | REC_CATCH_EXCEPTION | 290 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.createChannel(String) | STYLE | REC_CATCH_EXCEPTION | 321 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.getChannelCode(int) | STYLE | REC_CATCH_EXCEPTION | 267 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.getChannelCodes(String) | STYLE | REC_CATCH_EXCEPTION | 216 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.getChannels(boolean) | STYLE | REC_CATCH_EXCEPTION | 164 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.getGroupNodes() | STYLE | REC_CATCH_EXCEPTION | 66 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Channels.getInstruments() | STYLE | REC_CATCH_EXCEPTION | 407 | Low |
| gov.usgs.volcanoes.winston.db.Channels.channelExists(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 285 | High |
| gov.usgs.volcanoes.winston.db.Channels.createChannel(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 318 | High |
| gov.usgs.volcanoes.winston.db.Channels.getChannelID(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 183 | High |
| gov.usgs.volcanoes.winston.db.Channels.getInstrumentId(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 235 | High |
| gov.usgs.volcanoes.winston.db.Channels.createChannel(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 316 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.db.Channels$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 93-97 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in gov.usgs.volcanoes.winston.db.Data.getNumSamples(double, double, double) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 350 | Medium |
| Dead store to epsilon in gov.usgs.volcanoes.winston.db.Data.findGaps(String, double, double) | STYLE | DLS_DEAD_LOCAL_STORE | 168 | Medium |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.db.Data.getDownsamplingSQL(String, double, DownsamplingType, int) | I18N | DM_CONVERT_CASE | 567 | Low |
| gov.usgs.volcanoes.winston.db.Data.getNumSamples(double, double, double) invokes inefficient new Double(double) constructor; use Double.valueOf(double) instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 350 | Low |
| gov.usgs.volcanoes.winston.db.Data.findGaps(String, double, double) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 148 | Medium |
| gov.usgs.volcanoes.winston.db.Data.getTimeSpan(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 65 | Medium |
| Should gov.usgs.volcanoes.winston.db.Data.getTimeSpan(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 63 | Low |
| Redundant nullcheck of bufs, which is known to be non-null in gov.usgs.volcanoes.winston.db.Data.findGaps(String, double, double) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 162 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Data.findGaps(String, double, double) | STYLE | REC_CATCH_EXCEPTION | 197 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Data.getRSAMData(String, double, double, int, DownsamplingType, int) | STYLE | REC_CATCH_EXCEPTION | 511 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Data.getTraceBufs(String, double, double, int) | STYLE | REC_CATCH_EXCEPTION | 365 | Low |
| gov.usgs.volcanoes.winston.db.Data.getDownsamplingSQL(String, double, DownsamplingType, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 573 | Medium |
| gov.usgs.volcanoes.winston.db.Data.getTimeSpan(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 65 | High |
| gov.usgs.volcanoes.winston.db.Data.findGaps(String, double, double) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 148 | Low |
| gov.usgs.volcanoes.winston.db.Data.getRSAMData(String, double, double, int, DownsamplingType, int) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 524 | Low |
| gov.usgs.volcanoes.winston.db.Data.getTraceBufBytes(String, double, double, int) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 305 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Data.getHelicorderData(String, double, double, int) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 441 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Data.getTraceBufBytes(String, double, double, int) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 273 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Deriver.processConfigFile() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 72 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Export.export(String, String, double, double) | STYLE | REC_CATCH_EXCEPTION | 63 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Input.calculateSpan(String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 153 | Medium |
| gov.usgs.volcanoes.winston.db.Input.checkTable(String, String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 185 | Medium |
| gov.usgs.volcanoes.winston.db.Input.getDayTables(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 241 | Medium |
| gov.usgs.volcanoes.winston.db.Input.purgeTables(String, int, Admin) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 577 | Medium |
| gov.usgs.volcanoes.winston.db.Input.tableExists(String, String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 656 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.calculateSpan(String) | STYLE | REC_CATCH_EXCEPTION | 162 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.checkTable(String, String) | STYLE | REC_CATCH_EXCEPTION | 193 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.createDayTable(String, String) | STYLE | REC_CATCH_EXCEPTION | 212 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.createTable(String, String) | STYLE | REC_CATCH_EXCEPTION | 229 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.getDayTables(String) | STYLE | REC_CATCH_EXCEPTION | 257 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf, boolean) | STYLE | REC_CATCH_EXCEPTION | 510 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.purgeTables(String, int, Admin) | STYLE | REC_CATCH_EXCEPTION | 570 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Input.tableExists(String, String) | STYLE | REC_CATCH_EXCEPTION | 664 | Low |
| gov.usgs.volcanoes.winston.db.Input.setTimeSpan(String, double, double) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 626 | High |
| gov.usgs.volcanoes.winston.db.Input.createDayTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 201 | Medium |
| gov.usgs.volcanoes.winston.db.Input.createTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 220 | Medium |
| gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 300 | Medium |
| gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf, boolean) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 473 | Medium |
| gov.usgs.volcanoes.winston.db.Input.calculateSpan(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 153 | Low |
| gov.usgs.volcanoes.winston.db.Input.checkTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 185 | Low |
| gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf, boolean) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 418 | Low |
| gov.usgs.volcanoes.winston.db.Input.purgeTables(String, int, Admin) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 577 | Low |
| gov.usgs.volcanoes.winston.db.Input.tableExists(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 656 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 304 | Medium |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Input.inputTraceBuf(TraceBuf, boolean) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 422 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.db.Input$ChannelInputOptimizer be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 44-70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Test for floating point equality in gov.usgs.volcanoes.winston.db.InputEW.inputTraceBufs(List, boolean, int, int) | STYLE | FE_FLOATING_POINT_EQUALITY | 511 | Low |
| gov.usgs.volcanoes.winston.db.InputEW.getSid(String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 309 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.tableExists(String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 696 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.getDayTables(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 173 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.getHelicorderRow(String, double, boolean) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 228 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.getTimeSpan(String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 334 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.purgeTables(String, int) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 569 | Medium |
| Should gov.usgs.volcanoes.winston.db.InputEW.getTimeSpan(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 347 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.InputEW.createDayTable(String, String) | STYLE | REC_CATCH_EXCEPTION | 164 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.InputEW.purgeTables(String, int) | STYLE | REC_CATCH_EXCEPTION | 562 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.InputEW.tableExists(String) | STYLE | REC_CATCH_EXCEPTION | 703 | Low |
| gov.usgs.volcanoes.winston.db.InputEW.getSid(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 309 | High |
| gov.usgs.volcanoes.winston.db.InputEW.getTimeSpan(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 334 | High |
| gov.usgs.volcanoes.winston.db.InputEW.setTimeSpan(String, double, double) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 658 | High |
| gov.usgs.volcanoes.winston.db.InputEW.tableExists(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 696 | High |
| gov.usgs.volcanoes.winston.db.InputEW.createDayTable(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 131 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.getHelicorderRow(String, double, boolean) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 228 | Low |
| gov.usgs.volcanoes.winston.db.InputEW.purgeTables(String, int) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 569 | Low |
| gov.usgs.volcanoes.winston.db.InputEW.writeHelicorderData(String, Set) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 795 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.InputEW.getInputStatement(String, TraceBuf) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 259 | Low |
| Write to static field gov.usgs.volcanoes.winston.db.InputEW.channelTimeSpans from instance method new gov.usgs.volcanoes.winston.db.InputEW(WinstonDatabase) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 101 | Medium |
| Write to static field gov.usgs.volcanoes.winston.db.InputEW.checkTableCache from instance method new gov.usgs.volcanoes.winston.db.InputEW(WinstonDatabase) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 98 | Medium |
| gov.usgs.volcanoes.winston.db.InputEW.inputMetadata(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 377 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Merge.mergeWaves(String, String) invokes inefficient new Double(double) constructor; use Double.valueOf(double) instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 122 | Low |
| gov.usgs.volcanoes.winston.db.Merge.mergeHelicorders(String, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 65 | Medium |
| gov.usgs.volcanoes.winston.db.Merge.mergeHelicorders(String, String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 72 | Medium |
| gov.usgs.volcanoes.winston.db.Merge.mergeWaves(String, String) may fail to close PreparedStatement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 129 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Merge.mergeHelicorders(String, String) | STYLE | REC_CATCH_EXCEPTION | 96 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.Merge.mergeWaves(String, String) | STYLE | REC_CATCH_EXCEPTION | 153 | Low |
| gov.usgs.volcanoes.winston.db.Merge.mergeHelicorders(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 51 | Low |
| gov.usgs.volcanoes.winston.db.Merge.mergeWaves(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 108 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Merge.mergeHelicorders(String, String) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 72 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.Merge.mergeWaves(String, String) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 129 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Upgrade$Upgrader1_0_0to1_0_1.upgrade() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 157 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.Upgrade$Upgrader1_0_1to1_1_0.upgrade() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 110 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.WaveServerEmulator.getWaveServerRaw(String, String, String, String, double, double) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 219 | Medium |
| gov.usgs.volcanoes.winston.db.WaveServerEmulator.getWaveServerMenuItem(int, double, double) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 131 | Medium |
| Should gov.usgs.volcanoes.winston.db.WaveServerEmulator.getWaveServerRaw(String, String, String, String, double, double) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 193 | Low |
| Redundant nullcheck of ts, which is known to be non-null in gov.usgs.volcanoes.winston.db.WaveServerEmulator.getWaveServerMenu(boolean, double, double, double) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 105 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.WinstonDatabase.connect() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 90 | Medium |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.getSchemaVersion() may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 151 | Medium |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.tableExists(String, String) may fail to clean up java.sql.ResultSet on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 316 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.WinstonDatabase.checkDatabase() | STYLE | REC_CATCH_EXCEPTION | 298 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.WinstonDatabase.createTables() | STYLE | REC_CATCH_EXCEPTION | 258 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.db.WinstonDatabase.tableExists(String, String) | STYLE | REC_CATCH_EXCEPTION | 321 | Low |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.checkDatabase() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 297 | Low |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.createTables() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 219 | Low |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.tableExists(String, String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 316 | Low |
| gov.usgs.volcanoes.winston.db.WinstonDatabase.useDatabase(String) passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 274 | Low |
| A prepared statement is generated from a nonconstant String in gov.usgs.volcanoes.winston.db.WinstonDatabase.getPreparedStatement(String) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 330 | Low |
| Private method gov.usgs.volcanoes.winston.db.WinstonDatabase.execute(String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 162-187 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.WinstonDatabase$2.attempt() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 175 | Medium |
| gov.usgs.volcanoes.winston.db.WinstonDatabase$2.attempt() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 174 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.db.WinstonDatabase$3.attempt() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 203 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.in.ImportSAC.readFile(String) | STYLE | REC_CATCH_EXCEPTION | 46 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.ImportSeed.getArguments(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 99 | Low |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.ImportSeed.main(String[]) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 110 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.ImportSeisan.getArguments(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 122 | Low |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.ImportSeisan.main(String[]) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.StaticImporter.setupWinston() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 62 | Medium |
| gov.usgs.volcanoes.winston.in.StaticImporter.process(List, StaticImporter) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 125 | Low |
| gov.usgs.volcanoes.winston.in.StaticImporter.instructions isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 | High |
| gov.usgs.volcanoes.winston.in.StaticImporter.db isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available | Low |
| gov.usgs.volcanoes.winston.in.StaticImporter.driver isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available | Low |
| gov.usgs.volcanoes.winston.in.StaticImporter.url isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | Not available | Low |
| Redundant nullcheck of java.io.File.getName(), which is known to be non-null in gov.usgs.volcanoes.winston.in.StaticImporter.process(List, StaticImporter) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 142 | Low |
| Unread public/protected field: gov.usgs.volcanoes.winston.in.StaticImporter.data | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 66 | Medium |
| Unused public or protected field: gov.usgs.volcanoes.winston.in.StaticImporter.db | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Not available | Medium |
| Unused public or protected field: gov.usgs.volcanoes.winston.in.StaticImporter.driver | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Not available | Medium |
| Unused public or protected field: gov.usgs.volcanoes.winston.in.StaticImporter.url | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Not available | Medium |
| StaticImporter.channels not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 79 | Low |
| StaticImporter.input not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 112 | Low |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 119 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 86 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 84 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.in.StaticImporter.processArguments(Arguments) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 168 | Medium |
| gov.usgs.volcanoes.winston.in.StaticImporter.importMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.WaveServerCollector.run() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 169 | Low |
| Result of integer multiplication cast to long in gov.usgs.volcanoes.winston.in.WaveServerCollector.run() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 168 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.ew.ImportEW.consoleInputManager(ImportEW) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 958 | Medium |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.run() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 747 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.in.ew.ImportEW.consoleInputManager(ImportEW) | I18N | DM_CONVERT_CASE | 931 | Low |
| Found reliance on default encoding in gov.usgs.volcanoes.winston.in.ew.ImportEW.consoleInputManager(ImportEW): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 919 | High |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.fatalError(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 232 | Medium |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.consoleInputManager(ImportEW) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 941 | Low |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.getArguments(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 889 | Low |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.JSAP_EXPLANATION_PREFACE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 95 | High |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.JSAP_PROGRAM_NAME isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 94 | High |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.in.ew.ImportEW.processFilters() | STYLE | REC_CATCH_EXCEPTION | 408 | Low |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in gov.usgs.volcanoes.winston.in.ew.ImportEW.importChannel(ConcurrentLinkedQueue) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 635 | Low |
| Switch statement found in gov.usgs.volcanoes.winston.in.ew.ImportEW.importChannel(ConcurrentLinkedQueue) where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 649-651 | Medium |
| gov.usgs.volcanoes.winston.in.ew.ImportEW.cycle(boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 521 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.in.ew.ImportEW$2.run() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 546 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from gov.usgs.earthworm.message.Message to gov.usgs.earthworm.message.TraceBuf in gov.usgs.volcanoes.winston.in.ew.ImportEW$TraceBufHandler.messageReceived(Message) | STYLE | BC_UNCONFIRMED_CAST | 463 | Medium |
| Useless control flow in gov.usgs.volcanoes.winston.in.ew.ImportEW$TraceBufHandler.messageReceived(Message) | STYLE | UCF_USELESS_CONTROL_FLOW | 490 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.in.ew.ImportWS.main(String[]) | I18N | DM_CONVERT_CASE | 333 | Low |
| Found reliance on default encoding in gov.usgs.volcanoes.winston.in.ew.ImportWS.main(String[]): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 328 | High |
| gov.usgs.volcanoes.winston.in.ew.ImportWS.parseTimeRange(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 186 | Medium |
| gov.usgs.volcanoes.winston.in.ew.ImportWS.getArguments(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 303 | Low |
| gov.usgs.volcanoes.winston.in.ew.ImportWS.JSAP_EXPLANATION_PREFACE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 85 | High |
| gov.usgs.volcanoes.winston.in.ew.ImportWS.JSAP_PROGRAM_NAME isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 84 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in gov.usgs.volcanoes.winston.in.ew.ImportWSJob.getData(double[]) where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 181-184 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.in.ew.TraceBufFilter.configure(ConfigFile) | I18N | DM_CONVERT_CASE | 42 | Low |
| gov.usgs.volcanoes.winston.in.ew.TraceBufFilter defines compareTo(TraceBufFilter) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 91 | Low |
| Switch statement found in gov.usgs.volcanoes.winston.in.ew.TraceBufFilter.configure(ConfigFile) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 46-54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new gov.usgs.volcanoes.winston.in.metadata.AbstractMetadataImporter(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in gov.usgs.volcanoes.winston.in.metadata.ImportHypoinverse.readMetadata(String): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 39 | High |
| gov.usgs.volcanoes.winston.in.metadata.ImportHypoinverse.readMetadata(String) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 39 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.in.metadata.ImportHypoinverse.readMetadata(String) | STYLE | REC_CATCH_EXCEPTION | 65 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field gov.usgs.volcanoes.winston.legacyServer.ServerHandler.instances from instance method new gov.usgs.volcanoes.winston.legacyServer.ServerHandler(WWS) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.legacyServer.ServerHandler$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 60-63 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.WWS.main(String[]) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 75 | Medium |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.legacyServer.WWS.main(String[]) | I18N | DM_CONVERT_CASE | 54 | Low |
| Found reliance on default encoding in gov.usgs.volcanoes.winston.legacyServer.WWS.main(String[]): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 45 | High |
| gov.usgs.volcanoes.winston.legacyServer.WWS.fatalError(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 150 | Medium |
| Result of integer multiplication cast to long in gov.usgs.volcanoes.winston.legacyServer.WWS.processConfigFile() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 297 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.WWSClient.getProtocolVersion() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 67 | Low |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.legacyServer.WWSClient.getProtocolVersion() | STYLE | REC_CATCH_EXCEPTION | 63 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.getHelicorder(String, String, String, String, double, double, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 197 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.getRSAMData(String, String, String, String, double, double, int, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 254 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.getWave(String, String, String, String, double, double, boolean) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 186 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.outputSac(String, int, Double, Double, String, String, double, double) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 323 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.outputSac(String, int, Double, Double, String, String, double, double) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 329 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.WWSClient.outputSac(String, int, Double, Double, String, String, double, double) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 348 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.WWSCommandString.getDouble(int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 52 | Low |
| gov.usgs.volcanoes.winston.legacyServer.WWSCommandString.getCommandSplits() may expose internal representation by returning WWSCommandString.commandSplits | MALICIOUS_CODE | EI_EXPOSE_REP | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in gov.usgs.volcanoes.winston.legacyServer.cmd.BaseCommand.writeWaveAsAscii(Wave, int, String, String, String, String, String, double, double, String, SocketChannel): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 134 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.GetChannelsCommand.doCommand(Object, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.GetMetadataCommand.getChannelMetadata(WWSCommandString, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 90 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.GetMetadataCommand.getInstrumentMetadata(WWSCommandString, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 61 | Medium |
| gov.usgs.volcanoes.winston.legacyServer.cmd.GetMetadataCommand.appendMap(StringBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to t1 in gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNLRSAMRawCommand.doCommand(Object, SocketChannel) | STYLE | DLS_DEAD_LOCAL_STORE | 36 | Low |
| Dead store to t2 in gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNLRSAMRawCommand.doCommand(Object, SocketChannel) | STYLE | DLS_DEAD_LOCAL_STORE | 37 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNLRawCommand.doCommand(Object, SocketChannel) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 48 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNLRawCommand.doCommand(Object, SocketChannel) | STYLE | REC_CATCH_EXCEPTION | 48 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNRawCommand.doCommand(Object, SocketChannel) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 48 | Medium |
| Exception is caught when Exception is not thrown in gov.usgs.volcanoes.winston.legacyServer.cmd.GetSCNRawCommand.doCommand(Object, SocketChannel) | STYLE | REC_CATCH_EXCEPTION | 48 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.HttpCommand.getCommand(String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.StatusCommand.doCommand(Object, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 55 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.StatusCommand.doCommand(Object, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 51 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.legacyServer.cmd.StatusCommand.doCommand(Object, SocketChannel) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpGapsCommand.now | PERFORMANCE | URF_UNREAD_FIELD | 34 | Medium |
| Unused field: gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpGapsCommand.gap | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to error in gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpHeliCommand.sendResponse() | STYLE | DLS_DEAD_LOCAL_STORE | 142 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to Url in gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpMenuCommand.getUsage(HttpRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 140 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpMenuCommand$1.compare(String[], String[]) incorrectly handles double value | BAD_PRACTICE | CO_COMPARETO_INCORRECT_FLOATING | 121 | Medium |
| The class gov.usgs.volcanoes.winston.legacyServer.cmd.http.HttpMenuCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 108-133 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.FdsnDateFormat is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 19-35 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.command.FdsnUsageCommand.InterfaceDescriptionTemplate doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| The field name gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.command.FdsnUsageCommand.UrlBuillderTemplate doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.command.FdsnWadlCommand.sendResponse() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.constraint.FdsnTimeConstraint.dateStringToDouble(String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to minLength in gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.dataselect.FdsnDataselectQuery.sendData(Channel, OutputStream) | STYLE | DLS_DEAD_LOCAL_STORE | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to stationEnd in gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.station.FdsnStationQuery.generateStationText() | STYLE | DLS_DEAD_LOCAL_STORE | 153 | Low |
| Dead store to stationStart in gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.station.FdsnStationQuery.generateStationText() | STYLE | DLS_DEAD_LOCAL_STORE | 152 | Low |
| Redundant nullcheck of responseXml, which is known to be non-null in gov.usgs.volcanoes.winston.legacyServer.cmd.http.fdsn.station.FdsnStationQuery.sendXml() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 248 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.ConnectionStatistics.printConnections(String) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 168 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.server.ConnectionStatistics$Connection be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 62-93 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.server.WWS.main(String[]) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 103 | Medium |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.server.WWS.main(String[]) | I18N | DM_CONVERT_CASE | 78 | Low |
| gov.usgs.volcanoes.winston.server.WWS.fatalError(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 161 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase() in gov.usgs.volcanoes.winston.server.http.HttpCommandFactory.get(WinstonDatabasePool, String) | I18N | DM_CONVERT_CASE | 95 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.http.HttpCommandHandler$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 158-161 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.server.http.HttpConstants.applyDefaults(Map) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of header, which is known to be non-null in gov.usgs.volcanoes.winston.server.http.cmd.GapsCommand.writeComputer() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 251 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.http.cmd.HeliCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 68-71 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of html, which is known to be non-null in gov.usgs.volcanoes.winston.server.http.cmd.MenuCommand.doCommand(ChannelHandlerContext, FullHttpRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.http.cmd.MenuCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 130-133 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.server.http.cmd.MenuCommand$2.compare(String[], String[]) incorrectly handles double value | BAD_PRACTICE | CO_COMPARETO_INCORRECT_FLOATING | 197 | Medium |
| The class gov.usgs.volcanoes.winston.server.http.cmd.MenuCommand$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 184-209 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.http.cmd.StatusCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 71-74 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to wave in gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.DataselectService.sendChannel(ChannelConstraint, List, WinstonDatabasePool, ChannelHandlerContext) | STYLE | DLS_DEAD_LOCAL_STORE | 133 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.ErrorResponse.status, which is known to be non-null in gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.ErrorResponse.sendError() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.FdsnwsRequest.request | PERFORMANCE | URF_UNREAD_FIELD | 28 | Low |
| Unread public/protected field: gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.FdsnwsRequest.majorVersion | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 32 | Low |
| Unread public/protected field: gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.FdsnwsRequest.method | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 33 | Low |
| Unread public/protected field: gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.FdsnwsRequest.service | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 31 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.TimeConstraint.dateStringToDouble(String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.server.wws.WwsCommandString.getDouble(int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 104 | Low |
| gov.usgs.volcanoes.winston.server.wws.WwsCommandString.getCommandSplits() may expose internal representation by returning WwsCommandString.commandSplits | MALICIOUS_CODE | EI_EXPOSE_REP | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.EwDataRequest$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 46-48 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.EwDataRequest$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 60-62 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.GetChannelsCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.GetMetadataCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 49 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.GetMetadataCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 54 | Medium |
| gov.usgs.volcanoes.winston.server.wws.cmd.GetMetadataCommand.appendMap(StringBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 156 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetMetadataCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 66-69 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetMetadataCommand$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 75-78 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in gov.usgs.volcanoes.winston.server.wws.cmd.GetScnlCommand.doCommand(ChannelHandlerContext, WwsCommandString): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 107 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetScnlCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 76-80 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetScnlHeliRawCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 56-60 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetScnlRawCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 81-85 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetScnlRsamRawCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 56-58 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.GetWaveRawCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 57-61 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of ts, which is known to be non-null in gov.usgs.volcanoes.winston.server.wws.cmd.MenuCommand.generateMenu(List, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 102 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.MenuCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 63-66 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.StatusCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 73 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.StatusCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 59 | Medium |
| Format string should use %n rather than \n in gov.usgs.volcanoes.winston.server.wws.cmd.StatusCommand.doCommand(ChannelHandlerContext, WwsCommandString) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.server.wws.cmd.StatusCommand$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 64-66 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new gov.usgs.volcanoes.winston.tools.TermIO(): new java.io.PrintStream(OutputStream) | I18N | DM_DEFAULT_ENCODING | 59 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.tools.TermIO$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 96-100 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in gov.usgs.volcanoes.winston.tools.TermIO$DocumentOutputStream.write(byte[], int, int): new String(byte[], int, int) | I18N | DM_DEFAULT_ENCODING | 188 | High |
| Should gov.usgs.volcanoes.winston.tools.TermIO$DocumentOutputStream be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 160-199 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field gov.usgs.volcanoes.winston.tools.WinstonTools.application from instance method new gov.usgs.volcanoes.winston.tools.WinstonTools(String[]) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.tools.WinstonToolsMenu$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 28-32 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.tools.WinstonToolsMenu$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 45-49 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.tools.WinstonToolsMenu$3 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 60-63 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.tools.WinstonToolsMenu$4.actionPerformed(ActionEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 71 | Medium |
| The class gov.usgs.volcanoes.winston.tools.WinstonToolsMenu$4 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 69-72 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class gov.usgs.volcanoes.winston.tools.WinstonToolsRunnablePanel$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 16-21 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.AdminPanel defines non-transient non-serializable instance field ug | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| AdminPanel.ug not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.AdminPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 76 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.ExportSACPanel$TimeRangeDocumentListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 191-210 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.ExportSACPanel$TimeRangeOption be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 172-183 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ImportInstrumentLocations.fileP not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportInstrumentLocations.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 97 | Low |
| ImportInstrumentLocations.fileType not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportInstrumentLocations.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 96 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.ImportSACPanel defines non-transient non-serializable instance field is | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| ImportSACPanel.fileP not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportSACPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 94 | Low |
| ImportSACPanel.rsamDeltaF not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportSACPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 91 | Low |
| ImportSACPanel.rsamDurationF not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportSACPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 93 | Low |
| ImportSACPanel.scnlP not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportSACPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 104 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel defines non-transient non-serializable instance field is | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.fileP from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 64 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.importB from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 69 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.rsamDeltaF from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 65 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.rsamDurationF from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportSeedPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 67 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel defines non-transient non-serializable instance field ws | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.port from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 106 | Medium |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.waveServer from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 105 | Medium |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.chunkDelay from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 111 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.chunkSize from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 109 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createChannels from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 114 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.end from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 135 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.explicitB from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 120 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.findGaps from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 115 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.importB from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 150 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.rangeList from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 141 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.relativeB from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 121 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.scnlPanel from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 117 | Low |
| Write to static field gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.start from instance method gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.createFields() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 127 | Low |
| ImportWSPanel.ws not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 184 | Low |
| ImportWSPanel.ws not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel.stop() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 194 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel$TimeRangeDocumentListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 254-273 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel$TimeRangeFocusListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 239-247 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.ImportWSPanel$TimeRangeOption be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 220-231 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.PlotHelicorderPanel$TimeRangeDocumentListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 58-77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should gov.usgs.volcanoes.winston.tools.pannel.PlotHelicorderPanel$TimeRangeOption be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 86-97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.TimePanel defines non-transient non-serializable instance field time | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Observable to gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject in gov.usgs.volcanoes.winston.tools.pannel.TimePanel$EwBox.update(Observable, Object) | STYLE | BC_UNCONFIRMED_CAST | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Observable to gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject in gov.usgs.volcanoes.winston.tools.pannel.TimePanel$InputTimeBox.update(Observable, Object) | STYLE | BC_UNCONFIRMED_CAST | 100 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Observable to gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject in gov.usgs.volcanoes.winston.tools.pannel.TimePanel$J2kBox.update(Observable, Object) | STYLE | BC_UNCONFIRMED_CAST | 141 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Observable to gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject in gov.usgs.volcanoes.winston.tools.pannel.TimePanel$StandardTimeBox.update(Observable, Object) | STYLE | BC_UNCONFIRMED_CAST | 180 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject.setDate(Date) may expose internal representation by storing an externally mutable object into TimePanel$TimeSubject.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 224 | Medium |
| Should gov.usgs.volcanoes.winston.tools.pannel.TimePanel$TimeSubject be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 198-227 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gov.usgs.volcanoes.winston.tools.pannel.WinstonUpgradePanel defines non-transient non-serializable instance field ug | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| WinstonUpgradePanel.ug not initialized in constructor and dereferenced in gov.usgs.volcanoes.winston.tools.pannel.WinstonUpgradePanel.go() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 77 | Low |
