The following document contains the results of PMD 5.3.2.
| Violation | Line |
|---|---|
| Possible God class (WMC=58, ATFD=41, TCC=0.04743083003952569) | 1–468 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| It is somewhat confusing to have a field name matching the declaring class name | 28 |
| It is somewhat confusing to have a field name matching the declaring class name | 28 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 39 |
| Avoid variables with short names like s | 68 |
| Avoid variables with short names like c | 68 |
| Avoid variables with short names like c | 68 |
| Avoid variables with short names like s | 68 |
| Avoid using if...else statements without curly braces | 77 |
| Avoid using if...else statements without curly braces | 79 |
| Avoid using Literals in Conditional Statements | 81 |
| Avoid using if...else statements without curly braces | 82 |
| Avoid using if...else statements without curly braces | 84 |
| Avoid using Literals in Conditional Statements | 86 |
| Avoid using if...else statements without curly braces | 87 |
| Avoid using if...else statements without curly braces | 89 |
| Avoid using Literals in Conditional Statements | 91 |
| Avoid using if...else statements without curly braces | 92 |
| Avoid using if...else statements without curly braces | 94 |
| Avoid variables with short names like rs | 105 |
| Avoid variables with short names like rs | 105 |
| publicMethodCommentRequirement Required | 109–153 |
| Parameter 'aparentRetention' is not assigned and could be declared final | 109 |
| Avoid variables with short names like rs | 109 |
| Avoid variables with short names like rs | 109 |
| Avoid variables with short names like mt | 114 |
| Local variable 'mt' could be declared final | 114 |
| Avoid variables with short names like mt | 114 |
| Avoid using if statements without curly braces | 120–121 |
| Avoid using Literals in Conditional Statements | 120 |
| Avoid using Literals in Conditional Statements | 123 |
| Avoid using if statements without curly braces | 123–124 |
| Avoid using if statements without curly braces | 126–127 |
| Avoid using if statements without curly braces | 129–130 |
| Avoid using if...else statements without curly braces | 135 |
| Avoid using if...else statements without curly braces | 137 |
| Avoid using Literals in Conditional Statements | 139 |
| Avoid using if...else statements without curly braces | 140 |
| Avoid using if...else statements without curly braces | 142 |
| Avoid using Literals in Conditional Statements | 144 |
| Avoid using if...else statements without curly braces | 145 |
| Avoid using if...else statements without curly braces | 147 |
| Avoid using Literals in Conditional Statements | 149 |
| Avoid using if...else statements without curly braces | 150 |
| Avoid using if...else statements without curly braces | 152 |
| Avoid variables with short names like s | 161 |
| Avoid variables with short names like s | 161 |
| Avoid variables with short names like ss | 162 |
| Avoid variables with short names like ss | 162 |
| Avoid using Literals in Conditional Statements | 170 |
| Avoid using Literals in Conditional Statements | 172 |
| Avoid using if statements without curly braces | 172–173 |
| Avoid using if statements without curly braces | 174–175 |
| Avoid using Literals in Conditional Statements | 174 |
| Avoid using Literals in Conditional Statements | 176 |
| Avoid using if statements without curly braces | 176–177 |
| Avoid variables with short names like gs | 181 |
| Avoid variables with short names like gs | 181 |
| Avoid using for statements without curly braces | 182–183 |
| Avoid using if...else statements without curly braces | 190 |
| Avoid using if...else statements without curly braces | 192 |
| Avoid using Literals in Conditional Statements | 194 |
| Avoid using if...else statements without curly braces | 195 |
| Avoid using if...else statements without curly braces | 197 |
| Avoid using Literals in Conditional Statements | 199 |
| Avoid using if...else statements without curly braces | 200 |
| Avoid using if...else statements without curly braces | 202 |
| Avoid using Literals in Conditional Statements | 204 |
| Avoid using if...else statements without curly braces | 205 |
| Avoid using if...else statements without curly braces | 207 |
| Avoid variables with short names like g | 236 |
| Avoid variables with short names like g | 236 |
| Avoid using if statements without curly braces | 237–238 |
| Avoid using if statements without curly braces | 303–304 |
| A method should have only one exit point, and that should be the last statement in the method | 304 |
| Avoid variables with short names like gs | 306 |
| Avoid variables with short names like gs | 306 |
| Prefer StringBuffer over += for concatenating strings | 308 |
| Prefer StringBuffer over += for concatenating strings | 310 |
| publicMethodCommentRequirement Required | 333–335 |
| Found 'DU'-anomaly for variable 'min' (lines '343'-'353'). | 343–353 |
| Found 'DD'-anomaly for variable 'min' (lines '343'-'347'). | 343–347 |
| Found 'DU'-anomaly for variable 'max' (lines '344'-'353'). | 344–353 |
| Found 'DD'-anomaly for variable 'max' (lines '344'-'348'). | 344–348 |
| publicMethodCommentRequirement Required | 355–357 |
| Avoid using if statements without curly braces | 416–417 |
| A method should have only one exit point, and that should be the last statement in the method | 417 |
| Avoid using if statements without curly braces | 437–438 |
| A method should have only one exit point, and that should be the last statement in the method | 438 |
| Avoid variables with short names like o | 456 |
| Avoid variables with short names like o | 456 |
| Avoid using if statements without curly braces | 457–458 |
| A method should have only one exit point, and that should be the last statement in the method | 458 |
| Avoid using if statements without curly braces | 460–461 |
| A method should have only one exit point, and that should be the last statement in the method | 461 |
| Avoid using if statements without curly braces | 463–464 |
| A method should have only one exit point, and that should be the last statement in the method | 464 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 13 |
| fieldCommentRequirement Required | 14 |
| fieldCommentRequirement Required | 15 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 17 |
| publicMethodCommentRequirement Required | 19–24 |
| Avoid variables with short names like rs | 19 |
| Avoid variables with short names like rs | 19 |
| publicMethodCommentRequirement Required | 27–33 |
| Avoid variables with short names like s | 28 |
| Avoid variables with short names like s | 28 |
| Avoid using if...else statements without curly braces | 30 |
| A method should have only one exit point, and that should be the last statement in the method | 30 |
| Avoid using if...else statements without curly braces | 32 |
| publicMethodCommentRequirement Required | 35–38 |
| Found 'UR'-anomaly for variable 'node' (lines '35'-'37'). | 35–37 |
| Avoid using for statements without curly braces | 36–37 |
| Violation | Line |
|---|---|
| Variables should start with a lowercase character, 'NULL' starts with uppercase character. | 21 |
| The field name indicates a constant but its modifiers do not | 21 |
| Variables should start with a lowercase character, 'NULL' starts with uppercase character. | 21 |
| fieldCommentRequirement Required | 21 |
| The field name indicates a constant but its modifiers do not | 21 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 32 |
| publicMethodCommentRequirement Required | 34 |
| Document empty constructor | 34 |
| Avoid variables with short names like rs | 36 |
| Avoid variables with short names like rs | 36 |
| publicMethodCommentRequirement Required | 36–50 |
| publicMethodCommentRequirement Required | 52–54 |
| publicMethodCommentRequirement Required | 56–58 |
| publicMethodCommentRequirement Required | 60–62 |
| publicMethodCommentRequirement Required | 64–66 |
| Avoid variables with short names like d | 64 |
| Avoid variables with short names like d | 64 |
| Avoid variables with short names like d | 68 |
| publicMethodCommentRequirement Required | 68–70 |
| Avoid variables with short names like d | 68 |
| publicMethodCommentRequirement Required | 72–76 |
| Avoid using if statements without curly braces | 73–74 |
| A method should have only one exit point, and that should be the last statement in the method | 74 |
| publicMethodCommentRequirement Required | 78–82 |
| Avoid using if statements without curly braces | 79–80 |
| A method should have only one exit point, and that should be the last statement in the method | 80 |
| publicMethodCommentRequirement Required | 84–88 |
| Avoid using if statements without curly braces | 85–86 |
| A method should have only one exit point, and that should be the last statement in the method | 86 |
| publicMethodCommentRequirement Required | 90–92 |
| Avoid variables with short names like s | 90 |
| Avoid variables with short names like s | 90 |
| publicMethodCommentRequirement Required | 94–96 |
| publicMethodCommentRequirement Required | 98–100 |
| publicMethodCommentRequirement Required | 102–104 |
| publicMethodCommentRequirement Required | 107–109 |
| publicMethodCommentRequirement Required | 111–113 |
| publicMethodCommentRequirement Required | 115–117 |
| publicMethodCommentRequirement Required | 119–121 |
| publicMethodCommentRequirement Required | 123–125 |
| Violation | Line |
|---|---|
| Possible God class (WMC=58, ATFD=93, TCC=0.0) | 1–403 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 33–34 |
| When instantiating a SimpleDateFormat object, specify a Locale | 34 |
| enumCommentRequirement Required | 36–60 |
| fieldCommentRequirement Required | 39 |
| Avoid variables with short names like s | 41 |
| Avoid variables with short names like s | 41 |
| publicMethodCommentRequirement Required | 45–55 |
| Avoid reassigning parameters such as 's' | 45 |
| Found 'UR'-anomaly for variable 'm' (lines '45'-'51'). | 45–51 |
| Avoid variables with short names like s | 45 |
| Avoid variables with short names like s | 45 |
| Avoid variables with short names like i | 46 |
| Avoid variables with short names like i | 46 |
| Avoid using if statements without curly braces | 47–48 |
| Avoid using for statements without curly braces | 50–52 |
| Avoid using if statements without curly braces | 51–52 |
| A method should have only one exit point, and that should be the last statement in the method | 52 |
| publicMethodCommentRequirement Required | 57–59 |
| Avoid variables with short names like a | 62 |
| Avoid variables with short names like a | 62 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 62 |
| publicMethodCommentRequirement Required | 62–151 |
| Overridable method 'outputInstructions' called during object construction | 65 |
| Overridable method 'parseArgs' called during object construction | 88 |
| System.out.print is used | 92 |
| System.out.println is used | 97 |
| System.out.println is used | 116 |
| System.out.println is used | 120 |
| System.out.print is used | 130 |
| System.out.println is used | 143 |
| Avoid printStackTrace(); use a logger call instead. | 148 |
| System.out.println is used | 150 |
| publicMethodCommentRequirement Required | 153–172 |
| System.out.println is used | 154 |
| System.out.println is used | 155 |
| System.out.println is used | 156 |
| System.out.println is used | 157 |
| System.out.println is used | 158 |
| System.out.println is used | 159 |
| System.out.println is used | 160 |
| System.out.println is used | 161 |
| System.out.println is used | 162 |
| System.out.println is used | 163 |
| System.out.println is used | 164 |
| System.out.println is used | 165 |
| System.out.println is used | 166 |
| System.out.println is used | 167 |
| System.out.println is used | 168 |
| System.out.println is used | 169 |
| System.out.println is used | 170 |
| System.out.println is used | 171 |
| Each class should declare at least one constructor | 174–198 |
| headerCommentRequirement Required | 174–198 |
| fieldCommentRequirement Required | 175 |
| Use explicit scoping instead of the default package private level | 175 |
| fieldCommentRequirement Required | 176 |
| Use explicit scoping instead of the default package private level | 176 |
| fieldCommentRequirement Required | 177 |
| Use explicit scoping instead of the default package private level | 177 |
| Use explicit scoping instead of the default package private level | 178 |
| fieldCommentRequirement Required | 178 |
| fieldCommentRequirement Required | 180 |
| Use explicit scoping instead of the default package private level | 180 |
| Use explicit scoping instead of the default package private level | 181 |
| fieldCommentRequirement Required | 181 |
| Use explicit scoping instead of the default package private level | 182 |
| fieldCommentRequirement Required | 182 |
| fieldCommentRequirement Required | 184 |
| Use explicit scoping instead of the default package private level | 184 |
| fieldCommentRequirement Required | 185 |
| Use explicit scoping instead of the default package private level | 185 |
| Use explicit scoping instead of the default package private level | 186 |
| fieldCommentRequirement Required | 186 |
| Use explicit scoping instead of the default package private level | 187 |
| fieldCommentRequirement Required | 187 |
| Use explicit scoping instead of the default package private level | 189 |
| fieldCommentRequirement Required | 189 |
| fieldCommentRequirement Required | 190 |
| Use explicit scoping instead of the default package private level | 190 |
| Avoid using redundant field initializer for 'showClip' | 191 |
| fieldCommentRequirement Required | 191 |
| Use explicit scoping instead of the default package private level | 191 |
| Use explicit scoping instead of the default package private level | 193 |
| fieldCommentRequirement Required | 193 |
| Use explicit scoping instead of the default package private level | 194 |
| Avoid using redundant field initializer for 'timeZoneOffset' | 194 |
| fieldCommentRequirement Required | 194 |
| Use explicit scoping instead of the default package private level | 196 |
| fieldCommentRequirement Required | 196 |
| fieldCommentRequirement Required | 197 |
| Use explicit scoping instead of the default package private level | 197 |
| Avoid variables with short names like s | 200 |
| Avoid variables with short names like s | 200 |
| publicMethodCommentRequirement Required | 200–209 |
| System.out.println is used | 201 |
| Avoid printStackTrace(); use a logger call instead. | 206 |
| publicMethodCommentRequirement Required | 211–397 |
| Avoid variables with short names like hp | 212 |
| Avoid variables with short names like hp | 212 |
| Avoid using Literals in Conditional Statements | 213 |
| Avoid using if statements without curly braces | 213–214 |
| Avoid using if...else statements without curly braces | 218 |
| Avoid using if...else statements without curly braces | 220 |
| System.out.println is used | 220 |
| Avoid empty catch blocks | 225–226 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 225 |
| Avoid using if...else statements without curly braces | 228 |
| Avoid using if...else statements without curly braces | 230 |
| System.out.println is used | 230 |
| Avoid using if...else statements without curly braces | 234 |
| Avoid using if...else statements without curly braces | 236 |
| System.out.println is used | 236 |
| Avoid variables with short names like s | 238 |
| Avoid variables with short names like s | 238 |
| Avoid variables with short names like x | 240 |
| Avoid variables with short names like x | 240 |
| Found 'DD'-anomaly for variable 'x' (lines '240'-'242'). | 240–242 |
| Avoid empty catch blocks | 243–244 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 243 |
| Avoid using if statements without curly braces | 245–246 |
| System.out.println is used | 247 |
| Found 'DD'-anomaly for variable 'y' (lines '253'-'255'). | 253–255 |
| Avoid variables with short names like y | 253 |
| Avoid variables with short names like y | 253 |
| Avoid empty catch blocks | 256–257 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 256 |
| Avoid using if statements without curly braces | 258–259 |
| System.out.println is used | 260 |
| Avoid variables with short names like lm | 266 |
| Avoid variables with short names like lm | 266 |
| Found 'DD'-anomaly for variable 'lm' (lines '266'-'268'). | 266–268 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 269 |
| Avoid empty catch blocks | 269–270 |
| Avoid using if statements without curly braces | 271–272 |
| System.out.println is used | 273 |
| Avoid variables with short names like rm | 279 |
| Avoid variables with short names like rm | 279 |
| Found 'DD'-anomaly for variable 'rm' (lines '279'-'281'). | 279–281 |
| Avoid empty catch blocks | 282–283 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 282 |
| Avoid using if statements without curly braces | 284–285 |
| System.out.println is used | 286 |
| Avoid variables with short names like m | 292 |
| Found 'DD'-anomaly for variable 'm' (lines '292'-'294'). | 292–294 |
| Avoid variables with short names like m | 292 |
| Avoid empty catch blocks | 295–296 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 295 |
| Avoid using if statements without curly braces | 297–298 |
| System.out.println is used | 299 |
| Avoid variables with short names like h | 305 |
| Avoid variables with short names like h | 305 |
| Found 'DD'-anomaly for variable 'h' (lines '305'-'307'). | 305–307 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 308 |
| Avoid empty catch blocks | 308–309 |
| Avoid using if statements without curly braces | 310–311 |
| System.out.println is used | 312 |
| System.out.println is used | 319 |
| System.out.println is used | 330 |
| Avoid variables with short names like h | 335 |
| Avoid variables with short names like h | 335 |
| Avoid empty catch blocks | 338–339 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 338 |
| Avoid using if statements without curly braces | 340–341 |
| System.out.println is used | 342 |
| These nested if statements could be combined | 349–360 |
| Position literals first in String comparisons | 349 |
| Found 'DD'-anomaly for variable 'date' (lines '350'-'352'). | 350–352 |
| Avoid empty catch blocks | 353–354 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 353 |
| Avoid using if statements without curly braces | 355–356 |
| System.out.println is used | 358 |
| Avoid variables with short names like c | 365 |
| Avoid variables with short names like c | 365 |
| Found 'DD'-anomaly for variable 'c' (lines '365'-'367'). | 365–367 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 368 |
| Avoid empty catch blocks | 368–369 |
| Avoid using if statements without curly braces | 370–371 |
| System.out.println is used | 372 |
| Found 'DD'-anomaly for variable 'b' (lines '378'-'380'). | 378–380 |
| Avoid variables with short names like b | 378 |
| Avoid variables with short names like b | 378 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 381 |
| Avoid empty catch blocks | 381–382 |
| Avoid using if statements without curly braces | 383–384 |
| System.out.println is used | 385 |
| Position literals first in String comparisons | 391 |
| System.out.println is used | 392 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 399 |
| publicMethodCommentRequirement Required | 399–401 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 3–10 |
| Each class should declare at least one constructor | 3–10 |
| fieldCommentRequirement Required | 5 |
| fieldCommentRequirement Required | 7 |
| fieldCommentRequirement Required | 9 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–409 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 53 |
| publicMethodCommentRequirement Required | 55–58 |
| Parameter 'handler' is not assigned and could be declared final | 69 |
| Parameter 'req' is not assigned and could be declared final | 69 |
| Local variable 'workerGroup' could be declared final | 70 |
| Avoid variables with short names like b | 73 |
| Local variable 'b' could be declared final | 73 |
| Avoid variables with short names like b | 73 |
| publicMethodCommentRequirement Required | 79–81 |
| Parameter 'ch' is not assigned and could be declared final | 79 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 79 |
| Local variable 'handlerKey' could be declared final | 84 |
| Avoid variables with short names like ch | 86 |
| Local variable 'ch' could be declared final | 86 |
| Avoid variables with short names like ch | 86 |
| System.err.println is used | 88 |
| Local variable 'lastWriteFuture' could be declared final | 90–91 |
| Found 'DU'-anomaly for variable 'lastWriteFuture' (lines '91'-'102'). | 91–102 |
| Found 'DU'-anomaly for variable 'lastWriteFuture' (lines '91'-'102'). | 91–102 |
| Avoid throwing raw exception types. | 98 |
| Local variable 'version' could be declared final | 111 |
| Local variable 'rsam' could be declared final | 132 |
| Avoid variables with short names like st | 133 |
| Avoid variables with short names like st | 133 |
| Local variable 'st' could be declared final | 133 |
| Local variable 'et' could be declared final | 134 |
| Avoid variables with short names like et | 134 |
| Avoid variables with short names like et | 134 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 155–156 |
| Local variable 'scnl' could be declared final | 158 |
| Local variable 'timeSpan' could be declared final | 159 |
| Local variable 'wave' could be declared final | 176 |
| Avoid variables with short names like st | 177 |
| Local variable 'st' could be declared final | 177 |
| Avoid variables with short names like st | 177 |
| Avoid variables with short names like et | 178 |
| Local variable 'et' could be declared final | 178 |
| Avoid variables with short names like et | 178 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 198–199 |
| Local variable 'scnl' could be declared final | 200 |
| Local variable 'timeSpan' could be declared final | 201 |
| Local variable 'heliData' could be declared final | 218 |
| Local variable 'st' could be declared final | 219 |
| Avoid variables with short names like st | 219 |
| Avoid variables with short names like st | 219 |
| Avoid variables with short names like et | 220 |
| Local variable 'et' could be declared final | 220 |
| Avoid variables with short names like et | 220 |
| Avoid variables with short names like df | 241 |
| When instantiating a SimpleDateFormat object, specify a Locale | 241 |
| Avoid variables with short names like df | 241 |
| Local variable 'filename' could be declared final | 244 |
| System.out.println is used | 245 |
| Local variable 'wave' could be declared final | 247 |
| System.err.println is used | 248 |
| System.err.println is used | 254 |
| Avoid printStackTrace(); use a logger call instead. | 255 |
| Found 'UR'-anomaly for variable 'i' (lines '271'-'277'). | 271–277 |
| System.out.println is used | 272 |
| Local variable 'wave' could be declared final | 274 |
| System.out.println is used | 277 |
| System.out.println is used | 294 |
| Local variable 'heliData' could be declared final | 296 |
| System.out.println is used | 298 |
| System.out.println is used | 315 |
| Local variable 'rsam' could be declared final | 317 |
| System.out.println is used | 319 |
| Local variable 'channels' could be declared final | 339 |
| Local variable 'req' could be declared final | 340 |
| Found 'UR'-anomaly for variable 'chan' (lines '354'-'359'). | 354–359 |
| Local variable 'wws' could be declared final | 355 |
| Local variable 'channels' could be declared final | 356 |
| System.out.println is used | 357 |
| Local variable 'chan' could be declared final | 358 |
| System.out.println is used | 359 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 370 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 403 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 13–28 |
| Parameter 'msgBuf' is not assigned and could be declared final | 14 |
| publicMethodCommentRequirement Required | 14–27 |
| Local variable 'eol' could be declared final | 15 |
| A method should have only one exit point, and that should be the last statement in the method | 17 |
| Local variable 'bos' could be declared final | 19 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 22–23 |
| Local variable 'newLine' could be declared final | 22–23 |
| Found 'DU'-anomaly for variable 'newLine' (lines '23'-'27'). | 23–27 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'gov.usgs.plot.data.Wave' | 11 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| Parameter 'isCompressed' is not assigned and could be declared final | 28 |
| publicMethodCommentRequirement Required | 28–33 |
| It is a good practice to call super() in a constructor | 28–33 |
| Parameter 'heliData' is not assigned and could be declared final | 28 |
| Assigning an Object to null is a code smell. Consider refactoring. | 32 |
| publicMethodCommentRequirement Required | 36–65 |
| Parameter 'msg' is not assigned and could be declared final | 36 |
| Local variable 'msgBuf' could be declared final | 37 |
| Local variable 'header' could be declared final | 39 |
| Local variable 'parts' could be declared final | 44 |
| Do not add empty strings | 48 |
| Found 'DD'-anomaly for variable 'bytes' (lines '55'-'57'). | 55–57 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'gov.usgs.plot.data.Wave' | 11 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| publicMethodCommentRequirement Required | 28–33 |
| Parameter 'isCompressed' is not assigned and could be declared final | 28 |
| Parameter 'rsam' is not assigned and could be declared final | 28 |
| It is a good practice to call super() in a constructor | 28–33 |
| Assigning an Object to null is a code smell. Consider refactoring. | 32 |
| publicMethodCommentRequirement Required | 36–65 |
| Parameter 'msg' is not assigned and could be declared final | 36 |
| Local variable 'msgBuf' could be declared final | 37 |
| Local variable 'header' could be declared final | 39 |
| Local variable 'parts' could be declared final | 44 |
| Do not add empty strings | 48 |
| Found 'DD'-anomaly for variable 'bytes' (lines '55'-'57'). | 55–57 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| publicMethodCommentRequirement Required | 27–32 |
| Parameter 'wave' is not assigned and could be declared final | 27 |
| Parameter 'isCompressed' is not assigned and could be declared final | 27 |
| It is a good practice to call super() in a constructor | 27–32 |
| Assigning an Object to null is a code smell. Consider refactoring. | 31 |
| publicMethodCommentRequirement Required | 35–64 |
| Parameter 'msg' is not assigned and could be declared final | 35 |
| Local variable 'msgBuf' could be declared final | 36 |
| Local variable 'header' could be declared final | 38 |
| Local variable 'parts' could be declared final | 43 |
| Do not add empty strings | 47 |
| Found 'DD'-anomaly for variable 'bytes' (lines '54'-'56'). | 54–56 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 22 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 23 |
| fieldCommentRequirement Required | 23 |
| Private field 'menu' could be made final; it is only initialized in the declaration or constructor. | 23 |
| Parameter 'channels' is not assigned and could be declared final | 25 |
| publicMethodCommentRequirement Required | 25–31 |
| publicMethodCommentRequirement Required | 34–60 |
| Parameter 'msg' is not assigned and could be declared final | 34 |
| Found 'UR'-anomaly for variable 'line' (lines '34'-'53'). | 34–53 |
| Local variable 'msgBuf' could be declared final | 35 |
| Local variable 'header' could be declared final | 38 |
| Local variable 'chunk' could be declared final | 48 |
| Local variable 'line' could be declared final | 52 |
| Avoid instantiating new objects inside loops | 53 |
| Parameter 'buf' is not assigned and could be declared final | 62 |
| Found 'DD'-anomaly for variable 'lines' (lines '63'-'66'). | 63–66 |
| Avoid using Literals in Conditional Statements | 65 |
| Found 'DD'-anomaly for variable 'lines' (lines '66'-'66'). | 66 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.nio.charset.Charset' | 4 |
| Avoid unused imports such as 'java.util.List' | 5 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 20 |
| Parameter 'version' is not assigned and could be declared final | 22 |
| publicMethodCommentRequirement Required | 22–25 |
| Parameter 'msg' is not assigned and could be declared final | 28 |
| publicMethodCommentRequirement Required | 28–39 |
| Local variable 'msgBuf' could be declared final | 29 |
| Local variable 'header' could be declared final | 31 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 3–5 |
| Each class should declare at least one constructor | 3–5 |
| fieldCommentRequirement Required | 4 |
| Avoid using redundant field initializer for 'version' | 4 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'gov.usgs.volcanoes.core.util.StringUtils' | 25 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 41–49 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 92 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 92 |
| Avoid throwing raw exception types. | 128 |
| Avoid throwing raw exception types. | 131 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 9–24 |
| Each class should declare at least one constructor | 9–24 |
| fieldCommentRequirement Required | 11 |
| Variables that are final and static should be all capitals, 'handlerKey' is not all capitals. | 11 |
| Variables that are final and static should be all capitals, 'handlerKey' is not all capitals. | 11 |
| Parameter 'ctx' is not assigned and could be declared final | 14 |
| Parameter 'msg' is not assigned and could be declared final | 14 |
| publicMethodCommentRequirement Required | 14–17 |
| Local variable 'handler' could be declared final | 15 |
| Parameter 'ctx' is not assigned and could be declared final | 20 |
| Parameter 'cause' is not assigned and could be declared final | 20 |
| publicMethodCommentRequirement Required | 20–23 |
| Avoid printStackTrace(); use a logger call instead. | 21 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 11–34 |
| Abstract classes should be named AbstractXXX | 11–34 |
| publicMethodCommentRequirement Required | 18–20 |
| Violation | Line |
|---|---|
| Possible God class (WMC=83, ATFD=33, TCC=0.0) | 1–505 |
| fieldCommentRequirement Required | 20 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 30 |
| Found 'DU'-anomaly for variable 'cmd' (lines '36'-'143'). | 36–143 |
| Avoid variables with short names like cf | 39 |
| Avoid variables with short names like cf | 39 |
| Avoid variables with short names like db | 42 |
| Avoid variables with short names like db | 42 |
| Found 'DU'-anomaly for variable 'admin' (lines '43'-'143'). | 43–143 |
| Found 'DD'-anomaly for variable 'delay' (lines '44'-'53'). | 44–53 |
| Found 'DU'-anomaly for variable 'delay' (lines '44'-'143'). | 44–143 |
| Position literals first in String comparisons | 49 |
| Found 'DD'-anomaly for variable 'delay' (lines '53'-'53'). | 53 |
| Found 'DU'-anomaly for variable 'delay' (lines '53'-'143'). | 53–143 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 54 |
| Avoid assignments in operands | 59 |
| Found 'DU'-anomaly for variable 'cmd' (lines '59'-'143'). | 59–143 |
| Position literals first in String comparisons | 62 |
| Position literals first in String comparisons | 64 |
| Found 'DU'-anomaly for variable 'times' (lines '65'-'143'). | 65–143 |
| Found 'DD'-anomaly for variable 'times' (lines '65'-'69'). | 65–69 |
| Found 'DD'-anomaly for variable 'times' (lines '65'-'65'). | 65 |
| Position literals first in String comparisons | 68 |
| Found 'DD'-anomaly for variable 'times' (lines '69'-'65'). | 69–65 |
| Found 'DU'-anomaly for variable 'times' (lines '69'-'143'). | 69–143 |
| Position literals first in String comparisons | 77 |
| Position literals first in String comparisons | 77 |
| Position literals first in String comparisons | 80 |
| System.err.println is used | 85 |
| Position literals first in String comparisons | 94 |
| Position literals first in String comparisons | 94 |
| Found 'DD'-anomaly for variable 'channel' (lines '95'-'99'). | 95–99 |
| Found 'DD'-anomaly for variable 'days' (lines '96'-'101'). | 96–101 |
| Found 'DD'-anomaly for variable 'channel' (lines '99'-'95'). | 99–95 |
| Found 'DU'-anomaly for variable 'channel' (lines '99'-'143'). | 99–143 |
| Found 'DD'-anomaly for variable 'status' (lines '103'-'106'). | 103–106 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 105 |
| Position literals first in String comparisons | 110 |
| Position literals first in String comparisons | 116 |
| Avoid variables with short names like ch | 119 |
| Avoid variables with short names like ch | 119 |
| Avoid using final local variables, turn them into fields | 119 |
| System.err.println is used | 135 |
| Avoid using Literals in Conditional Statements | 146 |
| System.err.println is used | 147 |
| System.out.println is used | 149 |
| Do not add empty strings | 177 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 183 |
| fieldCommentRequirement Required | 183 |
| fieldCommentRequirement Required | 185 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 185 |
| fieldCommentRequirement Required | 187 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 187 |
| Avoid variables with short names like db | 196 |
| Avoid variables with short names like db | 196 |
| Avoid variables with short names like w | 205 |
| Avoid variables with short names like w | 205 |
| Avoid variables with short names like st | 216 |
| Avoid variables with short names like st | 216 |
| System.out.print is used | 219 |
| System.out.println is used | 221 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 223 |
| Ensure that resources like this ResultSet object are closed after use | 237 |
| Avoid variables with short names like rs | 237 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 237–238 |
| Avoid variables with short names like rs | 237 |
| The String literal "Msg_text" appears 4 times in this file; the first occurrence is on line 240 | 240 |
| Avoid variables with short names like s | 240 |
| Avoid variables with short names like s | 240 |
| A method should have only one exit point, and that should be the last statement in the method | 243 |
| Position literals first in String comparisons | 245 |
| Avoid variables with short names like ch | 253 |
| Avoid variables with short names like ch | 253 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 257 |
| Found 'DD'-anomaly for variable 'ch' (lines '269'-'284'). | 269–284 |
| Avoid variables with short names like ch | 269 |
| Avoid variables with short names like ch | 269 |
| Found 'DD'-anomaly for variable 'ch' (lines '269'-'277'). | 269–277 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 272 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 286 |
| Found 'UR'-anomaly for variable 'ch' (lines '294'-'298'). | 294–298 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 301 |
| Avoid printStackTrace(); use a logger call instead. | 302 |
| Avoid variables with short names like ch | 312 |
| Avoid variables with short names like ch | 312 |
| Found 'DD'-anomaly for variable 'valid' (lines '327'-'335'). | 327–335 |
| Found 'DD'-anomaly for variable 'valid' (lines '327'-'344'). | 327–344 |
| Found 'DD'-anomaly for variable 'valid' (lines '327'-'340'). | 327–340 |
| Avoid variables with short names like ca | 330 |
| Avoid variables with short names like ca | 330 |
| Avoid assignments in operands | 333–334 |
| Useless parentheses. | 334 |
| Found 'UR'-anomaly for variable 'ch' (lines '355'-'358'). | 355–358 |
| Avoid variables with short names like st | 356 |
| Avoid variables with short names like st | 356 |
| System.out.print is used | 359 |
| System.out.print is used | 361 |
| System.out.println is used | 363 |
| Avoid variables with short names like ch | 385 |
| Avoid variables with short names like ch | 385 |
| Found 'DD'-anomaly for variable 'ch' (lines '385'-'392'). | 385–392 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 388 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 400 |
| Found 'UR'-anomaly for variable 'ch' (lines '412'-'416'). | 412–416 |
| Avoid variables with short names like ch | 430 |
| Avoid variables with short names like ch | 430 |
| Found 'DD'-anomaly for variable 'fix' (lines '433'-'457'). | 433–457 |
| Found 'DD'-anomaly for variable 'fix' (lines '433'-'445'). | 433–445 |
| Found 'DU'-anomaly for variable 'fix' (lines '433'-'472'). | 433–472 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 433 |
| Ensure that resources like this Statement object are closed after use | 434 |
| Avoid variables with short names like st | 434 |
| Avoid variables with short names like st | 434 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 437 |
| Avoid variables with short names like rs | 437 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 437 |
| Ensure that resources like this ResultSet object are closed after use | 437 |
| Avoid variables with short names like rs | 437 |
| Avoid variables with short names like s | 439 |
| Avoid variables with short names like s | 439 |
| A method should have only one exit point, and that should be the last statement in the method | 442 |
| Position literals first in String comparisons | 444 |
| Found 'DU'-anomaly for variable 'fix' (lines '445'-'472'). | 445–472 |
| Found 'DD'-anomaly for variable 'fix' (lines '445'-'457'). | 445–457 |
| A method should have only one exit point, and that should be the last statement in the method | 453 |
| The String literal "REPAIR TABLE `" appears 4 times in this file; the first occurrence is on line 464 | 464 |
| A method should have only one exit point, and that should be the last statement in the method | 467 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 468 |
| Avoid variables with short names like ct | 485 |
| Avoid variables with short names like ct | 485 |
| Avoid unnecessary comparisons in boolean expressions | 486 |
| A method should have only one exit point, and that should be the last statement in the method | 487 |
| Avoid unnecessary comparisons in boolean expressions | 493 |
| A method should have only one exit point, and that should be the last statement in the method | 494 |
| A method should have only one exit point, and that should be the last statement in the method | 499 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 500 |
| Violation | Line |
|---|---|
| Possible God class (WMC=55, ATFD=45, TCC=0.01098901098901099) | 1–413 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 33 |
| Avoid variables with short names like w | 41 |
| Avoid variables with short names like w | 41 |
| Avoid using if statements without curly braces | 51–52 |
| A method should have only one exit point, and that should be the last statement in the method | 52 |
| Avoid variables with short names like rs | 57 |
| Avoid variables with short names like rs | 57 |
| Ensure that resources like this ResultSet object are closed after use | 57 |
| Avoid instantiating new objects inside loops | 59 |
| Avoid variables with short names like gn | 59 |
| Avoid variables with short names like gn | 59 |
| A method should have only one exit point, and that should be the last statement in the method | 65 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 66 |
| Avoid variables with short names like i | 72 |
| publicMethodCommentRequirement Required | 72–74 |
| Parameter 'i' is not assigned and could be declared final | 72 |
| Avoid variables with short names like i | 72 |
| publicMethodCommentRequirement Required | 94–98 |
| Avoid variables with short names like c1 | 94 |
| Avoid variables with short names like c2 | 94 |
| Avoid variables with short names like c2 | 94 |
| Avoid variables with short names like c1 | 94 |
| Avoid variables with short names like t1 | 95 |
| Avoid variables with short names like t1 | 95 |
| Avoid variables with short names like t2 | 96 |
| Avoid variables with short names like t2 | 96 |
| Avoid using if statements without curly braces | 112–113 |
| A method should have only one exit point, and that should be the last statement in the method | 113 |
| Ensure that resources like this ResultSet object are closed after use | 117 |
| Avoid variables with short names like rs | 117 |
| Avoid variables with short names like rs | 117 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 121 |
| Avoid instantiating new objects inside loops | 124 |
| Avoid variables with short names like ch | 124 |
| Avoid variables with short names like ch | 124 |
| Found 'DU'-anomaly for variable 'nodes' (lines '132'-'168'). | 132–168 |
| Found 'DU'-anomaly for variable 'nid' (lines '137'-'168'). | 137–168 |
| Found 'DD'-anomaly for variable 'nid' (lines '137'-'137'). | 137 |
| Avoid variables with short names like ch | 138 |
| Avoid variables with short names like ch | 138 |
| Avoid variables with short names like gn | 140 |
| Avoid variables with short names like gn | 140 |
| Avoid using if statements without curly braces | 141–142 |
| Found 'DU'-anomaly for variable 'ps' (lines '148'-'168'). | 148–168 |
| Avoid variables with short names like ps | 148 |
| Avoid variables with short names like ps | 148 |
| Avoid variables with short names like md | 151 |
| Avoid variables with short names like md | 151 |
| Avoid using if statements without curly braces | 155–156 |
| Avoid instantiating new objects inside loops | 156 |
| A method should have only one exit point, and that should be the last statement in the method | 163 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 164 |
| Avoid using if statements without curly braces | 177–178 |
| A method should have only one exit point, and that should be the last statement in the method | 178 |
| Found 'DD'-anomaly for variable 'result' (lines '181'-'186'). | 181–186 |
| Ensure that resources like this ResultSet object are closed after use | 183 |
| Avoid variables with short names like rs | 183 |
| Avoid variables with short names like rs | 183 |
| Avoid using if statements without curly braces | 185–186 |
| A method should have only one exit point, and that should be the last statement in the method | 188 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 189 |
| Avoid using if statements without curly braces | 203–204 |
| A method should have only one exit point, and that should be the last statement in the method | 204 |
| Avoid variables with short names like rs | 209 |
| Avoid variables with short names like rs | 209 |
| Ensure that resources like this ResultSet object are closed after use | 209 |
| A method should have only one exit point, and that should be the last statement in the method | 215 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 216 |
| Avoid using if statements without curly braces | 229–230 |
| A method should have only one exit point, and that should be the last statement in the method | 230 |
| Found 'DD'-anomaly for variable 'result' (lines '233'-'238'). | 233–238 |
| Ensure that resources like this ResultSet object are closed after use | 235 |
| Avoid variables with short names like rs | 235 |
| Avoid variables with short names like rs | 235 |
| Avoid using if statements without curly braces | 237–238 |
| A method should have only one exit point, and that should be the last statement in the method | 240 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 241 |
| Avoid using if statements without curly braces | 255–256 |
| A method should have only one exit point, and that should be the last statement in the method | 256 |
| Found 'DD'-anomaly for variable 'result' (lines '259'-'264'). | 259–264 |
| Ensure that resources like this ResultSet object are closed after use | 261 |
| Avoid variables with short names like rs | 261 |
| Avoid variables with short names like rs | 261 |
| Avoid using if statements without curly braces | 263–264 |
| A method should have only one exit point, and that should be the last statement in the method | 266 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 267 |
| Avoid using if statements without curly braces | 280–281 |
| A method should have only one exit point, and that should be the last statement in the method | 281 |
| Found 'DD'-anomaly for variable 'result' (lines '283'-'287'). | 283–287 |
| Ensure that resources like this ResultSet object are closed after use | 285 |
| Avoid variables with short names like rs | 285 |
| Avoid variables with short names like rs | 285 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 285–286 |
| A method should have only one exit point, and that should be the last statement in the method | 289 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 290 |
| Avoid using if statements without curly braces | 312–313 |
| A method should have only one exit point, and that should be the last statement in the method | 313 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 321 |
| Avoid using if statements without curly braces | 336–337 |
| Avoid variables with short names like ps | 341 |
| Avoid variables with short names like ps | 341 |
| Found 'DD'-anomaly for variable 'ps' (lines '341'-'344'). | 341–344 |
| Found 'DD'-anomaly for variable 'ps' (lines '341'-'348'). | 341–348 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 368 |
| Found 'UR'-anomaly for variable 'inst' (lines '379'-'397'). | 379–397 |
| Avoid using if statements without curly braces | 380–381 |
| A method should have only one exit point, and that should be the last statement in the method | 381 |
| Avoid variables with short names like rs | 385 |
| Avoid variables with short names like rs | 385 |
| Ensure that resources like this ResultSet object are closed after use | 385 |
| Avoid instantiating new objects inside loops | 388 |
| Avoid variables with short names like ps | 393 |
| Avoid variables with short names like ps | 393 |
| Found 'DU'-anomaly for variable 'ps' (lines '393'-'411'). | 393–411 |
| Avoid variables with short names like md | 396 |
| Avoid variables with short names like md | 396 |
| Avoid using if statements without curly braces | 400–401 |
| Avoid instantiating new objects inside loops | 401 |
| A method should have only one exit point, and that should be the last statement in the method | 406 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 407 |
| Violation | Line |
|---|---|
| Possible God class (WMC=103, ATFD=48, TCC=0.15151515151515152) | 1–605 |
| Avoid short class names like Data | 31–605 |
| Avoid short class names like Data | 31–605 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| Avoid variables with short names like w | 46 |
| Avoid variables with short names like w | 46 |
| When instantiating a SimpleDateFormat object, specify a Locale | 50 |
| Return an empty array rather than null. | 61–75 |
| Avoid using if statements without curly braces | 62–63 |
| A method should have only one exit point, and that should be the last statement in the method | 63 |
| Ensure that resources like this ResultSet object are closed after use | 65 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 65–66 |
| Avoid variables with short names like rs | 65 |
| Avoid variables with short names like rs | 65 |
| Avoid variables with short names like d | 68 |
| Avoid variables with short names like d | 68 |
| A method should have only one exit point, and that should be the last statement in the method | 70 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 71 |
| Avoid variables with short names like t2 | 98 |
| Avoid variables with short names like t1 | 98 |
| Avoid variables with short names like t1 | 98 |
| Avoid variables with short names like t2 | 98 |
| Avoid variables with short names like ct | 100 |
| Avoid variables with short names like ct | 100 |
| Avoid variables with short names like t1 | 118 |
| Avoid variables with short names like t1 | 118 |
| Avoid variables with short names like t2 | 118 |
| Found 'UR'-anomaly for variable 'day' (lines '118'-'137'). | 118–137 |
| Avoid variables with short names like t2 | 118 |
| Avoid using if statements without curly braces | 119–120 |
| A method should have only one exit point, and that should be the last statement in the method | 120 |
| A method should have only one exit point, and that should be the last statement in the method | 126 |
| When instantiating a SimpleDateFormat object, specify a Locale | 130 |
| Avoid using if statements without curly braces | 140–141 |
| Avoid using if statements without curly braces | 143–144 |
| Avoid using if statements without curly braces | 145–146 |
| Ensure that resources like this ResultSet object are closed after use | 148 |
| Avoid variables with short names like rs | 148 |
| Avoid variables with short names like rs | 148 |
| Avoid using if statements without curly braces | 153–154 |
| Avoid using if statements without curly braces | 155–156 |
| Avoid instantiating new objects inside loops | 157 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 162 |
| A method should have only one exit point, and that should be the last statement in the method | 165 |
| Avoid using final local variables, turn them into fields | 168 |
| Found 'DU'-anomaly for variable 'epsilon' (lines '168'-'201'). | 168–201 |
| Found 'DU'-anomaly for variable 'last' (lines '172'-'201'). | 172–201 |
| Avoid using if statements without curly braces | 178–179 |
| Avoid using if statements without curly braces | 180–181 |
| Avoid using if statements without curly braces | 182–183 |
| Avoid using if statements without curly braces | 184–185 |
| Avoid instantiating new objects inside loops | 187 |
| Found 'DU'-anomaly for variable 'last' (lines '190'-'201'). | 190–201 |
| A method should have only one exit point, and that should be the last statement in the method | 196 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 197 |
| Avoid printStackTrace(); use a logger call instead. | 198 |
| Avoid variables with short names like t2 | 218 |
| Avoid variables with short names like t1 | 218 |
| Avoid variables with short names like t1 | 218 |
| Avoid variables with short names like t2 | 218 |
| Avoid variables with short names like rs | 227 |
| Avoid variables with short names like rs | 227 |
| Avoid variables with short names like b | 228 |
| Avoid variables with short names like b | 228 |
| Avoid variables with short names like bs | 229 |
| Found 'DD'-anomaly for variable 'bs' (lines '229'-'230'). | 229–230 |
| Avoid variables with short names like bs | 229 |
| Avoid variables with short names like t1 | 246 |
| Found 'UR'-anomaly for variable 'date' (lines '246'-'271'). | 246–271 |
| Avoid variables with short names like t2 | 246 |
| Avoid variables with short names like t2 | 246 |
| Avoid variables with short names like t1 | 246 |
| Found 'DU'-anomaly for variable 'numSamplesCounter' (lines '248'-'332'). | 248–332 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 248 |
| Avoid using if statements without curly braces | 249–250 |
| A method should have only one exit point, and that should be the last statement in the method | 250 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 252 |
| Avoid variables with short names like ct | 252 |
| Avoid variables with short names like ct | 252 |
| Found 'DU'-anomaly for variable 'ct' (lines '252'-'332'). | 252–332 |
| Found 'DU'-anomaly for variable 'bufs' (lines '254'-'332'). | 254–332 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 255 |
| Found 'DU'-anomaly for variable 'endDate' (lines '255'-'332'). | 255–332 |
| Found 'DU'-anomaly for variable 'done' (lines '256'-'332'). | 256–332 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 256 |
| Avoid variables with short names like rs | 257 |
| Found 'DD'-anomaly for variable 'rs' (lines '257'-'305'). | 257–305 |
| Avoid variables with short names like rs | 257 |
| Found 'DU'-anomaly for variable 'rs' (lines '257'-'332'). | 257–332 |
| Found 'DD'-anomaly for variable 'rs' (lines '257'-'276'). | 257–276 |
| Avoid variables with short names like ps | 273 |
| Avoid variables with short names like ps | 273 |
| These nested if statements could be combined | 278–287 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 279 |
| Found 'DU'-anomaly for variable 'buf' (lines '279'-'332'). | 279–332 |
| Deeply nested if..then statements are hard to read | 281–285 |
| The String literal " rows) " appears 5 times in this file; the first occurrence is on line 282 | 282 |
| The String literal "Max rows (" appears 5 times in this file; the first occurrence is on line 282 | 282 |
| The String literal "for data source " appears 5 times in this file; the first occurrence is on line 283 | 283 |
| The String literal "exceeded." appears 5 times in this file; the first occurrence is on line 284 | 284 |
| Avoid using if statements without curly braces | 298–299 |
| Found 'DU'-anomaly for variable 'done' (lines '299'-'332'). | 299–332 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 314 |
| Avoid using if statements without curly braces | 316–318 |
| A method should have only one exit point, and that should be the last statement in the method | 324 |
| Avoid variables with short names like st | 349 |
| Avoid variables with short names like st | 349 |
| Avoid variables with short names like et | 349 |
| Avoid variables with short names like sr | 349 |
| Avoid variables with short names like sr | 349 |
| Avoid variables with short names like et | 349 |
| Avoid variables with short names like t1 | 353 |
| publicMethodCommentRequirement Required | 353–369 |
| Avoid variables with short names like t2 | 353 |
| Found 'UR'-anomaly for variable 'buf' (lines '353'-'362'). | 353–362 |
| Avoid variables with short names like t1 | 353 |
| Avoid variables with short names like t2 | 353 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 356 |
| Avoid using if statements without curly braces | 356–357 |
| A method should have only one exit point, and that should be the last statement in the method | 357 |
| Avoid using for statements without curly braces | 361–362 |
| Avoid instantiating new objects inside loops | 362 |
| A method should have only one exit point, and that should be the last statement in the method | 364 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 365 |
| Avoid variables with short names like t1 | 383 |
| Avoid variables with short names like t1 | 383 |
| Avoid variables with short names like t2 | 383 |
| Avoid variables with short names like t2 | 383 |
| Avoid using if statements without curly braces | 385–386 |
| A method should have only one exit point, and that should be the last statement in the method | 386 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 389 |
| Avoid using if...else statements without curly braces | 390 |
| A method should have only one exit point, and that should be the last statement in the method | 390 |
| publicMethodCommentRequirement Required | 398–464 |
| Avoid variables with short names like t2 | 398 |
| Avoid variables with short names like t1 | 398 |
| Avoid variables with short names like t2 | 398 |
| Avoid variables with short names like t1 | 398 |
| Avoid using if statements without curly braces | 400–401 |
| A method should have only one exit point, and that should be the last statement in the method | 401 |
| Found 'DU'-anomaly for variable 'ct' (lines '403'-'464'). | 403–464 |
| Avoid variables with short names like ct | 403 |
| Avoid variables with short names like ct | 403 |
| Found 'DU'-anomaly for variable 'endDate' (lines '407'-'464'). | 407–464 |
| Found 'DU'-anomaly for variable 'list' (lines '409'-'464'). | 409–464 |
| Avoid using if statements without curly braces | 412–413 |
| Found 'DU'-anomaly for variable 'done' (lines '413'-'464'). | 413–464 |
| Avoid variables with short names like rs | 416 |
| Found 'DD'-anomaly for variable 'rs' (lines '416'-'445'). | 416–445 |
| Found 'DD'-anomaly for variable 'rs' (lines '416'-'431'). | 416–431 |
| Avoid variables with short names like rs | 416 |
| Prefer StringBuffer over += for concatenating strings | 421 |
| Avoid variables with short names like s | 426 |
| Avoid variables with short names like s | 426 |
| The String literal "FROM" appears 4 times in this file; the first occurrence is on line 427 | 427 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 432 |
| Avoid using if statements without curly braces | 436–438 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 446 |
| Avoid instantiating new objects inside loops | 452 |
| Avoid variables with short names like d | 452 |
| Avoid variables with short names like d | 452 |
| A method should have only one exit point, and that should be the last statement in the method | 459 |
| Avoid variables with short names like t1 | 466 |
| publicMethodCommentRequirement Required | 466–550 |
| Avoid variables with short names like t2 | 466 |
| Avoid variables with short names like t2 | 466 |
| Avoid variables with short names like t1 | 466 |
| Avoid variables with short names like ds | 467 |
| Avoid variables with short names like ds | 467 |
| Avoid using if statements without curly braces | 468–469 |
| A method should have only one exit point, and that should be the last statement in the method | 469 |
| Found 'DU'-anomaly for variable 'ct' (lines '472'-'550'). | 472–550 |
| Avoid variables with short names like ct | 472 |
| Avoid variables with short names like ct | 472 |
| Found 'DU'-anomaly for variable 'endDate' (lines '476'-'550'). | 476–550 |
| Found 'DU'-anomaly for variable 'numSamplesCounter' (lines '478'-'550'). | 478–550 |
| Found 'DU'-anomaly for variable 'list' (lines '479'-'550'). | 479–550 |
| Avoid using if statements without curly braces | 482–483 |
| Found 'DU'-anomaly for variable 'done' (lines '483'-'550'). | 483–550 |
| Found 'DU'-anomaly for variable 'rs' (lines '486'-'550'). | 486–550 |
| Avoid variables with short names like rs | 486 |
| Avoid variables with short names like rs | 486 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 486 |
| Found 'DD'-anomaly for variable 'sql' (lines '487'-'490'). | 487–490 |
| Avoid using exceptions as flow control. | 491 |
| New exception is thrown in catch block, original stack trace may be lost | 492 |
| Prefer StringBuffer over += for concatenating strings | 495 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 511 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 525 |
| Avoid variables with short names like d | 540 |
| Avoid instantiating new objects inside loops | 540 |
| Avoid variables with short names like d | 540 |
| A method should have only one exit point, and that should be the last statement in the method | 545 |
| Found 'UR'-anomaly for variable 'column' (lines '557'-'573'). | 557–573 |
| Avoid variables with short names like ds | 558 |
| Avoid variables with short names like ds | 558 |
| Avoid using if statements without curly braces | 559–560 |
| A method should have only one exit point, and that should be the last statement in the method | 562 |
| Avoid using if...else statements without curly braces | 562 |
| Avoid using if...else statements without curly braces | 564–565 |
| A method should have only one exit point, and that should be the last statement in the method | 564–565 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 567 |
| Avoid excessively long variable names like sql_from_where_clause | 568 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 568 |
| Avoid excessively long variable names like sql_from_where_clause | 568 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 569 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'avg_sql' is not final. | 571 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'avg_sql' is not final. | 571 |
| Prefer StringBuffer over += for concatenating strings | 573 |
| Prefer StringBuffer over += for concatenating strings | 575 |
| Prefer StringBuffer over += for concatenating strings | 576 |
| Prefer StringBuffer over += for concatenating strings | 577 |
| Avoid using if...else statements without curly braces | 580 |
| publicMethodCommentRequirement Required | 583–585 |
| Avoid variables with short names like rs | 587 |
| Avoid variables with short names like rs | 587 |
| publicMethodCommentRequirement Required | 587–602 |
| A method should have only one exit point, and that should be the last statement in the method | 589 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 25 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 25 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 25 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 26 |
| fieldCommentRequirement Required | 26 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 26 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 28 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 28 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 29 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 29 |
| fieldCommentRequirement Required | 30 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 30 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 30 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 41 |
| This final field could be made static | 41 |
| fieldCommentRequirement Required | 43 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 49 |
| publicMethodCommentRequirement Required | 51–57 |
| Overridable method 'processConfigFile' called during object construction | 53 |
| Overridable method 'deriveAll' called during object construction | 56 |
| publicMethodCommentRequirement Required | 59–80 |
| Avoid variables with short names like t | 65 |
| Avoid variables with short names like t | 65 |
| System.err.println is used | 71 |
| publicMethodCommentRequirement Required | 82–87 |
| Found 'UR'-anomaly for variable 'channel' (lines '82'-'84'). | 82–84 |
| Avoid variables with short names like t2 | 89 |
| Avoid variables with short names like t2 | 89 |
| Avoid variables with short names like ch | 89 |
| Avoid variables with short names like t1 | 89 |
| Avoid variables with short names like t1 | 89 |
| Avoid variables with short names like ch | 89 |
| Avoid variables with short names like ct | 92 |
| Avoid variables with short names like ct | 92 |
| Found 'DD'-anomaly for variable 'tbs' (lines '93'-'102'). | 93–102 |
| Found 'DU'-anomaly for variable 'tbs' (lines '93'-'116'). | 93–116 |
| Avoid using if statements without curly braces | 95–96 |
| Avoid instantiating new objects inside loops | 100 |
| Avoid empty catch blocks | 103–104 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 107 |
| Avoid instantiating new objects inside loops | 108 |
| publicMethodCommentRequirement Required | 118–120 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 118 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 19 |
| Perhaps 'winston' could be replaced by a local variable. | 19 |
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| Avoid variables with short names like w | 26 |
| Avoid variables with short names like w | 26 |
| publicMethodCommentRequirement Required | 26–29 |
| publicMethodCommentRequirement Required | 31–36 |
| publicMethodCommentRequirement Required | 38–66 |
| Avoid variables with short names like t1 | 38 |
| Avoid variables with short names like t2 | 38 |
| Avoid variables with short names like t2 | 38 |
| Avoid variables with short names like t1 | 38 |
| Avoid using final local variables, turn them into fields | 40 |
| Found 'DU'-anomaly for variable 'maxSize' (lines '40'-'66'). | 40–66 |
| Avoid variables with short names like ct | 43 |
| Avoid variables with short names like ct | 43 |
| Found 'DD'-anomaly for variable 'cnt' (lines '44'-'61'). | 44–61 |
| Found 'DU'-anomaly for variable 'cnt' (lines '44'-'66'). | 44–66 |
| Avoid variables with short names like sw | 46 |
| Avoid variables with short names like sw | 46 |
| System.out.println is used | 60 |
| Found 'DU'-anomaly for variable 'cnt' (lines '61'-'66'). | 61–66 |
| Found 'DD'-anomaly for variable 'cnt' (lines '61'-'61'). | 61 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 63 |
| Avoid printStackTrace(); use a logger call instead. | 64 |
| publicMethodCommentRequirement Required | 68–95 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 68 |
| Avoid using Literals in Conditional Statements | 69 |
| System.out.println is used | 70 |
| System.out.println is used | 72 |
| System.out.println is used | 73 |
| System.out.println is used | 75 |
| System.out.println is used | 76 |
| System.out.println is used | 77 |
| System.out.println is used | 78 |
| System.out.println is used | 79 |
| System.out.println is used | 80 |
| When instantiating a SimpleDateFormat object, specify a Locale | 87 |
| Avoid variables with short names like t1 | 89 |
| Avoid variables with short names like t1 | 89 |
| Avoid variables with short names like t2 | 90 |
| Avoid variables with short names like t2 | 90 |
| System.out.println is used | 91 |
| Violation | Line |
|---|---|
| Possible God class (WMC=83, ATFD=99, TCC=0.041666666666666664) | 1–685 |
| headerCommentRequirement Required | 38–71 |
| fieldCommentRequirement Required | 39 |
| Use explicit scoping instead of the default package private level | 39 |
| Use explicit scoping instead of the default package private level | 40 |
| Avoid using implementation types like 'TreeMap'; use the interface instead | 40 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| Avoid variables with short names like t1 | 41 |
| Use explicit scoping instead of the default package private level | 41 |
| Avoid variables with short names like t1 | 41 |
| fieldCommentRequirement Required | 42 |
| Avoid variables with short names like t2 | 42 |
| Use explicit scoping instead of the default package private level | 42 |
| Avoid variables with short names like t2 | 42 |
| Avoid variables with short names like c | 44 |
| publicMethodCommentRequirement Required | 44–49 |
| Avoid variables with short names like c | 44 |
| publicMethodCommentRequirement Required | 51–53 |
| publicMethodCommentRequirement Required | 55–57 |
| Avoid variables with short names like d | 60 |
| publicMethodCommentRequirement Required | 60–70 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 60 |
| Avoid variables with short names like d | 60 |
| Avoid using Literals in Conditional Statements | 62 |
| Avoid variables with short names like it | 64 |
| Avoid variables with short names like it | 64 |
| Found 'DU'-anomaly for variable 'it' (lines '64'-'70'). | 64–70 |
| enumCommentRequirement Required | 73–75 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 77 |
| fieldCommentRequirement Required | 77 |
| fieldCommentRequirement Required | 78 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 78 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 78 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 79 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 79 |
| fieldCommentRequirement Required | 79 |
| fieldCommentRequirement Required | 81 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 81 |
| fieldCommentRequirement Required | 82 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 82 |
| fieldCommentRequirement Required | 84 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 84 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 86 |
| fieldCommentRequirement Required | 86 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 86 |
| fieldCommentRequirement Required | 88 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 88 |
| Avoid using redundant field initializer for 'maxDays' | 88 |
| fieldCommentRequirement Required | 90 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 90 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 92 |
| fieldCommentRequirement Required | 92 |
| Avoid using redundant field initializer for 'writeLocks' | 92 |
| publicMethodCommentRequirement Required | 138–145 |
| Avoid variables with short names like w | 138 |
| Avoid variables with short names like w | 138 |
| When instantiating a SimpleDateFormat object, specify a Locale | 143 |
| publicMethodCommentRequirement Required | 147–165 |
| Found 'DD'-anomaly for variable 'mint' (lines '150'-'155'). | 150–155 |
| Found 'DD'-anomaly for variable 'maxt' (lines '151'-'159'). | 151–159 |
| Avoid variables with short names like rs | 153 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 153 |
| Avoid variables with short names like rs | 153 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 153 |
| Ensure that resources like this ResultSet object are closed after use | 153 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 162 |
| A method should have only one exit point, and that should be the last statement in the method | 181 |
| Ensure that resources like this ResultSet object are closed after use | 185 |
| Avoid variables with short names like rs | 185 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 185–186 |
| Avoid variables with short names like rs | 185 |
| A method should have only one exit point, and that should be the last statement in the method | 192 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 193 |
| The String literal "` (" appears 4 times in this file; the first occurrence is on line 202 | 202 |
| The String literal "CREATE TABLE `" appears 4 times in this file; the first occurrence is on line 202 | 202 |
| The String literal "$$H" appears 9 times in this file; the first occurrence is on line 207 | 207 |
| A method should have only one exit point, and that should be the last statement in the method | 211 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 212 |
| A method should have only one exit point, and that should be the last statement in the method | 228 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 229 |
| publicMethodCommentRequirement Required | 235–261 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 237 |
| Found 'DU'-anomaly for variable 'list' (lines '237'-'261'). | 237–261 |
| A method should have only one exit point, and that should be the last statement in the method | 239 |
| Ensure that resources like this ResultSet object are closed after use | 241 |
| Avoid variables with short names like rs | 241 |
| Avoid variables with short names like rs | 241 |
| A method should have only one exit point, and that should be the last statement in the method | 256 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 257 |
| Avoid variables with short names like tb | 269 |
| Avoid variables with short names like tb | 269 |
| Found 'DD'-anomaly for variable 'result' (lines '270'-'377'). | 270–377 |
| Found 'DU'-anomaly for variable 'result' (lines '270'-'382'). | 270–382 |
| Avoid variables with short names like ts | 283 |
| Avoid variables with short names like ts | 283 |
| Found 'DU'-anomaly for variable 'createdTable' (lines '285'-'382'). | 285–382 |
| Found 'DD'-anomaly for variable 'createdTable' (lines '285'-'288'). | 285–288 |
| Found 'DU'-anomaly for variable 'table' (lines '324'-'382'). | 324–382 |
| Found 'DD'-anomaly for variable 'heliList' (lines '327'-'354'). | 327–354 |
| Found 'DD'-anomaly for variable 'j' (lines '328'-'359'). | 328–359 |
| Avoid variables with short names like j | 328 |
| Found 'DU'-anomaly for variable 'j' (lines '328'-'382'). | 328–382 |
| Avoid variables with short names like j | 328 |
| Avoid variables with short names like d | 330 |
| Avoid variables with short names like d | 330 |
| Avoid using final local variables, turn them into fields | 332 |
| Avoid instantiating new objects inside loops | 349 |
| Found 'DD'-anomaly for variable 'heliList' (lines '354'-'354'). | 354 |
| Found 'DU'-anomaly for variable 'st' (lines '356'-'382'). | 356–382 |
| Avoid variables with short names like st | 356 |
| Avoid variables with short names like st | 356 |
| Found 'DU'-anomaly for variable 'dt' (lines '357'-'382'). | 357–382 |
| Avoid variables with short names like dt | 357 |
| Avoid variables with short names like dt | 357 |
| Avoid variables with short names like d | 360 |
| Avoid variables with short names like d | 360 |
| Found 'DD'-anomaly for variable 'd' (lines '360'-'362'). | 360–362 |
| The String literal "UPDATE `" appears 4 times in this file; the first occurrence is on line 372 | 372 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 378 |
| Avoid variables with short names like tb | 397 |
| Avoid variables with short names like tb | 397 |
| Avoid variables with short names like ts | 410 |
| Avoid variables with short names like ts | 410 |
| A method should have only one exit point, and that should be the last statement in the method | 436 |
| Found 'DU'-anomaly for variable 'table' (lines '447'-'514'). | 447–514 |
| Found 'DD'-anomaly for variable 'heliList' (lines '450'-'477'). | 450–477 |
| Found 'DU'-anomaly for variable 'j' (lines '451'-'514'). | 451–514 |
| Avoid variables with short names like j | 451 |
| Found 'DD'-anomaly for variable 'j' (lines '451'-'482'). | 451–482 |
| Avoid variables with short names like j | 451 |
| Avoid variables with short names like d | 453 |
| Avoid variables with short names like d | 453 |
| Found 'DD'-anomaly for variable 'filled' (lines '455'-'460'). | 455–460 |
| Avoid variables with short names like rs | 457 |
| Ensure that resources like this ResultSet object are closed after use | 457 |
| Avoid variables with short names like rs | 457 |
| Avoid instantiating new objects inside loops | 461–462 |
| Found 'DD'-anomaly for variable 'd' (lines '461'-'467'). | 461–467 |
| Avoid instantiating new objects inside loops | 467 |
| Found 'DD'-anomaly for variable 'heliList' (lines '477'-'477'). | 477 |
| Avoid variables with short names like st | 479 |
| Found 'DU'-anomaly for variable 'st' (lines '479'-'514'). | 479–514 |
| Avoid variables with short names like st | 479 |
| Found 'DU'-anomaly for variable 'dt' (lines '480'-'514'). | 480–514 |
| Avoid variables with short names like dt | 480 |
| Avoid variables with short names like dt | 480 |
| Avoid variables with short names like d | 483 |
| Found 'DD'-anomaly for variable 'd' (lines '483'-'485'). | 483–485 |
| Avoid variables with short names like d | 483 |
| A method should have only one exit point, and that should be the last statement in the method | 509 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 510 |
| Avoid reassigning parameters such as 'admin' | 535 |
| Found 'UR'-anomaly for variable 'table' (lines '535'-'556'). | 535–556 |
| A method should have only one exit point, and that should be the last statement in the method | 537 |
| Avoid variables with short names like df | 540 |
| Avoid variables with short names like df | 540 |
| When instantiating a SimpleDateFormat object, specify a Locale | 540 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 548 |
| A method should have only one exit point, and that should be the last statement in the method | 550 |
| Found 'DU'-anomaly for variable 'deleted' (lines '553'-'600'). | 553–600 |
| Found 'DD'-anomaly for variable 'deleted' (lines '553'-'568'). | 553–568 |
| Found 'DU'-anomaly for variable 'setTime' (lines '554'-'600'). | 554–600 |
| Found 'DD'-anomaly for variable 'setTime' (lines '554'-'583'). | 554–583 |
| Avoid variables with short names like ss | 556 |
| Avoid variables with short names like ss | 556 |
| A method should have only one exit point, and that should be the last statement in the method | 561 |
| Found 'DU'-anomaly for variable 'deleted' (lines '568'-'600'). | 568–600 |
| Found 'DD'-anomaly for variable 'deleted' (lines '568'-'568'). | 568 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 570 |
| Ensure that resources like this ResultSet object are closed after use | 577 |
| Avoid variables with short names like rs | 577 |
| Avoid variables with short names like rs | 577 |
| Avoid variables with short names like t1 | 580 |
| Avoid variables with short names like t1 | 580 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 584 |
| Avoid variables with short names like i | 609 |
| Avoid variables with short names like i | 609 |
| Avoid variables with short names like st | 615 |
| Avoid variables with short names like et | 615 |
| Avoid variables with short names like st | 615 |
| Avoid variables with short names like et | 615 |
| publicMethodCommentRequirement Required | 615–639 |
| Found 'DU'-anomaly for variable 'opt' (lines '620'-'639'). | 620–639 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 636 |
| publicMethodCommentRequirement Required | 641–643 |
| Avoid variables with short names like db | 641 |
| Avoid variables with short names like db | 641 |
| Avoid variables with short names like b | 645 |
| publicMethodCommentRequirement Required | 645–647 |
| Avoid variables with short names like b | 645 |
| A method should have only one exit point, and that should be the last statement in the method | 652 |
| Avoid variables with short names like rs | 656 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 656–657 |
| Ensure that resources like this ResultSet object are closed after use | 656 |
| Avoid variables with short names like rs | 656 |
| A method should have only one exit point, and that should be the last statement in the method | 663 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 664 |
| Avoid empty catch blocks | 664–665 |
| publicMethodCommentRequirement Required | 671–684 |
| Assigning an Object to null is a code smell. Consider refactoring. | 678 |
| Violation | Line |
|---|---|
| Possible God class (WMC=105, ATFD=126, TCC=0.017543859649122806) | 1–806 |
| headerCommentRequirement Required | 43–51 |
| fieldCommentRequirement Required | 44 |
| Avoid variables with short names like MU | 45 |
| Avoid variables with short names like MU | 45 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| headerCommentRequirement Required | 53–66 |
| enumCommentRequirement Required | 54–56 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 59 |
| fieldCommentRequirement Required | 60 |
| Avoid variables with short names like tb | 62 |
| publicMethodCommentRequirement Required | 62–65 |
| Avoid variables with short names like c | 62 |
| Avoid variables with short names like c | 62 |
| Avoid variables with short names like tb | 62 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 68 |
| fieldCommentRequirement Required | 68 |
| Possible unsafe assignment to a non-final static field in a constructor. | 68 |
| Possible unsafe assignment to a non-final static field in a constructor. | 75 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 75 |
| fieldCommentRequirement Required | 75 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 76 |
| fieldCommentRequirement Required | 76 |
| Avoid excessively long variable names like channelHelicorderRows | 79 |
| Avoid excessively long variable names like channelHelicorderRows | 79 |
| fieldCommentRequirement Required | 79 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 79 |
| fieldCommentRequirement Required | 81 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 81 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 82 |
| fieldCommentRequirement Required | 82 |
| Avoid using redundant field initializer for 'enableValarmView' | 84 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 84 |
| fieldCommentRequirement Required | 84 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 86 |
| fieldCommentRequirement Required | 86 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 87 |
| fieldCommentRequirement Required | 87 |
| fieldCommentRequirement Required | 88 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 88 |
| Avoid variables with short names like w | 96 |
| Avoid variables with short names like w | 96 |
| When instantiating a SimpleDateFormat object, specify a Locale | 104 |
| The String literal "$$H" appears 6 times in this file; the first occurrence is on line 125 | 125 |
| Found 'DU'-anomaly for variable 'waveTableLast' (lines '126'-'168'). | 126–168 |
| Found 'DU'-anomaly for variable 'heliTableLast' (lines '127'-'168'). | 127–168 |
| Found 'DU'-anomaly for variable 'waveTableall' (lines '128'-'168'). | 128–168 |
| Found 'DU'-anomaly for variable 'heliTableall' (lines '129'-'168'). | 129–168 |
| System.out.println is used | 135–136 |
| Prefer StringBuffer over += for concatenating strings | 152 |
| Prefer StringBuffer over += for concatenating strings | 158 |
| A method should have only one exit point, and that should be the last statement in the method | 163 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 164 |
| Found 'UR'-anomaly for variable 'table' (lines '170'-'183'). | 170–183 |
| Avoid variables with short names like rs | 173 |
| Ensure that resources like this ResultSet object are closed after use | 173 |
| Avoid variables with short names like rs | 173 |
| A method should have only one exit point, and that should be the last statement in the method | 189 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 190 |
| Avoid variables with short names like d | 218 |
| Avoid variables with short names like d | 218 |
| A method should have only one exit point, and that should be the last statement in the method | 220 |
| Found 'DU'-anomaly for variable 'table' (lines '224'-'251'). | 224–251 |
| Ensure that resources like this ResultSet object are closed after use | 228 |
| Avoid variables with short names like rs | 228 |
| Avoid variables with short names like rs | 228 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 235 |
| Avoid variables with short names like tb | 253 |
| Avoid variables with short names like tb | 253 |
| A method should have only one exit point, and that should be the last statement in the method | 256 |
| A method should have only one exit point, and that should be the last statement in the method | 263 |
| Avoid reassigning parameters such as 'delta' | 281 |
| A method should have only one exit point, and that should be the last statement in the method | 285 |
| Found 'DU'-anomaly for variable 'sampleSum' (lines '289'-'304'). | 289–304 |
| Avoid variables with short names like hr | 292 |
| Avoid variables with short names like hr | 292 |
| Avoid if (x != y) ..; else ..; | 299–303 |
| A method should have only one exit point, and that should be the last statement in the method | 300 |
| Avoid variables with short names like c | 306 |
| Avoid variables with short names like c | 306 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 306 |
| Avoid variables with short names like rs | 309 |
| Avoid variables with short names like rs | 309 |
| Ensure that resources like this ResultSet object are closed after use | 309 |
| Return an empty array rather than null. | 327–348 |
| Avoid variables with short names like d | 328 |
| Avoid variables with short names like d | 328 |
| A method should have only one exit point, and that should be the last statement in the method | 330 |
| Avoid variables with short names like rs | 334 |
| Ensure that resources like this ResultSet object are closed after use | 334 |
| Avoid variables with short names like rs | 334 |
| Found 'DD'-anomaly for variable 'd' (lines '336'-'338'). | 336–338 |
| Found 'DD'-anomaly for variable 'd' (lines '338'-'339'). | 338–339 |
| A method should have only one exit point, and that should be the last statement in the method | 343 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 344 |
| Avoid variables with short names like m | 362 |
| Avoid variables with short names like m | 362 |
| Avoid if (x != y) ..; else ..; | 364–388 |
| Found 'DU'-anomaly for variable 'sid' (lines '368'-'389'). | 368–389 |
| Avoid variables with short names like ps | 370 |
| Avoid variables with short names like ps | 370 |
| Found 'DU'-anomaly for variable 'ps' (lines '370'-'389'). | 370–389 |
| Avoid variables with short names like it | 372 |
| Avoid variables with short names like it | 372 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 384 |
| Avoid printStackTrace(); use a logger call instead. | 386 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 410 |
| A method should have only one exit point, and that should be the last statement in the method | 411 |
| A method should have only one exit point, and that should be the last statement in the method | 415 |
| A method should have only one exit point, and that should be the last statement in the method | 421 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 424 |
| Found 'DU'-anomaly for variable 'stBefore' (lines '424'-'523'). | 424–523 |
| A method should have only one exit point, and that should be the last statement in the method | 427 |
| Avoid variables with short names like it | 434 |
| Avoid variables with short names like it | 434 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '436'-'461'). | 436–461 |
| Found 'DU'-anomaly for variable 'tableCreated' (lines '436'-'523'). | 436–523 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '436'-'457'). | 436–457 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '436'-'497'). | 436–497 |
| Avoid variables with short names like tb | 437 |
| Avoid variables with short names like tb | 437 |
| Avoid instantiating new objects inside loops | 438 |
| Avoid variables with short names like ts | 449 |
| Avoid variables with short names like ts | 449 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '457'-'461'). | 457–461 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '457'-'497'). | 457–497 |
| Found 'DU'-anomaly for variable 'tableCreated' (lines '457'-'523'). | 457–523 |
| Found 'DU'-anomaly for variable 'tableCreated' (lines '461'-'523'). | 461–523 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '461'-'497'). | 461–497 |
| Found 'DD'-anomaly for variable 'tableCreated' (lines '497'-'436'). | 497–436 |
| Found 'DU'-anomaly for variable 'tableCreated' (lines '497'-'523'). | 497–523 |
| Found 'UR'-anomaly for variable 'table' (lines '525'-'552'). | 525–552 |
| publicMethodCommentRequirement Required | 525–589 |
| A method should have only one exit point, and that should be the last statement in the method | 527 |
| A method should have only one exit point, and that should be the last statement in the method | 531 |
| A method should have only one exit point, and that should be the last statement in the method | 535 |
| Found 'DD'-anomaly for variable 'deleted' (lines '549'-'560'). | 549–560 |
| Found 'DD'-anomaly for variable 'setTime' (lines '550'-'575'). | 550–575 |
| Avoid variables with short names like ss | 552 |
| Avoid variables with short names like ss | 552 |
| Found 'DD'-anomaly for variable 'deleted' (lines '560'-'560'). | 560 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 562 |
| Avoid variables with short names like rs | 569 |
| Ensure that resources like this ResultSet object are closed after use | 569 |
| Avoid variables with short names like rs | 569 |
| Avoid variables with short names like t1 | 572 |
| Avoid variables with short names like t1 | 572 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 576 |
| publicMethodCommentRequirement Required | 591–627 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 593 |
| A method should have only one exit point, and that should be the last statement in the method | 594 |
| A method should have only one exit point, and that should be the last statement in the method | 598 |
| A method should have only one exit point, and that should be the last statement in the method | 604 |
| Avoid variables with short names like it | 608 |
| Avoid variables with short names like it | 608 |
| Avoid variables with short names like tb | 610 |
| Avoid variables with short names like tb | 610 |
| Avoid variables with short names like ts | 619 |
| Avoid variables with short names like ts | 619 |
| publicMethodCommentRequirement Required | 629–632 |
| Avoid variables with short names like mr | 634 |
| Avoid variables with short names like mr | 634 |
| publicMethodCommentRequirement Required | 634–637 |
| Avoid variables with short names like nd | 634 |
| Avoid variables with short names like nd | 634 |
| Avoid variables with short names like et | 651 |
| Avoid variables with short names like st | 651 |
| Avoid variables with short names like et | 651 |
| Avoid variables with short names like st | 651 |
| Avoid variables with short names like d | 653 |
| Avoid variables with short names like d | 653 |
| Found 'DU'-anomaly for variable 'd' (lines '653'-'668'). | 653–668 |
| Found 'DU'-anomaly for variable 'd' (lines '656'-'668'). | 656–668 |
| Found 'DU'-anomaly for variable 'd' (lines '663'-'668'). | 663–668 |
| Avoid variables with short names like db | 676 |
| Avoid variables with short names like db | 676 |
| A method should have only one exit point, and that should be the last statement in the method | 692 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 696 |
| Ensure that resources like this ResultSet object are closed after use | 696 |
| Avoid variables with short names like rs | 696 |
| Avoid variables with short names like rs | 696 |
| A method should have only one exit point, and that should be the last statement in the method | 702 |
| Avoid empty catch blocks | 703–704 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 703 |
| Avoid variables with short names like tb | 730 |
| Avoid unused method parameters such as 'date'. | 730 |
| Avoid variables with short names like tb | 730 |
| Found 'DD'-anomaly for variable 'heliList' (lines '736'-'740'). | 736–740 |
| Found 'DU'-anomaly for variable 'heliList' (lines '736'-'770'). | 736–770 |
| Avoid variables with short names like j | 737 |
| Found 'DD'-anomaly for variable 'j' (lines '737'-'751'). | 737–751 |
| Avoid variables with short names like j | 737 |
| Found 'DU'-anomaly for variable 'j' (lines '737'-'770'). | 737–770 |
| Found 'DD'-anomaly for variable 'heliList' (lines '740'-'740'). | 740 |
| Found 'DD'-anomaly for variable 'heliList' (lines '740'-'743'). | 740–743 |
| Found 'DU'-anomaly for variable 'heliList' (lines '740'-'770'). | 740–770 |
| Avoid variables with short names like mu | 742 |
| Avoid variables with short names like mu | 742 |
| Found 'DD'-anomaly for variable 'heliList' (lines '743'-'740'). | 743–740 |
| Found 'DU'-anomaly for variable 'heliList' (lines '743'-'770'). | 743–770 |
| Found 'DD'-anomaly for variable 'j' (lines '745'-'751'). | 745–751 |
| Found 'DU'-anomaly for variable 'j' (lines '745'-'770'). | 745–770 |
| Found 'DU'-anomaly for variable 'st' (lines '747'-'770'). | 747–770 |
| Avoid variables with short names like st | 747 |
| Avoid variables with short names like st | 747 |
| Found 'DU'-anomaly for variable 'dt' (lines '748'-'770'). | 748–770 |
| Avoid variables with short names like dt | 748 |
| Avoid variables with short names like dt | 748 |
| Avoid variables with short names like d | 752 |
| Avoid variables with short names like d | 752 |
| Found 'DD'-anomaly for variable 'd' (lines '752'-'754'). | 752–754 |
| Found 'DD'-anomaly for variable 'd' (lines '766'-'752'). | 766–752 |
| Found 'DU'-anomaly for variable 'd' (lines '766'-'770'). | 766–770 |
| Found 'UR'-anomaly for variable 'j2k' (lines '780'-'784'). | 780–784 |
| A method should have only one exit point, and that should be the last statement in the method | 799 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| publicMethodCommentRequirement Required | 30–36 |
| Avoid using final local variables, turn them into fields | 31 |
| publicMethodCommentRequirement Required | 38–42 |
| publicMethodCommentRequirement Required | 44–99 |
| Found 'DD'-anomaly for variable 'total' (lines '48'-'54'). | 48–54 |
| Found 'DD'-anomaly for variable 'total' (lines '48'-'62'). | 48–62 |
| Ensure that resources like this ResultSet object are closed after use | 51 |
| The String literal "$$H" appears 4 times in this file; the first occurrence is on line 52 | 52 |
| Found 'DD'-anomaly for variable 'total' (lines '54'-'62'). | 54–62 |
| Found 'DD'-anomaly for variable 'total' (lines '54'-'54'). | 54 |
| Ensure that resources like this ResultSet object are closed after use | 60 |
| Found 'DD'-anomaly for variable 'total' (lines '62'-'68'). | 62–68 |
| Found 'DD'-anomaly for variable 'total' (lines '62'-'64'). | 62–64 |
| Found 'DD'-anomaly for variable 'total' (lines '64'-'64'). | 64 |
| Found 'DD'-anomaly for variable 'total' (lines '64'-'68'). | 64–68 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 65 |
| Avoid instantiating new objects inside loops | 65 |
| Found 'DD'-anomaly for variable 'total' (lines '68'-'89'). | 68–89 |
| Found 'DD'-anomaly for variable 'read' (lines '69'-'93'). | 69–93 |
| Found 'DU'-anomaly for variable 'insert' (lines '72'-'99'). | 72–99 |
| Avoid variables with short names like d | 76 |
| Avoid variables with short names like d | 76 |
| Avoid instantiating new objects inside loops | 85 |
| Found 'DD'-anomaly for variable 'total' (lines '89'-'89'). | 89 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 96 |
| publicMethodCommentRequirement Required | 101–156 |
| Found 'DD'-anomaly for variable 'total' (lines '105'-'111'). | 105–111 |
| Found 'DD'-anomaly for variable 'total' (lines '105'-'119'). | 105–119 |
| Ensure that resources like this ResultSet object are closed after use | 108 |
| Found 'DD'-anomaly for variable 'total' (lines '111'-'111'). | 111 |
| Found 'DD'-anomaly for variable 'total' (lines '111'-'119'). | 111–119 |
| Ensure that resources like this ResultSet object are closed after use | 117 |
| Found 'DD'-anomaly for variable 'total' (lines '119'-'121'). | 119–121 |
| Found 'DD'-anomaly for variable 'total' (lines '119'-'125'). | 119–125 |
| Found 'DD'-anomaly for variable 'total' (lines '121'-'125'). | 121–125 |
| Found 'DD'-anomaly for variable 'total' (lines '121'-'121'). | 121 |
| Avoid instantiating new objects inside loops | 122 |
| Found 'DD'-anomaly for variable 'total' (lines '125'-'146'). | 125–146 |
| Found 'DD'-anomaly for variable 'read' (lines '127'-'150'). | 127–150 |
| Found 'DU'-anomaly for variable 'insert' (lines '129'-'156'). | 129–156 |
| Avoid variables with short names like d | 133 |
| Avoid variables with short names like d | 133 |
| Avoid instantiating new objects inside loops | 142 |
| Found 'DD'-anomaly for variable 'total' (lines '146'-'146'). | 146 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 153 |
| publicMethodCommentRequirement Required | 158–164 |
| publicMethodCommentRequirement Required | 166–169 |
| publicMethodCommentRequirement Required | 171–181 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 171 |
| Avoid using Literals in Conditional Statements | 172 |
| System.err.println is used | 173 |
| System.err.println is used | 175 |
| System.err.println is used | 176 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 21 |
| publicMethodCommentRequirement Required | 23–25 |
| Avoid variables with short names like b | 23 |
| Avoid variables with short names like b | 23 |
| publicMethodCommentRequirement Required | 27–29 |
| protectedMethodCommentRequirement Required | 32–44 |
| Avoid variables with short names like ps | 33 |
| Avoid variables with short names like ps | 33 |
| Avoid variables with short names like ct | 35 |
| Avoid variables with short names like ct | 35 |
| A method should have only one exit point, and that should be the last statement in the method | 38 |
| System.err.println is used | 40 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 14 |
| fieldCommentRequirement Required | 15–16 |
| publicMethodCommentRequirement Required | 18–24 |
| Avoid variables with short names like cf | 19 |
| Avoid variables with short names like cf | 19 |
| Avoid variables with short names like db | 22 |
| Avoid variables with short names like db | 22 |
| headerCommentRequirement Required | 26–43 |
| Abstract classes should be named AbstractXXX | 26–43 |
| Abstract classes should be named AbstractXXX | 26–43 |
| Each class should declare at least one constructor | 26–43 |
| fieldCommentRequirement Required | 27 |
| Avoid excessively long variable names like destinationVersion | 28 |
| Avoid excessively long variable names like destinationVersion | 28 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 30 |
| publicMethodCommentRequirement Required | 32–34 |
| System.out.println is used | 33 |
| publicMethodCommentRequirement Required | 36–38 |
| publicMethodCommentRequirement Required | 40 |
| publicMethodCommentRequirement Required | 42 |
| headerCommentRequirement Required | 45–74 |
| publicMethodCommentRequirement Required | 46–52 |
| It is a good practice to call super() in a constructor | 46–52 |
| The String literal "Estimated execution time: under 1 second." appears 4 times in this file; the first occurrence is on line 50 | 50 |
| publicMethodCommentRequirement Required | 55–57 |
| publicMethodCommentRequirement Required | 60–73 |
| System.out.println is used | 62 |
| System.out.println is used | 66 |
| System.err.println is used | 70 |
| Avoid printStackTrace(); use a logger call instead. | 71 |
| headerCommentRequirement Required | 76–136 |
| It is a good practice to call super() in a constructor | 77–84 |
| publicMethodCommentRequirement Required | 77–84 |
| publicMethodCommentRequirement Required | 87–89 |
| publicMethodCommentRequirement Required | 92–135 |
| System.out.println is used | 94 |
| System.out.println is used | 101 |
| System.out.println is used | 109 |
| System.out.println is used | 118 |
| System.out.println is used | 123 |
| System.out.println is used | 128 |
| System.err.println is used | 132 |
| Avoid printStackTrace(); use a logger call instead. | 133 |
| headerCommentRequirement Required | 138–173 |
| It is a good practice to call super() in a constructor | 139–146 |
| publicMethodCommentRequirement Required | 139–146 |
| publicMethodCommentRequirement Required | 149–151 |
| publicMethodCommentRequirement Required | 154–172 |
| System.out.println is used | 156 |
| System.out.println is used | 160 |
| System.out.println is used | 163 |
| System.out.println is used | 165 |
| System.err.println is used | 169 |
| Avoid printStackTrace(); use a logger call instead. | 170 |
| publicMethodCommentRequirement Required | 175–186 |
| Avoid excessively long variable names like currentSchemaVersion | 178 |
| Found 'DU'-anomaly for variable 'currentSchemaVersion' (lines '178'-'186'). | 178–186 |
| Avoid excessively long variable names like currentSchemaVersion | 178 |
| Avoid using if statements without curly braces | 180–181 |
| A method should have only one exit point, and that should be the last statement in the method | 181 |
| publicMethodCommentRequirement Required | 188–202 |
| System.out.println is used | 191 |
| System.out.println is used | 193 |
| System.out.println is used | 194 |
| System.out.println is used | 195 |
| System.out.println is used | 196–197 |
| System.out.println is used | 199–200 |
| publicMethodCommentRequirement Required | 204–211 |
| Avoid using if...else statements without curly braces | 208 |
| A method should have only one exit point, and that should be the last statement in the method | 208 |
| Avoid using if...else statements without curly braces | 210 |
| publicMethodCommentRequirement Required | 213–227 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 213 |
| Avoid variables with short names like ug | 214 |
| Avoid variables with short names like ug | 214 |
| Avoid excessively long variable names like currentSchemaVersion | 218 |
| Avoid excessively long variable names like currentSchemaVersion | 218 |
| System.out.println is used | 219 |
| System.out.println is used | 220 |
| System.out.println is used | 222 |
| System.out.println is used | 223 |
| System.out.println is used | 224 |
| System.out.println is used | 225 |
| publicMethodCommentRequirement Required | 229–234 |
| A method should have only one exit point, and that should be the last statement in the method | 231 |
| Avoid using if...else statements without curly braces | 231 |
| Avoid using if...else statements without curly braces | 233 |
| publicMethodCommentRequirement Required | 236–238 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| Perhaps 'dateFormat' could be replaced by a local variable. | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| Avoid variables with short names like w | 43 |
| Avoid variables with short names like w | 43 |
| publicMethodCommentRequirement Required | 43–52 |
| When instantiating a SimpleDateFormat object, specify a Locale | 47 |
| publicMethodCommentRequirement Required | 54–56 |
| Avoid variables with short names like s | 54 |
| Avoid variables with short names like s | 54 |
| Avoid variables with short names like c | 54 |
| Avoid variables with short names like n | 54 |
| Avoid variables with short names like n | 54 |
| Avoid variables with short names like c | 54 |
| Avoid variables with short names like c | 58 |
| Avoid variables with short names like n | 58 |
| Avoid variables with short names like s | 58 |
| Avoid variables with short names like l | 58 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 58 |
| publicMethodCommentRequirement Required | 58–66 |
| Avoid variables with short names like s | 58 |
| Avoid variables with short names like n | 58 |
| Avoid variables with short names like l | 58 |
| Avoid variables with short names like c | 58 |
| Found 'DD'-anomaly for variable 'loc' (lines '59'-'61'). | 59–61 |
| Avoid variables with short names like id | 64 |
| Avoid variables with short names like id | 64 |
| Consider simply returning the value vs storing it in local variable 'id' | 65 |
| Found 'UR'-anomaly for variable 'st' (lines '84'-'97'). | 84–97 |
| publicMethodCommentRequirement Required | 84–121 |
| A method should have only one exit point, and that should be the last statement in the method | 87 |
| A method should have only one exit point, and that should be the last statement in the method | 92 |
| Found 'DD'-anomaly for variable 'ss' (lines '97'-'97'). | 97 |
| Avoid variables with short names like ss | 97 |
| Found 'DU'-anomaly for variable 'ss' (lines '97'-'121'). | 97–121 |
| Avoid variables with short names like ss | 97 |
| Found 'DD'-anomaly for variable 'ts' (lines '98'-'102'). | 98–102 |
| Avoid variables with short names like ts | 98 |
| Avoid variables with short names like ts | 98 |
| Avoid variables with short names like p | 123 |
| publicMethodCommentRequirement Required | 123–162 |
| Avoid variables with short names like p | 123 |
| A method should have only one exit point, and that should be the last statement in the method | 125 |
| Found 'DD'-anomaly for variable 'result' (lines '129'-'152'). | 129–152 |
| Ensure that resources like this ResultSet object are closed after use | 131 |
| Avoid variables with short names like rs | 131 |
| Avoid variables with short names like rs | 131 |
| Avoid variables with short names like ts | 135 |
| Avoid variables with short names like ts | 135 |
| Avoid variables with short names like st | 147 |
| Avoid variables with short names like st | 147 |
| Avoid variables with short names like ch | 149 |
| Avoid variables with short names like ch | 149 |
| Avoid variables with short names like nw | 150 |
| Avoid variables with short names like nw | 150 |
| A method should have only one exit point, and that should be the last statement in the method | 157 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 158 |
| publicMethodCommentRequirement Required | 164–177 |
| Avoid variables with short names like c | 164 |
| Avoid variables with short names like s | 164 |
| Avoid variables with short names like s | 164 |
| Avoid variables with short names like n | 164 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 164–165 |
| Avoid variables with short names like n | 164 |
| Avoid variables with short names like c | 164 |
| Avoid variables with short names like l | 165 |
| Avoid variables with short names like l | 165 |
| Found 'DD'-anomaly for variable 'loc' (lines '166'-'168'). | 166–168 |
| Avoid variables with short names like id | 171 |
| Avoid variables with short names like id | 171 |
| A method should have only one exit point, and that should be the last statement in the method | 173 |
| publicMethodCommentRequirement Required | 179–182 |
| Avoid variables with short names like t1 | 179 |
| Avoid variables with short names like s | 179 |
| Avoid variables with short names like c | 179 |
| Avoid variables with short names like s | 179 |
| Avoid variables with short names like n | 179 |
| Avoid variables with short names like n | 179 |
| Avoid variables with short names like c | 179 |
| Avoid variables with short names like t1 | 179 |
| Avoid variables with short names like t2 | 180 |
| Avoid variables with short names like t2 | 180 |
| Avoid variables with short names like c | 185 |
| Found 'UR'-anomaly for variable 'buf' (lines '185'-'210'). | 185–210 |
| Avoid variables with short names like n | 185 |
| Avoid variables with short names like n | 185 |
| Avoid variables with short names like s | 185 |
| publicMethodCommentRequirement Required | 185–224 |
| Return an empty array rather than null. | 185–224 |
| Avoid variables with short names like c | 185 |
| Avoid variables with short names like l | 185 |
| Avoid variables with short names like s | 185 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 185–186 |
| Avoid variables with short names like l | 185 |
| Avoid variables with short names like t2 | 186 |
| Avoid variables with short names like t2 | 186 |
| Avoid variables with short names like t1 | 186 |
| Avoid variables with short names like t1 | 186 |
| Found 'DD'-anomaly for variable 'lc' (lines '187'-'189'). | 187–189 |
| Avoid variables with short names like lc | 187 |
| Avoid variables with short names like lc | 187 |
| A method should have only one exit point, and that should be the last statement in the method | 193 |
| Found 'DD'-anomaly for variable 'bufs' (lines '195'-'197'). | 195–197 |
| Avoid empty catch blocks | 198–199 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 200 |
| A method should have only one exit point, and that should be the last statement in the method | 201 |
| Avoid variables with short names like lr | 213 |
| Avoid variables with short names like lr | 213 |
| Found 'DD'-anomaly for variable 'lr' (lines '213'-'215'). | 213–215 |
| A method should have only one exit point, and that should be the last statement in the method | 219 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 219 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 220 |
| Violation | Line |
|---|---|
| Possible God class (WMC=48, ATFD=14, TCC=0.0935672514619883) | 1–356 |
| fieldCommentRequirement Required | 27 |
| Avoid excessively long variable names like WINSTON_TABLE_DATE_FORMAT | 29 |
| fieldCommentRequirement Required | 29 |
| Avoid excessively long variable names like WINSTON_TABLE_DATE_FORMAT | 29 |
| Avoid excessively long variable names like CURRENT_SCHEMA_VERSION | 30 |
| Avoid excessively long variable names like CURRENT_SCHEMA_VERSION | 30 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| Avoid excessively long variable names like DEFAULT_DATABASE_PREFIX | 31 |
| Avoid excessively long variable names like DEFAULT_DATABASE_PREFIX | 31 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 32 |
| fieldCommentRequirement Required | 32 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 32 |
| fieldCommentRequirement Required | 33 |
| Avoid excessively long variable names like DEFAULT_CACHE_CAPACITY | 33 |
| Avoid excessively long variable names like DEFAULT_CACHE_CAPACITY | 33 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| Avoid excessively long variable names like preparedStatements | 50 |
| Avoid excessively long variable names like preparedStatements | 50 |
| fieldCommentRequirement Required | 50 |
| publicMethodCommentRequirement Required | 52–54 |
| publicMethodCommentRequirement Required | 56–59 |
| publicMethodCommentRequirement Required | 61–76 |
| Useless parentheses. | 72 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 91 |
| Assigning an Object to null is a code smell. Consider refactoring. | 92 |
| Assigning an Object to null is a code smell. Consider refactoring. | 93 |
| publicMethodCommentRequirement Required | 99–110 |
| Avoid using if statements without curly braces | 100–101 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 107 |
| publicMethodCommentRequirement Required | 112–129 |
| A method should have only one exit point, and that should be the last statement in the method | 114 |
| Avoid using if...else statements without curly braces | 114 |
| publicMethodCommentRequirement Required | 119–122 |
| Avoid empty catch blocks | 124–126 |
| publicMethodCommentRequirement Required | 131–133 |
| publicMethodCommentRequirement Required | 135–137 |
| publicMethodCommentRequirement Required | 139–141 |
| publicMethodCommentRequirement Required | 143–145 |
| publicMethodCommentRequirement Required | 147–159 |
| Avoid variables with short names like sv | 149 |
| Avoid variables with short names like sv | 149 |
| Found 'DD'-anomaly for variable 'sv' (lines '149'-'154'). | 149–154 |
| Avoid variables with short names like rs | 151 |
| Ensure that resources like this ResultSet object are closed after use | 151 |
| Avoid variables with short names like rs | 151 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 151–152 |
| Found 'DD'-anomaly for variable 'sv' (lines '154'-'156'). | 154–156 |
| Found 'DD'-anomaly for variable 'b' (lines '162'-'164'). | 162–164 |
| Avoid variables with short names like b | 162 |
| Avoid variables with short names like b | 162 |
| Found 'DD'-anomaly for variable 'b' (lines '162'-'164'). | 162–164 |
| Found 'DD'-anomaly for variable 'b' (lines '162'-'164'). | 162–164 |
| Found 'DU'-anomaly for variable 'b' (lines '164'-'188'). | 164–188 |
| Found 'DU'-anomaly for variable 'b' (lines '164'-'188'). | 164–188 |
| Found 'DU'-anomaly for variable 'b' (lines '164'-'188'). | 164–188 |
| publicMethodCommentRequirement Required | 166–169 |
| publicMethodCommentRequirement Required | 172–182 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 175 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 180 |
| Avoid empty catch blocks | 184–186 |
| publicMethodCommentRequirement Required | 190–215 |
| Found 'DD'-anomaly for variable 'rs' (lines '191'-'193'). | 191–193 |
| Avoid variables with short names like rs | 191 |
| Found 'DD'-anomaly for variable 'rs' (lines '191'-'193'). | 191–193 |
| Avoid variables with short names like rs | 191 |
| Found 'DD'-anomaly for variable 'rs' (lines '191'-'193'). | 191–193 |
| Found 'DU'-anomaly for variable 'rs' (lines '193'-'215'). | 193–215 |
| Found 'DU'-anomaly for variable 'rs' (lines '193'-'215'). | 193–215 |
| Found 'DU'-anomaly for variable 'rs' (lines '193'-'215'). | 193–215 |
| publicMethodCommentRequirement Required | 195–198 |
| publicMethodCommentRequirement Required | 201–209 |
| Avoid empty catch blocks | 211–213 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 258 |
| publicMethodCommentRequirement Required | 264–266 |
| publicMethodCommentRequirement Required | 268–288 |
| Avoid variables with short names like db | 268 |
| Avoid variables with short names like db | 268 |
| Avoid using if statements without curly braces | 269–270 |
| A method should have only one exit point, and that should be the last statement in the method | 270 |
| A method should have only one exit point, and that should be the last statement in the method | 280 |
| Avoid if (x != y) ..; else ..; | 282–285 |
| Avoid using if...else statements without curly braces | 283 |
| Avoid using if...else statements without curly braces | 285 |
| publicMethodCommentRequirement Required | 290–312 |
| Avoid using if statements without curly braces | 291–292 |
| A method should have only one exit point, and that should be the last statement in the method | 292 |
| Found 'DD'-anomaly for variable 'failed' (lines '295'-'299'). | 295–299 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 298 |
| A method should have only one exit point, and that should be the last statement in the method | 307 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 308 |
| Avoid variables with short names like db | 314 |
| publicMethodCommentRequirement Required | 314–324 |
| Avoid variables with short names like db | 314 |
| Avoid variables with short names like rs | 316 |
| Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. | 316–317 |
| Avoid variables with short names like rs | 316 |
| Ensure that resources like this ResultSet object are closed after use | 316 |
| A method should have only one exit point, and that should be the last statement in the method | 320 |
| Avoid empty catch blocks | 321–322 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 321 |
| publicMethodCommentRequirement Required | 326–340 |
| Avoid variables with short names like ps | 328 |
| Avoid variables with short names like ps | 328 |
| A method should have only one exit point, and that should be the last statement in the method | 335 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 336 |
| publicMethodCommentRequirement Required | 342–344 |
| publicMethodCommentRequirement Required | 346–355 |
| Avoid variables with short names like cf | 346 |
| Avoid variables with short names like cf | 346 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| Avoid variables with short names like fn | 25 |
| publicMethodCommentRequirement Required | 25–50 |
| Avoid variables with short names like fn | 25 |
| Avoid variables with short names like ch | 31 |
| Avoid variables with short names like ch | 31 |
| Avoid variables with short names like sw | 36 |
| Avoid variables with short names like sw | 36 |
| Avoid using if statements without curly braces | 40–41 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 43 |
| A method should have only one exit point, and that should be the last statement in the method | 45 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 46 |
| System.err.println is used | 47 |
| publicMethodCommentRequirement Required | 52–54 |
| Avoid variables with short names like s | 52 |
| Avoid variables with short names like s | 52 |
| Avoid variables with short names like as | 56 |
| Avoid variables with short names like as | 56 |
| publicMethodCommentRequirement Required | 56–84 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 56 |
| Avoid variables with short names like is | 64 |
| Avoid variables with short names like is | 64 |
| System.out.println is used | 78 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 28–29 |
| fieldCommentRequirement Required | 31–45 |
| The String literal "rsamDelta" appears 4 times in this file; the first occurrence is on line 40 | 40 |
| The String literal "rsamDuration" appears 4 times in this file; the first occurrence is on line 42 | 42 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| publicMethodCommentRequirement Required | 52–54 |
| publicMethodCommentRequirement Required | 56–64 |
| Avoid variables with short names like fn | 67 |
| Found 'UR'-anomaly for variable 'ch' (lines '67'-'79'). | 67–79 |
| Avoid variables with short names like fn | 67 |
| publicMethodCommentRequirement Required | 67–84 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 68 |
| Avoid instantiating new objects inside loops | 78 |
| publicMethodCommentRequirement Required | 86–106 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 86 |
| Found 'DD'-anomaly for variable 'config' (lines '87'-'91'). | 87–91 |
| Avoid using if statements without curly braces | 96–97 |
| System.err.println is used | 97 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 101 |
| Avoid printStackTrace(); use a logger call instead. | 102 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 108 |
| Found 'UR'-anomaly for variable 'file' (lines '108'-'117'). | 108–117 |
| publicMethodCommentRequirement Required | 108–120 |
| System.out.printf is used | 110 |
| Avoid variables with short names like is | 113 |
| Avoid variables with short names like is | 113 |
| Avoid using for statements without curly braces | 116–117 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.HashSet' | 13 |
| Avoid unused imports such as 'java.util.Set' | 16 |
| Avoid unused imports such as 'gov.usgs.volcanoes.core.legacy.Arguments' | 21 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 32–33 |
| fieldCommentRequirement Required | 35–49 |
| The String literal "rsamDelta" appears 4 times in this file; the first occurrence is on line 44 | 44 |
| The String literal "rsamDuration" appears 4 times in this file; the first occurrence is on line 46 | 46 |
| fieldCommentRequirement Required | 51 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 53 |
| fieldCommentRequirement Required | 54 |
| publicMethodCommentRequirement Required | 56–58 |
| publicMethodCommentRequirement Required | 60–68 |
| Avoid variables with short names like fn | 71 |
| publicMethodCommentRequirement Required | 71–106 |
| Avoid variables with short names like fn | 71 |
| Found 'UR'-anomaly for variable 'ch' (lines '71'-'99'). | 71–99 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 72 |
| System.out.println is used | 77 |
| System.out.println is used | 82 |
| System.out.println is used | 87 |
| System.out.println is used | 92 |
| Local variable 'chan' could be declared final | 99 |
| Avoid instantiating new objects inside loops | 100 |
| publicMethodCommentRequirement Required | 109–129 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 109 |
| Found 'DD'-anomaly for variable 'config' (lines '110'-'114'). | 110–114 |
| Avoid using if statements without curly braces | 119–120 |
| System.err.println is used | 120 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 124 |
| Avoid printStackTrace(); use a logger call instead. | 125 |
| publicMethodCommentRequirement Required | 131–143 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 131 |
| Found 'UR'-anomaly for variable 'file' (lines '131'-'140'). | 131–140 |
| System.out.printf is used | 133 |
| Avoid variables with short names like is | 136 |
| Avoid variables with short names like is | 136 |
| Avoid using for statements without curly braces | 139–140 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 36–180 |
| Abstract classes should be named AbstractXXX | 36–180 |
| fieldCommentRequirement Required | 37 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 37 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| Avoid variables with short names like db | 46 |
| Avoid variables with short names like db | 46 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| Avoid unnecessary constructors - the compiler will generate these for you | 52 |
| Document empty constructor | 52 |
| publicMethodCommentRequirement Required | 52 |
| publicMethodCommentRequirement Required | 54–67 |
| Avoid variables with short names like cf | 55 |
| Avoid variables with short names like cf | 55 |
| Avoid variables with short names like db | 58 |
| Avoid variables with short names like db | 58 |
| System.err.println is used | 61 |
| Found 'UR'-anomaly for variable 'code' (lines '69'-'79'). | 69–79 |
| publicMethodCommentRequirement Required | 69–120 |
| System.out.println is used | 71 |
| Found 'DD'-anomaly for variable 'minTime' (lines '76'-'103'). | 76–103 |
| Found 'DU'-anomaly for variable 'minTime' (lines '76'-'120'). | 76–120 |
| Found 'DU'-anomaly for variable 'maxTime' (lines '77'-'120'). | 77–120 |
| Found 'DD'-anomaly for variable 'maxTime' (lines '77'-'104'). | 77–104 |
| System.out.println is used | 80 |
| System.out.printf is used | 84 |
| System.out.printf is used | 86 |
| Avoid instantiating new objects inside loops | 87 |
| Found 'DU'-anomaly for variable 'maxSamples' (lines '89'-'120'). | 89–120 |
| Found 'DD'-anomaly for variable 'maxSamples' (lines '89'-'89'). | 89 |
| Avoid variables with short names like it | 90 |
| Avoid variables with short names like it | 90 |
| Avoid instantiating new objects inside loops | 91 |
| Avoid variables with short names like tb | 102 |
| Avoid variables with short names like tb | 102 |
| Avoid instantiating new objects inside loops | 102 |
| Assigning an Object to null is a code smell. Consider refactoring. | 107 |
| Found 'DU'-anomaly for variable 'waves' (lines '109'-'120'). | 109–120 |
| Found 'DD'-anomaly for variable 'waves' (lines '109'-'85'). | 109–85 |
| Assigning an Object to null is a code smell. Consider refactoring. | 109 |
| System.out.println is used | 113 |
| System.out.println is used | 116 |
| System.out.printf is used | 119 |
| Found 'UR'-anomaly for variable 'ff' (lines '122'-'142'). | 122–142 |
| publicMethodCommentRequirement Required | 122–154 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 123 |
| System.out.println is used | 124 |
| Avoid variables with short names like it | 129 |
| Avoid variables with short names like it | 129 |
| Avoid variables with short names like fn | 131 |
| Avoid variables with short names like fn | 131 |
| System.out.println is used | 132 |
| Avoid instantiating new objects inside loops | 135 |
| Avoid variables with short names like f | 135 |
| Avoid variables with short names like f | 135 |
| Local variable 'dFiles' could be declared final | 137 |
| Avoid using if statements without curly braces | 138–139 |
| Avoid using if statements without curly braces | 142–143 |
| System.out.println is used | 149 |
| protectedMethodCommentRequirement Required | 156–161 |
| publicMethodCommentRequirement Required | 163–169 |
| Avoid variables with short names like rd | 164 |
| Avoid variables with short names like rd | 164 |
| Avoid variables with short names like rl | 166 |
| Avoid variables with short names like rl | 166 |
| System.out.printf is used | 168 |
| Avoid variables with short names like i | 171 |
| Avoid variables with short names like i | 171 |
| publicMethodCommentRequirement Required | 171–173 |
| publicMethodCommentRequirement Required | 175–177 |
| Avoid variables with short names like i | 175 |
| Avoid variables with short names like i | 175 |
| publicMethodCommentRequirement Required | 179 |
| Avoid variables with short names like fn | 179 |
| Avoid variables with short names like fn | 179 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 24 |
| Field COLLECT has the same name as a method | 24 |
| Field COLLECT has the same name as a method | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| Perhaps 'winston' could be replaced by a local variable. | 27 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| Avoid variables with short names like n | 39 |
| Avoid variables with short names like n | 39 |
| publicMethodCommentRequirement Required | 39–52 |
| Avoid variables with short names like w | 39 |
| Avoid variables with short names like ws | 39 |
| It is a good practice to call super() in a constructor | 39–52 |
| Avoid variables with short names like ws | 39 |
| Avoid variables with short names like w | 39 |
| Avoid variables with short names like md | 40 |
| Avoid variables with short names like md | 40 |
| Avoid variables with short names like d | 40 |
| Avoid variables with short names like i | 40 |
| Avoid variables with short names like d | 40 |
| Avoid variables with short names like i | 40 |
| Avoid variables with short names like m | 40 |
| Avoid variables with short names like m | 40 |
| publicMethodCommentRequirement Required | 54–56 |
| publicMethodCommentRequirement Required | 58–60 |
| Document empty method body | 58–60 |
| Avoid variables with short names like ci | 62 |
| publicMethodCommentRequirement Required | 62–64 |
| Avoid variables with short names like ci | 62 |
| Avoid variables with short names like t1 | 66 |
| Avoid variables with short names like t2 | 66 |
| Found 'UR'-anomaly for variable 'o' (lines '66'-'83'). | 66–83 |
| publicMethodCommentRequirement Required | 66–92 |
| Avoid variables with short names like t2 | 66 |
| Avoid variables with short names like t1 | 66 |
| Avoid variables with short names like ct | 67 |
| Avoid variables with short names like ct | 67 |
| Avoid variables with short names like ts | 70 |
| Avoid variables with short names like ts | 70 |
| Found 'DD'-anomaly for variable 'tbs' (lines '71'-'77'). | 71–77 |
| Found 'DD'-anomaly for variable 'tbs' (lines '71'-'73'). | 71–73 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 81 |
| Avoid variables with short names like tb | 83 |
| Avoid variables with short names like tb | 83 |
| Avoid variables with short names like te | 88 |
| Avoid variables with short names like te | 88 |
| System.out.println is used | 89 |
| publicMethodCommentRequirement Required | 94–123 |
| Found 'DU'-anomaly for variable 'menu' (lines '95'-'123'). | 95–123 |
| Avoid variables with short names like it | 96 |
| Avoid variables with short names like it | 96 |
| System.out.println is used | 100 |
| Avoid variables with short names like mi | 104 |
| Avoid variables with short names like mi | 104 |
| Avoid using if statements without curly braces | 105–106 |
| Avoid instantiating new objects inside loops | 112 |
| System.out.println is used | 118 |
| publicMethodCommentRequirement Required | 125–163 |
| Found 'UR'-anomaly for variable 'o' (lines '125'-'153'). | 125–153 |
| Avoid variables with short names like it | 126 |
| Avoid variables with short names like it | 126 |
| Avoid variables with short names like ts | 128 |
| Avoid variables with short names like ts | 128 |
| System.out.print is used | 131 |
| Found 'DD'-anomaly for variable 'stationOk' (lines '133'-'136'). | 133–136 |
| System.out.print is used | 135 |
| Avoid using if statements without curly braces | 138–139 |
| Avoid using if statements without curly braces | 144–145 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 149 |
| System.out.print is used | 150 |
| Avoid variables with short names like tb | 153 |
| Avoid variables with short names like tb | 153 |
| Avoid variables with short names like te | 159 |
| Avoid variables with short names like te | 159 |
| System.out.println is used | 161 |
| publicMethodCommentRequirement Required | 166–183 |
| Avoid empty catch blocks | 169–170 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 169 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 176 |
| Avoid printStackTrace(); use a logger call instead. | 177 |
| Violation | Line |
|---|---|
| enumCommentRequirement Required | 19–39 |
| Avoid variables with short names like c | 22 |
| publicMethodCommentRequirement Required | 22–38 |
| Avoid variables with short names like c | 22 |
| The default label should be the last label in a switch statement | 23–37 |
| A method should have only one exit point, and that should be the last statement in the method | 26 |
| A method should have only one exit point, and that should be the last statement in the method | 28 |
| A method should have only one exit point, and that should be the last statement in the method | 30 |
| A method should have only one exit point, and that should be the last statement in the method | 32 |
| A method should have only one exit point, and that should be the last statement in the method | 34 |
| fieldCommentRequirement Required | 41 |
| Avoid using redundant field initializer for 'successes' | 42 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 43 |
| Avoid using redundant field initializer for 'failures' | 43 |
| fieldCommentRequirement Required | 44 |
| Avoid using redundant field initializer for 'lastBufTime' | 45 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| Avoid variables with short names like c | 50 |
| Avoid variables with short names like c | 50 |
| publicMethodCommentRequirement Required | 50–54 |
| When instantiating a SimpleDateFormat object, specify a Locale | 51 |
| Avoid variables with short names like tb | 56 |
| publicMethodCommentRequirement Required | 56–69 |
| Avoid variables with short names like tb | 56 |
| Avoid using if...else statements without curly braces | 62 |
| publicMethodCommentRequirement Required | 71–74 |
| publicMethodCommentRequirement Required | 76–78 |
| publicMethodCommentRequirement Required | 81–85 |
| publicMethodCommentRequirement Required | 87–118 |
| publicMethodCommentRequirement Required | 89–116 |
| The default label should be the last label in a switch statement | 91–111 |
| Avoid using if statements without curly braces | 112–113 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–986 |
| Possible God class (WMC=138, ATFD=121, TCC=0.0291005291005291) | 1–986 |
| fieldCommentRequirement Required | 61 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 63 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 63 |
| fieldCommentRequirement Required | 63 |
| fieldCommentRequirement Required | 64 |
| fieldCommentRequirement Required | 65 |
| fieldCommentRequirement Required | 67 |
| Avoid excessively long variable names like DEFAULT_HEARTBEAT_INTERVAL | 68 |
| fieldCommentRequirement Required | 68 |
| Avoid excessively long variable names like DEFAULT_HEARTBEAT_INTERVAL | 68 |
| Avoid excessively long variable names like DEFAULT_EXPECTED_HEARTBEAT_INTERVAL | 69 |
| fieldCommentRequirement Required | 69 |
| Avoid excessively long variable names like DEFAULT_EXPECTED_HEARTBEAT_INTERVAL | 69 |
| fieldCommentRequirement Required | 70 |
| Avoid excessively long variable names like DEFAULT_STATUS_INTERVAL | 70 |
| Avoid excessively long variable names like DEFAULT_STATUS_INTERVAL | 70 |
| Avoid excessively long variable names like DEFAULT_RECEIVE_ID | 71 |
| Avoid excessively long variable names like DEFAULT_RECEIVE_ID | 71 |
| fieldCommentRequirement Required | 71 |
| fieldCommentRequirement Required | 72 |
| fieldCommentRequirement Required | 73 |
| Avoid excessively long variable names like DEFAULT_TABLE_ENGINE | 74 |
| fieldCommentRequirement Required | 74 |
| Avoid excessively long variable names like DEFAULT_TABLE_ENGINE | 74 |
| fieldCommentRequirement Required | 75 |
| Avoid excessively long variable names like DEFAULT_MAX_BACKLOG | 76 |
| fieldCommentRequirement Required | 76 |
| Avoid excessively long variable names like DEFAULT_MAX_BACKLOG | 76 |
| fieldCommentRequirement Required | 77 |
| fieldCommentRequirement Required | 78 |
| fieldCommentRequirement Required | 79 |
| Avoid excessively long variable names like DEFAULT_LOG_NUM_FILES | 79 |
| Avoid excessively long variable names like DEFAULT_LOG_NUM_FILES | 79 |
| fieldCommentRequirement Required | 80 |
| Avoid excessively long variable names like DEFAULT_LOG_FILE_SIZE | 80 |
| Avoid excessively long variable names like DEFAULT_LOG_FILE_SIZE | 80 |
| Avoid excessively long variable names like DEFAULT_ENABLE_VALARM_VIEW | 81 |
| fieldCommentRequirement Required | 81 |
| Avoid excessively long variable names like DEFAULT_ENABLE_VALARM_VIEW | 81 |
| fieldCommentRequirement Required | 83 |
| Avoid excessively long variable names like DEFAULT_TIME_THRESHOLD | 83 |
| Avoid excessively long variable names like DEFAULT_TIME_THRESHOLD | 83 |
| Avoid excessively long variable names like DEFAULT_BACKLOG_THRESHOLD | 84 |
| Avoid excessively long variable names like DEFAULT_BACKLOG_THRESHOLD | 84 |
| fieldCommentRequirement Required | 84 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 85 |
| fieldCommentRequirement Required | 85 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 85 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 86 |
| fieldCommentRequirement Required | 86 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 86 |
| fieldCommentRequirement Required | 87 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 87 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 87 |
| fieldCommentRequirement Required | 89 |
| Avoid excessively long variable names like DEFAULT_DROP_TABLE_DELAY | 89 |
| Avoid excessively long variable names like DEFAULT_DROP_TABLE_DELAY | 89 |
| fieldCommentRequirement Required | 91 |
| Avoid excessively long variable names like DEFAULT_REPAIR_RETRY_INTERVAL | 91 |
| Avoid excessively long variable names like DEFAULT_REPAIR_RETRY_INTERVAL | 91 |
| The field name indicates a constant but its modifiers do not | 94 |
| Variables should start with a lowercase character, 'JSAP_PROGRAM_NAME' starts with uppercase character. | 94 |
| Variables should start with a lowercase character, 'JSAP_PROGRAM_NAME' starts with uppercase character. | 94 |
| The field name indicates a constant but its modifiers do not | 94 |
| fieldCommentRequirement Required | 94 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_PROGRAM_NAME' is not final. | 94 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_PROGRAM_NAME' is not final. | 94 |
| fieldCommentRequirement Required | 95–97 |
| Avoid excessively long variable names like JSAP_EXPLANATION_PREFACE | 95 |
| Avoid excessively long variable names like JSAP_EXPLANATION_PREFACE | 95 |
| Variables should start with a lowercase character, 'JSAP_EXPLANATION_PREFACE' starts with uppercase character. | 95 |
| The field name indicates a constant but its modifiers do not | 95–97 |
| Variables should start with a lowercase character, 'JSAP_EXPLANATION_PREFACE' starts with uppercase character. | 95 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_EXPLANATION_PREFACE' is not final. | 95 |
| The field name indicates a constant but its modifiers do not | 95–97 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_EXPLANATION_PREFACE' is not final. | 95 |
| Avoid excessively long variable names like DEFAULT_JSAP_EXPLANATION | 99 |
| fieldCommentRequirement Required | 99–108 |
| Avoid excessively long variable names like DEFAULT_JSAP_EXPLANATION | 99 |
| fieldCommentRequirement Required | 110–123 |
| Avoid excessively long variable names like DEFAULT_JSAP_PARAMETERS | 110 |
| Avoid excessively long variable names like DEFAULT_JSAP_PARAMETERS | 110 |
| fieldCommentRequirement Required | 125 |
| fieldCommentRequirement Required | 126 |
| fieldCommentRequirement Required | 128 |
| Perhaps 'winston' could be replaced by a local variable. | 128 |
| fieldCommentRequirement Required | 129 |
| fieldCommentRequirement Required | 130 |
| fieldCommentRequirement Required | 132 |
| fieldCommentRequirement Required | 133 |
| fieldCommentRequirement Required | 134 |
| fieldCommentRequirement Required | 136 |
| fieldCommentRequirement Required | 137 |
| fieldCommentRequirement Required | 138 |
| fieldCommentRequirement Required | 140 |
| Perhaps 'fixerWinston' could be replaced by a local variable. | 141 |
| fieldCommentRequirement Required | 141 |
| fieldCommentRequirement Required | 142 |
| fieldCommentRequirement Required | 143 |
| fieldCommentRequirement Required | 144 |
| fieldCommentRequirement Required | 145 |
| Avoid excessively long variable names like repairRetryInterval | 146 |
| Avoid excessively long variable names like repairRetryInterval | 146 |
| fieldCommentRequirement Required | 146 |
| fieldCommentRequirement Required | 148 |
| Avoid excessively long variable names like totalTraceBufsWritten | 149 |
| fieldCommentRequirement Required | 149 |
| Avoid excessively long variable names like totalTraceBufsWritten | 149 |
| Avoid using redundant field initializer for 'totalTraceBufsWritten' | 149 |
| fieldCommentRequirement Required | 150 |
| fieldCommentRequirement Required | 151 |
| Avoid excessively long variable names like totalTraceBufsDropped | 151 |
| Avoid excessively long variable names like totalTraceBufsDropped | 151 |
| Avoid excessively long variable names like totalTraceBufsAccepted | 152 |
| fieldCommentRequirement Required | 152 |
| Avoid excessively long variable names like totalTraceBufsAccepted | 152 |
| Avoid excessively long variable names like totalTraceBufsRejected | 153 |
| fieldCommentRequirement Required | 153 |
| Avoid excessively long variable names like totalTraceBufsRejected | 153 |
| Avoid excessively long variable names like totalTraceBufsFailed | 154 |
| Avoid excessively long variable names like totalTraceBufsFailed | 154 |
| fieldCommentRequirement Required | 154 |
| fieldCommentRequirement Required | 155 |
| fieldCommentRequirement Required | 156 |
| fieldCommentRequirement Required | 157 |
| fieldCommentRequirement Required | 158 |
| fieldCommentRequirement Required | 160 |
| fieldCommentRequirement Required | 161 |
| fieldCommentRequirement Required | 163 |
| fieldCommentRequirement Required | 164 |
| fieldCommentRequirement Required | 165 |
| Field quit has the same name as a method | 167 |
| Use of modifier volatile is not recommended. | 167 |
| Field quit has the same name as a method | 167 |
| fieldCommentRequirement Required | 167 |
| Avoid using redundant field initializer for 'quit' | 167 |
| fieldCommentRequirement Required | 169 |
| fieldCommentRequirement Required | 170 |
| Avoid variables with short names like fn | 172 |
| publicMethodCommentRequirement Required | 172–189 |
| Avoid variables with short names like fn | 172 |
| Avoid variables with short names like e | 179 |
| Avoid variables with short names like e | 179 |
| publicMethodCommentRequirement Required | 179–181 |
| Overridable method 'processConfigFile' called during object construction | 188 |
| It is a good practice to call super() in a constructor | 195–213 |
| When instantiating a SimpleDateFormat object, specify a Locale | 199 |
| When instantiating a SimpleDateFormat object, specify a Locale | 201 |
| Avoid variables with short names like e | 221 |
| Avoid variables with short names like e | 221 |
| Avoid printStackTrace(); use a logger call instead. | 224 |
| Avoid variables with short names like to | 300 |
| Avoid variables with short names like to | 300 |
| Avoid using if statements without curly braces | 324–325 |
| Avoid using if statements without curly braces | 329–330 |
| Avoid excessively long variable names like winstonTableEngine | 333 |
| Avoid excessively long variable names like winstonTableEngine | 333 |
| Avoid using if statements without curly braces | 334–335 |
| Avoid excessively long variable names like winstonStatementCacheCap | 337 |
| Avoid excessively long variable names like winstonStatementCacheCap | 337 |
| Avoid using if statements without curly braces | 343–344 |
| protectedMethodCommentRequirement Required | 358–371 |
| Found 'UR'-anomaly for variable 'filter' (lines '373'-'388'). | 373–388 |
| protectedMethodCommentRequirement Required | 373–389 |
| Found 'UR'-anomaly for variable 'options' (lines '373'-'377'). | 373–377 |
| Position literals first in String comparisons | 377 |
| Avoid using if statements without curly braces | 377–378 |
| Avoid variables with short names like tc | 379 |
| Avoid variables with short names like tc | 379 |
| Avoid instantiating new objects inside loops | 381 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 383 |
| Avoid using for statements without curly braces | 387–388 |
| protectedMethodCommentRequirement Required | 391–415 |
| Found 'UR'-anomaly for variable 'filter' (lines '391'-'414'). | 391–414 |
| Found 'UR'-anomaly for variable 'filterName' (lines '391'-'395'). | 391–395 |
| Avoid variables with short names like fc | 395 |
| Avoid variables with short names like fc | 395 |
| Local variable 'newFilterClass' could be declared final | 399 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 408 |
| Avoid using for statements without curly braces | 413–414 |
| Avoid variables with short names like tb | 424 |
| Found 'UR'-anomaly for variable 'filter' (lines '424'-'427'). | 424–427 |
| Avoid variables with short names like tb | 424 |
| Found 'DU'-anomaly for variable 'options' (lines '425'-'439'). | 425–439 |
| Avoid variables with short names like m | 429 |
| Avoid variables with short names like m | 429 |
| Avoid using if statements without curly braces | 430–431 |
| Avoid using if statements without curly braces | 433–434 |
| A method should have only one exit point, and that should be the last statement in the method | 434 |
| Avoid variables with short names like m | 441 |
| Avoid variables with short names like c | 441 |
| Avoid variables with short names like c | 441 |
| Avoid variables with short names like m | 441 |
| Avoid variables with short names like cm | 442 |
| Avoid variables with short names like cm | 442 |
| Each class should declare at least one constructor | 460–495 |
| publicMethodCommentRequirement Required | 461–494 |
| Avoid variables with short names like tb | 463 |
| Avoid variables with short names like tb | 463 |
| Found 'DD'-anomaly for variable 'accept' (lines '467'-'469'). | 467–469 |
| Avoid if (x != y) ..; else ..; | 468–478 |
| Avoid using if...else statements without curly braces | 478 |
| Avoid using if statements without curly braces | 487–488 |
| Avoid empty if statements | 490–492 |
| Avoid variables with short names like tb | 497 |
| Avoid variables with short names like tb | 497 |
| protectedMethodCommentRequirement Required | 497–516 |
| Avoid variables with short names like q | 499 |
| Avoid variables with short names like q | 499 |
| Avoid variables with short names like ip | 505 |
| Avoid variables with short names like ip | 505 |
| Avoid using Literals in Conditional Statements | 512 |
| Found 'UR'-anomaly for variable 'key' (lines '518'-'521'). | 518–521 |
| Avoid variables with short names like q | 521 |
| Avoid variables with short names like q | 521 |
| Avoid using if statements without curly braces | 522–523 |
| Avoid variables with short names like ip | 525 |
| Avoid variables with short names like ip | 525 |
| Avoid using if statements without curly braces | 530–531 |
| publicMethodCommentRequirement Required | 541–551 |
| Avoid empty catch blocks | 546–547 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 546 |
| Avoid using if statements without curly braces | 556–557 |
| A method should have only one exit point, and that should be the last statement in the method | 557 |
| Avoid using if...else statements without curly braces | 562 |
| Avoid using if...else statements without curly braces | 564 |
| A method should have only one exit point, and that should be the last statement in the method | 564 |
| publicMethodCommentRequirement Required | 569–579 |
| Avoid variables with short names like q | 583 |
| Avoid variables with short names like q | 583 |
| The String literal "channels" appears 4 times in this file; the first occurrence is on line 584 | 584 |
| System.out.println is used | 585 |
| System.out.println is used | 586 |
| Avoid variables with short names like tb | 589 |
| Avoid variables with short names like tb | 589 |
| Avoid variables with short names like t | 600 |
| Avoid variables with short names like t | 600 |
| Avoid using if statements without curly braces | 602–603 |
| Avoid variables with short names like ip | 609 |
| Avoid variables with short names like ip | 609 |
| Avoid using Literals in Conditional Statements | 620 |
| A switch statement does not contain a break | 622–639 |
| Avoid using if statements without curly braces | 634–635 |
| Found 'DD'-anomaly for variable 'repair' (lines '644'-'662'). | 644–662 |
| Found 'DD'-anomaly for variable 'repair' (lines '644'-'657'). | 644–657 |
| A switch statement does not contain a break | 645–694 |
| Avoid variables with short names like dt | 696 |
| Avoid variables with short names like dt | 696 |
| Avoid using if statements without curly braces | 698–699 |
| Avoid using if statements without curly braces | 707–708 |
| Avoid variables with short names like dt | 712 |
| Avoid variables with short names like dt | 712 |
| Avoid using if statements without curly braces | 716–717 |
| Avoid variables with short names like m | 722 |
| Avoid variables with short names like m | 722 |
| System.out.println is used | 725 |
| System.out.println is used | 728 |
| publicMethodCommentRequirement Required | 735–768 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 747 |
| Avoid empty catch blocks | 747–748 |
| A catch statement should never catch throwable since it includes errors. | 758 |
| Avoid printStackTrace(); use a logger call instead. | 760 |
| A catch statement should never catch throwable since it includes errors. | 765 |
| Avoid variables with short names like tb | 770 |
| Avoid variables with short names like tb | 770 |
| Found 'UR'-anomaly for variable 'tf' (lines '770'-'776'). | 770–776 |
| protectedMethodCommentRequirement Required | 770–784 |
| Avoid variables with short names like ip | 772 |
| Avoid variables with short names like ip | 772 |
| Found 'DD'-anomaly for variable 'ip' (lines '774'-'777'). | 774–777 |
| publicMethodCommentRequirement Required | 786–796 |
| A catch statement should never catch throwable since it includes errors. | 790 |
| Found 'UR'-anomaly for variable 's' (lines '798'-'846'). | 798–846 |
| publicMethodCommentRequirement Required | 798–847 |
| Avoid variables with short names like ht | 809 |
| Avoid variables with short names like ht | 809 |
| Found 'DD'-anomaly for variable 'dt' (lines '810'-'817'). | 810–817 |
| Avoid variables with short names like dt | 810 |
| Avoid variables with short names like dt | 810 |
| Avoid using if...else statements without curly braces | 812 |
| Avoid using if...else statements without curly braces | 814–815 |
| Found 'DU'-anomaly for variable 'dt' (lines '817'-'847'). | 817–847 |
| Avoid using if...else statements without curly braces | 819 |
| Avoid using if...else statements without curly braces | 821–822 |
| Avoid variables with short names like rt | 824 |
| Avoid variables with short names like rt | 824 |
| Avoid using for statements without curly braces | 845–846 |
| System.out.println is used | 846 |
| Avoid variables with short names like s | 849 |
| publicMethodCommentRequirement Required | 849–867 |
| Found 'UR'-anomaly for variable 'channel' (lines '849'-'864'). | 849–864 |
| Avoid variables with short names like s | 849 |
| Found 'DD'-anomaly for variable 'col' (lines '850'-'852'). | 850–852 |
| Avoid using Literals in Conditional Statements | 851 |
| Avoid using if statements without curly braces | 851–852 |
| System.out.println is used | 855 |
| System.out.println is used | 856 |
| System.out.println is used | 864 |
| System.out.println is used | 866 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 875 |
| Found 'DD'-anomaly for variable 'config' (lines '876'-'881'). | 876–881 |
| System.err.println is used | 887 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 891 |
| Avoid printStackTrace(); use a logger call instead. | 892 |
| publicMethodCommentRequirement Required | 898–909 |
| Avoid variables with short names like sb | 899 |
| StringBuffer constructor is initialized with size 16, but has at least 141 characters appended. | 899 |
| Avoid variables with short names like sb | 899 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 900 |
| StringBuffer (or StringBuilder).append is called 7 consecutive times with literal Strings. Use a single append with a single combined String. | 900 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 901 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 902 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 903 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 904 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 905 |
| System.out.println is used | 908 |
| Avoid variables with short names like im | 917 |
| Avoid variables with short names like im | 917 |
| Found 'DU'-anomaly for variable 'in' (lines '919'-'966'). | 919–966 |
| Avoid variables with short names like in | 919 |
| Avoid variables with short names like in | 919 |
| Avoid variables with short names like s | 923 |
| Found 'DD'-anomaly for variable 's' (lines '923'-'925'). | 923–925 |
| Avoid variables with short names like s | 923 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 931 |
| Position literals first in String comparisons | 932 |
| A catch statement should never catch throwable since it includes errors. | 936 |
| Position literals first in String comparisons | 942 |
| Avoid using if...else statements without curly braces | 943 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 944 |
| Avoid using if...else statements without curly braces | 945 |
| Position literals first in String comparisons | 946 |
| Avoid using if...else statements without curly braces | 947 |
| Position literals first in String comparisons | 948 |
| Avoid using if...else statements without curly braces | 949 |
| Position literals first in String comparisons | 950 |
| Avoid using if...else statements without curly braces | 951 |
| Position literals first in String comparisons | 952 |
| Avoid using if...else statements without curly braces | 953 |
| Position literals first in String comparisons | 954 |
| Position literals first in String comparisons | 957 |
| Avoid using if...else statements without curly braces | 958 |
| Avoid using if...else statements without curly braces | 960 |
| publicMethodCommentRequirement Required | 968–985 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 968 |
| Avoid variables with short names like fn | 972 |
| Avoid variables with short names like fn | 972 |
| Avoid variables with short names like im | 976 |
| Avoid variables with short names like im | 976 |
| Avoid using if statements without curly braces | 983–984 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 37 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 39 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 39 |
| fieldCommentRequirement Required | 39 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 40 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 40 |
| fieldCommentRequirement Required | 40 |
| Avoid excessively long variable names like DEFAULT_CHUNK_DELAY | 41 |
| fieldCommentRequirement Required | 41 |
| Avoid excessively long variable names like DEFAULT_CHUNK_DELAY | 41 |
| fieldCommentRequirement Required | 43 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 43 |
| Avoid excessively long variable names like DEFAULT_RSAM_ENABLE | 43 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 44 |
| Avoid excessively long variable names like DEFAULT_RSAM_DELTA | 44 |
| fieldCommentRequirement Required | 44 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 45 |
| Avoid excessively long variable names like DEFAULT_RSAM_DURATION | 45 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 51 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 54 |
| fieldCommentRequirement Required | 56 |
| Perhaps 'createDatabase' could be replaced by a local variable. | 57 |
| fieldCommentRequirement Required | 57 |
| fieldCommentRequirement Required | 59 |
| fieldCommentRequirement Required | 60 |
| fieldCommentRequirement Required | 61 |
| fieldCommentRequirement Required | 63 |
| fieldCommentRequirement Required | 64 |
| fieldCommentRequirement Required | 66 |
| fieldCommentRequirement Required | 67 |
| fieldCommentRequirement Required | 69 |
| fieldCommentRequirement Required | 70 |
| fieldCommentRequirement Required | 71 |
| fieldCommentRequirement Required | 73 |
| Avoid using redundant field initializer for 'totalInserted' | 73 |
| fieldCommentRequirement Required | 74 |
| Avoid using redundant field initializer for 'totalDownloadTime' | 74 |
| fieldCommentRequirement Required | 75 |
| Avoid using redundant field initializer for 'totalInsertTime' | 75 |
| fieldCommentRequirement Required | 77 |
| Avoid using redundant field initializer for 'requestSCNL' | 77 |
| Field quit has the same name as a method | 79 |
| fieldCommentRequirement Required | 79 |
| Avoid using redundant field initializer for 'quit' | 79 |
| Field quit has the same name as a method | 79 |
| fieldCommentRequirement Required | 81 |
| The field name indicates a constant but its modifiers do not | 84 |
| Variables should start with a lowercase character, 'JSAP_PROGRAM_NAME' starts with uppercase character. | 84 |
| fieldCommentRequirement Required | 84 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_PROGRAM_NAME' is not final. | 84 |
| The field name indicates a constant but its modifiers do not | 84 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_PROGRAM_NAME' is not final. | 84 |
| Variables should start with a lowercase character, 'JSAP_PROGRAM_NAME' starts with uppercase character. | 84 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_EXPLANATION_PREFACE' is not final. | 85 |
| The field name indicates a constant but its modifiers do not | 85–87 |
| Variables should start with a lowercase character, 'JSAP_EXPLANATION_PREFACE' starts with uppercase character. | 85 |
| Variables should start with a lowercase character, 'JSAP_EXPLANATION_PREFACE' starts with uppercase character. | 85 |
| Avoid excessively long variable names like JSAP_EXPLANATION_PREFACE | 85 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JSAP_EXPLANATION_PREFACE' is not final. | 85 |
| Avoid excessively long variable names like JSAP_EXPLANATION_PREFACE | 85 |
| fieldCommentRequirement Required | 85–87 |
| The field name indicates a constant but its modifiers do not | 85–87 |
| Avoid excessively long variable names like DEFAULT_JSAP_EXPLANATION | 89 |
| Avoid excessively long variable names like DEFAULT_JSAP_EXPLANATION | 89 |
| fieldCommentRequirement Required | 89–90 |
| fieldCommentRequirement Required | 92–100 |
| Avoid excessively long variable names like DEFAULT_JSAP_PARAMETERS | 92 |
| Avoid excessively long variable names like DEFAULT_JSAP_PARAMETERS | 92 |
| The String literal "timeRange" appears 4 times in this file; the first occurrence is on line 93 | 93 |
| The String literal "waveServer" appears 5 times in this file; the first occurrence is on line 95 | 95 |
| publicMethodCommentRequirement Required | 102–104 |
| publicMethodCommentRequirement Required | 106–110 |
| Overridable method 'processConfig' called during object construction | 109 |
| publicMethodCommentRequirement Required | 112–114 |
| publicMethodCommentRequirement Required | 116–118 |
| A getX() method which returns a boolean should be named isX() | 120–122 |
| A getX() method which returns a boolean should be named isX() | 120–122 |
| publicMethodCommentRequirement Required | 120–122 |
| publicMethodCommentRequirement Required | 124–171 |
| Avoid variables with short names like s | 138 |
| Avoid variables with short names like s | 138 |
| Avoid using if statements without curly braces | 139–140 |
| Avoid throwing raw exception types. | 140 |
| Avoid variables with short names like ti | 173 |
| Avoid variables with short names like td | 173 |
| Avoid variables with short names like t | 173 |
| Avoid variables with short names like ti | 173 |
| Avoid variables with short names like t | 173 |
| Avoid variables with short names like td | 173 |
| publicMethodCommentRequirement Required | 173–177 |
| Avoid variables with short names like tr | 181 |
| Avoid variables with short names like tr | 181 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 184 |
| Avoid variables with short names like w | 194 |
| Avoid variables with short names like w | 194 |
| publicMethodCommentRequirement Required | 194–196 |
| Avoid variables with short names like ws | 198 |
| Avoid variables with short names like ws | 198 |
| publicMethodCommentRequirement Required | 198–200 |
| publicMethodCommentRequirement Required | 210–212 |
| Found 'UR'-anomaly for variable 'channel' (lines '214'-'221'). | 214–221 |
| publicMethodCommentRequirement Required | 214–242 |
| Found 'UR'-anomaly for variable 'item' (lines '214'-'226'). | 214–226 |
| Avoid variables with short names like ss | 221 |
| Avoid variables with short names like ss | 221 |
| Found 'DD'-anomaly for variable 'loc' (lines '222'-'224'). | 222–224 |
| Avoid using if statements without curly braces | 223–224 |
| Avoid using Literals in Conditional Statements | 223 |
| Avoid variables with short names like wc | 227 |
| Avoid variables with short names like wc | 227 |
| Avoid using if statements without curly braces | 229–230 |
| Avoid instantiating new objects inside loops | 233 |
| publicMethodCommentRequirement Required | 244–264 |
| Found 'UR'-anomaly for variable 'job' (lines '244'-'246'). | 244–246 |
| Found 'UR'-anomaly for variable 'gap' (lines '244'-'250'). | 244–250 |
| Avoid using for statements without curly braces | 249–250 |
| Avoid using if statements without curly braces | 254–255 |
| Avoid using short method names | 266 |
| publicMethodCommentRequirement Required | 266–273 |
| Avoid using short method names | 266 |
| publicMethodCommentRequirement Required | 268–270 |
| publicMethodCommentRequirement Required | 275–282 |
| Avoid if (x != y) ..; else ..; | 276–279 |
| Avoid using if...else statements without curly braces | 277 |
| Avoid using if...else statements without curly braces | 279 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 289 |
| Found 'DD'-anomaly for variable 'config' (lines '290'-'295'). | 290–295 |
| Avoid using if statements without curly braces | 300–301 |
| System.err.println is used | 301 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 305 |
| Avoid printStackTrace(); use a logger call instead. | 306 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 312 |
| publicMethodCommentRequirement Required | 312–338 |
| Avoid variables with short names like w | 314 |
| Avoid variables with short names like w | 314 |
| Avoid using if statements without curly braces | 316–317 |
| Avoid using if statements without curly braces | 319–320 |
| Useless parentheses. | 324 |
| This statement may have some unnecessary parentheses | 324 |
| Avoid variables with short names like in | 328 |
| Found 'DU'-anomaly for variable 'in' (lines '328'-'338'). | 328–338 |
| Avoid variables with short names like in | 328 |
| Avoid variables with short names like s | 331 |
| Avoid variables with short names like s | 331 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 333 |
| Avoid using if statements without curly braces | 334–335 |
| Position literals first in String comparisons | 334 |
| Avoid variables with short names like b | 340 |
| publicMethodCommentRequirement Required | 340–342 |
| Avoid variables with short names like b | 340 |
| Violation | Line |
|---|---|
| Possible God class (WMC=52, ATFD=26, TCC=0.3090909090909091) | 1–275 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 30 |
| Perhaps 'winston' could be replaced by a local variable. | 30 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| Field quit has the same name as a method | 48 |
| fieldCommentRequirement Required | 48 |
| Avoid using redundant field initializer for 'quit' | 48 |
| Field quit has the same name as a method | 48 |
| Private field 'requestSCNL' could be made final; it is only initialized in the declaration or constructor. | 50 |
| fieldCommentRequirement Required | 50 |
| Avoid using redundant field initializer for 'requestSCNL' | 50 |
| fieldCommentRequirement Required | 52 |
| Avoid variables with short names like w | 54 |
| Avoid variables with short names like is | 54 |
| Avoid variables with short names like ws | 54 |
| Avoid variables with short names like is | 54 |
| Avoid variables with short names like w | 54 |
| publicMethodCommentRequirement Required | 54–63 |
| Avoid variables with short names like ws | 54 |
| Avoid variables with short names like en | 65 |
| publicMethodCommentRequirement Required | 65–69 |
| Avoid variables with short names like rd | 65 |
| Avoid variables with short names like rd | 65 |
| Avoid variables with short names like en | 65 |
| Avoid variables with short names like rl | 65 |
| Avoid variables with short names like rl | 65 |
| publicMethodCommentRequirement Required | 71–73 |
| Avoid variables with short names like c | 71 |
| Avoid variables with short names like c | 71 |
| publicMethodCommentRequirement Required | 75–77 |
| publicMethodCommentRequirement Required | 79–81 |
| Avoid variables with short names like t1 | 79 |
| Avoid variables with short names like t1 | 79 |
| Avoid variables with short names like t2 | 79 |
| Avoid variables with short names like t2 | 79 |
| publicMethodCommentRequirement Required | 83–85 |
| Avoid variables with short names like ms | 87 |
| Avoid variables with short names like ms | 87 |
| publicMethodCommentRequirement Required | 87–89 |
| publicMethodCommentRequirement Required | 91–93 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 95 |
| Avoid variables with short names like ss | 97 |
| Avoid variables with short names like ss | 97 |
| Found 'DD'-anomaly for variable 'loc' (lines '98'-'100'). | 98–100 |
| Avoid using Literals in Conditional Statements | 99 |
| Avoid using if statements without curly braces | 99–100 |
| Avoid using if statements without curly braces | 102–103 |
| Found 'DU'-anomaly for variable 'loc' (lines '103'-'233'). | 103–233 |
| Avoid variables with short names like t1 | 105 |
| Avoid variables with short names like t1 | 105 |
| Avoid variables with short names like t2 | 106 |
| Avoid variables with short names like t2 | 106 |
| Avoid variables with short names like ct | 113 |
| Avoid variables with short names like ct | 113 |
| Found 'DD'-anomaly for variable 'tbs' (lines '114'-'125'). | 114–125 |
| Found 'DU'-anomaly for variable 'tbs' (lines '114'-'233'). | 114–233 |
| Found 'DU'-anomaly for variable 'timer' (lines '115'-'233'). | 115–233 |
| Found 'DU'-anomaly for variable 'total' (lines '116'-'233'). | 116–233 |
| Found 'DD'-anomaly for variable 'total' (lines '116'-'184'). | 116–184 |
| Found 'DU'-anomaly for variable 'totalInsTime' (lines '117'-'233'). | 117–233 |
| Found 'DU'-anomaly for variable 'totalDlTime' (lines '118'-'233'). | 118–233 |
| Avoid using if statements without curly braces | 120–121 |
| Avoid instantiating new objects inside loops | 124 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 129 |
| Avoid variables with short names like it | 130 |
| Avoid variables with short names like it | 130 |
| Found 'DD'-anomaly for variable 'minTime' (lines '131'-'135'). | 131–135 |
| Found 'DD'-anomaly for variable 'maxTime' (lines '132'-'136'). | 132–136 |
| Avoid variables with short names like tb | 134 |
| Avoid variables with short names like tb | 134 |
| Avoid using if statements without curly braces | 150–151 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 150 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 157 |
| Avoid printStackTrace(); use a logger call instead. | 158 |
| Avoid instantiating new objects inside loops | 160 |
| Avoid using Literals in Conditional Statements | 171 |
| Avoid variables with short names like tb | 178 |
| Found 'DU'-anomaly for variable 'tb' (lines '178'-'233'). | 178–233 |
| Avoid variables with short names like tb | 178 |
| A switch statement does not contain a break | 179–220 |
| A catch statement should never catch throwable since it includes errors. | 230 |
| Avoid printStackTrace(); use a logger call instead. | 231 |
| Found 'UR'-anomaly for variable 'span' (lines '235'-'238'). | 235–238 |
| Avoid using if statements without curly braces | 237–238 |
| publicMethodCommentRequirement Required | 242–247 |
| Found 'UR'-anomaly for variable 'span' (lines '242'-'245'). | 242–245 |
| Avoid using for statements without curly braces | 244–245 |
| publicMethodCommentRequirement Required | 249–274 |
| Avoid using short method names | 249 |
| Avoid using short method names | 249 |
| Found 'UR'-anomaly for variable 'span' (lines '249'-'251'). | 249–251 |
| Violation | Line |
|---|---|
| publicMethodCommentRequirement Required | 10–12 |
| Avoid unnecessary constructors - the compiler will generate these for you | 10–12 |
| publicMethodCommentRequirement Required | 16–18 |
| Avoid variables with short names like tb | 16 |
| Avoid variables with short names like tb | 16 |
| Useless parentheses. | 17 |
| This statement may have some unnecessary parentheses | 17 |
| publicMethodCommentRequirement Required | 21–23 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 13 |
| Document empty constructor | 13 |
| publicMethodCommentRequirement Required | 13 |
| Avoid unnecessary constructors - the compiler will generate these for you | 13 |
| publicMethodCommentRequirement Required | 16–23 |
| Avoid variables with short names like tb | 16 |
| Avoid variables with short names like tb | 16 |
| Avoid using if statements without curly braces | 17–18 |
| A method should have only one exit point, and that should be the last statement in the method | 18 |
| Avoid variables with short names like t | 20 |
| Avoid variables with short names like t | 20 |
| Avoid variables with short names like ds | 21 |
| Avoid variables with short names like ds | 21 |
| Useless parentheses. | 22 |
| publicMethodCommentRequirement Required | 26–28 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 17–53 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 19 |
| Avoid variables with short names like cf | 23 |
| Avoid variables with short names like cf | 23 |
| publicMethodCommentRequirement Required | 23–31 |
| Avoid using if statements without curly braces | 25–26 |
| Avoid variables with short names like tb | 34 |
| publicMethodCommentRequirement Required | 34–47 |
| Avoid variables with short names like tb | 34 |
| Avoid variables with short names like g | 36 |
| Avoid variables with short names like g | 36 |
| Avoid variables with short names like g2 | 37 |
| Avoid variables with short names like g2 | 37 |
| Avoid variables with short names like g3 | 38 |
| Avoid variables with short names like g3 | 38 |
| Avoid variables with short names like g4 | 39 |
| Avoid variables with short names like g4 | 39 |
| A method should have only one exit point, and that should be the last statement in the method | 44 |
| Avoid using if...else statements without curly braces | 46 |
| publicMethodCommentRequirement Required | 50–52 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 14 |
| fieldCommentRequirement Required | 15 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| Document empty constructor | 22 |
| publicMethodCommentRequirement Required | 22 |
| Avoid unnecessary constructors - the compiler will generate these for you | 22 |
| Avoid variables with short names like cf | 24 |
| Avoid variables with short names like cf | 24 |
| publicMethodCommentRequirement Required | 24–36 |
| publicMethodCommentRequirement Required | 38–49 |
| Avoid variables with short names like dt | 40 |
| Avoid variables with short names like dt | 40 |
| Avoid using if statements without curly braces | 41–42 |
| A method should have only one exit point, and that should be the last statement in the method | 42 |
| Avoid unnecessary if..then..else statements when returning booleans | 45–46 |
| Avoid using if statements without curly braces | 45–46 |
| A method should have only one exit point, and that should be the last statement in the method | 46 |
| publicMethodCommentRequirement Required | 52–56 |
| Violation | Line |
|---|---|
| Private field 'name' could be made final; it is only initialized in the declaration or constructor. | 18 |
| fieldCommentRequirement Required | 18 |
| Private field 'options' could be made final; it is only initialized in the declaration or constructor. | 19 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| Private field 'filters' could be made final; it is only initialized in the declaration or constructor. | 20 |
| Avoid variables with short names like cf | 22 |
| Avoid variables with short names like n | 22 |
| Avoid variables with short names like n | 22 |
| Avoid variables with short names like cf | 22 |
| publicMethodCommentRequirement Required | 22–36 |
| Avoid variables with short names like at | 26 |
| Avoid variables with short names like at | 26 |
| Avoid using if statements without curly braces | 27–28 |
| Avoid variables with short names like fs | 30 |
| Avoid variables with short names like fs | 30 |
| Avoid instantiating new objects inside loops | 33 |
| publicMethodCommentRequirement Required | 38–40 |
| Found 'UR'-anomaly for variable 'filter' (lines '42'-'44'). | 42–44 |
| Avoid variables with short names like tb | 42 |
| Avoid variables with short names like tb | 42 |
| publicMethodCommentRequirement Required | 42–48 |
| Avoid using if statements without curly braces | 44–45 |
| A method should have only one exit point, and that should be the last statement in the method | 45 |
| publicMethodCommentRequirement Required | 50–52 |
| publicMethodCommentRequirement Required | 55–57 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| publicMethodCommentRequirement Required | 26–31 |
| It is a good practice to call super() in a constructor | 26–31 |
| publicMethodCommentRequirement Required | 33–35 |
| It is a good practice to call super() in a constructor | 33–35 |
| publicMethodCommentRequirement Required | 37–44 |
| Avoid variables with short names like l | 37 |
| Avoid variables with short names like s | 37 |
| It is a good practice to call super() in a constructor | 37–44 |
| Avoid variables with short names like n | 37 |
| Avoid variables with short names like c | 37 |
| Avoid variables with short names like l | 37 |
| Avoid variables with short names like c | 37 |
| Avoid variables with short names like s | 37 |
| Avoid variables with short names like n | 37 |
| publicMethodCommentRequirement Required | 46–57 |
| Avoid variables with short names like ss | 47 |
| Avoid variables with short names like ss | 47 |
| Avoid using Literals in Conditional Statements | 48 |
| Avoid variables with short names like cf | 60 |
| publicMethodCommentRequirement Required | 60–70 |
| Avoid variables with short names like cf | 60 |
| Avoid using if statements without curly braces | 62–63 |
| A method should have only one exit point, and that should be the last statement in the method | 63 |
| Avoid using if statements without curly braces | 66–67 |
| Avoid using if statements without curly braces | 73–74 |
| A method should have only one exit point, and that should be the last statement in the method | 74 |
| publicMethodCommentRequirement Required | 80–94 |
| Avoid variables with short names like tb | 80 |
| Avoid variables with short names like tb | 80 |
| Avoid using if statements without curly braces | 81–82 |
| A method should have only one exit point, and that should be the last statement in the method | 82 |
| Avoid using if statements without curly braces | 84–85 |
| A method should have only one exit point, and that should be the last statement in the method | 85 |
| Avoid using if statements without curly braces | 87–88 |
| A method should have only one exit point, and that should be the last statement in the method | 88 |
| Avoid using if statements without curly braces | 90–91 |
| Avoid unnecessary if..then..else statements when returning booleans | 90–91 |
| A method should have only one exit point, and that should be the last statement in the method | 91 |
| publicMethodCommentRequirement Required | 97–100 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 18 |
| Document empty constructor | 20 |
| It is a good practice to call super() in a constructor | 20 |
| publicMethodCommentRequirement Required | 20 |
| publicMethodCommentRequirement Required | 22–26 |
| Avoid variables with short names like cf | 29 |
| Avoid variables with short names like cf | 29 |
| publicMethodCommentRequirement Required | 29–36 |
| Avoid using if statements without curly braces | 31–32 |
| Avoid variables with short names like tb | 39 |
| Avoid variables with short names like tb | 39 |
| publicMethodCommentRequirement Required | 39–48 |
| Avoid variables with short names like dt | 40 |
| Avoid variables with short names like dt | 40 |
| Avoid using if statements without curly braces | 41–42 |
| A method should have only one exit point, and that should be the last statement in the method | 42 |
| Avoid using if statements without curly braces | 44–45 |
| Avoid unnecessary if..then..else statements when returning booleans | 44–45 |
| A method should have only one exit point, and that should be the last statement in the method | 45 |
| publicMethodCommentRequirement Required | 51–54 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 17–93 |
| Abstract classes should be named AbstractXXX | 17–93 |
| Field keepRejects has the same name as a method | 18 |
| fieldCommentRequirement Required | 18 |
| Field keepRejects has the same name as a method | 18 |
| Avoid using redundant field initializer for 'keepRejects' | 18 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| Avoid variables with short names like tb | 26 |
| publicMethodCommentRequirement Required | 26 |
| Avoid variables with short names like tb | 26 |
| publicMethodCommentRequirement Required | 28 |
| Avoid unnecessary constructors - the compiler will generate these for you | 28 |
| Document empty constructor | 28 |
| Avoid variables with short names like cf | 30 |
| Avoid variables with short names like cf | 30 |
| publicMethodCommentRequirement Required | 30–57 |
| Avoid using if statements without curly braces | 31–32 |
| A method should have only one exit point, and that should be the last statement in the method | 32 |
| Avoid using if statements without curly braces | 42–43 |
| Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals(). | 42 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 42 |
| Switch statements should have a default label | 46–56 |
| Avoid variables with short names like b | 59 |
| Avoid variables with short names like b | 59 |
| publicMethodCommentRequirement Required | 59–61 |
| publicMethodCommentRequirement Required | 63–65 |
| publicMethodCommentRequirement Required | 67–69 |
| publicMethodCommentRequirement Required | 71–73 |
| publicMethodCommentRequirement Required | 75–77 |
| publicMethodCommentRequirement Required | 79–81 |
| publicMethodCommentRequirement Required | 83–88 |
| Avoid variables with short names like n | 83 |
| Avoid variables with short names like v | 83 |
| Avoid variables with short names like v | 83 |
| Avoid variables with short names like n | 83 |
| Avoid using if statements without curly braces | 84–85 |
| publicMethodCommentRequirement Required | 90–92 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 21 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILE | 23 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILE | 23 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 25 |
| Avoid variables with short names like fn | 27 |
| publicMethodCommentRequirement Required | 27 |
| Avoid variables with short names like fn | 27 |
| protectedMethodCommentRequirement Required | 29–45 |
| Avoid variables with short names like cf | 30 |
| Avoid variables with short names like cf | 30 |
| System.err.print is used | 32 |
| Found 'UR'-anomaly for variable 'instrument' (lines '47'-'50'). | 47–50 |
| publicMethodCommentRequirement Required | 47–53 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 20–92 |
| fieldCommentRequirement Required | 21 |
| Avoid variables with short names like me | 23 |
| fieldCommentRequirement Required | 23 |
| Variables that are final and static should be all capitals, 'me' is not all capitals. | 23 |
| Variables that are final and static should be all capitals, 'me' is not all capitals. | 23 |
| Avoid variables with short names like me | 23 |
| publicMethodCommentRequirement Required | 25–27 |
| Avoid variables with short names like fn | 30 |
| publicMethodCommentRequirement Required | 30–67 |
| Avoid variables with short names like fn | 30 |
| Avoid variables with short names like ls | 35 |
| Avoid variables with short names like ls | 35 |
| Avoid assignments in operands | 48 |
| Found 'DU'-anomaly for variable 'object' (lines '48'-'67'). | 48–67 |
| Avoid variables with short names like b | 49 |
| Avoid variables with short names like b | 49 |
| Avoid using Literals in Conditional Statements | 50 |
| Avoid using if statements without curly braces | 50–51 |
| Avoid instantiating new objects inside loops | 53 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 63 |
| Avoid printStackTrace(); use a logger call instead. | 64 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 72 |
| System.err.println is used | 77 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 24 |
| Variables that are final and static should be all capitals, 'me' is not all capitals. | 26 |
| Variables that are final and static should be all capitals, 'me' is not all capitals. | 26 |
| Avoid variables with short names like me | 26 |
| fieldCommentRequirement Required | 26 |
| Avoid variables with short names like me | 26 |
| publicMethodCommentRequirement Required | 28–30 |
| Avoid variables with short names like fn | 33 |
| publicMethodCommentRequirement Required | 33–69 |
| Avoid variables with short names like fn | 33 |
| Avoid variables with short names like in | 39 |
| Avoid variables with short names like in | 39 |
| Avoid instantiating new objects inside loops | 43 |
| Avoid using if statements without curly braces | 48–49 |
| Avoid using if statements without curly braces | 54–55 |
| An empty statement (semicolon) not part of a loop | 56 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 65 |
| Avoid printStackTrace(); use a logger call instead. | 66 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 74 |
| System.err.println is used | 79 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 41 |
| Avoid using redundant field initializer for 'instances' | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 43 |
| publicMethodCommentRequirement Required | 45–56 |
| Avoid variables with short names like s | 45 |
| Avoid variables with short names like s | 45 |
| Overridable method 'setupCommandHandlers' called during object construction | 55 |
| protectedMethodCommentRequirement Required | 59–80 |
| publicMethodCommentRequirement Required | 61–63 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid short class names like WWS | 27–332 |
| Avoid short class names like WWS | 27–332 |
| fieldCommentRequirement Required | 28 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 36 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 36 |
| Found 'DU'-anomaly for variable 'in' (lines '45'-'81'). | 45–81 |
| Avoid variables with short names like in | 45 |
| Avoid variables with short names like in | 45 |
| Avoid variables with short names like s | 52 |
| Avoid variables with short names like s | 52 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 54 |
| Position literals first in String comparisons | 55 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 58 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 60 |
| Position literals first in String comparisons | 62 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 64 |
| Position literals first in String comparisons | 66 |
| Position literals first in String comparisons | 68 |
| Position literals first in String comparisons | 70 |
| Position literals first in String comparisons | 72 |
| Position literals first in String comparisons | 74 |
| publicMethodCommentRequirement Required | 83–103 |
| StringBuffer constructor is initialized with size 16, but has at least 610 characters appended. | 84 |
| Avoid variables with short names like sb | 84 |
| Avoid variables with short names like sb | 84 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 85 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 85 |
| StringBuffer (or StringBuilder).append is called 16 consecutive times with literal Strings. Use a single append with a single combined String. | 85 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 86 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 87 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 88 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 89 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 90 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 91 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 92 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 93 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 94 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 95 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 96 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 97 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 98 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 99 |
| System.out.println is used | 102 |
| fieldCommentRequirement Required | 105 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 105 |
| fieldCommentRequirement Required | 107 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 107 |
| fieldCommentRequirement Required | 108 |
| Avoid using redundant field initializer for 'embargo' | 108 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 108 |
| fieldCommentRequirement Required | 110 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 110 |
| fieldCommentRequirement Required | 111 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 111 |
| Field httpMaxSize has the same name as a method | 111 |
| Field httpMaxSize has the same name as a method | 111 |
| Avoid excessively long variable names like httpRefreshInterval | 112 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 112 |
| Avoid excessively long variable names like httpRefreshInterval | 112 |
| Field httpRefreshInterval has the same name as a method | 112 |
| fieldCommentRequirement Required | 112 |
| Field httpRefreshInterval has the same name as a method | 112 |
| fieldCommentRequirement Required | 113 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 113 |
| fieldCommentRequirement Required | 114 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 114 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 116 |
| fieldCommentRequirement Required | 116 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 117 |
| fieldCommentRequirement Required | 117 |
| Field maxDays has the same name as a method | 119 |
| Avoid using redundant field initializer for 'maxDays' | 119 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 119 |
| Field maxDays has the same name as a method | 119 |
| fieldCommentRequirement Required | 119 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 121 |
| fieldCommentRequirement Required | 121 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 123 |
| fieldCommentRequirement Required | 123 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 125 |
| fieldCommentRequirement Required | 125 |
| Avoid excessively long variable names like winstonStatementCacheCap | 127 |
| Avoid excessively long variable names like winstonStatementCacheCap | 127 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 127 |
| fieldCommentRequirement Required | 127 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 129 |
| fieldCommentRequirement Required | 129 |
| fieldCommentRequirement Required | 131 |
| Avoid variables with short names like cf | 131 |
| Perhaps 'cf' could be replaced by a local variable. | 131 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 131 |
| Avoid variables with short names like cf | 131 |
| Avoid variables with short names like cf | 136 |
| Avoid variables with short names like cf | 136 |
| Overridable method 'processConfigFile' called during object construction | 142 |
| Avoid instantiating new objects inside loops | 144 |
| protectedMethodCommentRequirement Required | 148–151 |
| publicMethodCommentRequirement Required | 153–155 |
| publicMethodCommentRequirement Required | 157–159 |
| publicMethodCommentRequirement Required | 161–163 |
| publicMethodCommentRequirement Required | 174–176 |
| publicMethodCommentRequirement Required | 178–180 |
| publicMethodCommentRequirement Required | 191–193 |
| publicMethodCommentRequirement Required | 195–197 |
| publicMethodCommentRequirement Required | 199–201 |
| publicMethodCommentRequirement Required | 203–245 |
| publicMethodCommentRequirement Required | 247–249 |
| Avoid variables with short names like a | 261 |
| Avoid variables with short names like a | 261 |
| Avoid variables with short names like p | 271 |
| Avoid variables with short names like p | 271 |
| Avoid variables with short names like k | 278 |
| Avoid variables with short names like k | 278 |
| Avoid variables with short names like h | 282 |
| Avoid variables with short names like h | 282 |
| Avoid variables with short names like m | 289 |
| Avoid variables with short names like m | 289 |
| Avoid variables with short names like i | 297 |
| Avoid variables with short names like i | 297 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 7 |
| Package name contains upper case characters | 7 |
| fieldCommentRequirement Required | 27 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 29 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 29 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 37 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 53 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 53 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Possible God class (WMC=74, ATFD=35, TCC=0.0) | 1–456 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 40 |
| Avoid unused private fields such as 'LOGGER'. | 40 |
| fieldCommentRequirement Required | 42 |
| Avoid variables with short names like p | 44 |
| Avoid variables with short names like p | 44 |
| publicMethodCommentRequirement Required | 44–47 |
| Avoid variables with short names like h | 44 |
| Avoid variables with short names like h | 44 |
| publicMethodCommentRequirement Required | 49–51 |
| Avoid variables with short names like rl | 49 |
| Avoid variables with short names like rl | 49 |
| publicMethodCommentRequirement Required | 53–71 |
| Found 'DD'-anomaly for variable 'version' (lines '54'-'62'). | 54–62 |
| Avoid using if statements without curly braces | 56–57 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 63 |
| Avoid empty catch blocks | 63–64 |
| Avoid empty catch blocks | 67–68 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 67 |
| protectedMethodCommentRequirement Required | 73–123 |
| Found 'DU'-anomaly for variable 'ret' (lines '74'-'123'). | 74–123 |
| Found 'DU'-anomaly for variable 'ret' (lines '74'-'123'). | 74–123 |
| Found 'DU'-anomaly for variable 'ret' (lines '74'-'123'). | 74–123 |
| Avoid variables with short names like rt | 75 |
| Found 'DU'-anomaly for variable 'rt' (lines '75'-'123'). | 75–123 |
| Avoid variables with short names like rt | 75 |
| Found 'DU'-anomaly for variable 'rt' (lines '75'-'123'). | 75–123 |
| Found 'DU'-anomaly for variable 'rt' (lines '75'-'123'). | 75–123 |
| publicMethodCommentRequirement Required | 77–79 |
| publicMethodCommentRequirement Required | 82–115 |
| Avoid using if statements without curly braces | 84–85 |
| Avoid variables with short names like ss | 95 |
| Avoid variables with short names like ss | 95 |
| Avoid using if statements without curly braces | 97–98 |
| Found 'DD'-anomaly for variable 'buf' (lines '100'-'102'). | 100–102 |
| Found 'DD'-anomaly for variable 'buf' (lines '100'-'102'). | 100–102 |
| Found 'DD'-anomaly for variable 'buf' (lines '100'-'102'). | 100–102 |
| Avoid using if statements without curly braces | 101–102 |
| Avoid empty catch blocks | 119–121 |
| publicMethodCommentRequirement Required | 125–127 |
| publicMethodCommentRequirement Required | 129–182 |
| Found 'DD'-anomaly for variable 'result' (lines '130'-'156'). | 130–156 |
| Found 'DD'-anomaly for variable 'result' (lines '130'-'156'). | 130–156 |
| Found 'DD'-anomaly for variable 'result' (lines '130'-'156'). | 130–156 |
| Found 'DU'-anomaly for variable 'result' (lines '130'-'182'). | 130–182 |
| Found 'DU'-anomaly for variable 'result' (lines '130'-'182'). | 130–182 |
| Found 'DU'-anomaly for variable 'result' (lines '130'-'182'). | 130–182 |
| Found 'DU'-anomaly for variable 'rt' (lines '131'-'182'). | 131–182 |
| Avoid variables with short names like rt | 131 |
| Found 'DU'-anomaly for variable 'rt' (lines '131'-'182'). | 131–182 |
| Avoid variables with short names like rt | 131 |
| Found 'DU'-anomaly for variable 'rt' (lines '131'-'182'). | 131–182 |
| publicMethodCommentRequirement Required | 133–135 |
| publicMethodCommentRequirement Required | 138–164 |
| Avoid using if statements without curly braces | 140–141 |
| Avoid using if statements without curly braces | 144–145 |
| Prefer StringBuffer over += for concatenating strings | 145 |
| Avoid variables with short names like ss | 148 |
| Avoid variables with short names like ss | 148 |
| Avoid using if statements without curly braces | 150–151 |
| Avoid using for statements without curly braces | 153–154 |
| Found 'DU'-anomaly for variable 'result' (lines '156'-'182'). | 156–182 |
| Found 'DU'-anomaly for variable 'result' (lines '156'-'182'). | 156–182 |
| Found 'DU'-anomaly for variable 'result' (lines '156'-'182'). | 156–182 |
| Avoid empty catch blocks | 168–170 |
| Avoid using if statements without curly braces | 172–173 |
| A method should have only one exit point, and that should be the last statement in the method | 173 |
| Avoid instantiating new objects inside loops | 177 |
| Avoid variables with short names like ch | 177 |
| Avoid variables with short names like ch | 177 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 184–185 |
| publicMethodCommentRequirement Required | 184–193 |
| Avoid using if statements without curly braces | 189–190 |
| A method should have only one exit point, and that should be the last statement in the method | 190 |
| publicMethodCommentRequirement Required | 195–204 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 195–196 |
| Avoid using if statements without curly braces | 200–201 |
| A method should have only one exit point, and that should be the last statement in the method | 201 |
| publicMethodCommentRequirement Required | 206–208 |
| Avoid variables with short names like d | 210 |
| Avoid variables with short names like d | 210 |
| publicMethodCommentRequirement Required | 210–249 |
| Avoid variables with short names like rt | 212 |
| Found 'DU'-anomaly for variable 'rt' (lines '212'-'249'). | 212–249 |
| Found 'DU'-anomaly for variable 'rt' (lines '212'-'249'). | 212–249 |
| Avoid variables with short names like rt | 212 |
| Found 'DU'-anomaly for variable 'rt' (lines '212'-'249'). | 212–249 |
| publicMethodCommentRequirement Required | 214–216 |
| publicMethodCommentRequirement Required | 219–245 |
| Avoid using if statements without curly braces | 221–222 |
| Avoid variables with short names like ss | 228 |
| Avoid variables with short names like ss | 228 |
| Avoid using if statements without curly braces | 230–231 |
| Avoid using for statements without curly braces | 234–235 |
| publicMethodCommentRequirement Required | 251–261 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 251–253 |
| Avoid using if statements without curly braces | 257–258 |
| A method should have only one exit point, and that should be the last statement in the method | 258 |
| Avoid variables with short names like s | 263 |
| publicMethodCommentRequirement Required | 263–269 |
| Avoid variables with short names like et | 263 |
| Avoid variables with short names like st | 263 |
| Avoid variables with short names like p | 263 |
| Avoid variables with short names like st | 263 |
| Avoid variables with short names like p | 263 |
| Avoid variables with short names like et | 263 |
| Avoid variables with short names like s | 263 |
| Avoid variables with short names like c | 264 |
| Avoid variables with short names like c | 264 |
| Avoid variables with short names like df | 265 |
| When instantiating a SimpleDateFormat object, specify a Locale | 265 |
| Avoid variables with short names like df | 265 |
| Avoid variables with short names like p | 271 |
| Avoid variables with short names like s | 271 |
| Avoid variables with short names like st | 271 |
| publicMethodCommentRequirement Required | 271–302 |
| Avoid variables with short names like et | 271 |
| Avoid variables with short names like st | 271 |
| Avoid variables with short names like p | 271 |
| Avoid variables with short names like et | 271 |
| Avoid variables with short names like s | 271 |
| Avoid variables with short names like c | 272 |
| Avoid variables with short names like c | 272 |
| Avoid variables with short names like fn | 272 |
| Avoid variables with short names like fn | 272 |
| Avoid if (x != y) ..; else ..; | 284–301 |
| Avoid using if statements without curly braces | 289–290 |
| Prefer StringBuffer over += for concatenating strings | 290 |
| System.err.println is used | 296 |
| Avoid printStackTrace(); use a logger call instead. | 297 |
| System.out.println is used | 300 |
| publicMethodCommentRequirement Required | 304–373 |
| Avoid variables with short names like st | 304 |
| Avoid variables with short names like st | 304 |
| Avoid variables with short names like fn | 305 |
| Avoid variables with short names like fn | 305 |
| Avoid variables with short names like et | 305 |
| Avoid variables with short names like c | 305 |
| Avoid variables with short names like c | 305 |
| Avoid variables with short names like et | 305 |
| Avoid variables with short names like N | 319 |
| Avoid variables with short names like N | 319 |
| Avoid variables with short names like t1 | 320 |
| Avoid variables with short names like t1 | 320 |
| Avoid variables with short names like t2 | 321 |
| Found 'DD'-anomaly for variable 't2' (lines '321'-'345'). | 321–345 |
| Avoid variables with short names like t2 | 321 |
| Found 'DD'-anomaly for variable 't2' (lines '321'-'326'). | 321–326 |
| System.out.printf is used | 323 |
| System.out.printf is used | 327 |
| System.out.printf is used | 329 |
| Avoid using if statements without curly braces | 330–331 |
| Avoid using if statements without curly braces | 333–342 |
| System.out.printf is used | 335 |
| System.out.println is used | 337 |
| Avoid printStackTrace(); use a logger call instead. | 341 |
| System.out.printf is used | 346 |
| System.out.printf is used | 348 |
| Avoid using if statements without curly braces | 350–351 |
| Avoid if (x != y) ..; else ..; | 355–372 |
| Avoid using if statements without curly braces | 360–361 |
| Prefer StringBuffer over += for concatenating strings | 361 |
| System.err.println is used | 367 |
| Avoid printStackTrace(); use a logger call instead. | 368 |
| System.out.println is used | 371 |
| Avoid variables with short names like p | 375 |
| Avoid variables with short names like s | 375 |
| Avoid variables with short names like et | 375 |
| Avoid variables with short names like s | 375 |
| Avoid variables with short names like et | 375 |
| Avoid variables with short names like st | 375 |
| Avoid variables with short names like st | 375 |
| Avoid variables with short names like p | 375 |
| Found 'UR'-anomaly for variable 'i' (lines '375'-'392'). | 375–392 |
| publicMethodCommentRequirement Required | 375–397 |
| Avoid variables with short names like c | 376 |
| Avoid variables with short names like c | 376 |
| System.out.println is used | 377 |
| Avoid if (x != y) ..; else ..; | 389–396 |
| Avoid using for statements without curly braces | 391–392 |
| System.out.println is used | 392 |
| System.out.println is used | 395 |
| publicMethodCommentRequirement Required | 399–454 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 399 |
| Avoid variables with short names like as | 399 |
| Avoid variables with short names like as | 399 |
| Avoid variables with short names like df | 400 |
| Avoid variables with short names like df | 400 |
| When instantiating a SimpleDateFormat object, specify a Locale | 400 |
| Found 'DD'-anomaly for variable 'st' (lines '403'-'439'). | 403–439 |
| Avoid variables with short names like st | 403 |
| Avoid variables with short names like st | 403 |
| Found 'DD'-anomaly for variable 'et' (lines '404'-'440'). | 404–440 |
| Avoid variables with short names like et | 404 |
| Avoid variables with short names like et | 404 |
| Avoid variables with short names like s | 405 |
| Avoid variables with short names like s | 405 |
| Avoid variables with short names like p | 406 |
| Avoid variables with short names like p | 406 |
| Avoid variables with short names like c | 407 |
| Avoid variables with short names like c | 407 |
| System.err.println is used | 424 |
| System.out.println is used | 425 |
| System.out.println is used | 426 |
| System.out.println is used | 427 |
| System.out.println is used | 428 |
| System.out.println is used | 429 |
| System.out.println is used | 430 |
| System.out.println is used | 431 |
| Found 'DU'-anomaly for variable 's' (lines '435'-'454'). | 435–454 |
| Found 'DU'-anomaly for variable 'p' (lines '436'-'454'). | 436–454 |
| Found 'DU'-anomaly for variable 'st' (lines '439'-'454'). | 439–454 |
| Found 'DU'-anomaly for variable 'et' (lines '440'-'454'). | 440–454 |
| Avoid printStackTrace(); use a logger call instead. | 442 |
| Found 'DU'-anomaly for variable 'c' (lines '444'-'454'). | 444–454 |
| System.out.println is used | 447 |
| Avoid using if statements without curly braces | 451–452 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 17 |
| publicMethodCommentRequirement Required | 19–22 |
| publicMethodCommentRequirement Required | 24–26 |
| publicMethodCommentRequirement Required | 28–30 |
| Avoid variables with short names like i | 32 |
| publicMethodCommentRequirement Required | 32–37 |
| Avoid variables with short names like i | 32 |
| Avoid using if...else statements without curly braces | 34 |
| A method should have only one exit point, and that should be the last statement in the method | 34 |
| Avoid using if...else statements without curly braces | 36 |
| Avoid variables with short names like i | 39 |
| Avoid variables with short names like i | 39 |
| publicMethodCommentRequirement Required | 39–46 |
| Found 'DD'-anomaly for variable 'result' (lines '40'-'42'). | 40–42 |
| Avoid empty catch blocks | 43–44 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 43 |
| Avoid variables with short names like i | 48 |
| Avoid variables with short names like i | 48 |
| publicMethodCommentRequirement Required | 48–55 |
| Found 'DD'-anomaly for variable 'result' (lines '49'-'51'). | 49–51 |
| Avoid empty catch blocks | 52–53 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 52 |
| publicMethodCommentRequirement Required | 57–62 |
| Avoid using Literals in Conditional Statements | 58 |
| A method should have only one exit point, and that should be the last statement in the method | 59 |
| Avoid using if...else statements without curly braces | 59 |
| Avoid using if...else statements without curly braces | 61 |
| publicMethodCommentRequirement Required | 64–73 |
| Avoid using Literals in Conditional Statements | 65 |
| A method should have only one exit point, and that should be the last statement in the method | 66 |
| Avoid using if...else statements without curly braces | 66 |
| Found 'DD'-anomaly for variable 'loc' (lines '68'-'70'). | 68–70 |
| Avoid using if statements without curly braces | 69–70 |
| publicMethodCommentRequirement Required | 75–83 |
| Found 'DD'-anomaly for variable 'ofs' (lines '76'-'78'). | 76–78 |
| Avoid using if statements without curly braces | 77–78 |
| Avoid using if...else statements without curly braces | 80 |
| A method should have only one exit point, and that should be the last statement in the method | 80 |
| Avoid using if...else statements without curly braces | 82 |
| publicMethodCommentRequirement Required | 85–93 |
| Found 'DD'-anomaly for variable 'ofs' (lines '86'-'88'). | 86–88 |
| Avoid using if statements without curly braces | 87–88 |
| A method should have only one exit point, and that should be the last statement in the method | 90 |
| Avoid using if...else statements without curly braces | 90 |
| Avoid using if...else statements without curly braces | 92 |
| publicMethodCommentRequirement Required | 95–97 |
| publicMethodCommentRequirement Required | 99–101 |
| publicMethodCommentRequirement Required | 103–111 |
| Avoid using if statements without curly braces | 104–105 |
| A method should have only one exit point, and that should be the last statement in the method | 105 |
| Avoid unnecessary if..then..else statements when returning booleans | 107–108 |
| Avoid using if statements without curly braces | 107–108 |
| A method should have only one exit point, and that should be the last statement in the method | 108 |
| publicMethodCommentRequirement Required | 113–121 |
| Avoid using if statements without curly braces | 114–115 |
| A method should have only one exit point, and that should be the last statement in the method | 115 |
| Avoid unnecessary if..then..else statements when returning booleans | 117–118 |
| Avoid using if statements without curly braces | 117–118 |
| A method should have only one exit point, and that should be the last statement in the method | 118 |
| publicMethodCommentRequirement Required | 123–128 |
| Avoid using Literals in Conditional Statements | 124 |
| Avoid using if statements without curly braces | 124–125 |
| A method should have only one exit point, and that should be the last statement in the method | 125 |
| publicMethodCommentRequirement Required | 130–135 |
| Avoid using if statements without curly braces | 131–132 |
| Avoid using Literals in Conditional Statements | 131 |
| A method should have only one exit point, and that should be the last statement in the method | 132 |
| publicMethodCommentRequirement Required | 137–142 |
| Avoid using Literals in Conditional Statements | 138 |
| Avoid using if statements without curly braces | 138–139 |
| A method should have only one exit point, and that should be the last statement in the method | 139 |
| publicMethodCommentRequirement Required | 144–149 |
| Avoid using if statements without curly braces | 145–146 |
| Avoid using Literals in Conditional Statements | 145 |
| A method should have only one exit point, and that should be the last statement in the method | 146 |
| publicMethodCommentRequirement Required | 152–155 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 26–187 |
| Abstract classes should be named AbstractXXX | 26–187 |
| Avoid unused private fields such as 'LOGGER'. | 27 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| Avoid variables with short names like db | 40 |
| Avoid variables with short names like nt | 40 |
| Avoid variables with short names like nt | 40 |
| publicMethodCommentRequirement Required | 40–50 |
| Avoid variables with short names like db | 40 |
| protectedMethodCommentRequirement Required | 52–59 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 52–53 |
| Avoid variables with short names like s | 52 |
| Avoid variables with short names like id | 52 |
| Avoid variables with short names like id | 52 |
| Avoid variables with short names like s | 52 |
| Avoid variables with short names like c | 53 |
| Avoid variables with short names like l | 53 |
| Avoid variables with short names like n | 53 |
| Avoid variables with short names like c | 53 |
| Avoid variables with short names like l | 53 |
| Avoid variables with short names like n | 53 |
| Found 'DD'-anomaly for variable 'loc' (lines '54'-'56'). | 54–56 |
| Avoid using if statements without curly braces | 55–56 |
| Avoid variables with short names like bb | 61 |
| protectedMethodCommentRequirement Required | 61–72 |
| Avoid variables with short names like id | 61 |
| Avoid variables with short names like bb | 61 |
| Avoid reassigning parameters such as 'bb' | 61 |
| Avoid variables with short names like id | 61 |
| A method should have only one exit point, and that should be the last statement in the method | 65 |
| Avoid using if statements without curly braces | 67–68 |
| Avoid variables with short names like d | 74 |
| protectedMethodCommentRequirement Required | 74–88 |
| Avoid variables with short names like d | 74 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 74 |
| Avoid using if statements without curly braces | 75–76 |
| A method should have only one exit point, and that should be the last statement in the method | 76 |
| Avoid using if statements without curly braces | 78–79 |
| A method should have only one exit point, and that should be the last statement in the method | 79 |
| Avoid using if statements without curly braces | 81–82 |
| A method should have only one exit point, and that should be the last statement in the method | 82 |
| Avoid using if statements without curly braces | 84–85 |
| A method should have only one exit point, and that should be the last statement in the method | 85 |
| protectedMethodCommentRequirement Required | 90–92 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 90 |
| Avoid variables with short names like d | 90 |
| Avoid variables with short names like d | 90 |
| Avoid reassigning parameters such as 't2' | 94 |
| protectedMethodCommentRequirement Required | 94–116 |
| Avoid variables with short names like t1 | 94 |
| Avoid variables with short names like t2 | 94 |
| Avoid variables with short names like t2 | 94 |
| Avoid variables with short names like t1 | 94 |
| Avoid reassigning parameters such as 't1' | 94 |
| Avoid using if statements without curly braces | 95–96 |
| A method should have only one exit point, and that should be the last statement in the method | 96 |
| Avoid variables with short names like tb | 98 |
| Avoid variables with short names like tb | 98 |
| Avoid using if statements without curly braces | 100–101 |
| Avoid using if statements without curly braces | 106–107 |
| Avoid using if statements without curly braces | 109–110 |
| A method should have only one exit point, and that should be the last statement in the method | 110 |
| Avoid using if statements without curly braces | 112–113 |
| A method should have only one exit point, and that should be the last statement in the method | 113 |
| Avoid variables with short names like s | 118 |
| Avoid variables with short names like s | 118 |
| Avoid variables with short names like id | 118 |
| Avoid variables with short names like id | 118 |
| Rather than using a lot of String arguments, consider using a container object for those values. | 118–120 |
| publicMethodCommentRequirement Required | 118–172 |
| Avoid variables with short names like t1 | 119 |
| Avoid variables with short names like c | 119 |
| Avoid variables with short names like c | 119 |
| Avoid variables with short names like n | 119 |
| Avoid variables with short names like l | 119 |
| Avoid variables with short names like t1 | 119 |
| Avoid variables with short names like n | 119 |
| Avoid variables with short names like t2 | 119 |
| Avoid variables with short names like t2 | 119 |
| Avoid variables with short names like l | 119 |
| Found 'DD'-anomaly for variable 'sts' (lines '122'-'132'). | 122–132 |
| Avoid variables with short names like ct | 125 |
| Avoid variables with short names like ct | 125 |
| Avoid variables with short names like dt | 126 |
| Avoid variables with short names like dt | 126 |
| Found 'DU'-anomaly for variable 'dt' (lines '126'-'172'). | 126–172 |
| Avoid using if statements without curly braces | 128–129 |
| Avoid variables with short names like bb | 133 |
| Avoid variables with short names like bb | 133 |
| Found 'DU'-anomaly for variable 'ct' (lines '153'-'172'). | 153–172 |
| Avoid using if...else statements without curly braces | 160 |
| Avoid using if...else statements without curly braces | 162 |
| Avoid using if statements without curly braces | 166–167 |
| Avoid variables with short names like t | 181 |
| Avoid variables with short names like t | 181 |
| Use explicit scoping instead of the default package private level | 181–186 |
| Avoid using if...else statements without curly braces | 183 |
| A method should have only one exit point, and that should be the last statement in the method | 183 |
| Avoid using if...else statements without curly braces | 185 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 21 |
| Avoid variables with short names like nt | 23 |
| Avoid variables with short names like db | 23 |
| publicMethodCommentRequirement Required | 23–26 |
| Avoid variables with short names like nt | 23 |
| Avoid variables with short names like db | 23 |
| publicMethodCommentRequirement Required | 28–52 |
| Found 'UR'-anomaly for variable 'ch' (lines '28'-'44'). | 28–44 |
| Found 'UR'-anomaly for variable 'ch' (lines '28'-'42'). | 28–42 |
| Avoid using if statements without curly braces | 30–31 |
| Found 'DD'-anomaly for variable 'metadata' (lines '33'-'35'). | 33–35 |
| Avoid using if statements without curly braces | 34–35 |
| Avoid variables with short names like sb | 38 |
| Avoid variables with short names like sb | 38 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 42 |
| Avoid using if...else statements without curly braces | 42 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 44 |
| Avoid using if...else statements without curly braces | 44 |
| Avoid variables with short names like c | 48 |
| Avoid variables with short names like c | 48 |
| Found 'DD'-anomaly for variable 'c' (lines '48'-'50'). | 48–50 |
| Avoid using if statements without curly braces | 49–50 |
| Prefer StringBuffer over += for concatenating strings | 50 |
| There is log block not surrounded by if | 51 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 21 |
| Avoid variables with short names like db | 23 |
| Avoid variables with short names like nt | 23 |
| Avoid variables with short names like nt | 23 |
| publicMethodCommentRequirement Required | 23–26 |
| Avoid variables with short names like db | 23 |
| Avoid variables with short names like s | 28 |
| Avoid variables with short names like s | 28 |
| Avoid using if statements without curly braces | 29–30 |
| A method should have only one exit point, and that should be the last statement in the method | 30 |
| Avoid variables with short names like sb | 34 |
| Avoid variables with short names like sb | 34 |
| Found 'UR'-anomaly for variable 'value' (lines '34'-'40'). | 34–40 |
| Avoid appending characters as strings in StringBuffer.append. | 36 |
| Avoid using if statements without curly braces | 37–38 |
| Avoid variables with short names like sb | 45 |
| Avoid variables with short names like sb | 45 |
| Found 'UR'-anomaly for variable 'key' (lines '45'-'50'). | 45–50 |
| Avoid using if statements without curly braces | 46–47 |
| Avoid appending characters as strings in StringBuffer.append. | 52 |
| Avoid appending characters as strings in StringBuffer.append. | 54 |
| Found 'UR'-anomaly for variable 'inst' (lines '58'-'64'). | 58–64 |
| Avoid variables with short names like sb | 60 |
| Avoid variables with short names like sb | 60 |
| StringBuffer constructor is initialized with size 16, but has at least 60 characters appended. | 60 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 65 |
| Avoid appending characters as strings in StringBuffer.append. | 65 |
| Avoid appending characters as strings in StringBuffer.append. | 68 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 68 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 71 |
| Avoid appending characters as strings in StringBuffer.append. | 71 |
| Avoid appending characters as strings in StringBuffer.append. | 74 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 74 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 77 |
| Avoid appending characters as strings in StringBuffer.append. | 77 |
| Avoid appending characters as strings in StringBuffer.append. | 80 |
| Avoid appending characters as strings in StringBuffer.append. | 82 |
| Found 'UR'-anomaly for variable 'ch' (lines '87'-'93'). | 87–93 |
| StringBuffer constructor is initialized with size 16, but has at least 75 characters appended. | 89 |
| Avoid variables with short names like sb | 89 |
| Avoid variables with short names like sb | 89 |
| Avoid appending characters as strings in StringBuffer.append. | 94 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 94 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 97 |
| Avoid appending characters as strings in StringBuffer.append. | 97 |
| Avoid appending characters as strings in StringBuffer.append. | 100 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 100 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 103 |
| Avoid appending characters as strings in StringBuffer.append. | 103 |
| Avoid appending characters as strings in StringBuffer.append. | 106 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 106 |
| Avoid appending characters as strings in StringBuffer.append. | 109 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 109 |
| Avoid appending characters as strings in StringBuffer.append. | 112 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 112 |
| Avoid appending characters as strings in StringBuffer.append. | 115 |
| Avoid appending characters as strings in StringBuffer.append. | 117 |
| Avoid appending characters as strings in StringBuffer.append. | 119 |
| publicMethodCommentRequirement Required | 124–136 |
| Avoid variables with short names like ss | 126 |
| Avoid variables with short names like ss | 126 |
| Avoid using Literals in Conditional Statements | 127 |
| Avoid using if statements without curly braces | 127–128 |
| Avoid using if...else statements without curly braces | 131 |
| Avoid using if statements without curly braces | 132–133 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 21 |
| Avoid variables with short names like nt | 21 |
| Avoid variables with short names like db | 21 |
| Avoid variables with short names like nt | 21 |
| publicMethodCommentRequirement Required | 21–23 |
| publicMethodCommentRequirement Required | 25–62 |
| Found 'DD'-anomaly for variable 'totalBytes' (lines '26'-'54'). | 26–54 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 26 |
| Found 'DU'-anomaly for variable 'totalBytes' (lines '26'-'62'). | 26–62 |
| Avoid using if statements without curly braces | 28–29 |
| A method should have only one exit point, and that should be the last statement in the method | 29 |
| A method should have only one exit point, and that should be the last statement in the method | 34 |
| Avoid variables with short names like t1 | 37 |
| Found 'DD'-anomaly for variable 't1' (lines '37'-'38'). | 37–38 |
| Avoid variables with short names like t1 | 37 |
| Found 'DD'-anomaly for variable 't2' (lines '40'-'41'). | 40–41 |
| Avoid variables with short names like t2 | 40 |
| Avoid variables with short names like t2 | 40 |
| Found 'DD'-anomaly for variable 'wave' (lines '48'-'50'). | 48–50 |
| Avoid empty catch blocks | 51–52 |
| Avoid if (x != y) ..; else ..; | 53–57 |
| Avoid using if...else statements without curly braces | 54–55 |
| Avoid using if...else statements without curly braces | 57 |
| There is log block not surrounded by if | 61 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 22 |
| Avoid variables with short names like nt | 24 |
| Avoid variables with short names like db | 24 |
| Avoid variables with short names like nt | 24 |
| Avoid variables with short names like db | 24 |
| publicMethodCommentRequirement Required | 24–26 |
| publicMethodCommentRequirement Required | 28–66 |
| Found 'DU'-anomaly for variable 'totalBytes' (lines '29'-'66'). | 29–66 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 29 |
| Found 'DD'-anomaly for variable 'totalBytes' (lines '29'-'58'). | 29–58 |
| Avoid using if statements without curly braces | 31–32 |
| A method should have only one exit point, and that should be the last statement in the method | 32 |
| A method should have only one exit point, and that should be the last statement in the method | 38 |
| Avoid variables with short names like t1 | 41 |
| Found 'DD'-anomaly for variable 't1' (lines '41'-'42'). | 41–42 |
| Avoid variables with short names like t1 | 41 |
| Avoid variables with short names like t2 | 44 |
| Avoid variables with short names like t2 | 44 |
| Found 'DD'-anomaly for variable 't2' (lines '44'-'45'). | 44–45 |
| Found 'DD'-anomaly for variable 'wave' (lines '52'-'54'). | 52–54 |
| Avoid empty catch blocks | 55–56 |
| Avoid if (x != y) ..; else ..; | 57–61 |
| Avoid using if...else statements without curly braces | 58–59 |
| Avoid using if...else statements without curly braces | 61 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 25 |
| Avoid variables with short names like nt | 27 |
| Avoid variables with short names like db | 27 |
| publicMethodCommentRequirement Required | 27–29 |
| Avoid variables with short names like db | 27 |
| Avoid variables with short names like nt | 27 |
| publicMethodCommentRequirement Required | 31–58 |
| Avoid using if statements without curly braces | 33–34 |
| Found 'DD'-anomaly for variable 'et' (lines '36'-'37'). | 36–37 |
| Avoid variables with short names like et | 36 |
| Avoid variables with short names like et | 36 |
| Avoid variables with short names like st | 39 |
| Found 'DD'-anomaly for variable 'st' (lines '39'-'40'). | 39–40 |
| Avoid variables with short names like st | 39 |
| Found 'DD'-anomaly for variable 'heli' (lines '43'-'46'). | 43–46 |
| Avoid empty catch blocks | 47–48 |
| Avoid variables with short names like bb | 50 |
| Avoid variables with short names like bb | 50 |
| Found 'DD'-anomaly for variable 'bb' (lines '50'-'52'). | 50–52 |
| Avoid using if statements without curly braces | 51–52 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 23 |
| Avoid variables with short names like nt | 25 |
| Avoid variables with short names like db | 25 |
| Avoid variables with short names like db | 25 |
| Avoid variables with short names like nt | 25 |
| publicMethodCommentRequirement Required | 25–27 |
| publicMethodCommentRequirement Required | 29–62 |
| Avoid using if statements without curly braces | 31–33 |
| Found 'DD'-anomaly for variable 'rsam' (lines '35'-'51'). | 35–51 |
| Avoid variables with short names like t1 | 36 |
| Found 'DD'-anomaly for variable 't1' (lines '36'-'40'). | 36–40 |
| Avoid variables with short names like t1 | 36 |
| Avoid variables with short names like t2 | 37 |
| Avoid variables with short names like t2 | 37 |
| Found 'DD'-anomaly for variable 't2' (lines '37'-'43'). | 37–43 |
| Found 'DD'-anomaly for variable 't1' (lines '40'-'41'). | 40–41 |
| Found 'DD'-anomaly for variable 't2' (lines '43'-'44'). | 43–44 |
| Avoid variables with short names like ds | 46 |
| Avoid variables with short names like ds | 46 |
| Found 'DD'-anomaly for variable 'dst' (lines '47'-'49'). | 47–49 |
| Avoid using if statements without curly braces | 48–49 |
| Avoid using Literals in Conditional Statements | 48 |
| Avoid empty catch blocks | 52–54 |
| Avoid variables with short names like bb | 55 |
| Found 'DD'-anomaly for variable 'bb' (lines '55'-'57'). | 55–57 |
| Avoid variables with short names like bb | 55 |
| Avoid using if statements without curly braces | 56–57 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like nt | 22 |
| Avoid variables with short names like nt | 22 |
| Avoid variables with short names like db | 22 |
| publicMethodCommentRequirement Required | 22–24 |
| Avoid variables with short names like db | 22 |
| publicMethodCommentRequirement Required | 26–111 |
| Avoid variables with short names like ct | 28 |
| Avoid variables with short names like ct | 28 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 28 |
| Found 'DU'-anomaly for variable 'ct' (lines '28'-'111'). | 28–111 |
| Avoid variables with short names like ss | 31 |
| Avoid variables with short names like ss | 31 |
| Avoid using if statements without curly braces | 32–33 |
| Avoid using Literals in Conditional Statements | 32 |
| A method should have only one exit point, and that should be the last statement in the method | 33 |
| Avoid variables with short names like id | 35 |
| Avoid variables with short names like id | 35 |
| Avoid variables with short names like s | 36 |
| Avoid variables with short names like s | 36 |
| Avoid variables with short names like c | 37 |
| Avoid variables with short names like c | 37 |
| Avoid variables with short names like n | 38 |
| Avoid variables with short names like n | 38 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 39 |
| Avoid variables with short names like l | 39 |
| Avoid variables with short names like l | 39 |
| Found 'DU'-anomaly for variable 'l' (lines '39'-'111'). | 39–111 |
| Found 'DD'-anomaly for variable 't1' (lines '40'-'43'). | 40–43 |
| Avoid variables with short names like t1 | 40 |
| Avoid variables with short names like t1 | 40 |
| Found 'DD'-anomaly for variable 't2' (lines '41'-'46'). | 41–46 |
| Avoid variables with short names like t2 | 41 |
| Avoid variables with short names like t2 | 41 |
| Found 'DD'-anomaly for variable 't1' (lines '43'-'44'). | 43–44 |
| Found 'DD'-anomaly for variable 't2' (lines '46'-'47'). | 46–47 |
| Avoid empty catch blocks | 48–49 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 48 |
| Avoid using if statements without curly braces | 51–52 |
| A method should have only one exit point, and that should be the last statement in the method | 52 |
| A method should have only one exit point, and that should be the last statement in the method | 57 |
| Avoid using if statements without curly braces | 71–77 |
| There is log block not surrounded by if | 72 |
| Found 'DD'-anomaly for variable 'totalBytes' (lines '79'-'92'). | 79–92 |
| Avoid if (x != y) ..; else ..; | 80–105 |
| Avoid variables with short names like bb | 84 |
| Avoid variables with short names like bb | 84 |
| Avoid using if statements without curly braces | 94–100 |
| There is log block not surrounded by if | 95 |
| There is log block not surrounded by if | 109 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 23 |
| Avoid variables with short names like nt | 25 |
| Avoid variables with short names like db | 25 |
| publicMethodCommentRequirement Required | 25–27 |
| Avoid variables with short names like db | 25 |
| Avoid variables with short names like nt | 25 |
| publicMethodCommentRequirement Required | 29–89 |
| Avoid variables with short names like ss | 32 |
| Avoid variables with short names like ss | 32 |
| Avoid using if statements without curly braces | 33–34 |
| Avoid using Literals in Conditional Statements | 33 |
| A method should have only one exit point, and that should be the last statement in the method | 34 |
| Avoid variables with short names like id | 36 |
| Avoid variables with short names like id | 36 |
| Avoid variables with short names like s | 37 |
| Avoid variables with short names like s | 37 |
| Avoid variables with short names like c | 38 |
| Avoid variables with short names like c | 38 |
| Avoid variables with short names like n | 39 |
| Avoid variables with short names like n | 39 |
| Found 'DD'-anomaly for variable 't1' (lines '40'-'43'). | 40–43 |
| Avoid variables with short names like t1 | 40 |
| Avoid variables with short names like t1 | 40 |
| Avoid variables with short names like t2 | 41 |
| Found 'DD'-anomaly for variable 't2' (lines '41'-'46'). | 41–46 |
| Avoid variables with short names like t2 | 41 |
| Found 'DD'-anomaly for variable 't1' (lines '43'-'44'). | 43–44 |
| Found 'DD'-anomaly for variable 't2' (lines '46'-'47'). | 46–47 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 48 |
| Avoid empty catch blocks | 48–49 |
| Avoid using if statements without curly braces | 51–52 |
| A method should have only one exit point, and that should be the last statement in the method | 52 |
| A method should have only one exit point, and that should be the last statement in the method | 57 |
| Found 'DD'-anomaly for variable 'totalBytes' (lines '69'-'81'). | 69–81 |
| Avoid if (x != y) ..; else ..; | 70–85 |
| Avoid variables with short names like bb | 74 |
| Avoid variables with short names like bb | 74 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 29 |
| Avoid variables with short names like nt | 31 |
| publicMethodCommentRequirement Required | 31–33 |
| Avoid variables with short names like db | 31 |
| Avoid variables with short names like nt | 31 |
| Avoid variables with short names like db | 31 |
| publicMethodCommentRequirement Required | 35–84 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 36 |
| Avoid variables with short names like ct | 36 |
| Found 'DU'-anomaly for variable 'ct' (lines '36'-'84'). | 36–84 |
| Avoid variables with short names like ct | 36 |
| Avoid using if statements without curly braces | 39–40 |
| Found 'DD'-anomaly for variable 'et' (lines '42'-'43'). | 42–43 |
| Avoid variables with short names like et | 42 |
| Avoid variables with short names like et | 42 |
| Avoid variables with short names like st | 45 |
| Found 'DD'-anomaly for variable 'st' (lines '45'-'46'). | 45–46 |
| Avoid variables with short names like st | 45 |
| Found 'DD'-anomaly for variable 'wave' (lines '49'-'52'). | 49–52 |
| Avoid empty catch blocks | 53–54 |
| Avoid using if statements without curly braces | 59–63 |
| Avoid variables with short names like bb | 65 |
| Avoid variables with short names like bb | 65 |
| Found 'DD'-anomaly for variable 'bb' (lines '65'-'67'). | 65–67 |
| Avoid using if statements without curly braces | 66–67 |
| Avoid using if statements without curly braces | 76–80 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–211 |
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| Avoid using implementation types like 'LinkedHashMap'; use the interface instead | 48 |
| Avoid variables with short names like nt | 50 |
| Avoid variables with short names like db | 50 |
| Avoid variables with short names like db | 50 |
| Avoid variables with short names like nt | 50 |
| publicMethodCommentRequirement Required | 50–69 |
| Avoid variables with short names like ch | 51 |
| Avoid variables with short names like ch | 51 |
| protectedMethodCommentRequirement Required | 71–73 |
| publicMethodCommentRequirement Required | 75–97 |
| Avoid if (x != y) ..; else ..; | 83–94 |
| Avoid using if...else statements without curly braces | 84 |
| Avoid variables with short names like in | 86 |
| Avoid variables with short names like in | 86 |
| Found 'DU'-anomaly for variable 'mimeType' (lines '88'-'97'). | 88–97 |
| Avoid if (x != y) ..; else ..; | 90–93 |
| Avoid using if...else statements without curly braces | 91 |
| Avoid using if...else statements without curly braces | 93 |
| Avoid using if statements without curly braces | 95–96 |
| Found 'UR'-anomaly for variable 'key' (lines '99'-'104'). | 99–104 |
| Found 'DD'-anomaly for variable 'cmd' (lines '100'-'105'). | 100–105 |
| Found 'DU'-anomaly for variable 'prefixLen' (lines '102'-'111'). | 102–111 |
| Found 'DD'-anomaly for variable 'cmd' (lines '105'-'105'). | 105 |
| Found 'DU'-anomaly for variable 'prefixLen' (lines '106'-'111'). | 106–111 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 113 |
| Avoid variables with short names like in | 113 |
| publicMethodCommentRequirement Required | 113–134 |
| Avoid variables with short names like in | 113 |
| Avoid variables with short names like i | 119 |
| Avoid variables with short names like i | 119 |
| Avoid printStackTrace(); use a logger call instead. | 132 |
| Found 'UR'-anomaly for variable 'tz' (lines '136'-'149'). | 136–149 |
| Found 'UR'-anomaly for variable 'cmd' (lines '136'-'173'). | 136–173 |
| Found 'UR'-anomaly for variable 'cmd' (lines '136'-'184'). | 136–184 |
| Found 'UR'-anomaly for variable 'chan' (lines '136'-'155'). | 136–155 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 139–140 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 139–140 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 141 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 143 |
| Avoid using for statements without curly braces | 148–149 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150 |
| Avoid using for statements without curly braces | 154–155 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 156 |
| StringBuffer (or StringBuilder).append is called 8 consecutive times with literal Strings. Use a single append with a single combined String. | 158–159 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 158–159 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 160 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 161 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 163 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 164–165 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 166 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 168 |
| Found 'DD'-anomaly for variable 'i' (lines '170'-'182'). | 170–182 |
| Avoid variables with short names like i | 170 |
| Avoid variables with short names like i | 170 |
| Avoid using if statements without curly braces | 173–175 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 178 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 178 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 179 |
| Found 'DU'-anomaly for variable 'i' (lines '182'-'210'). | 182–210 |
| Avoid using if statements without curly braces | 184–185 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 187 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 192 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 192 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 194 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 195 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 195 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 196 |
| Avoid using if...else statements without curly braces | 203 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| enumCommentRequirement Required | 9–32 |
| fieldCommentRequirement Required | 14 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 17 |
| Parameter 'clazz' is not assigned and could be declared final | 19 |
| Parameter 'command' is not assigned and could be declared final | 19 |
| publicMethodCommentRequirement Required | 24–31 |
| Found 'UR'-anomaly for variable 'cmd' (lines '24'-'26'). | 24–26 |
| Parameter 'command' is not assigned and could be declared final | 24 |
| Local variable 'cmd' could be declared final | 25 |
| Avoid throwing raw exception types. | 30 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 18 |
| Avoid variables with short names like nt | 18 |
| Avoid variables with short names like db | 18 |
| publicMethodCommentRequirement Required | 18–20 |
| Avoid variables with short names like nt | 18 |
| publicMethodCommentRequirement Required | 22–40 |
| Found 'UR'-anomaly for variable 's' (lines '22'-'35'). | 22–35 |
| Found 'DD'-anomaly for variable 'scnl' (lines '24'-'26'). | 24–26 |
| Avoid using if statements without curly braces | 25–26 |
| Avoid using if statements without curly braces | 28–29 |
| Avoid variables with short names like sb | 31 |
| Avoid variables with short names like sb | 31 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 32 |
| Avoid using for statements without curly braces | 34–35 |
| There is log block not surrounded by if | 39 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| publicMethodCommentRequirement Required | 36–39 |
| Avoid variables with short names like db | 36 |
| Avoid variables with short names like nt | 36 |
| Avoid variables with short names like db | 36 |
| Avoid variables with short names like nt | 36 |
| Found 'UR'-anomaly for variable 'st' (lines '41'-'60'). | 41–60 |
| publicMethodCommentRequirement Required | 41–76 |
| Found 'DU'-anomaly for variable 'ageThreshold' (lines '44'-'76'). | 44–76 |
| Found 'DU'-anomaly for variable 'now' (lines '45'-'76'). | 45–76 |
| Avoid variables with short names like sb | 48 |
| Avoid variables with short names like sb | 48 |
| Found 'DD'-anomaly for variable 'lines' (lines '49'-'52'). | 49–52 |
| Found 'DD'-anomaly for variable 'lines' (lines '52'-'56'). | 52–56 |
| Found 'DD'-anomaly for variable 'lines' (lines '56'-'71'). | 56–71 |
| Avoid using for statements without curly braces | 59–61 |
| Avoid using if statements without curly braces | 60–61 |
| Avoid using if statements without curly braces | 63–64 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 63 |
| Found 'DD'-anomaly for variable 'd' (lines '66'-'67'). | 66–67 |
| Avoid variables with short names like d | 66 |
| Avoid variables with short names like d | 66 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 31 |
| Avoid excessively long variable names like DISPLAY_DATE_FORMAT | 32 |
| Avoid excessively long variable names like DISPLAY_DATE_FORMAT | 32 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 43 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| Avoid variables with short names like db | 73 |
| Avoid variables with short names like nt | 73 |
| Avoid variables with short names like nt | 73 |
| Avoid variables with short names like db | 73 |
| Avoid variables with short names like c | 92 |
| Avoid variables with short names like c | 92 |
| Avoid variables with short names like t1 | 138 |
| Avoid variables with short names like t1 | 138 |
| Found 'DD'-anomaly for variable 'startTime' (lines '139'-'143'). | 139–143 |
| Found 'DD'-anomaly for variable 'startTime' (lines '139'-'150'). | 139–150 |
| When instantiating a SimpleDateFormat object, specify a Locale | 145 |
| Avoid variables with short names like bt | 147 |
| Avoid variables with short names like bt | 147 |
| Found 'DD'-anomaly for variable 'startTime' (lines '150'-'152'). | 150–152 |
| protectedMethodCommentRequirement Required | 162–166 |
| Avoid variables with short names like t1 | 162 |
| Avoid variables with short names like t1 | 162 |
| Avoid variables with short names like tz | 163 |
| Avoid variables with short names like tz | 163 |
| Avoid variables with short names like t2 | 174 |
| Avoid variables with short names like t2 | 174 |
| Found 'DD'-anomaly for variable 'endTime' (lines '175'-'177'). | 175–177 |
| Found 'DD'-anomaly for variable 'endTime' (lines '175'-'184'). | 175–184 |
| Avoid using if...else statements without curly braces | 177 |
| When instantiating a SimpleDateFormat object, specify a Locale | 179 |
| Avoid variables with short names like bt | 181 |
| Avoid variables with short names like bt | 181 |
| Found 'DD'-anomaly for variable 'endTime' (lines '184'-'186'). | 184–186 |
| Avoid variables with short names like t2 | 197 |
| Avoid variables with short names like tz | 197 |
| Avoid variables with short names like t2 | 197 |
| Avoid variables with short names like tz | 197 |
| Avoid variables with short names like t | 209 |
| Avoid variables with short names like t | 209 |
| Avoid using if...else statements without curly braces | 211 |
| A method should have only one exit point, and that should be the last statement in the method | 211 |
| Avoid using if...else statements without curly braces | 213 |
| Avoid variables with short names like in | 222 |
| Avoid variables with short names like in | 222 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 222 |
| Avoid unnecessary comparisons in boolean expressions | 223 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| headerCommentRequirement Required | 5–26 |
| Avoid modifiers which are implied by the context | 11 |
| Avoid modifiers which are implied by the context | 18 |
| Avoid modifiers which are implied by the context | 25 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 31–32 |
| fieldCommentRequirement Required | 33 |
| Use explicit scoping instead of the default package private level | 33 |
| Use explicit scoping instead of the default package private level | 34 |
| fieldCommentRequirement Required | 34 |
| Use explicit scoping instead of the default package private level | 36 |
| fieldCommentRequirement Required | 36 |
| Use explicit scoping instead of the default package private level | 37 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| Use explicit scoping instead of the default package private level | 38 |
| Use explicit scoping instead of the default package private level | 39 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| Use explicit scoping instead of the default package private level | 40 |
| fieldCommentRequirement Required | 41 |
| Use explicit scoping instead of the default package private level | 41 |
| fieldCommentRequirement Required | 42 |
| Use explicit scoping instead of the default package private level | 42 |
| Field writeComputer has the same name as a method | 43 |
| fieldCommentRequirement Required | 43 |
| Field writeComputer has the same name as a method | 43 |
| Use explicit scoping instead of the default package private level | 43 |
| Use explicit scoping instead of the default package private level | 45 |
| fieldCommentRequirement Required | 45 |
| Use explicit scoping instead of the default package private level | 46 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| Use explicit scoping instead of the default package private level | 47 |
| Use explicit scoping instead of the default package private level | 49 |
| fieldCommentRequirement Required | 49 |
| Use explicit scoping instead of the default package private level | 50 |
| fieldCommentRequirement Required | 50 |
| Use explicit scoping instead of the default package private level | 51 |
| fieldCommentRequirement Required | 51 |
| Use explicit scoping instead of the default package private level | 57 |
| fieldCommentRequirement Required | 57 |
| Use explicit scoping instead of the default package private level | 58 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 60 |
| Use explicit scoping instead of the default package private level | 60 |
| Use explicit scoping instead of the default package private level | 61 |
| fieldCommentRequirement Required | 61 |
| Use explicit scoping instead of the default package private level | 62 |
| fieldCommentRequirement Required | 62 |
| Use explicit scoping instead of the default package private level | 63 |
| fieldCommentRequirement Required | 63 |
| publicMethodCommentRequirement Required | 65–67 |
| Avoid variables with short names like nt | 65 |
| Avoid variables with short names like nt | 65 |
| Avoid variables with short names like db | 65 |
| Avoid variables with short names like db | 65 |
| protectedMethodCommentRequirement Required | 70–127 |
| String.indexOf(char) is faster than String.indexOf(String). | 78 |
| Local variable 'dateF' could be declared final | 112 |
| When instantiating a SimpleDateFormat object, specify a Locale | 112 |
| Avoid using Literals in Conditional Statements | 121 |
| Use explicit scoping instead of the default package private level | 130–258 |
| Found 'UR'-anomaly for variable 'gap' (lines '130'-'208'). | 130–208 |
| StringBuffer constructor is initialized with size 16, but has at least 217 characters appended. | 132 |
| Avoid excessively long variable names like outputSettings_Analysis | 133 |
| StringBuffer constructor is initialized with size 16, but has at least 821 characters appended. | 133 |
| Avoid excessively long variable names like outputSettings_Analysis | 133 |
| StringBuffer constructor is initialized with size 16, but has at least 338 characters appended. | 135 |
| StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. | 136 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 139 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 145–147 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 145–147 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 145–147 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 145–147 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 145–147 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 148–149 |
| The String literal "</TD></TR>" appears 5 times in this file; the first occurrence is on line 149 | 149 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 149 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 149 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 149 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 149 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 151 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 151 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 151 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 151 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 151 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 152 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 152 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 152 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 152 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 152 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 153 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 153 |
| When instantiating a SimpleDateFormat object, specify a Locale | 196 |
| Local variable 'dateF' could be declared final | 196 |
| Found 'DU'-anomaly for variable 'dateF' (lines '196'-'258'). | 196–258 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 197–199 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 197–199 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 197–199 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 197–199 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 197–199 |
| Avoid using if...else statements without curly braces | 221 |
| Avoid using if...else statements without curly braces | 223 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 226 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 226 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 226 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 226 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 229–231 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 229–231 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 229–231 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 229–231 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 229–231 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 232 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 232 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 232 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 232 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 232 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 233–234 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 233–234 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 233–234 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 233–234 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 233–234 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 235–236 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 235–236 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 235–236 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 235–236 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 235–236 |
| Use explicit scoping instead of the default package private level | 261–289 |
| Found 'UR'-anomaly for variable 'gap' (lines '261'-'272'). | 261–272 |
| StringBuffer constructor is initialized with size 16, but has at least 120 characters appended. | 263 |
| StringBuffer constructor is initialized with size 16, but has at least 42 characters appended. | 264 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 283–286 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 283–286 |
| publicMethodCommentRequirement Required | 292–371 |
| StringBuffer constructor is initialized with size 16, but has at least 3663 characters appended. | 293 |
| StringBuffer (or StringBuilder).append is called 10 consecutive times with literal Strings. Use a single append with a single combined String. | 295–304 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 295–304 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 295–304 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 306 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 307–308 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 307–308 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 309–310 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 309–310 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 320–321 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 322 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 323 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 324–326 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 328 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 329 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 330 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 331 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 332 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 333 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 334–335 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 336 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 337–339 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 337–339 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 340 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 341–343 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 341–343 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 344–346 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 344–346 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 347 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 348 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 349–351 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 352–353 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 354 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 355 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 356 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 357 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 358–368 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 358–368 |
| publicMethodCommentRequirement Required | 373–375 |
| publicMethodCommentRequirement Required | 377–379 |
| publicMethodCommentRequirement Required | 382–384 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| Avoid variables with short names like nt | 40 |
| publicMethodCommentRequirement Required | 40–42 |
| Avoid variables with short names like db | 40 |
| Avoid variables with short names like nt | 40 |
| Avoid variables with short names like db | 40 |
| protectedMethodCommentRequirement Required | 45–158 |
| Avoid variables with short names like ct | 47 |
| Avoid variables with short names like ct | 47 |
| Found 'DD'-anomaly for variable 'error' (lines '49'-'54'). | 49–54 |
| Found 'DD'-anomaly for variable 'error' (lines '54'-'80'). | 54–80 |
| Found 'DD'-anomaly for variable 'error' (lines '54'-'66'). | 54–66 |
| Avoid using if...else statements without curly braces | 54 |
| Avoid using if statements without curly braces | 57–58 |
| Avoid variables with short names like tz | 61 |
| Avoid variables with short names like tz | 61 |
| Avoid using if statements without curly braces | 65–66 |
| Prefer StringBuffer over += for concatenating strings | 66 |
| Avoid using if statements without curly braces | 69–71 |
| Prefer StringBuffer over += for concatenating strings | 70 |
| Prefer StringBuffer over += for concatenating strings | 74 |
| Avoid using if...else statements without curly braces | 74 |
| Avoid using if statements without curly braces | 75–76 |
| Prefer StringBuffer over += for concatenating strings | 76 |
| Avoid using if statements without curly braces | 79–80 |
| Prefer StringBuffer over += for concatenating strings | 80 |
| Avoid using if statements without curly braces | 86–89 |
| Prefer StringBuffer over += for concatenating strings | 88 |
| Avoid using if statements without curly braces | 99–100 |
| Found 'DD'-anomaly for variable 'heliData' (lines '106'-'108'). | 106–108 |
| Avoid empty catch blocks | 110–111 |
| Avoid using if statements without curly braces | 115–122 |
| There is log block not surrounded by if | 116 |
| Avoid using if...else statements without curly braces | 125 |
| Avoid using if statements without curly braces | 130–132 |
| Avoid printStackTrace(); use a logger call instead. | 141 |
| Prefer StringBuffer over += for concatenating strings | 142 |
| Avoid using if statements without curly braces | 147–154 |
| There is log block not surrounded by if | 148 |
| publicMethodCommentRequirement Required | 160–291 |
| StringBuffer constructor is initialized with size 16, but has at least 5731 characters appended. | 161 |
| StringBuffer (or StringBuilder).append is called 16 consecutive times with literal Strings. Use a single append with a single combined String. | 163–178 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 163–178 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 163–178 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 180 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 181–182 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 181–182 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 183–184 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 183–184 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 185–186 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 185–186 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 187–188 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 187–188 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 189–190 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 189–190 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 191–192 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 191–192 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 214–215 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 216 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 217 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 218–220 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 222 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 223 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 224 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 225 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 226 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 227 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 228–229 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 230 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 231–233 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 231–233 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 234 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 235–237 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 235–237 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 238 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 239–241 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 239–241 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 242 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 243 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 244–246 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 244–246 |
| The String literal "\"></div>" appears 5 times in this file; the first occurrence is on line 246 | 246 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 247–249 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 247–249 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 250–252 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 250–252 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 253–255 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 253–255 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 256–257 |
| StringBuffer (or StringBuilder).append is called 9 consecutive times with literal Strings. Use a single append with a single combined String. | 258–260 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 258–260 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 261–262 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 263–264 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 265 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 266 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 267 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 268 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 269 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 270–288 |
| StringBuffer (or StringBuilder).append is called 6 consecutive times with literal Strings. Use a single append with a single combined String. | 270–288 |
| The String literal ").<br><br>" appears 5 times in this file; the first occurrence is on line 271 | 271 |
| Do not add empty strings | 275 |
| Do not add empty strings | 277 |
| Do not add empty strings | 279 |
| publicMethodCommentRequirement Required | 293–295 |
| publicMethodCommentRequirement Required | 297–299 |
| publicMethodCommentRequirement Required | 302–304 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_OB' is not final. | 25 |
| fieldCommentRequirement Required | 25 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_OB' is not final. | 25 |
| The field name indicates a constant but its modifiers do not | 25 |
| Variables should start with a lowercase character, 'DEFAULT_OB' starts with uppercase character. | 25 |
| The field name indicates a constant but its modifiers do not | 25 |
| Variables should start with a lowercase character, 'DEFAULT_OB' starts with uppercase character. | 25 |
| The field name indicates a constant but its modifiers do not | 26 |
| Variables should start with a lowercase character, 'DEFAULT_SO' starts with uppercase character. | 26 |
| fieldCommentRequirement Required | 26 |
| The field name indicates a constant but its modifiers do not | 26 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_SO' is not final. | 26 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_SO' is not final. | 26 |
| Variables should start with a lowercase character, 'DEFAULT_SO' starts with uppercase character. | 26 |
| Avoid variables with short names like nt | 28 |
| Avoid variables with short names like db | 28 |
| Avoid variables with short names like nt | 28 |
| publicMethodCommentRequirement Required | 28–30 |
| Avoid variables with short names like db | 28 |
| Found 'UR'-anomaly for variable 's' (lines '33'-'74'). | 33–74 |
| Found 'UR'-anomaly for variable 'line' (lines '33'-'80'). | 33–80 |
| protectedMethodCommentRequirement Required | 33–105 |
| A method should have only one exit point, and that should be the last statement in the method | 38 |
| Avoid variables with short names like o | 41 |
| Avoid variables with short names like o | 41 |
| Avoid variables with short names like tz | 48 |
| Avoid variables with short names like tz | 48 |
| Found 'DU'-anomaly for variable 'timeZone' (lines '49'-'105'). | 49–105 |
| Prefer StringBuffer over += for concatenating strings | 53 |
| Avoid using Literals in Conditional Statements | 57 |
| Avoid using if statements without curly braces | 57–58 |
| Found 'DU'-anomaly for variable 'colOrd' (lines '58'-'105'). | 58–105 |
| StringBuffer constructor is initialized with size 16, but has at least 181 characters appended. | 60 |
| Avoid using for statements without curly braces | 63–65 |
| Found 'DD'-anomaly for variable 'menu' (lines '71'-'74'). | 71–74 |
| Found 'DU'-anomaly for variable 'i' (lines '72'-'105'). | 72–105 |
| Avoid variables with short names like i | 72 |
| Avoid variables with short names like i | 72 |
| Avoid using for statements without curly braces | 73–74 |
| Found 'DD'-anomaly for variable 'menu' (lines '74'-'74'). | 74 |
| Avoid using Literals in Conditional Statements | 80 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 81 |
| Avoid instantiating new objects inside loops | 85 |
| Local variable 'dateF' could be declared final | 85 |
| When instantiating a SimpleDateFormat object, specify a Locale | 85 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 91 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 92 |
| The String literal "</td>" appears 8 times in this file; the first occurrence is on line 92 | 92 |
| The String literal "<td>" appears 8 times in this file; the first occurrence is on line 92 | 92 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 93 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 94 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 95 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 96 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 97 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 98 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 99 |
| Avoid variables with short names like e2 | 109 |
| publicMethodCommentRequirement Required | 109–135 |
| Avoid variables with short names like e1 | 109 |
| Avoid variables with short names like e1 | 109 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 109 |
| Avoid variables with short names like e2 | 109 |
| Avoid variables with short names like d1 | 112 |
| Avoid variables with short names like d1 | 112 |
| Avoid variables with short names like d2 | 113 |
| Avoid variables with short names like d2 | 113 |
| Avoid variables with short names like d | 117 |
| Avoid variables with short names like d | 117 |
| Avoid using if statements without curly braces | 118–119 |
| Avoid variables with short names like i | 121 |
| Avoid variables with short names like i | 121 |
| Avoid using Literals in Conditional Statements | 123 |
| Avoid using if...else statements without curly braces | 124 |
| Avoid using if...else statements without curly braces | 126 |
| Avoid using Literals in Conditional Statements | 130 |
| Avoid using if...else statements without curly braces | 131 |
| Avoid using if...else statements without curly braces | 133 |
| publicMethodCommentRequirement Required | 139–211 |
| Found 'DU'-anomaly for variable 'Url' (lines '140'-'211'). | 140–211 |
| Avoid unused local variables such as 'Url'. | 140 |
| The String literal "Host" appears 6 times in this file; the first occurrence is on line 140 | 140 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 140 |
| StringBuffer constructor is initialized with size 16, but has at least 2686 characters appended. | 142 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 144–150 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 144–150 |
| StringBuffer (or StringBuilder).append is called 7 consecutive times with literal Strings. Use a single append with a single combined String. | 144–150 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 152–153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 152–153 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 154–155 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 154–155 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 156–157 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 158 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 159 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 160–163 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 165–166 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 167 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 168 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 169 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 170 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 171 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 172–174 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 175 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 176–177 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 178–183 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 184–185 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 186–188 |
| StringBuffer (or StringBuilder).append is called 7 consecutive times with literal Strings. Use a single append with a single combined String. | 186–188 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 190 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 191 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 192 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 193 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 194 |
| StringBuffer (or StringBuilder).append is called 5 consecutive times with literal Strings. Use a single append with a single combined String. | 195–200 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 195–200 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 201 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 203 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204–206 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 204–206 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 207–208 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 207–208 |
| publicMethodCommentRequirement Required | 213–215 |
| publicMethodCommentRequirement Required | 217–219 |
| publicMethodCommentRequirement Required | 222–224 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 51 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 53 |
| fieldCommentRequirement Required | 54 |
| Avoid excessively long variable names like runningMedianPeriod | 55 |
| Avoid excessively long variable names like runningMedianPeriod | 55 |
| fieldCommentRequirement Required | 55 |
| fieldCommentRequirement Required | 56 |
| fieldCommentRequirement Required | 57 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 59 |
| fieldCommentRequirement Required | 60 |
| fieldCommentRequirement Required | 61 |
| Avoid variables with short names like db | 63 |
| Avoid variables with short names like db | 63 |
| publicMethodCommentRequirement Required | 63–65 |
| Avoid variables with short names like nt | 63 |
| Avoid variables with short names like nt | 63 |
| Avoid using if...else statements without curly braces | 70 |
| String.indexOf(char) is faster than String.indexOf(String). | 73 |
| Avoid using if statements without curly braces | 73–74 |
| Avoid using if statements without curly braces | 80–82 |
| Avoid using if statements without curly braces | 85–87 |
| Avoid using if statements without curly braces | 94–96 |
| Assigning an Object to null is a code smell. Consider refactoring. | 117 |
| Avoid using Literals in Conditional Statements | 122 |
| Avoid using if statements without curly braces | 132–133 |
| Avoid using if statements without curly braces | 135–136 |
| Avoid using if statements without curly braces | 138–139 |
| Avoid using if statements without curly braces | 145–146 |
| Avoid using if statements without curly braces | 152–153 |
| Avoid variables with short names like mr | 161 |
| Avoid variables with short names like mr | 161 |
| Avoid printStackTrace(); use a logger call instead. | 188 |
| protectedMethodCommentRequirement Required | 206–218 |
| Avoid using if...else statements without curly braces | 214 |
| Avoid using if...else statements without curly braces | 216 |
| publicMethodCommentRequirement Required | 220–386 |
| StringBuffer constructor is initialized with size 16, but has at least 6770 characters appended. | 221 |
| StringBuffer (or StringBuilder).append is called 20 consecutive times with literal Strings. Use a single append with a single combined String. | 223–242 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 223–242 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 223–242 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 244 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 245–246 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 245–246 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 247–248 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 247–248 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 249–250 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 249–250 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 251–252 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 251–252 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 253–254 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 253–254 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 255–256 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 255–256 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 295–296 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 297 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 298 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 299–303 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 305 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 306 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 307 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 308 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 309 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 310 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 311–312 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 313 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 314–316 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 314–316 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 317 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 318–320 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 318–320 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 321–323 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 321–323 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 324 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 325 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 326–328 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 326–328 |
| The String literal "\"></div>" appears 6 times in this file; the first occurrence is on line 328 | 328 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 329–331 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 329–331 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 332–334 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 332–334 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 335–337 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 335–337 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 338–340 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 338–340 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 341–342 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 343–344 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 345–347 |
| StringBuffer (or StringBuilder).append is called 11 consecutive times with literal Strings. Use a single append with a single combined String. | 345–347 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 348–349 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 350–351 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 352–353 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 354 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 356 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 357 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 358 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 359 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 360–383 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 360–383 |
| The String literal ").<br><br>" appears 8 times in this file; the first occurrence is on line 363 | 363 |
| Do not add empty strings | 365 |
| Do not add empty strings | 367 |
| Do not add empty strings | 369 |
| Do not add empty strings | 379 |
| Do not add empty strings | 382 |
| publicMethodCommentRequirement Required | 388–390 |
| publicMethodCommentRequirement Required | 392–394 |
| publicMethodCommentRequirement Required | 397–399 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 25 |
| Avoid variables with short names like nt | 27 |
| Avoid variables with short names like db | 27 |
| Avoid variables with short names like db | 27 |
| publicMethodCommentRequirement Required | 27–29 |
| Avoid variables with short names like nt | 27 |
| Found 'UR'-anomaly for variable 'chan1' (lines '32'-'177'). | 32–177 |
| protectedMethodCommentRequirement Required | 32–195 |
| Found 'UR'-anomaly for variable 's' (lines '32'-'89'). | 32–89 |
| Found 'DD'-anomaly for variable 'i' (lines '42'-'38'). | 42–38 |
| Avoid using Literals in Conditional Statements | 59 |
| Avoid using if...else statements without curly braces | 60 |
| Avoid using if...else statements without curly braces | 62 |
| Avoid using if...else statements without curly braces | 64 |
| Avoid using if...else statements without curly braces | 66 |
| Avoid using if...else statements without curly braces | 68 |
| Avoid using if...else statements without curly braces | 70 |
| StringBuffer constructor is initialized with size 16, but has at least 2772 characters appended. | 73 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 74–83 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 74–83 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 85 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 86 |
| Avoid using for statements without curly braces | 88–89 |
| The String literal "\"," appears 6 times in this file; the first occurrence is on line 89 | 89 |
| The String literal "\"\");" appears 6 times in this file; the first occurrence is on line 90 | 90 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 90 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 90 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 92 |
| Avoid using for statements without curly braces | 94–95 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 96 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 96 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 98 |
| Avoid using for statements without curly braces | 100–101 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 102 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 102 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 104 |
| Avoid using for statements without curly braces | 106–107 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 108 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 108 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 110 |
| Avoid using for statements without curly braces | 112–113 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 114 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 114 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 116 |
| Avoid using for statements without curly braces | 118–119 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 120 |
| StringBuffer (or StringBuilder).append is called 5 consecutive times with literal Strings. Use a single append with a single combined String. | 120 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 125 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 126–127 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 128–129 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 128–129 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 130–131 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 130–131 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 132–133 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 135–136 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 140–143 |
| The String literal " channels</A> (" appears 6 times in this file; the first occurrence is on line 142 | 142 |
| The String literal "%)</TD></TR>" appears 6 times in this file; the first occurrence is on line 143 | 143 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 145–148 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 150–153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 155–158 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 160–163 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 165–168 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 165–168 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 169 |
| Avoid variables with short names like i | 175 |
| Avoid variables with short names like i | 175 |
| Found 'DU'-anomaly for variable 'i' (lines '175'-'195'). | 175–195 |
| Avoid variables with short names like a | 177 |
| Avoid variables with short names like a | 177 |
| Avoid variables with short names like bg | 179 |
| Avoid variables with short names like bg | 179 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 186 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 186 |
| publicMethodCommentRequirement Required | 197–215 |
| StringBuffer constructor is initialized with size 16, but has at least 355 characters appended. | 200 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202–203 |
| StringBuffer (or StringBuilder).append is called 4 consecutive times with literal Strings. Use a single append with a single combined String. | 202–203 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 205 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 206–207 |
| StringBuffer (or StringBuilder).append is called 6 consecutive times with literal Strings. Use a single append with a single combined String. | 206–207 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 208 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 209 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 210 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 211 |
| publicMethodCommentRequirement Required | 217–219 |
| publicMethodCommentRequirement Required | 221–223 |
| publicMethodCommentRequirement Required | 226–228 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 16 |
| publicMethodCommentRequirement Required | 18–20 |
| publicMethodCommentRequirement Required | 23–36 |
| Avoid reassigning parameters such as 'source' | 23 |
| Avoid reassigning parameters such as 'source' | 23 |
| Avoid reassigning parameters such as 'source' | 23 |
| Avoid using if statements without curly braces | 25–26 |
| Avoid variables with short names like t | 28 |
| Avoid variables with short names like t | 28 |
| Avoid using if statements without curly braces | 29–30 |
| Avoid using if statements without curly braces | 32–33 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 19–68 |
| Abstract classes should be named AbstractXXX | 19–68 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 23 |
| Avoid variables with short names like db | 25 |
| Avoid variables with short names like nt | 25 |
| Avoid variables with short names like nt | 25 |
| Avoid variables with short names like db | 25 |
| publicMethodCommentRequirement Required | 25–28 |
| Avoid variables with short names like c | 39 |
| Avoid variables with short names like c | 39 |
| protectedMethodCommentRequirement Required | 47–66 |
| Avoid variables with short names like sb | 48 |
| StringBuffer constructor is initialized with size 16, but has at least 132 characters appended. | 48 |
| Avoid variables with short names like sb | 48 |
| The String literal "\n\n" appears 5 times in this file; the first occurrence is on line 49 | 49 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 49 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 50 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 50 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 50 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 51–52 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 51–52 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 53 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 54–55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 54–55 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 56 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 57 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 57 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 57 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 58 |
| Do not add empty strings | 62 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 28–249 |
| Abstract classes should be named AbstractXXX | 28–249 |
| fieldCommentRequirement Required | 29 |
| Avoid excessively long variable names like DUMMY_CHANNEL_ARRAY | 29 |
| Avoid excessively long variable names like DUMMY_CHANNEL_ARRAY | 29 |
| Avoid excessively long variable names like channelConstraints | 31 |
| Avoid excessively long variable names like channelConstraints | 31 |
| fieldCommentRequirement Required | 31 |
| Avoid excessively long variable names like geographicConstraint | 32 |
| Avoid excessively long variable names like geographicConstraint | 32 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| protectedMethodCommentRequirement Required | 38–41 |
| Avoid variables with short names like db | 38 |
| Avoid variables with short names like nt | 38 |
| Avoid variables with short names like db | 38 |
| Avoid variables with short names like nt | 38 |
| Avoid variables with short names like c | 52 |
| Avoid variables with short names like c | 52 |
| Avoid using if...else statements without curly braces | 83 |
| Avoid using if...else statements without curly braces | 85 |
| protectedMethodCommentRequirement Required | 88–92 |
| Found 'UR'-anomaly for variable 'sta' (lines '95'-'111'). | 95–111 |
| Found 'UR'-anomaly for variable 'cha' (lines '95'-'111'). | 95–111 |
| Found 'UR'-anomaly for variable 'loc' (lines '95'-'107'). | 95–107 |
| Found 'UR'-anomaly for variable 'net' (lines '95'-'111'). | 95–111 |
| Avoid using if statements without curly braces | 107–108 |
| Position literals first in String comparisons | 107 |
| Avoid instantiating new objects inside loops | 111 |
| System.out.println is used | 113 |
| Avoid if (x != y) ..; else ..; | 128–139 |
| System.out.println is used | 141 |
| Avoid if (x != y) ..; else ..; | 150–157 |
| System.out.println is used | 159 |
| Avoid variables with short names like s2 | 163 |
| Avoid variables with short names like s1 | 163 |
| Avoid variables with short names like s2 | 163 |
| Avoid variables with short names like s1 | 163 |
| Avoid using if statements without curly braces | 165–166 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid reassigning parameters such as 'arg' | 171 |
| protectedMethodCommentRequirement Required | 171–187 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid reassigning parameters such as 'arg' | 171 |
| Avoid using if statements without curly braces | 172–173 |
| A method should have only one exit point, and that should be the last statement in the method | 173 |
| protectedMethodCommentRequirement Required | 189–219 |
| Found 'UR'-anomaly for variable 'line' (lines '189'-'196'). | 189–196 |
| Found 'DD'-anomaly for variable 'index' (lines '193'-'195'). | 193–195 |
| Found 'DD'-anomaly for variable 'index' (lines '195'-'195'). | 195 |
| Avoid using if statements without curly braces | 196–197 |
| Avoid variables with short names like s | 201 |
| Avoid variables with short names like s | 201 |
| Avoid using Literals in Conditional Statements | 202 |
| Found 'DU'-anomaly for variable 's' (lines '205'-'219'). | 205–219 |
| Avoid using Literals in Conditional Statements | 206 |
| Avoid if (x != y) ..; else ..; | 206–216 |
| Avoid using if statements without curly braces | 209–210 |
| Avoid variables with short names like c | 212 |
| Avoid variables with short names like c | 212 |
| Avoid instantiating new objects inside loops | 213 |
| Avoid instantiating new objects inside loops | 215 |
| protectedMethodCommentRequirement Required | 221–229 |
| Found 'UR'-anomaly for variable 'c' (lines '221'-'225'). | 221–225 |
| Avoid using for statements without curly braces | 224–226 |
| Avoid using if statements without curly braces | 225–226 |
| Found 'UR'-anomaly for variable 'cons' (lines '231'-'234'). | 231–234 |
| Avoid variables with short names like c | 231 |
| Avoid variables with short names like c | 231 |
| Found 'DD'-anomaly for variable 'matches' (lines '232'-'235'). | 232–235 |
| Avoid using if statements without curly braces | 240–241 |
| Avoid using if statements without curly braces | 243–244 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 30–88 |
| Abstract classes should be named AbstractXXX | 30–88 |
| fieldCommentRequirement Required | 31 |
| Avoid excessively long variable names like UrlBuillderTemplate | 33 |
| fieldCommentRequirement Required | 33 |
| Variables should start with a lowercase character, 'UrlBuillderTemplate' starts with uppercase character. | 33 |
| Variables should start with a lowercase character, 'UrlBuillderTemplate' starts with uppercase character. | 33 |
| Avoid excessively long variable names like UrlBuillderTemplate | 33 |
| Variables should start with a lowercase character, 'InterfaceDescriptionTemplate' starts with uppercase character. | 34 |
| Variables should start with a lowercase character, 'InterfaceDescriptionTemplate' starts with uppercase character. | 34 |
| Avoid excessively long variable names like InterfaceDescriptionTemplate | 34 |
| fieldCommentRequirement Required | 34 |
| Avoid excessively long variable names like InterfaceDescriptionTemplate | 34 |
| fieldCommentRequirement Required | 36 |
| Avoid variables with short names like db | 38 |
| publicMethodCommentRequirement Required | 38–41 |
| Avoid variables with short names like nt | 38 |
| Avoid variables with short names like nt | 38 |
| Avoid variables with short names like db | 38 |
| Local variable 'obj' could be declared final | 51 |
| protectedMethodCommentRequirement Required | 61–87 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 63 |
| Local variable 'root' could be declared final | 63 |
| Local variable 'template' could be declared final | 70 |
| Avoid variables with short names like sw | 71 |
| Local variable 'sw' could be declared final | 71 |
| Avoid variables with short names like sw | 71 |
| Local variable 'html' could be declared final | 73 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 13–26 |
| Abstract classes should be named AbstractXXX | 13–26 |
| protectedMethodCommentRequirement Required | 15–17 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| protectedMethodCommentRequirement Required | 20–25 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 20–81 |
| Abstract classes should be named AbstractXXX | 20–81 |
| fieldCommentRequirement Required | 22 |
| Avoid variables with short names like nt | 24 |
| Avoid variables with short names like db | 24 |
| publicMethodCommentRequirement Required | 24–26 |
| Avoid variables with short names like nt | 24 |
| Avoid variables with short names like db | 24 |
| protectedMethodCommentRequirement Required | 29–56 |
| Avoid variables with short names like in | 32 |
| Avoid variables with short names like in | 32 |
| Avoid excessively long variable names like inputStringBuilder | 33 |
| Avoid excessively long variable names like inputStringBuilder | 33 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 39 |
| Avoid printStackTrace(); use a logger call instead. | 44 |
| Avoid empty catch blocks | 45–47 |
| Found 'DD'-anomaly for variable 'xml' (lines '49'-'50'). | 49–50 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 13 |
| fieldCommentRequirement Required | 14 |
| fieldCommentRequirement Required | 15 |
| fieldCommentRequirement Required | 16 |
| publicMethodCommentRequirement Required | 24–36 |
| System.out.println is used | 33 |
| Avoid using if...else statements without curly braces | 33 |
| Avoid using if statements without curly braces | 34–35 |
| System.out.println is used | 35 |
| publicMethodCommentRequirement Required | 38–40 |
| Avoid variables with short names like c | 38 |
| Avoid variables with short names like c | 38 |
| Avoid variables with short names like in | 42 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 42 |
| Avoid variables with short names like in | 42 |
| Avoid using if statements without curly braces | 43–44 |
| A method should have only one exit point, and that should be the last statement in the method | 44 |
| Avoid using if statements without curly braces | 45–46 |
| A method should have only one exit point, and that should be the last statement in the method | 46 |
| Avoid using if statements without curly braces | 47–48 |
| A method should have only one exit point, and that should be the last statement in the method | 48 |
| publicMethodCommentRequirement Required | 53–78 |
| Avoid using if statements without curly braces | 55–56 |
| A method should have only one exit point, and that should be the last statement in the method | 56 |
| Avoid using if statements without curly braces | 59–60 |
| A method should have only one exit point, and that should be the last statement in the method | 60 |
| Avoid using if statements without curly braces | 63–64 |
| A method should have only one exit point, and that should be the last statement in the method | 64 |
| Avoid using if statements without curly braces | 67–68 |
| A method should have only one exit point, and that should be the last statement in the method | 68 |
| Avoid using if statements without curly braces | 71–72 |
| A method should have only one exit point, and that should be the last statement in the method | 72 |
| Avoid using if statements without curly braces | 74–75 |
| A method should have only one exit point, and that should be the last statement in the method | 75 |
| publicMethodCommentRequirement Required | 80–105 |
| Avoid using if statements without curly braces | 82–83 |
| A method should have only one exit point, and that should be the last statement in the method | 83 |
| Avoid using if statements without curly braces | 86–87 |
| A method should have only one exit point, and that should be the last statement in the method | 87 |
| Avoid using if statements without curly braces | 90–91 |
| A method should have only one exit point, and that should be the last statement in the method | 91 |
| Avoid using if statements without curly braces | 94–95 |
| A method should have only one exit point, and that should be the last statement in the method | 95 |
| Avoid using if statements without curly braces | 98–99 |
| A method should have only one exit point, and that should be the last statement in the method | 99 |
| Avoid using if statements without curly braces | 101–102 |
| A method should have only one exit point, and that should be the last statement in the method | 102 |
| publicMethodCommentRequirement Required | 107–109 |
| publicMethodCommentRequirement Required | 112–114 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| publicMethodCommentRequirement Required | 14 |
| Avoid modifiers which are implied by the context | 14 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LATITUDE' is not final. | 17 |
| The field name indicates a constant but its modifiers do not | 17 |
| Variables should start with a lowercase character, 'DEFAULT_LATITUDE' starts with uppercase character. | 17 |
| The field name indicates a constant but its modifiers do not | 17 |
| fieldCommentRequirement Required | 17 |
| Avoid using redundant field initializer for 'DEFAULT_LATITUDE' | 17 |
| Variables should start with a lowercase character, 'DEFAULT_LATITUDE' starts with uppercase character. | 17 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LATITUDE' is not final. | 17 |
| Variables should start with a lowercase character, 'DEFAULT_LONGITUDE' starts with uppercase character. | 18 |
| Variables should start with a lowercase character, 'DEFAULT_LONGITUDE' starts with uppercase character. | 18 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LONGITUDE' is not final. | 18 |
| fieldCommentRequirement Required | 18 |
| The field name indicates a constant but its modifiers do not | 18 |
| The field name indicates a constant but its modifiers do not | 18 |
| Avoid using redundant field initializer for 'DEFAULT_LONGITUDE' | 18 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LONGITUDE' is not final. | 18 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MINRADIUS' is not final. | 19 |
| The field name indicates a constant but its modifiers do not | 19 |
| fieldCommentRequirement Required | 19 |
| Variables should start with a lowercase character, 'DEFAULT_MINRADIUS' starts with uppercase character. | 19 |
| Variables should start with a lowercase character, 'DEFAULT_MINRADIUS' starts with uppercase character. | 19 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MINRADIUS' is not final. | 19 |
| Avoid using redundant field initializer for 'DEFAULT_MINRADIUS' | 19 |
| The field name indicates a constant but its modifiers do not | 19 |
| Variables should start with a lowercase character, 'DEFAULT_MAXRADIUS' starts with uppercase character. | 20 |
| The field name indicates a constant but its modifiers do not | 20 |
| fieldCommentRequirement Required | 20 |
| The field name indicates a constant but its modifiers do not | 20 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MAXRADIUS' is not final. | 20 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MAXRADIUS' is not final. | 20 |
| Variables should start with a lowercase character, 'DEFAULT_MAXRADIUS' starts with uppercase character. | 20 |
| Use explicit scoping instead of the default package private level | 22 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| Use explicit scoping instead of the default package private level | 23 |
| Use explicit scoping instead of the default package private level | 24 |
| fieldCommentRequirement Required | 24 |
| publicMethodCommentRequirement Required | 26–35 |
| publicMethodCommentRequirement Required | 37–50 |
| Avoid variables with short names like i | 38 |
| Avoid variables with short names like i | 38 |
| A method should have only one exit point, and that should be the last statement in the method | 43 |
| Avoid variables with short names like p | 46 |
| Avoid variables with short names like p | 46 |
| Useless parentheses. | 49 |
| publicMethodCommentRequirement Required | 53–56 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 15 |
| Avoid excessively long variable names like DEFAULT_MINLATITUDE | 15 |
| Avoid excessively long variable names like DEFAULT_MINLATITUDE | 15 |
| fieldCommentRequirement Required | 16 |
| Avoid excessively long variable names like DEFAULT_MAXLATITUDE | 16 |
| Avoid excessively long variable names like DEFAULT_MAXLATITUDE | 16 |
| Avoid excessively long variable names like DEFAULT_MINLONGITUDE | 17 |
| Avoid excessively long variable names like DEFAULT_MINLONGITUDE | 17 |
| fieldCommentRequirement Required | 17 |
| Avoid excessively long variable names like DEFAULT_MAXLONGITUDE | 18 |
| fieldCommentRequirement Required | 18 |
| Avoid excessively long variable names like DEFAULT_MAXLONGITUDE | 18 |
| fieldCommentRequirement Required | 20 |
| fieldCommentRequirement Required | 21 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| publicMethodCommentRequirement Required | 25–33 |
| publicMethodCommentRequirement Required | 35–51 |
| Avoid variables with short names like i | 36 |
| Avoid variables with short names like i | 36 |
| Avoid using if statements without curly braces | 38–39 |
| A method should have only one exit point, and that should be the last statement in the method | 39 |
| Avoid using if statements without curly braces | 41–42 |
| A method should have only one exit point, and that should be the last statement in the method | 42 |
| Avoid using if statements without curly braces | 44–45 |
| A method should have only one exit point, and that should be the last statement in the method | 45 |
| Avoid unnecessary if..then..else statements when returning booleans | 47–48 |
| Avoid using if statements without curly braces | 47–48 |
| A method should have only one exit point, and that should be the last statement in the method | 48 |
| publicMethodCommentRequirement Required | 54–57 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Abstract classes should be named AbstractXXX | 14–41 |
| Abstract classes should be named AbstractXXX | 14–41 |
| fieldCommentRequirement Required | 15 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 18 |
| Private field 'fdsnDate' could be made final; it is only initialized in the declaration or constructor. | 18 |
| protectedMethodCommentRequirement Required | 20–22 |
| Avoid variables with short names like s1 | 24 |
| protectedMethodCommentRequirement Required | 24–40 |
| Avoid variables with short names like s2 | 24 |
| Avoid variables with short names like s2 | 24 |
| Avoid variables with short names like s1 | 24 |
| Avoid variables with short names like s | 25 |
| Avoid variables with short names like s | 25 |
| Avoid using if statements without curly braces | 27–28 |
| Prefer StringBuffer over += for concatenating strings | 28 |
| Prefer StringBuffer over += for concatenating strings | 32 |
| Avoid using if...else statements without curly braces | 32 |
| Avoid using if...else statements without curly braces | 34 |
| Avoid using if...else statements without curly braces | 36–37 |
| Avoid using while statements without curly braces | 36–37 |
| Prefer StringBuffer over += for concatenating strings | 37 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 18 |
| publicMethodCommentRequirement Required | 20–29 |
| New exception is thrown in catch block, original stack trace may be lost | 27 |
| publicMethodCommentRequirement Required | 31–43 |
| A method should have only one exit point, and that should be the last statement in the method | 34 |
| Avoid unnecessary if..then..else statements when returning booleans | 38–40 |
| A method should have only one exit point, and that should be the last statement in the method | 39 |
| publicMethodCommentRequirement Required | 45–57 |
| A method should have only one exit point, and that should be the last statement in the method | 48 |
| Avoid unnecessary if..then..else statements when returning booleans | 52–54 |
| A method should have only one exit point, and that should be the last statement in the method | 53 |
| publicMethodCommentRequirement Required | 60–63 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 16 |
| Use explicit scoping instead of the default package private level | 16 |
| fieldCommentRequirement Required | 17 |
| Use explicit scoping instead of the default package private level | 17 |
| Use explicit scoping instead of the default package private level | 18 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 19 |
| Use explicit scoping instead of the default package private level | 19 |
| publicMethodCommentRequirement Required | 21–33 |
| New exception is thrown in catch block, original stack trace may be lost | 30 |
| publicMethodCommentRequirement Required | 35–45 |
| Avoid using if statements without curly braces | 37–38 |
| A method should have only one exit point, and that should be the last statement in the method | 38 |
| Avoid unnecessary if..then..else statements when returning booleans | 41–42 |
| Avoid using if statements without curly braces | 41–42 |
| A method should have only one exit point, and that should be the last statement in the method | 42 |
| publicMethodCommentRequirement Required | 48–52 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 42 |
| Avoid variables with short names like db | 42 |
| Avoid variables with short names like nt | 42 |
| Avoid variables with short names like nt | 42 |
| publicMethodCommentRequirement Required | 42–45 |
| publicMethodCommentRequirement Required | 48–50 |
| protectedMethodCommentRequirement Required | 53–76 |
| Found 'UR'-anomaly for variable 'c' (lines '53'-'62'). | 53–62 |
| Found 'DD'-anomaly for variable 'outputStream' (lines '58'-'60'). | 58–60 |
| Avoid using if statements without curly braces | 70–71 |
| Avoid empty catch blocks | 72–74 |
| Found 'UR'-anomaly for variable 'c' (lines '78'-'92'). | 78–92 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 81 |
| Found 'DU'-anomaly for variable 'dos' (lines '81'-'160'). | 81–160 |
| Avoid unused local variables such as 'minLength'. | 82 |
| Found 'DD'-anomaly for variable 'minLength' (lines '84'-'86'). | 84–86 |
| Found 'DU'-anomaly for variable 'minLength' (lines '86'-'160'). | 86–160 |
| Found 'DD'-anomaly for variable 'channelConstraint' (lines '90'-'92'). | 90–92 |
| Found 'DD'-anomaly for variable 'channelConstraint' (lines '92'-'92'). | 92 |
| Avoid using if statements without curly braces | 93–94 |
| Avoid using if statements without curly braces | 96–97 |
| A method should have only one exit point, and that should be the last statement in the method | 97 |
| Avoid using if statements without curly braces | 100–101 |
| Found 'DU'-anomaly for variable 'bufs' (lines '104'-'160'). | 104–160 |
| Found 'DU'-anomaly for variable 'seq' (lines '105'-'160'). | 105–160 |
| Avoid printStackTrace(); use a logger call instead. | 112 |
| Avoid unused local variables such as 'previousEnd'. | 115 |
| Avoid using final local variables, turn them into fields | 115 |
| Avoid variables with short names like it | 116 |
| Avoid variables with short names like it | 116 |
| Avoid variables with short names like tb | 119 |
| Avoid variables with short names like tb | 119 |
| Avoid instantiating new objects inside loops | 120 |
| Do not use the short type | 126 |
| Avoid instantiating new objects inside loops | 128 |
| Avoid instantiating new objects inside loops | 131 |
| Avoid instantiating new objects inside loops | 133 |
| Found 'DD'-anomaly for variable 'data' (lines '142'-'144'). | 142–144 |
| Avoid printStackTrace(); use a logger call instead. | 149 |
| Avoid printStackTrace(); use a logger call instead. | 151 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| An Interface should be used only to model a behaviour; consider converting this to a class. | 8–11 |
| Avoid modifiers which are implied by the context | 10 |
| fieldCommentRequirement Required | 10 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 15–19 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 22–24 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| publicMethodCommentRequirement Required | 15–18 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 21–23 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 15–18 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 21–23 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 15–18 |
| publicMethodCommentRequirement Required | 21–23 |
| publicMethodCommentRequirement Required | 26–28 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| An Interface should be used only to model a behaviour; consider converting this to a class. | 8–11 |
| Avoid modifiers which are implied by the context | 10 |
| fieldCommentRequirement Required | 10 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| protectedMethodCommentRequirement Required | 15–18 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 21–23 |
| publicMethodCommentRequirement Required | 26–28 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 15–19 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 22–24 |
| publicMethodCommentRequirement Required | 27–29 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| fieldCommentRequirement Required | 36 |
| Avoid variables with short names like nt | 38 |
| publicMethodCommentRequirement Required | 38–42 |
| Avoid variables with short names like nt | 38 |
| Avoid variables with short names like db | 38 |
| Avoid variables with short names like db | 38 |
| protectedMethodCommentRequirement Required | 46–57 |
| Avoid using if statements without curly braces | 47–48 |
| The String literal "level" appears 4 times in this file; the first occurrence is on line 47 | 47 |
| Avoid using if...else statements without curly braces | 51 |
| Avoid using if...else statements without curly braces | 53 |
| Avoid using if statements without curly braces | 60–61 |
| The String literal "no data" appears 5 times in this file; the first occurrence is on line 61 | 61 |
| Found 'DU'-anomaly for variable 'responseText' (lines '63'-'79'). | 63–79 |
| Found 'DD'-anomaly for variable 'responseText' (lines '63'-'71'). | 63–71 |
| Found 'DD'-anomaly for variable 'responseText' (lines '63'-'69'). | 63–69 |
| Found 'DD'-anomaly for variable 'responseText' (lines '63'-'67'). | 63–67 |
| Avoid using if...else statements without curly braces | 67 |
| Avoid using if...else statements without curly braces | 69 |
| Avoid using if...else statements without curly braces | 71 |
| Avoid using if...else statements without curly braces | 73 |
| Found 'UR'-anomaly for variable 'c' (lines '81'-'94'). | 81–94 |
| Found 'UR'-anomaly for variable 'c' (lines '81'-'92'). | 81–92 |
| StringBuffer constructor is initialized with size 16, but has at least 91 characters appended. | 82 |
| Found 'DD'-anomaly for variable 'stationStart' (lines '84'-'103'). | 84–103 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '85'-'104'). | 85–104 |
| Found 'DD'-anomaly for variable 'stationCount' (lines '87'-'102'). | 87–102 |
| Avoid using if statements without curly braces | 91–92 |
| Avoid if (x != y) ..; else ..; | 94–105 |
| The String literal " | " appears 4 times in this file; the first occurrence is on line 96 | 96 |
| Found 'DD'-anomaly for variable 'stationStart' (lines '98'-'103'). | 98–103 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '99'-'104'). | 99–104 |
| Found 'DD'-anomaly for variable 'stationCount' (lines '100'-'102'). | 100–102 |
| Found 'DD'-anomaly for variable 'stationCount' (lines '102'-'102'). | 102 |
| Found 'UR'-anomaly for variable 'c' (lines '116'-'127'). | 116–127 |
| Found 'UR'-anomaly for variable 'c' (lines '116'-'129'). | 116–129 |
| StringBuffer constructor is initialized with size 16, but has at least 106 characters appended. | 117 |
| Found 'DD'-anomaly for variable 'stationStart' (lines '120'-'138'). | 120–138 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '121'-'139'). | 121–139 |
| Avoid using if statements without curly braces | 126–127 |
| Avoid if (x != y) ..; else ..; | 129–140 |
| Found 'DD'-anomaly for variable 'stationStart' (lines '135'-'138'). | 135–138 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '136'-'139'). | 136–139 |
| Found 'DU'-anomaly for variable 'stationStart' (lines '152'-'156'). | 152–156 |
| Found 'DU'-anomaly for variable 'stationEnd' (lines '153'-'156'). | 153–156 |
| Found 'UR'-anomaly for variable 'c' (lines '158'-'164'). | 158–164 |
| StringBuffer constructor is initialized with size 16, but has at least 200 characters appended. | 159 |
| Position literals first in String comparisons | 164 |
| Avoid using if statements without curly braces | 176–177 |
| Found 'DD'-anomaly for variable 'dBuilder' (lines '180'-'182'). | 180–182 |
| Found 'DU'-anomaly for variable 'dBuilder' (lines '182'-'257'). | 182–257 |
| New exception is thrown in catch block, original stack trace may be lost | 184 |
| Avoid using if statements without curly braces | 206–207 |
| Avoid variables with short names like s | 211 |
| Avoid variables with short names like s | 211 |
| Avoid variables with short names like e | 215 |
| Avoid variables with short names like e | 215 |
| Avoid using if statements without curly braces | 232–233 |
| Avoid using Literals in Conditional Statements | 232 |
| Avoid using if...else statements without curly braces | 249 |
| Avoid variables with short names like c | 284 |
| Avoid variables with short names like c | 284 |
| Avoid variables with short names like e | 288 |
| Avoid variables with short names like e | 288 |
| Do not add empty strings | 290 |
| Do not add empty strings | 294 |
| Do not add empty strings | 298 |
| Avoid variables with short names like n | 302 |
| Avoid variables with short names like n | 302 |
| Avoid variables with short names like c | 310 |
| Avoid variables with short names like c | 310 |
| Position literals first in String comparisons | 312 |
| Avoid variables with short names like e | 316 |
| Avoid variables with short names like e | 316 |
| Do not add empty strings | 318 |
| Do not add empty strings | 322 |
| Do not add empty strings | 326 |
| Do not add empty strings | 331 |
| publicMethodCommentRequirement Required | 339–341 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| An Interface should be used only to model a behaviour; consider converting this to a class. | 8–11 |
| Avoid modifiers which are implied by the context | 10 |
| fieldCommentRequirement Required | 10 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 15–19 |
| publicMethodCommentRequirement Required | 22–24 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| publicMethodCommentRequirement Required | 15–18 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 21–23 |
| Violation | Line |
|---|---|
| Package name contains upper case characters | 1 |
| Package name contains upper case characters | 1 |
| Avoid variables with short names like db | 15 |
| publicMethodCommentRequirement Required | 15–19 |
| Avoid variables with short names like nt | 15 |
| Avoid variables with short names like db | 15 |
| Avoid variables with short names like nt | 15 |
| publicMethodCommentRequirement Required | 22–24 |
| Violation | Line |
|---|---|
| This abstract class does not have any abstract methods | 14–23 |
| Abstract classes should be named AbstractXXX | 14–23 |
| Abstract classes should be named AbstractXXX | 14–23 |
| fieldCommentRequirement Required | 16 |
| Field databasePool has the same name as a method | 16 |
| Field databasePool has the same name as a method | 16 |
| protectedMethodCommentRequirement Required | 18 |
| Document empty constructor | 18 |
| Parameter 'databasePool' is not assigned and could be declared final | 20 |
| publicMethodCommentRequirement Required | 20–22 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 32 |
| enumCommentRequirement Required | 34–54 |
| Avoid variables with short names like c | 37 |
| Avoid variables with short names like c | 37 |
| publicMethodCommentRequirement Required | 37–53 |
| Parameter 'c' is not assigned and could be declared final | 37 |
| The default label should be the last label in a switch statement | 38–52 |
| A method should have only one exit point, and that should be the last statement in the method | 41 |
| A method should have only one exit point, and that should be the last statement in the method | 43 |
| A method should have only one exit point, and that should be the last statement in the method | 45 |
| A method should have only one exit point, and that should be the last statement in the method | 47 |
| A method should have only one exit point, and that should be the last statement in the method | 49 |
| fieldCommentRequirement Required | 56 |
| fieldCommentRequirement Required | 57 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 59 |
| fieldCommentRequirement Required | 60 |
| Private field 'connectionMap' could be made final; it is only initialized in the declaration or constructor. | 60 |
| headerCommentRequirement Required | 62–95 |
| Field address has the same name as a method | 63 |
| fieldCommentRequirement Required | 63 |
| Field address has the same name as a method | 63 |
| fieldCommentRequirement Required | 64 |
| Avoid excessively long variable names like trafficShapingHandler | 64 |
| Avoid excessively long variable names like trafficShapingHandler | 64 |
| fieldCommentRequirement Required | 65 |
| Field connectTime has the same name as a method | 65 |
| Field connectTime has the same name as a method | 65 |
| Field lastTime has the same name as a method | 66 |
| Field lastTime has the same name as a method | 66 |
| fieldCommentRequirement Required | 66 |
| Private field 'lastTime' could be made final; it is only initialized in the declaration or constructor. | 66 |
| publicMethodCommentRequirement Required | 68–73 |
| Avoid excessively long variable names like trafficShapingHandler | 68 |
| Avoid excessively long variable names like trafficShapingHandler | 68 |
| Parameter 'address' is not assigned and could be declared final | 68 |
| Parameter 'trafficShapingHandler' is not assigned and could be declared final | 68 |
| publicMethodCommentRequirement Required | 75–77 |
| publicMethodCommentRequirement Required | 79–81 |
| publicMethodCommentRequirement Required | 83–85 |
| publicMethodCommentRequirement Required | 87–89 |
| publicMethodCommentRequirement Required | 92–94 |
| publicMethodCommentRequirement Required | 97–105 |
| publicMethodCommentRequirement Required | 107–109 |
| publicMethodCommentRequirement Required | 111–114 |
| Parameter 'socketAddress' is not assigned and could be declared final | 111 |
| publicMethodCommentRequirement Required | 116–118 |
| Parameter 'socketAddress' is not assigned and could be declared final | 120 |
| publicMethodCommentRequirement Required | 120–123 |
| publicMethodCommentRequirement Required | 125–127 |
| publicMethodCommentRequirement Required | 129–132 |
| publicMethodCommentRequirement Required | 134–136 |
| publicMethodCommentRequirement Required | 138–140 |
| publicMethodCommentRequirement Required | 142–146 |
| Parameter 'remoteAddress' is not assigned and could be declared final | 142 |
| Parameter 'trafficCounter2' is not assigned and could be declared final | 143 |
| publicMethodCommentRequirement Required | 148–150 |
| Parameter 'remoteAddress' is not assigned and could be declared final | 148 |
| publicMethodCommentRequirement Required | 152–182 |
| Found 'UR'-anomaly for variable 'connection' (lines '152'-'168'). | 152–168 |
| Avoid variables with short names like s | 152 |
| Avoid variables with short names like s | 152 |
| Parameter 's' is not assigned and could be declared final | 152 |
| Local variable 'sb' could be declared final | 153 |
| Avoid variables with short names like sb | 153 |
| StringBuffer constructor is initialized with size 16, but has at least 332 characters appended. | 153 |
| Avoid variables with short names like sb | 153 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 154 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 154 |
| Found 'DD'-anomaly for variable 'col' (lines '158'-'160'). | 158–160 |
| Avoid using Literals in Conditional Statements | 159 |
| Avoid using if statements without curly braces | 159–160 |
| Local variable 'desc' could be declared final | 161 |
| Local variable 'connections' could be declared final | 163 |
| Ensure that resources like this Connection object are closed after use | 167 |
| Local variable 'connection' could be declared final | 167 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 174–175 |
| StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 174–175 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 176 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 177 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 177 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 178 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 178 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 179 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 179 |
| publicMethodCommentRequirement Required | 184–212 |
| Parameter 'cs1' is not assigned and could be declared final | 186 |
| Parameter 'cs2' is not assigned and could be declared final | 186 |
| publicMethodCommentRequirement Required | 186–210 |
| The default label should be the last label in a switch statement | 188–205 |
| Avoid using if statements without curly braces | 206–207 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 3–5 |
| Each class should declare at least one constructor | 3–5 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 17 |
| publicMethodCommentRequirement Required | 19–21 |
| Parameter 'msg' is not assigned and could be declared final | 23 |
| publicMethodCommentRequirement Required | 23–25 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 48 |
| Avoid excessively long variable names like DEFAULT_ALLOW_HTTP | 49 |
| Avoid excessively long variable names like DEFAULT_ALLOW_HTTP | 49 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 53 |
| Parameter 'array2' is not assigned and could be declared final | 55 |
| Parameter 'array1' is not assigned and could be declared final | 55 |
| A method should have only one exit point, and that should be the last statement in the method | 58 |
| fieldCommentRequirement Required | 65 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 65 |
| fieldCommentRequirement Required | 66 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 66 |
| Avoid excessively long variable names like winstonDatabasePool | 66 |
| Avoid excessively long variable names like winstonDatabasePool | 66 |
| Avoid excessively long variable names like winstonDatabasePool | 73 |
| Parameter 'winstonDatabasePool' is not assigned and could be declared final | 73 |
| Avoid excessively long variable names like winstonDatabasePool | 73 |
| Parameter 'configFile' is not assigned and could be declared final | 73 |
| Parameter 'ctx' is not assigned and could be declared final | 80 |
| Parameter 'in' is not assigned and could be declared final | 80 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 80 |
| protectedMethodCommentRequirement Required | 80–105 |
| Parameter 'out' is not assigned and could be declared final | 80 |
| Avoid variables with short names like in | 80 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 80 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 80 |
| Avoid variables with short names like in | 80 |
| Avoid variables with short names like p | 93 |
| Avoid variables with short names like p | 93 |
| Found 'DU'-anomaly for variable 'p' (lines '93'-'105'). | 93–105 |
| Parameter 'p' is not assigned and could be declared final | 107 |
| Avoid variables with short names like p | 107 |
| Avoid variables with short names like p | 107 |
| Avoid variables with short names like p | 115 |
| Avoid variables with short names like p | 115 |
| Parameter 'p' is not assigned and could be declared final | 115 |
| Violation | Line |
|---|---|
| publicMethodCommentRequirement Required | 20–22 |
| Parameter 'checkInterval' is not assigned and could be declared final | 20 |
| publicMethodCommentRequirement Required | 24–26 |
| Parameter 'ctx' is not assigned and could be declared final | 24 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 24 |
| System.out.println is used | 25 |
| Violation | Line |
|---|---|
| Avoid short class names like WWS | 45–271 |
| Avoid short class names like WWS | 45–271 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| Avoid excessively long variable names like DEFAULT_DB_CONNECTIONS | 47 |
| Avoid excessively long variable names like DEFAULT_DB_CONNECTIONS | 47 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 55 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 55 |
| Found 'DU'-anomaly for variable 'run' (lines '68'-'111'). | 68–111 |
| Local variable 'console' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 70–110 |
| System.out.println is used | 72 |
| Avoid variables with short names like s | 73 |
| Avoid variables with short names like s | 73 |
| Avoid using if statements without curly braces | 75–76 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 78 |
| Position literals first in String comparisons | 79 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 82 |
| Position literals first in String comparisons | 90 |
| System.out.println is used | 92 |
| Position literals first in String comparisons | 93 |
| System.out.println is used | 95 |
| Position literals first in String comparisons | 96 |
| System.out.println is used | 98 |
| Position literals first in String comparisons | 99 |
| System.out.println is used | 101 |
| Position literals first in String comparisons | 102 |
| System.out.println is used | 109 |
| Avoid variables with short names like s | 113 |
| Parameter 's' is not assigned and could be declared final | 113 |
| Avoid variables with short names like s | 113 |
| publicMethodCommentRequirement Required | 113–115 |
| System.out.println is used | 114 |
| publicMethodCommentRequirement Required | 117–137 |
| StringBuffer constructor is initialized with size 16, but has at least 498 characters appended. | 118 |
| Avoid variables with short names like sb | 118 |
| Avoid variables with short names like sb | 118 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 119 |
| StringBuffer (or StringBuilder).append is called 13 consecutive times with literal Strings. Use a single append with a single combined String. | 119 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 119 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 120 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 121 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 123 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 124 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 127 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 128 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 129 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 130 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 131 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 132 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 133 |
| System.out.println is used | 136 |
| fieldCommentRequirement Required | 139 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 139 |
| fieldCommentRequirement Required | 140 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 140 |
| fieldCommentRequirement Required | 141 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 141 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 142 |
| fieldCommentRequirement Required | 142 |
| fieldCommentRequirement Required | 143 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 143 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 144 |
| fieldCommentRequirement Required | 144 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 145 |
| Avoid excessively long variable names like connectionStatistics | 145 |
| Avoid excessively long variable names like connectionStatistics | 145 |
| fieldCommentRequirement Required | 145 |
| Avoid variables with short names like cf | 150 |
| Avoid variables with short names like cf | 150 |
| Overridable method 'processConfigFile' called during object construction | 156 |
| protectedMethodCommentRequirement Required | 159–162 |
| publicMethodCommentRequirement Required | 164–227 |
| Avoid excessively long variable names like connectionStatsKey | 175 |
| Avoid excessively long variable names like connectionStatsKey | 175 |
| Avoid variables with short names like b | 178 |
| Avoid variables with short names like b | 178 |
| Avoid variables with short names like ch | 184 |
| publicMethodCommentRequirement Required | 184–202 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 184 |
| Parameter 'ch' is not assigned and could be declared final | 184 |
| Avoid variables with short names like ch | 184 |
| publicMethodCommentRequirement Required | 196–199 |
| Parameter 'future' is not assigned and could be declared final | 196 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 196 |
| Avoid variables with short names like f | 205 |
| Avoid variables with short names like f | 205 |
| publicMethodCommentRequirement Required | 229–238 |
| Avoid variables with short names like ff | 232 |
| Avoid variables with short names like ff | 232 |
| Avoid variables with short names like a | 250 |
| Avoid variables with short names like a | 250 |
| New exception is thrown in catch block, original stack trace may be lost | 255 |
| Avoid variables with short names like p | 260 |
| Avoid variables with short names like p | 260 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 27 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 27 |
| Avoid excessively long variable names like DEFAULT_CONFIG_FILENAME | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 30 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 44 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 44 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 23 |
| Avoid unused private fields such as 'DEFAULT_MAX_AGE'. | 23 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| It is a good practice to call super() in a constructor | 30–36 |
| publicMethodCommentRequirement Required | 30–36 |
| Parameter 'config' is not assigned and could be declared final | 30 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 39 |
| publicMethodCommentRequirement Required | 39–42 |
| Local variable 'winston' could be declared final | 40 |
| Consider simply returning the value vs storing it in local variable 'winston' | 41 |
| publicMethodCommentRequirement Required | 45–47 |
| Parameter 'obj' is not assigned and could be declared final | 45 |
| Violation | Line |
|---|---|
| Parameter 'poolConfig' is not assigned and could be declared final | 24 |
| Parameter 'configFile' is not assigned and could be declared final | 24 |
| publicMethodCommentRequirement Required | 24–26 |
| Parameter 'consumer' is not assigned and could be declared final | 28 |
| publicMethodCommentRequirement Required | 28–42 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 28 |
| Found 'DD'-anomaly for variable 'winston' (lines '29'-'31'). | 29–31 |
| Avoid if (x != y) ..; else ..; | 32–36 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 39–214 |
| Abstract classes should be named AbstractXXX | 39–214 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| Avoid unnecessary constructors - the compiler will generate these for you | 50–52 |
| Parameter 'ctx' is not assigned and could be declared final | 63 |
| Parameter 'request' is not assigned and could be declared final | 63 |
| protectedMethodCommentRequirement Required | 69–86 |
| Parameter 'request' is not assigned and could be declared final | 69 |
| Found 'DD'-anomaly for variable 'params' (lines '71'-'76'). | 71–76 |
| Found 'DU'-anomaly for variable 'params' (lines '71'-'86'). | 71–86 |
| Local variable 'method' could be declared final | 72 |
| Avoid excessively long variable names like queryStringDecoder | 75 |
| Avoid excessively long variable names like queryStringDecoder | 75 |
| Local variable 'queryStringDecoder' could be declared final | 75 |
| Found 'UR'-anomaly for variable 'param' (lines '88'-'96'). | 88–96 |
| Parameter 'request' is not assigned and could be declared final | 88 |
| protectedMethodCommentRequirement Required | 88–107 |
| Local variable 'params' could be declared final | 90 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 90 |
| Found 'DU'-anomaly for variable 'params' (lines '90'-'107'). | 90–107 |
| Local variable 'method' could be declared final | 91 |
| Avoid excessively long variable names like queryStringDecoder | 94 |
| Local variable 'queryStringDecoder' could be declared final | 94 |
| Avoid excessively long variable names like queryStringDecoder | 94 |
| Local variable 'param' could be declared final | 95 |
| Avoid variables with short names like t1 | 118 |
| Avoid variables with short names like t1 | 118 |
| Found 'DD'-anomaly for variable 'startTime' (lines '119'-'130'). | 119–130 |
| Found 'DD'-anomaly for variable 'startTime' (lines '119'-'123'). | 119–123 |
| When instantiating a SimpleDateFormat object, specify a Locale | 125 |
| Avoid variables with short names like bt | 127 |
| Avoid variables with short names like bt | 127 |
| Found 'DD'-anomaly for variable 'startTime' (lines '130'-'132'). | 130–132 |
| Avoid variables with short names like t1 | 142 |
| protectedMethodCommentRequirement Required | 142–146 |
| Avoid variables with short names like t1 | 142 |
| Avoid variables with short names like tz | 143 |
| Avoid variables with short names like tz | 143 |
| Avoid variables with short names like t2 | 154 |
| Avoid variables with short names like t2 | 154 |
| Found 'DD'-anomaly for variable 'endTime' (lines '155'-'157'). | 155–157 |
| Found 'DD'-anomaly for variable 'endTime' (lines '155'-'164'). | 155–164 |
| Avoid using if...else statements without curly braces | 157 |
| When instantiating a SimpleDateFormat object, specify a Locale | 159 |
| Avoid variables with short names like bt | 161 |
| Avoid variables with short names like bt | 161 |
| Found 'DD'-anomaly for variable 'endTime' (lines '164'-'166'). | 164–166 |
| Avoid variables with short names like tz | 177 |
| Avoid variables with short names like t2 | 177 |
| Avoid variables with short names like tz | 177 |
| Avoid variables with short names like t2 | 177 |
| Avoid variables with short names like t | 188 |
| Avoid variables with short names like t | 188 |
| Avoid using if...else statements without curly braces | 190 |
| A method should have only one exit point, and that should be the last statement in the method | 190 |
| Avoid using if...else statements without curly braces | 192 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 201 |
| Avoid variables with short names like in | 201 |
| Avoid variables with short names like in | 201 |
| Avoid unnecessary comparisons in boolean expressions | 202 |
| Parameter 'configFile' is not assigned and could be declared final | 211 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 23 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 50 |
| Parameter 'clazz' is not assigned and could be declared final | 52 |
| Parameter 'commandName' is not assigned and could be declared final | 52 |
| Parameter 'databasePool' is not assigned and could be declared final | 82 |
| Found 'UR'-anomaly for variable 'cmd' (lines '82'-'95'). | 82–95 |
| Avoid reassigning parameters such as 'command' | 82 |
| Avoid reassigning parameters such as 'command' | 82 |
| Local variable 'cmd' could be declared final | 94 |
| Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals(). | 95 |
| Found 'DU'-anomaly for variable 'baseCommand' (lines '98'-'109'). | 98–109 |
| New exception is thrown in catch block, original stack trace may be lost | 100 |
| New exception is thrown in catch block, original stack trace may be lost | 102 |
| Found 'UR'-anomaly for variable 'command' (lines '115'-'118'). | 115–118 |
| Local variable 'names' could be declared final | 116 |
| Local variable 'command' could be declared final | 117 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 6–207 |
| fieldCommentRequirement Required | 56 |
| fieldCommentRequirement Required | 58 |
| Avoid excessively long variable names like winstonDatabasePool | 58 |
| Avoid excessively long variable names like winstonDatabasePool | 58 |
| fieldCommentRequirement Required | 59 |
| Avoid excessively long variable names like connectionStatsKey | 61 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 61 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 61 |
| fieldCommentRequirement Required | 61 |
| Avoid excessively long variable names like connectionStatsKey | 61 |
| Parameter 'winstonDatabasePool' is not assigned and could be declared final | 73 |
| Parameter 'configFile' is not assigned and could be declared final | 73 |
| Avoid excessively long variable names like winstonDatabasePool | 73 |
| Avoid excessively long variable names like winstonDatabasePool | 73 |
| It is a good practice to call super() in a constructor | 73–76 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 79 |
| Parameter 'req' is not assigned and could be declared final | 79 |
| Parameter 'ctx' is not assigned and could be declared final | 79 |
| publicMethodCommentRequirement Required | 79–134 |
| Found 'DD'-anomaly for variable 'response' (lines '82'-'106'). | 82–106 |
| Found 'DD'-anomaly for variable 'response' (lines '82'-'103'). | 82–103 |
| Found 'DD'-anomaly for variable 'response' (lines '82'-'86'). | 82–86 |
| Local variable 'command' could be declared final | 84 |
| Avoid excessively long variable names like connectionStatistics | 95 |
| Local variable 'connectionStatistics' could be declared final | 95 |
| Avoid excessively long variable names like connectionStatistics | 95 |
| Local variable 'is' could be declared final | 100 |
| Avoid variables with short names like is | 100 |
| Avoid variables with short names like is | 100 |
| Found 'DD'-anomaly for variable 'response' (lines '103'-'111'). | 103–111 |
| Found 'DD'-anomaly for variable 'response' (lines '111'-'116'). | 111–116 |
| Do not add empty strings | 117 |
| Parameter 'httpVersion' is not assigned and could be declared final | 136 |
| Parameter 'status' is not assigned and could be declared final | 136 |
| Parameter 'html' is not assigned and could be declared final | 137 |
| Local variable 'response' could be declared final | 138–139 |
| Parameter 'status' is not assigned and could be declared final | 145 |
| Parameter 'httpVersion' is not assigned and could be declared final | 145 |
| Parameter 'is' is not assigned and could be declared final | 146 |
| Avoid variables with short names like is | 146 |
| Avoid variables with short names like is | 146 |
| Local variable 'file' could be declared final | 147 |
| Local variable 'response' could be declared final | 148–149 |
| Parameter 'host' is not assigned and could be declared final | 155 |
| Found 'DU'-anomaly for variable 'channels' (lines '158'-'195'). | 158–195 |
| Found 'DU'-anomaly for variable 'channels' (lines '158'-'195'). | 158–195 |
| publicMethodCommentRequirement Required | 160–162 |
| Parameter 'winston' is not assigned and could be declared final | 160 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 165 |
| New exception is thrown in catch block, original stack trace may be lost | 166 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 169 |
| Local variable 'root' could be declared final | 169 |
| Local variable 'cfg' could be declared final | 182 |
| Local variable 'template' could be declared final | 183 |
| Avoid variables with short names like sw | 184 |
| Avoid variables with short names like sw | 184 |
| Local variable 'sw' could be declared final | 184 |
| publicMethodCommentRequirement Required | 198–200 |
| Parameter 'ctx' is not assigned and could be declared final | 198 |
| Parameter 'cause' is not assigned and could be declared final | 203 |
| publicMethodCommentRequirement Required | 203–206 |
| Parameter 'ctx' is not assigned and could be declared final | 203 |
| Avoid printStackTrace(); use a logger call instead. | 204 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like DISPLAY_DATE_FORMAT | 21 |
| Avoid excessively long variable names like DISPLAY_DATE_FORMAT | 21 |
| The String literal "auto" appears 4 times in this file; the first occurrence is on line 57 | 57 |
| Avoid excessively long variable names like RSAM_DOWN_SAMPLE_PERIOD | 81 |
| Avoid excessively long variable names like RSAM_DOWN_SAMPLE_PERIOD | 81 |
| Avoid excessively long variable names like RSAM_REMOVE_MEAN_PERIOD | 108 |
| Avoid excessively long variable names like RSAM_REMOVE_MEAN_PERIOD | 108 |
| Avoid excessively long variable names like GAPS_MINIMUM_DURATION | 117 |
| Avoid excessively long variable names like GAPS_MINIMUM_DURATION | 117 |
| Parameter 'map' is not assigned and could be declared final | 130 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 131 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 22 |
| Variables should start with a lowercase character, 'LOGGER' starts with uppercase character. | 22 |
| Variables should start with a lowercase character, 'LOGGER' starts with uppercase character. | 22 |
| The Logger variable declaration does not contain the static and final modifiers | 22 |
| fieldCommentRequirement Required | 22 |
| Use explicit scoping instead of the default package private level | 22 |
| The field name indicates a constant but its modifiers do not | 22 |
| headerCommentRequirement Required | 24–26 |
| Avoid instantiation through private constructors from outside of the constructors class. | 25 |
| fieldCommentRequirement Required | 25 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 21–55 |
| fieldCommentRequirement Required | 22 |
| Variables that are final and static should be all capitals, 'mimeTypes' is not all capitals. | 23 |
| fieldCommentRequirement Required | 23 |
| Variables that are final and static should be all capitals, 'mimeTypes' is not all capitals. | 23 |
| Local variable 'map' could be declared final | 26 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 26 |
| Parameter 'fileName' is not assigned and could be declared final | 43 |
| Local variable 'index' could be declared final | 45 |
| Found 'DD'-anomaly for variable 'extension' (lines '46'-'51'). | 46–51 |
| Found 'DD'-anomaly for variable 'extension' (lines '46'-'49'). | 46–49 |
| Avoid using if...else statements without curly braces | 49 |
| Avoid using if statements without curly braces | 50–51 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 16–19 |
| fieldCommentRequirement Required | 17 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 19 |
| Parameter 'msg' is not assigned and could be declared final | 26 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 46 |
| Avoid unnecessary constructors - the compiler will generate these for you | 51–53 |
| Parameter 'request' is not assigned and could be declared final | 63 |
| Parameter 'ctx' is not assigned and could be declared final | 63 |
| Local variable 'splits' could be declared final | 64 |
| Avoid using Literals in Conditional Statements | 66 |
| Avoid using Literals in Conditional Statements | 68 |
| Local variable 'error' could be declared final | 71 |
| Parameter 'service' is not assigned and could be declared final | 81 |
| Parameter 'ctx' is not assigned and could be declared final | 81 |
| Parameter 'request' is not assigned and could be declared final | 81 |
| Local variable 'root' could be declared final | 82 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| Local variable 'cfg' could be declared final | 91 |
| Local variable 'template' could be declared final | 92 |
| Avoid variables with short names like sw | 94 |
| Local variable 'sw' could be declared final | 94 |
| Avoid variables with short names like sw | 94 |
| Local variable 'html' could be declared final | 96 |
| Local variable 'response' could be declared final | 99–100 |
| Parameter 'ctx' is not assigned and could be declared final | 116 |
| Parameter 'service' is not assigned and could be declared final | 116 |
| Parameter 'request' is not assigned and could be declared final | 116 |
| New exception is thrown in catch block, original stack trace may be lost | 123 |
| New exception is thrown in catch block, original stack trace may be lost | 130 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 6–263 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 54 |
| fieldCommentRequirement Required | 55 |
| fieldCommentRequirement Required | 56 |
| fieldCommentRequirement Required | 57 |
| Perhaps 'zone' could be replaced by a local variable. | 58 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 59 |
| Perhaps 'writeComputer' could be replaced by a local variable. | 60 |
| fieldCommentRequirement Required | 60 |
| Field writeComputer has the same name as a method | 60 |
| Field writeComputer has the same name as a method | 60 |
| fieldCommentRequirement Required | 62 |
| fieldCommentRequirement Required | 63 |
| fieldCommentRequirement Required | 64 |
| fieldCommentRequirement Required | 66 |
| Perhaps 'gapCount' could be replaced by a local variable. | 67 |
| fieldCommentRequirement Required | 67 |
| Perhaps 'gapLength' could be replaced by a local variable. | 69 |
| fieldCommentRequirement Required | 69 |
| fieldCommentRequirement Required | 70 |
| Perhaps 'totalGapLength' could be replaced by a local variable. | 70 |
| fieldCommentRequirement Required | 72 |
| fieldCommentRequirement Required | 73 |
| Avoid unnecessary constructors - the compiler will generate these for you | 78–80 |
| Parameter 'ctx' is not assigned and could be declared final | 83 |
| publicMethodCommentRequirement Required | 83–173 |
| Parameter 'request' is not assigned and could be declared final | 83 |
| StringBuffer constructor is initialized with size 16, but has at least 53 characters appended. | 87 |
| Local variable 'error' could be declared final | 87 |
| Found 'DU'-anomaly for variable 'error' (lines '87'-'173'). | 87–173 |
| Found 'DU'-anomaly for variable 'error' (lines '87'-'173'). | 87–173 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 87 |
| Found 'DU'-anomaly for variable 'params' (lines '91'-'173'). | 91–173 |
| Found 'DU'-anomaly for variable 'params' (lines '91'-'173'). | 91–173 |
| Avoid printStackTrace(); use a logger call instead. | 94 |
| String.indexOf(char) is faster than String.indexOf(String). | 104 |
| Avoid appending characters as strings in StringBuffer.append. | 113 |
| Local variable 'response' could be declared final | 135–136 |
| Local variable 'keepAlive' could be declared final | 139 |
| When instantiating a SimpleDateFormat object, specify a Locale | 147 |
| Local variable 'dateF' could be declared final | 147 |
| Parameter 'winston' is not assigned and could be declared final | 154 |
| publicMethodCommentRequirement Required | 154–156 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 158 |
| New exception is thrown in catch block, original stack trace may be lost | 159 |
| Avoid using Literals in Conditional Statements | 167 |
| Found 'UR'-anomaly for variable 'gap' (lines '176'-'187'). | 176–187 |
| Local variable 'root' could be declared final | 177 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 177 |
| Local variable 'gap' could be declared final | 186 |
| Local variable 'cfg' could be declared final | 198 |
| Local variable 'template' could be declared final | 199 |
| Avoid variables with short names like sw | 200 |
| Local variable 'sw' could be declared final | 200 |
| Avoid variables with short names like sw | 200 |
| Local variable 'html' could be declared final | 202 |
| Local variable 'response' could be declared final | 205–206 |
| Found 'UR'-anomaly for variable 'gap' (lines '222'-'233'). | 222–233 |
| StringBuffer constructor is initialized with size 16, but has at least 120 characters appended. | 224 |
| StringBuffer constructor is initialized with size 16, but has at least 42 characters appended. | 225 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 244–247 |
| Local variable 'response' could be declared final | 252–253 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| Avoid unnecessary constructors - the compiler will generate these for you | 46–48 |
| Parameter 'ctx' is not assigned and could be declared final | 51 |
| Parameter 'request' is not assigned and could be declared final | 51 |
| publicMethodCommentRequirement Required | 51–102 |
| Found 'DU'-anomaly for variable 'params' (lines '56'-'102'). | 56–102 |
| Found 'DU'-anomaly for variable 'params' (lines '56'-'102'). | 56–102 |
| New exception is thrown in catch block, original stack trace may be lost | 58 |
| Parameter 'winston' is not assigned and could be declared final | 70 |
| publicMethodCommentRequirement Required | 70–72 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 74 |
| New exception is thrown in catch block, original stack trace may be lost | 75 |
| New exception is thrown in catch block, original stack trace may be lost | 86 |
| Local variable 'response' could be declared final | 89–90 |
| Local variable 'httpRefreshInterval' could be declared final | 94 |
| Avoid excessively long variable names like httpRefreshInterval | 94 |
| Avoid excessively long variable names like httpRefreshInterval | 94 |
| Avoid using if statements without curly braces | 95–96 |
| Parameter 'params' is not assigned and could be declared final | 105 |
| Local variable 'settings' could be declared final | 108 |
| Local variable 'error' could be declared final | 109 |
| StringBuffer constructor is initialized with size 16, but has at least 53 characters appended. | 109 |
| Avoid variables with short names like tz | 117 |
| Avoid variables with short names like tz | 117 |
| Avoid using if statements without curly braces | 121–123 |
| Avoid using if statements without curly braces | 126–129 |
| Avoid using if...else statements without curly braces | 132 |
| Avoid using if statements without curly braces | 133–134 |
| Avoid using if statements without curly braces | 138–140 |
| Avoid appending characters as strings in StringBuffer.append. | 140 |
| Avoid using if statements without curly braces | 161–162 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 47 |
| Avoid unnecessary constructors - the compiler will generate these for you | 52–54 |
| Parameter 'request' is not assigned and could be declared final | 57 |
| Parameter 'ctx' is not assigned and could be declared final | 57 |
| publicMethodCommentRequirement Required | 57–103 |
| Found 'DU'-anomaly for variable 'error' (lines '58'-'103'). | 58–103 |
| StringBuffer constructor is initialized with size 16, but has at least 68 characters appended. | 58 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 58 |
| Local variable 'error' could be declared final | 58 |
| Found 'DU'-anomaly for variable 'params' (lines '62'-'103'). | 62–103 |
| New exception is thrown in catch block, original stack trace may be lost | 65 |
| Avoid variables with short names like o | 73 |
| Avoid variables with short names like o | 73 |
| Avoid variables with short names like tz | 80 |
| Avoid variables with short names like tz | 80 |
| Local variable 'html' could be declared final | 87 |
| Avoid if (x != y) ..; else ..; | 89–101 |
| Local variable 'response' could be declared final | 90–91 |
| Parameter 'sortCol' is not assigned and could be declared final | 106 |
| Parameter 'order' is not assigned and could be declared final | 106 |
| Parameter 'timeZone' is not assigned and could be declared final | 106 |
| Prefer StringBuffer over += for concatenating strings | 109 |
| Avoid using if statements without curly braces | 113–114 |
| Avoid using Literals in Conditional Statements | 113 |
| Found 'DU'-anomaly for variable 'colOrd' (lines '114'-'180'). | 114–180 |
| Found 'DU'-anomaly for variable 'colOrd' (lines '114'-'180'). | 114–180 |
| StringBuffer constructor is initialized with size 16, but has at least 254 characters appended. | 116 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 118 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 118 |
| Avoid using for statements without curly braces | 121–123 |
| Found 'DU'-anomaly for variable 'channels' (lines '130'-'180'). | 130–180 |
| Found 'DU'-anomaly for variable 'channels' (lines '130'-'180'). | 130–180 |
| publicMethodCommentRequirement Required | 132–134 |
| Parameter 'winston' is not assigned and could be declared final | 132 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 137 |
| New exception is thrown in catch block, original stack trace may be lost | 138 |
| Avoid variables with short names like i | 146 |
| Avoid variables with short names like i | 146 |
| Avoid using for statements without curly braces | 147–148 |
| Avoid using Literals in Conditional Statements | 154 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 155 |
| Local variable 'dateF' could be declared final | 159 |
| When instantiating a SimpleDateFormat object, specify a Locale | 159 |
| Avoid instantiating new objects inside loops | 159 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 165 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 166 |
| The String literal "<td>" appears 8 times in this file; the first occurrence is on line 166 | 166 |
| The String literal "</td>" appears 8 times in this file; the first occurrence is on line 166 | 166 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 167 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 168 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 169 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 170 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 171 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 172 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 173 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 177 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 177 |
| Avoid variables with short names like e1 | 185 |
| publicMethodCommentRequirement Required | 185–211 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 185 |
| Avoid variables with short names like e2 | 185 |
| Avoid variables with short names like e1 | 185 |
| Avoid variables with short names like e2 | 185 |
| Avoid variables with short names like d1 | 188 |
| Avoid variables with short names like d1 | 188 |
| Avoid variables with short names like d2 | 189 |
| Avoid variables with short names like d2 | 189 |
| Avoid variables with short names like d | 193 |
| Avoid variables with short names like d | 193 |
| Avoid using if statements without curly braces | 194–195 |
| Avoid variables with short names like i | 197 |
| Avoid variables with short names like i | 197 |
| Avoid using Literals in Conditional Statements | 199 |
| Avoid using if...else statements without curly braces | 200 |
| Avoid using if...else statements without curly braces | 202 |
| Avoid using Literals in Conditional Statements | 206 |
| Avoid using if...else statements without curly braces | 207 |
| Avoid using if...else statements without curly braces | 209 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 51 |
| fieldCommentRequirement Required | 52 |
| fieldCommentRequirement Required | 53 |
| fieldCommentRequirement Required | 54 |
| fieldCommentRequirement Required | 55 |
| fieldCommentRequirement Required | 56 |
| fieldCommentRequirement Required | 57 |
| Avoid excessively long variable names like runningMedianPeriod | 57 |
| Avoid excessively long variable names like runningMedianPeriod | 57 |
| fieldCommentRequirement Required | 58 |
| fieldCommentRequirement Required | 59 |
| fieldCommentRequirement Required | 60 |
| fieldCommentRequirement Required | 61 |
| fieldCommentRequirement Required | 62 |
| fieldCommentRequirement Required | 63 |
| Avoid unnecessary constructors - the compiler will generate these for you | 68–70 |
| Parameter 'request' is not assigned and could be declared final | 73 |
| Parameter 'ctx' is not assigned and could be declared final | 73 |
| publicMethodCommentRequirement Required | 73–95 |
| Found 'DU'-anomaly for variable 'params' (lines '79'-'95'). | 79–95 |
| New exception is thrown in catch block, original stack trace may be lost | 81 |
| Local variable 'errorString' could be declared final | 85 |
| Avoid using if...else statements without curly braces | 91 |
| Avoid using if...else statements without curly braces | 93 |
| Assigning an Object to null is a code smell. Consider refactoring. | 99 |
| Avoid using final local variables, turn them into fields | 102 |
| Avoid using final local variables, turn them into fields | 103 |
| Avoid using Literals in Conditional Statements | 104 |
| Parameter 'winston' is not assigned and could be declared final | 115 |
| publicMethodCommentRequirement Required | 115–117 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 119 |
| New exception is thrown in catch block, original stack trace may be lost | 120 |
| Avoid using if statements without curly braces | 126–127 |
| Avoid using if statements without curly braces | 129–130 |
| Avoid using if statements without curly braces | 132–133 |
| Avoid using exceptions as flow control. | 140 |
| New exception is thrown in catch block, original stack trace may be lost | 141–142 |
| Parameter 'arguments' is not assigned and could be declared final | 146 |
| Local variable 'errorString' could be declared final | 147 |
| StringBuffer constructor is initialized with size 16, but has at least 66 characters appended. | 147 |
| Avoid using if...else statements without curly braces | 151 |
| Avoid using if statements without curly braces | 154–155 |
| String.indexOf(char) is faster than String.indexOf(String). | 154 |
| Avoid using if statements without curly braces | 161–163 |
| Avoid using if statements without curly braces | 166–168 |
| Avoid variables with short names like mr | 211 |
| Avoid variables with short names like mr | 211 |
| Found 'DU'-anomaly for variable 'png' (lines '234'-'253'). | 234–253 |
| New exception is thrown in catch block, original stack trace may be lost | 236 |
| Local variable 'response' could be declared final | 239–240 |
| Local variable 'httpRefreshInterval' could be declared final | 244 |
| Avoid excessively long variable names like httpRefreshInterval | 244 |
| Avoid excessively long variable names like httpRefreshInterval | 244 |
| Avoid using if statements without curly braces | 245–246 |
| Local variable 'response' could be declared final | 259–260 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 48 |
| Avoid excessively long variable names like connectionStatsKey | 50 |
| Avoid excessively long variable names like connectionStatsKey | 50 |
| fieldCommentRequirement Required | 50 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 50 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 50 |
| Avoid unnecessary constructors - the compiler will generate these for you | 59–61 |
| Parameter 'request' is not assigned and could be declared final | 64 |
| publicMethodCommentRequirement Required | 64–149 |
| Parameter 'ctx' is not assigned and could be declared final | 64 |
| Found 'DU'-anomaly for variable 'formatter' (lines '65'-'149'). | 65–149 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 65 |
| Found 'DU'-anomaly for variable 'formatter' (lines '65'-'149'). | 65–149 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 66 |
| Found 'DU'-anomaly for variable 'now' (lines '66'-'149'). | 66–149 |
| Found 'DU'-anomaly for variable 'now' (lines '66'-'149'). | 66–149 |
| Found 'DU'-anomaly for variable 'sts' (lines '71'-'149'). | 71–149 |
| Found 'DU'-anomaly for variable 'sts' (lines '71'-'149'). | 71–149 |
| publicMethodCommentRequirement Required | 73–75 |
| Parameter 'winston' is not assigned and could be declared final | 73 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 78 |
| New exception is thrown in catch block, original stack trace may be lost | 79 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 84 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 85 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 86 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 87 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| Avoid using Literals in Conditional Statements | 94 |
| Avoid using if...else statements without curly braces | 95 |
| Avoid using if...else statements without curly braces | 97 |
| Avoid using if...else statements without curly braces | 99 |
| Avoid using if...else statements without curly braces | 101 |
| Avoid using if...else statements without curly braces | 103 |
| Avoid using if...else statements without curly braces | 105 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 108 |
| Local variable 'root' could be declared final | 108 |
| Avoid excessively long variable names like connectionStatistics | 119 |
| Avoid excessively long variable names like connectionStatistics | 119 |
| Local variable 'connectionStatistics' could be declared final | 119 |
| Local variable 'cfg' could be declared final | 127 |
| Local variable 'template' could be declared final | 128 |
| Avoid variables with short names like sw | 129 |
| Local variable 'sw' could be declared final | 129 |
| Avoid variables with short names like sw | 129 |
| Local variable 'html' could be declared final | 131 |
| Local variable 'response' could be declared final | 134–135 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'edu.iris.dmc.seedcodec.B1000Types' | 8 |
| Avoid unused imports such as 'edu.iris.dmc.seedcodec.Steim2' | 9 |
| Avoid unused imports such as 'edu.iris.dmc.seedcodec.SteimException' | 10 |
| Avoid unused imports such as 'edu.iris.dmc.seedcodec.SteimFrameBlock' | 11 |
| Avoid unused imports such as 'edu.sc.seis.seisFile.mseed.Blockette1000' | 12 |
| Avoid unused imports such as 'edu.sc.seis.seisFile.mseed.Btime' | 13 |
| Avoid unused imports such as 'edu.sc.seis.seisFile.mseed.DataHeader' | 14 |
| Avoid unused imports such as 'edu.sc.seis.seisFile.mseed.DataRecord' | 15 |
| Avoid unused imports such as 'edu.sc.seis.seisFile.mseed.SeedFormatException' | 16 |
| Avoid unused imports such as 'gov.usgs.util.Util' | 27 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.TimeConstraint' | 34 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47–195 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 52 |
| Avoid unused private fields such as 'LOGGER'. | 52 |
| Parameter 'ctx' is not assigned and could be declared final | 68 |
| Parameter 'databasePool' is not assigned and could be declared final | 68 |
| Parameter 'request' is not assigned and could be declared final | 69 |
| Local variable 'method' could be declared final | 70 |
| A switch statement does not contain a break | 72–90 |
| Local variable 'error' could be declared final | 83 |
| Parameter 'ctx' is not assigned and could be declared final | 93 |
| Found 'UR'-anomaly for variable 'chanConstraint' (lines '93'-'116'). | 93–116 |
| Parameter 'databasePool' is not assigned and could be declared final | 93 |
| Parameter 'request' is not assigned and could be declared final | 94 |
| Local variable 'arguments' could be declared final | 95 |
| Local variable 'chanConstraints' could be declared final | 98 |
| Local variable 'channels' could be declared final | 102 |
| Local variable 'error' could be declared final | 104 |
| Avoid unused local variables such as 'seq'. | 114 |
| Local variable 'seq' could be declared final | 114 |
| Found 'DU'-anomaly for variable 'seq' (lines '114'-'118'). | 114–118 |
| Local variable 'chanConstraint' could be declared final | 115 |
| Parameter 'chanConstraint' is not assigned and could be declared final | 120 |
| Parameter 'channels' is not assigned and could be declared final | 120 |
| Found 'UR'-anomaly for variable 'c' (lines '120'-'123'). | 120–123 |
| Found 'UR'-anomaly for variable 'c' (lines '120'-'123'). | 120–123 |
| Parameter 'ctx' is not assigned and could be declared final | 121 |
| Parameter 'databasePool' is not assigned and could be declared final | 121 |
| Avoid unused method parameters such as 'ctx'. | 121 |
| Local variable 'timeConstraint' could be declared final | 127 |
| Avoid variables with short names like st | 128 |
| Avoid variables with short names like st | 128 |
| Avoid variables with short names like et | 129 |
| Avoid variables with short names like et | 129 |
| Avoid unused local variables such as 'wave'. | 131 |
| Found 'DU'-anomaly for variable 'wave' (lines '133'-'185'). | 133–185 |
| Avoid instantiating new objects inside loops | 133–139 |
| Found 'DU'-anomaly for variable 'wave' (lines '133'-'185'). | 133–185 |
| Parameter 'winston' is not assigned and could be declared final | 135 |
| publicMethodCommentRequirement Required | 135–138 |
| Local variable 'data' could be declared final | 136 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 140 |
| New exception is thrown in catch block, original stack trace may be lost | 141 |
| protectedMethodCommentRequirement Required | 187–194 |
| Avoid variables with short names like c | 187 |
| Avoid variables with short names like c | 187 |
| Parameter 'constraints' is not assigned and could be declared final | 187 |
| Avoid variables with short names like it | 188 |
| Avoid variables with short names like it | 188 |
| Local variable 'it' could be declared final | 188 |
| Avoid using if statements without curly braces | 190–191 |
| A method should have only one exit point, and that should be the last statement in the method | 191 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| Field request has the same name as a method | 28 |
| Field request has the same name as a method | 28 |
| Field status has the same name as a method | 29 |
| Field status has the same name as a method | 29 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| Field shortDescription has the same name as a method | 30 |
| Field shortDescription has the same name as a method | 30 |
| Avoid excessively long variable names like detailedDescription | 31 |
| Avoid excessively long variable names like detailedDescription | 31 |
| fieldCommentRequirement Required | 31 |
| Field detailedDescription has the same name as a method | 31 |
| Field detailedDescription has the same name as a method | 31 |
| Field version has the same name as a method | 32 |
| Field version has the same name as a method | 32 |
| fieldCommentRequirement Required | 32 |
| Parameter 'ctx' is not assigned and could be declared final | 39 |
| Parameter 'request' is not assigned and could be declared final | 49 |
| Parameter 'status' is not assigned and could be declared final | 60 |
| Parameter 'shortDescription' is not assigned and could be declared final | 71 |
| Avoid excessively long variable names like detailedDescription | 82 |
| Avoid excessively long variable names like detailedDescription | 82 |
| Parameter 'detailedDescription' is not assigned and could be declared final | 82 |
| Parameter 'version' is not assigned and could be declared final | 93 |
| Avoid using if statements without curly braces | 102–104 |
| StringBuffer constructor is initialized with size 16, but has at least 72 characters appended. | 106 |
| Avoid variables with short names like sb | 106 |
| Avoid variables with short names like sb | 106 |
| Local variable 'sb' could be declared final | 106 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 107 |
| The String literal "\n\n" appears 4 times in this file; the first occurrence is on line 108 | 108 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 108 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 109 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 110 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 110 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 111 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 112 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 112 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 113 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 114 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 114 |
| Local variable 'html' could be declared final | 116 |
| Local variable 'response' could be declared final | 118–119 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 18 |
| It is a good practice to call super() in a constructor | 26–29 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 18–43 |
| The field name indicates a constant but its modifiers do not | 19 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DATE_STRING' is not final. | 19 |
| The field name indicates a constant but its modifiers do not | 19 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DATE_STRING' is not final. | 19 |
| Variables should start with a lowercase character, 'DATE_STRING' starts with uppercase character. | 19 |
| fieldCommentRequirement Required | 19 |
| Variables should start with a lowercase character, 'DATE_STRING' starts with uppercase character. | 19 |
| Parameter 'date' is not assigned and could be declared final | 27 |
| Local variable 'sFormat' could be declared final | 28 |
| When instantiating a SimpleDateFormat object, specify a Locale | 28 |
| Parameter 'date' is not assigned and could be declared final | 39 |
| Local variable 'sFormat' could be declared final | 40 |
| When instantiating a SimpleDateFormat object, specify a Locale | 40 |
| Violation | Line |
|---|---|
| Perhaps 'request' could be replaced by a local variable. | 17 |
| Avoid unused private fields such as 'request'. | 17 |
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 18 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| Parameter 'request' is not assigned and could be declared final | 27 |
| Local variable 'splits' could be declared final | 30 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 6–204 |
| Avoid unused imports such as 'java.util.ArrayList' | 12 |
| Avoid unused imports such as 'java.util.Iterator' | 15 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.ChannelConstraint' | 37 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.FdsnConstraint' | 38 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.GeographicConstraint' | 39 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.TimeConstraint' | 40 |
| Abstract classes should be named AbstractXXX | 59–204 |
| This abstract class does not have any abstract methods | 59–204 |
| Abstract classes should be named AbstractXXX | 59–204 |
| fieldCommentRequirement Required | 60 |
| fieldCommentRequirement Required | 62 |
| fieldCommentRequirement Required | 63 |
| Parameter 'request' is not assigned and could be declared final | 65 |
| Parameter 'ctx' is not assigned and could be declared final | 65 |
| protectedMethodCommentRequirement Required | 65–75 |
| Local variable 'response' could be declared final | 66–67 |
| Parameter 'request' is not assigned and could be declared final | 77 |
| protectedMethodCommentRequirement Required | 77–105 |
| Parameter 'ctx' is not assigned and could be declared final | 77 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 78 |
| Local variable 'root' could be declared final | 78 |
| Local variable 'cfg' could be declared final | 83 |
| Local variable 'template' could be declared final | 84 |
| Avoid variables with short names like sw | 86 |
| Avoid variables with short names like sw | 86 |
| Local variable 'sw' could be declared final | 86 |
| Local variable 'xml' could be declared final | 88 |
| Local variable 'response' could be declared final | 91–92 |
| protectedMethodCommentRequirement Required | 108–130 |
| protectedMethodCommentRequirement Required | 132–144 |
| Avoid variables with short names like s1 | 146 |
| Avoid variables with short names like s1 | 146 |
| protectedMethodCommentRequirement Required | 146–152 |
| Avoid variables with short names like s2 | 146 |
| Avoid variables with short names like s2 | 146 |
| Parameter 'arguments' is not assigned and could be declared final | 146 |
| Avoid using if statements without curly braces | 148–149 |
| protectedMethodCommentRequirement Required | 154–182 |
| Found 'UR'-anomaly for variable 'name' (lines '154'-'162'). | 154–162 |
| Parameter 'request' is not assigned and could be declared final | 154 |
| Found 'UR'-anomaly for variable 'list' (lines '154'-'169'). | 154–169 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 155 |
| Local variable 'arguments' could be declared final | 155 |
| Local variable 'decoder' could be declared final | 159 |
| Local variable 'name' could be declared final | 161 |
| Local variable 'lines' could be declared final | 166 |
| Local variable 'chans' could be declared final | 167 |
| Local variable 'list' could be declared final | 168 |
| Local variable 'idx' could be declared final | 169 |
| Avoid if (x != y) ..; else ..; | 170–174 |
| Parameter 'databasePool' is not assigned and could be declared final | 185 |
| protectedMethodCommentRequirement Required | 185–200 |
| Found 'DU'-anomaly for variable 'channels' (lines '189'-'200'). | 189–200 |
| Found 'DU'-anomaly for variable 'channels' (lines '189'-'200'). | 189–200 |
| Parameter 'winston' is not assigned and could be declared final | 191 |
| publicMethodCommentRequirement Required | 191–193 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 196 |
| New exception is thrown in catch block, original stack trace may be lost | 197 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 6–280 |
| Avoid unused imports such as 'java.io.IOException' | 8 |
| Avoid unused imports such as 'java.util.HashMap' | 11 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.db.Channels' | 29 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.db.WinstonDatabase' | 30 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.GeographicCircleConstraint' | 34 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.GeographicSquareConstraint' | 36 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.TimeConstraint' | 37 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.constraint.TimeSimpleConstraint' | 38 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.wws.WinstonConsumer' | 40 |
| Avoid unused imports such as 'io.netty.handler.codec.http.HttpMethod' | 47 |
| Avoid unused imports such as 'io.netty.handler.codec.http.QueryStringDecoder' | 49 |
| Avoid unused imports such as 'io.netty.handler.codec.http.multipart.Attribute' | 50 |
| Avoid unused imports such as 'io.netty.handler.codec.http.multipart.DefaultHttpDataFactory' | 51 |
| Avoid unused imports such as 'io.netty.handler.codec.http.multipart.HttpPostRequestDecoder' | 52 |
| Avoid unused imports such as 'io.netty.handler.codec.http.multipart.InterfaceHttpData' | 53 |
| Avoid unused imports such as 'io.netty.handler.codec.http.multipart.InterfaceHttpData.HttpDataType' | 54 |
| Avoid unused imports such as 'io.netty.util.CharsetUtil' | 55 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 63–280 |
| fieldCommentRequirement Required | 64 |
| fieldCommentRequirement Required | 65 |
| fieldCommentRequirement Required | 66 |
| fieldCommentRequirement Required | 68 |
| Parameter 'databasePool' is not assigned and could be declared final | 84 |
| Parameter 'ctx' is not assigned and could be declared final | 84 |
| Parameter 'request' is not assigned and could be declared final | 85 |
| Local variable 'queryStringIdx' could be declared final | 87 |
| A switch statement does not contain a break | 92–110 |
| Local variable 'error' could be declared final | 103 |
| Parameter 'ctx' is not assigned and could be declared final | 113 |
| Found 'UR'-anomaly for variable 'c' (lines '113'-'147'). | 113–147 |
| Parameter 'databasePool' is not assigned and could be declared final | 113 |
| Parameter 'request' is not assigned and could be declared final | 114 |
| Local variable 'arguments' could be declared final | 115 |
| Found 'DU'-anomaly for variable 'level' (lines '116'-'203'). | 116–203 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 116 |
| Local variable 'constraints' could be declared final | 118 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 118 |
| Found 'DU'-anomaly for variable 'constraints' (lines '118'-'203'). | 118–203 |
| Local variable 'channels' could be declared final | 121 |
| Local variable 'error' could be declared final | 123 |
| Local variable 'dBuilder' could be declared final | 135 |
| Local variable 'rootElement' could be declared final | 137 |
| Found 'DD'-anomaly for variable 'networkElement' (lines '139'-'153'). | 139–153 |
| Found 'DU'-anomaly for variable 'stationElement' (lines '140'-'203'). | 140–203 |
| Found 'DD'-anomaly for variable 'stationStart' (lines '141'-'181'). | 141–181 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '142'-'182'). | 142–182 |
| Avoid using if statements without curly braces | 158–159 |
| Avoid variables with short names like s | 163 |
| Avoid variables with short names like s | 163 |
| Avoid variables with short names like e | 167 |
| Avoid variables with short names like e | 167 |
| Found 'DD'-anomaly for variable 'stationEnd' (lines '169'-'182'). | 169–182 |
| Found 'DU'-anomaly for variable 'sta' (lines '176'-'203'). | 176–203 |
| Avoid using if statements without curly braces | 184–185 |
| Avoid using Literals in Conditional Statements | 184 |
| Local variable 'response' could be declared final | 190–191 |
| Avoid printStackTrace(); use a logger call instead. | 200 |
| Avoid variables with short names like c | 206 |
| Avoid variables with short names like c | 206 |
| Avoid variables with short names like e | 210 |
| Avoid variables with short names like e | 210 |
| Do not add empty strings | 212 |
| Do not add empty strings | 216 |
| Do not add empty strings | 220 |
| Avoid variables with short names like n | 224 |
| Avoid variables with short names like n | 224 |
| Avoid variables with short names like c | 232 |
| Avoid variables with short names like c | 232 |
| Position literals first in String comparisons | 234 |
| Avoid variables with short names like e | 238 |
| Avoid variables with short names like e | 238 |
| Do not add empty strings | 240 |
| Do not add empty strings | 244 |
| Do not add empty strings | 248 |
| Do not add empty strings | 253 |
| Parameter 'constraints' is not assigned and could be declared final | 259 |
| Avoid variables with short names like c | 259 |
| Avoid variables with short names like c | 259 |
| Local variable 'it' could be declared final | 261 |
| Avoid variables with short names like it | 261 |
| Avoid variables with short names like it | 261 |
| Avoid using if statements without curly braces | 263–264 |
| protectedMethodCommentRequirement Required | 269–278 |
| Parameter 'arguments' is not assigned and could be declared final | 269 |
| Local variable 'constraints' could be declared final | 271 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| It is a good practice to call super() in a constructor | 43–53 |
| Parameter 'arguments' is not assigned and could be declared final | 55 |
| publicMethodCommentRequirement Required | 55–68 |
| Local variable 'station' could be declared final | 56 |
| Local variable 'channel' could be declared final | 57 |
| Local variable 'network' could be declared final | 58 |
| Local variable 'location' could be declared final | 59 |
| Local variable 'startTime' could be declared final | 61 |
| Local variable 'endTime' could be declared final | 62 |
| Local variable 'chanConstraint' could be declared final | 64 |
| Parameter 'arguments' is not assigned and could be declared final | 70 |
| publicMethodCommentRequirement Required | 70–85 |
| Found 'UR'-anomaly for variable 'ch' (lines '70'-'77'). | 70–77 |
| Local variable 'constraints' could be declared final | 71 |
| Local variable 'chan' could be declared final | 75 |
| Local variable 'ch' could be declared final | 76 |
| Local variable 'chanParts' could be declared final | 77 |
| Local variable 'channelConstraint' could be declared final | 78 |
| Avoid instantiating new objects inside loops | 78 |
| Local variable 'timeConstraint' could be declared final | 79 |
| Avoid instantiating new objects inside loops | 79 |
| Avoid variables with short names like in | 97 |
| Avoid variables with short names like in | 97 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 97 |
| Avoid using if statements without curly braces | 98–99 |
| A method should have only one exit point, and that should be the last statement in the method | 99 |
| Avoid using if statements without curly braces | 100–101 |
| A method should have only one exit point, and that should be the last statement in the method | 101 |
| Avoid using if statements without curly braces | 102–103 |
| A method should have only one exit point, and that should be the last statement in the method | 103 |
| Avoid using if...else statements without curly braces | 117 |
| A method should have only one exit point, and that should be the last statement in the method | 117 |
| Avoid using if...else statements without curly braces | 119 |
| publicMethodCommentRequirement Required | 122–143 |
| Avoid using if statements without curly braces | 123–124 |
| A method should have only one exit point, and that should be the last statement in the method | 124 |
| Avoid using if statements without curly braces | 127–128 |
| A method should have only one exit point, and that should be the last statement in the method | 128 |
| Avoid using if statements without curly braces | 131–132 |
| A method should have only one exit point, and that should be the last statement in the method | 132 |
| Avoid using if statements without curly braces | 135–136 |
| A method should have only one exit point, and that should be the last statement in the method | 136 |
| Avoid unnecessary if..then..else statements when returning booleans | 139–140 |
| Avoid using if statements without curly braces | 139–140 |
| A method should have only one exit point, and that should be the last statement in the method | 140 |
| Avoid using if statements without curly braces | 153–154 |
| A method should have only one exit point, and that should be the last statement in the method | 154 |
| Avoid using if statements without curly braces | 157–158 |
| A method should have only one exit point, and that should be the last statement in the method | 158 |
| Avoid using if statements without curly braces | 161–162 |
| A method should have only one exit point, and that should be the last statement in the method | 162 |
| Avoid using if statements without curly braces | 165–166 |
| A method should have only one exit point, and that should be the last statement in the method | 166 |
| Avoid using if statements without curly braces | 169–170 |
| A method should have only one exit point, and that should be the last statement in the method | 170 |
| Avoid using if statements without curly braces | 172–173 |
| A method should have only one exit point, and that should be the last statement in the method | 173 |
| publicMethodCommentRequirement Required | 188–190 |
| Parameter 'inString' is not assigned and could be declared final | 192 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 192 |
| Found 'DD'-anomaly for variable 'outString' (lines '193'-'194'). | 193–194 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 18–43 |
| Abstract classes should be named AbstractXXX | 18–43 |
| protectedMethodCommentRequirement Required | 36–42 |
| Avoid variables with short names like s1 | 36 |
| Avoid variables with short names like s1 | 36 |
| Parameter 'arguments' is not assigned and could be declared final | 36 |
| Avoid variables with short names like s2 | 36 |
| Avoid variables with short names like s2 | 36 |
| Avoid using if statements without curly braces | 38–39 |
| Violation | Line |
|---|---|
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LATITUDE' is not final. | 23 |
| fieldCommentRequirement Required | 23 |
| Variables should start with a lowercase character, 'DEFAULT_LATITUDE' starts with uppercase character. | 23 |
| The field name indicates a constant but its modifiers do not | 23 |
| Avoid using redundant field initializer for 'DEFAULT_LATITUDE' | 23 |
| Variables should start with a lowercase character, 'DEFAULT_LATITUDE' starts with uppercase character. | 23 |
| The field name indicates a constant but its modifiers do not | 23 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LATITUDE' is not final. | 23 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LONGITUDE' is not final. | 24 |
| Avoid using redundant field initializer for 'DEFAULT_LONGITUDE' | 24 |
| Variables should start with a lowercase character, 'DEFAULT_LONGITUDE' starts with uppercase character. | 24 |
| The field name indicates a constant but its modifiers do not | 24 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_LONGITUDE' is not final. | 24 |
| fieldCommentRequirement Required | 24 |
| The field name indicates a constant but its modifiers do not | 24 |
| Variables should start with a lowercase character, 'DEFAULT_LONGITUDE' starts with uppercase character. | 24 |
| Avoid using redundant field initializer for 'DEFAULT_MINRADIUS' | 25 |
| The field name indicates a constant but its modifiers do not | 25 |
| The field name indicates a constant but its modifiers do not | 25 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MINRADIUS' is not final. | 25 |
| fieldCommentRequirement Required | 25 |
| Variables should start with a lowercase character, 'DEFAULT_MINRADIUS' starts with uppercase character. | 25 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MINRADIUS' is not final. | 25 |
| Variables should start with a lowercase character, 'DEFAULT_MINRADIUS' starts with uppercase character. | 25 |
| fieldCommentRequirement Required | 26 |
| The field name indicates a constant but its modifiers do not | 26 |
| Variables should start with a lowercase character, 'DEFAULT_MAXRADIUS' starts with uppercase character. | 26 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MAXRADIUS' is not final. | 26 |
| The field name indicates a constant but its modifiers do not | 26 |
| Variables should start with a lowercase character, 'DEFAULT_MAXRADIUS' starts with uppercase character. | 26 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'DEFAULT_MAXRADIUS' is not final. | 26 |
| fieldCommentRequirement Required | 28 |
| Private field 'point' could be made final; it is only initialized in the declaration or constructor. | 28 |
| fieldCommentRequirement Required | 29 |
| Private field 'minRadius' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Private field 'maxRadius' could be made final; it is only initialized in the declaration or constructor. | 30 |
| fieldCommentRequirement Required | 30 |
| It is a good practice to call super() in a constructor | 40–49 |
| publicMethodCommentRequirement Required | 51–64 |
| Avoid variables with short names like i | 52 |
| Avoid variables with short names like i | 52 |
| A method should have only one exit point, and that should be the last statement in the method | 57 |
| Avoid variables with short names like p | 60 |
| Avoid variables with short names like p | 60 |
| Useless parentheses. | 63 |
| publicMethodCommentRequirement Required | 67–70 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 7–26 |
| Abstract classes should be named AbstractXXX | 7–26 |
| headerCommentRequirement Required | 7–26 |
| Parameter 'arguments' is not assigned and could be declared final | 9 |
| publicMethodCommentRequirement Required | 9–25 |
| Avoid if (x != y) ..; else ..; | 15–24 |
| A method should have only one exit point, and that should be the last statement in the method | 16 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like DEFAULT_MINLATITUDE | 21 |
| fieldCommentRequirement Required | 21 |
| Avoid excessively long variable names like DEFAULT_MINLATITUDE | 21 |
| Avoid excessively long variable names like DEFAULT_MAXLATITUDE | 22 |
| fieldCommentRequirement Required | 22 |
| Avoid excessively long variable names like DEFAULT_MAXLATITUDE | 22 |
| fieldCommentRequirement Required | 23 |
| Avoid excessively long variable names like DEFAULT_MINLONGITUDE | 23 |
| Avoid excessively long variable names like DEFAULT_MINLONGITUDE | 23 |
| fieldCommentRequirement Required | 24 |
| Avoid excessively long variable names like DEFAULT_MAXLONGITUDE | 24 |
| Avoid excessively long variable names like DEFAULT_MAXLONGITUDE | 24 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| It is a good practice to call super() in a constructor | 40–48 |
| publicMethodCommentRequirement Required | 50–66 |
| Avoid variables with short names like i | 51 |
| Avoid variables with short names like i | 51 |
| Avoid using if statements without curly braces | 53–54 |
| A method should have only one exit point, and that should be the last statement in the method | 54 |
| Avoid using if statements without curly braces | 56–57 |
| A method should have only one exit point, and that should be the last statement in the method | 57 |
| Avoid using if statements without curly braces | 59–60 |
| A method should have only one exit point, and that should be the last statement in the method | 60 |
| Avoid using if statements without curly braces | 62–63 |
| Avoid unnecessary if..then..else statements when returning booleans | 62–63 |
| A method should have only one exit point, and that should be the last statement in the method | 63 |
| publicMethodCommentRequirement Required | 69–72 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.Map' | 9 |
| Avoid unused imports such as 'gov.usgs.volcanoes.winston.server.http.cmd.fdsnws.FdsnException' | 16 |
| Abstract classes should be named AbstractXXX | 25–47 |
| Each class should declare at least one constructor | 25–47 |
| Abstract classes should be named AbstractXXX | 25–47 |
| Avoid unused private fields such as 'LOGGER'. | 26 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| Avoid variables with short names like s2 | 31 |
| protectedMethodCommentRequirement Required | 31–46 |
| Avoid variables with short names like s2 | 31 |
| Avoid variables with short names like s1 | 31 |
| Avoid variables with short names like s1 | 31 |
| Avoid variables with short names like s | 32 |
| Avoid variables with short names like s | 32 |
| Avoid using if statements without curly braces | 33–34 |
| Prefer StringBuffer over += for concatenating strings | 34 |
| Avoid using if...else statements without curly braces | 38 |
| Prefer StringBuffer over += for concatenating strings | 38 |
| Avoid using if...else statements without curly braces | 40 |
| Avoid using if...else statements without curly braces | 42–43 |
| Avoid using while statements without curly braces | 42–43 |
| Prefer StringBuffer over += for concatenating strings | 43 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| Overridable method 'toString' called during object construction | 45 |
| New exception is thrown in catch block, original stack trace may be lost | 46 |
| Overridable method 'toString' called during object construction | 46 |
| publicMethodCommentRequirement Required | 50–62 |
| A method should have only one exit point, and that should be the last statement in the method | 53 |
| Avoid unnecessary if..then..else statements when returning booleans | 57–59 |
| A method should have only one exit point, and that should be the last statement in the method | 58 |
| publicMethodCommentRequirement Required | 64–76 |
| A method should have only one exit point, and that should be the last statement in the method | 67 |
| Avoid unnecessary if..then..else statements when returning booleans | 71–73 |
| A method should have only one exit point, and that should be the last statement in the method | 72 |
| publicMethodCommentRequirement Required | 79–82 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'gov.usgs.earthworm.message.TraceBuf' | 11 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| New exception is thrown in catch block, original stack trace may be lost | 47 |
| publicMethodCommentRequirement Required | 52–62 |
| Avoid using if statements without curly braces | 54–55 |
| A method should have only one exit point, and that should be the last statement in the method | 55 |
| Avoid unnecessary if..then..else statements when returning booleans | 58–59 |
| Avoid using if statements without curly braces | 58–59 |
| A method should have only one exit point, and that should be the last statement in the method | 59 |
| publicMethodCommentRequirement Required | 65–69 |
| publicMethodCommentRequirement Required | 71–77 |
| Parameter 'arguments' is not assigned and could be declared final | 71 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 19 |
| Parameter 'msg' is not assigned and could be declared final | 26 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 26 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 23–70 |
| Abstract classes should be named AbstractXXX | 23–70 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 29 |
| Avoid unnecessary constructors - the compiler will generate these for you | 34–36 |
| Parameter 'maxDays' is not assigned and could be declared final | 42 |
| Parameter 'req' is not assigned and could be declared final | 54 |
| Parameter 'ctx' is not assigned and could be declared final | 54 |
| protectedMethodCommentRequirement Required | 60–69 |
| Local variable 'decimalFormat' could be declared final | 62 |
| New exception is thrown in catch block, original stack trace may be lost | 67 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 25 |
| Violation | Line |
|---|---|
| Parameter 'clazz' is not assigned and could be declared final | 68 |
| Parameter 'command' is not assigned and could be declared final | 82 |
| Found 'UR'-anomaly for variable 'cmd' (lines '82'-'85'). | 82–85 |
| Parameter 'databasePool' is not assigned and could be declared final | 82 |
| Local variable 'cmd' could be declared final | 84 |
| Local variable 'baseCommand' could be declared final | 86 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| Avoid excessively long variable names like winstonDatabasePool | 32 |
| Avoid excessively long variable names like winstonDatabasePool | 32 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| Perhaps 'connectionStatistics' could be replaced by a local variable. | 34 |
| Avoid excessively long variable names like connectionStatistics | 34 |
| Avoid excessively long variable names like connectionStatistics | 34 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 36 |
| Avoid excessively long variable names like connectionStatsKey | 36 |
| fieldCommentRequirement Required | 36 |
| Avoid excessively long variable names like connectionStatsKey | 36 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 36 |
| It is a good practice to call super() in a constructor | 48–51 |
| Parameter 'winstonDatabasePool' is not assigned and could be declared final | 48 |
| Parameter 'configFile' is not assigned and could be declared final | 48 |
| Avoid excessively long variable names like winstonDatabasePool | 48 |
| Avoid excessively long variable names like winstonDatabasePool | 48 |
| publicMethodCommentRequirement Required | 54–70 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 54 |
| Parameter 'ctx' is not assigned and could be declared final | 54 |
| Parameter 'request' is not assigned and could be declared final | 54 |
| publicMethodCommentRequirement Required | 73–75 |
| Parameter 'ctx' is not assigned and could be declared final | 73 |
| Parameter 'ctx' is not assigned and could be declared final | 78 |
| publicMethodCommentRequirement Required | 78–81 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 78 |
| Parameter 'cause' is not assigned and could be declared final | 78 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| fieldCommentRequirement Required | 24 |
| Local variable 'cmdEnd' could be declared final | 34 |
| Avoid variables with short names like i | 74 |
| Avoid variables with short names like i | 74 |
| A method should have only one exit point, and that should be the last statement in the method | 76 |
| Avoid using if...else statements without curly braces | 76 |
| Avoid using if...else statements without curly braces | 78 |
| Avoid variables with short names like i | 86 |
| Avoid variables with short names like i | 86 |
| Found 'DD'-anomaly for variable 'result' (lines '87'-'89'). | 87–89 |
| Avoid empty catch blocks | 90–91 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 90 |
| Avoid variables with short names like i | 100 |
| Avoid variables with short names like i | 100 |
| Found 'DD'-anomaly for variable 'result' (lines '101'-'103'). | 101–103 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 104 |
| Avoid empty catch blocks | 104–105 |
| Avoid using Literals in Conditional Statements | 114 |
| Avoid using if...else statements without curly braces | 115 |
| A method should have only one exit point, and that should be the last statement in the method | 115 |
| Avoid using if...else statements without curly braces | 117 |
| Avoid using Literals in Conditional Statements | 125 |
| A method should have only one exit point, and that should be the last statement in the method | 126 |
| Avoid using if...else statements without curly braces | 126 |
| Found 'DD'-anomaly for variable 'loc' (lines '128'-'130'). | 128–130 |
| Avoid using if statements without curly braces | 129–130 |
| Found 'DD'-anomaly for variable 'ofs' (lines '141'-'143'). | 141–143 |
| Avoid using if statements without curly braces | 142–143 |
| Avoid using if...else statements without curly braces | 145 |
| A method should have only one exit point, and that should be the last statement in the method | 145 |
| Avoid using if...else statements without curly braces | 147 |
| Found 'DD'-anomaly for variable 'ofs' (lines '156'-'158'). | 156–158 |
| Avoid using if statements without curly braces | 157–158 |
| A method should have only one exit point, and that should be the last statement in the method | 160 |
| Avoid using if...else statements without curly braces | 160 |
| Avoid using if...else statements without curly braces | 162 |
| Avoid using if statements without curly braces | 188–189 |
| A method should have only one exit point, and that should be the last statement in the method | 189 |
| Avoid using if statements without curly braces | 191–192 |
| Avoid unnecessary if..then..else statements when returning booleans | 191–192 |
| A method should have only one exit point, and that should be the last statement in the method | 192 |
| Avoid using if statements without curly braces | 203–204 |
| A method should have only one exit point, and that should be the last statement in the method | 204 |
| Avoid unnecessary if..then..else statements when returning booleans | 206–207 |
| Avoid using if statements without curly braces | 206–207 |
| A method should have only one exit point, and that should be the last statement in the method | 207 |
| Avoid using Literals in Conditional Statements | 217 |
| Avoid using if statements without curly braces | 217–218 |
| A method should have only one exit point, and that should be the last statement in the method | 218 |
| Avoid using if statements without curly braces | 228–229 |
| Avoid using Literals in Conditional Statements | 228 |
| A method should have only one exit point, and that should be the last statement in the method | 229 |
| Avoid using if statements without curly braces | 239–240 |
| Avoid using Literals in Conditional Statements | 239 |
| A method should have only one exit point, and that should be the last statement in the method | 240 |
| Avoid using Literals in Conditional Statements | 250 |
| Avoid using if statements without curly braces | 250–251 |
| A method should have only one exit point, and that should be the last statement in the method | 251 |
| publicMethodCommentRequirement Required | 257–260 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 20–26 |
| protectedMethodCommentRequirement Required | 23–25 |
| Parameter 'command' is not assigned and could be declared final | 23 |
| Parameter 'out' is not assigned and could be declared final | 23 |
| Parameter 'ctx' is not assigned and could be declared final | 23 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 23 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 23–71 |
| Abstract classes should be named AbstractXXX | 23–71 |
| Abstract classes should be named AbstractXXX | 23–71 |
| fieldCommentRequirement Required | 24 |
| Parameter 'delimiter' is not assigned and could be declared final | 26 |
| Parameter 'cmd' is not assigned and could be declared final | 26 |
| protectedMethodCommentRequirement Required | 26–41 |
| Avoid variables with short names like s | 27 |
| Avoid variables with short names like s | 27 |
| Avoid variables with short names like c | 28 |
| Avoid variables with short names like c | 28 |
| Avoid variables with short names like n | 29 |
| Avoid variables with short names like n | 29 |
| Avoid variables with short names like l | 34 |
| Avoid variables with short names like l | 34 |
| Avoid using Literals in Conditional Statements | 35 |
| Prefer StringBuffer over += for concatenating strings | 36 |
| protectedMethodCommentRequirement Required | 43–55 |
| Avoid using final local variables, turn them into fields | 44 |
| Found 'DU'-anomaly for variable 'chanId' (lines '46'-'55'). | 46–55 |
| Found 'DU'-anomaly for variable 'chanId' (lines '46'-'55'). | 46–55 |
| publicMethodCommentRequirement Required | 47–49 |
| Parameter 'winston' is not assigned and could be declared final | 47 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 51 |
| New exception is thrown in catch block, original stack trace may be lost | 52 |
| protectedMethodCommentRequirement Required | 57–69 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '60'-'69'). | 60–69 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '60'-'69'). | 60–69 |
| Parameter 'winston' is not assigned and could be declared final | 61 |
| publicMethodCommentRequirement Required | 61–63 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 65 |
| New exception is thrown in catch block, original stack trace may be lost | 66 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 32 |
| Avoid unnecessary constructors - the compiler will generate these for you | 37–39 |
| publicMethodCommentRequirement Required | 41–78 |
| Parameter 'cmd' is not assigned and could be declared final | 41 |
| Parameter 'ctx' is not assigned and could be declared final | 41 |
| Avoid using final local variables, turn them into fields | 48 |
| Found 'DD'-anomaly for variable 'chs' (lines '55'-'57'). | 55–57 |
| Found 'DD'-anomaly for variable 'chs' (lines '55'-'57'). | 55–57 |
| Found 'DU'-anomaly for variable 'chs' (lines '57'-'78'). | 57–78 |
| Found 'DU'-anomaly for variable 'chs' (lines '57'-'78'). | 57–78 |
| Parameter 'winston' is not assigned and could be declared final | 58 |
| publicMethodCommentRequirement Required | 58–62 |
| Local variable 'channels' could be declared final | 59 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 64 |
| New exception is thrown in catch block, original stack trace may be lost | 65 |
| Avoid variables with short names like sb | 68 |
| Avoid variables with short names like sb | 68 |
| Avoid using if...else statements without curly braces | 72 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 72 |
| Avoid using if...else statements without curly braces | 74 |
| Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 74 |
| Violation | Line |
|---|---|
| Avoid unnecessary constructors - the compiler will generate these for you | 34–36 |
| Parameter 'ctx' is not assigned and could be declared final | 38 |
| Parameter 'cmd' is not assigned and could be declared final | 38 |
| publicMethodCommentRequirement Required | 38–63 |
| Avoid variables with short names like ss | 40 |
| Avoid variables with short names like ss | 40 |
| Avoid using Literals in Conditional Statements | 41 |
| Local variable 'sb' could be declared final | 45 |
| Avoid variables with short names like sb | 45 |
| Found 'DU'-anomaly for variable 'sb' (lines '45'-'63'). | 45–63 |
| Avoid variables with short names like sb | 45 |
| Local variable 'instruments' could be declared final | 48 |
| Local variable 'channels' could be declared final | 53 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 57 |
| New exception is thrown in catch block, original stack trace may be lost | 58 |
| publicMethodCommentRequirement Required | 68–70 |
| Parameter 'winston' is not assigned and could be declared final | 68 |
| Parameter 'winston' is not assigned and could be declared final | 77 |
| publicMethodCommentRequirement Required | 77–79 |
| Found 'UR'-anomaly for variable 'inst' (lines '83'-'87'). | 83–87 |
| Parameter 'insts' is not assigned and could be declared final | 83 |
| Avoid variables with short names like sb | 84 |
| StringBuffer constructor is initialized with size 16, but has at least 60 characters appended. | 84 |
| Avoid variables with short names like sb | 84 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 88 |
| Avoid appending characters as strings in StringBuffer.append. | 88 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 91 |
| Avoid appending characters as strings in StringBuffer.append. | 91 |
| Avoid appending characters as strings in StringBuffer.append. | 94 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 94 |
| Avoid appending characters as strings in StringBuffer.append. | 97 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 97 |
| Avoid appending characters as strings in StringBuffer.append. | 100 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 100 |
| Avoid appending characters as strings in StringBuffer.append. | 103 |
| Avoid appending characters as strings in StringBuffer.append. | 105 |
| Parameter 'chs' is not assigned and could be declared final | 110 |
| Found 'UR'-anomaly for variable 'ch' (lines '110'-'114'). | 110–114 |
| StringBuffer constructor is initialized with size 16, but has at least 75 characters appended. | 111 |
| Avoid variables with short names like sb | 111 |
| Avoid variables with short names like sb | 111 |
| Avoid appending characters as strings in StringBuffer.append. | 115 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 115 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 118 |
| Avoid appending characters as strings in StringBuffer.append. | 118 |
| Avoid appending characters as strings in StringBuffer.append. | 121 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 121 |
| Avoid appending characters as strings in StringBuffer.append. | 124 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 124 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 127 |
| Avoid appending characters as strings in StringBuffer.append. | 127 |
| Avoid appending characters as strings in StringBuffer.append. | 130 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 130 |
| Avoid appending characters as strings in StringBuffer.append. | 133 |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 133 |
| Avoid appending characters as strings in StringBuffer.append. | 136 |
| Avoid appending characters as strings in StringBuffer.append. | 138 |
| Avoid appending characters as strings in StringBuffer.append. | 140 |
| Avoid variables with short names like s | 145 |
| Avoid variables with short names like s | 145 |
| Avoid using if statements without curly braces | 146–147 |
| A method should have only one exit point, and that should be the last statement in the method | 147 |
| Avoid variables with short names like sb | 151 |
| Avoid variables with short names like sb | 151 |
| Found 'UR'-anomaly for variable 'key' (lines '151'-'156'). | 151–156 |
| Avoid using if statements without curly braces | 152–153 |
| Avoid appending characters as strings in StringBuffer.append. | 158 |
| Avoid appending characters as strings in StringBuffer.append. | 160 |
| Avoid variables with short names like sb | 164 |
| Found 'UR'-anomaly for variable 'value' (lines '164'-'170'). | 164–170 |
| Avoid variables with short names like sb | 164 |
| Avoid appending characters as strings in StringBuffer.append. | 166 |
| Avoid using if statements without curly braces | 167–168 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 29 |
| Parameter 'cmd' is not assigned and could be declared final | 39 |
| Parameter 'ctx' is not assigned and could be declared final | 39 |
| publicMethodCommentRequirement Required | 39–136 |
| Avoid using if statements without curly braces | 41–42 |
| Avoid variables with short names like id | 44 |
| Avoid variables with short names like id | 44 |
| Found 'DU'-anomaly for variable 'startTime' (lines '48'-'136'). | 48–136 |
| Found 'DU'-anomaly for variable 'startTime' (lines '48'-'136'). | 48–136 |
| Found 'DU'-anomaly for variable 'endTime' (lines '49'-'136'). | 49–136 |
| Found 'DU'-anomaly for variable 'endTime' (lines '49'-'136'). | 49–136 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 49 |
| A method should have only one exit point, and that should be the last statement in the method | 54 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '57'-'136'). | 57–136 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '57'-'136'). | 57–136 |
| Local variable 'hdrPreamble' could be declared final | 59 |
| Found 'DU'-anomaly for variable 'hdrPreamble' (lines '59'-'136'). | 59–136 |
| Found 'DU'-anomaly for variable 'hdrPreamble' (lines '59'-'136'). | 59–136 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'62'). | 60–62 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'66'). | 60–66 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'64'). | 60–64 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'64'). | 60–64 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'66'). | 60–66 |
| Found 'DD'-anomaly for variable 'errorString' (lines '60'-'62'). | 60–62 |
| A method should have only one exit point, and that should be the last statement in the method | 71 |
| Avoid using final local variables, turn them into fields | 74 |
| Found 'DU'-anomaly for variable 'wave' (lines '76'-'136'). | 76–136 |
| Found 'DU'-anomaly for variable 'wave' (lines '76'-'136'). | 76–136 |
| publicMethodCommentRequirement Required | 77–81 |
| Parameter 'winston' is not assigned and could be declared final | 77 |
| Avoid variables with short names like st | 78 |
| Local variable 'st' could be declared final | 78 |
| Avoid variables with short names like st | 78 |
| Avoid variables with short names like et | 79 |
| Avoid variables with short names like et | 79 |
| Local variable 'et' could be declared final | 79 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 83 |
| New exception is thrown in catch block, original stack trace may be lost | 84 |
| Avoid variables with short names like ct | 98 |
| Avoid variables with short names like ct | 98 |
| Avoid variables with short names like dt | 99 |
| Avoid variables with short names like dt | 99 |
| Avoid using if statements without curly braces | 101–102 |
| Avoid variables with short names like bb | 106 |
| Avoid variables with short names like bb | 106 |
| Avoid using if...else statements without curly braces | 124 |
| Avoid using if...else statements without curly braces | 126 |
| Avoid using if statements without curly braces | 130–131 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 31 |
| Avoid unnecessary constructors - the compiler will generate these for you | 36–38 |
| Parameter 'cmd' is not assigned and could be declared final | 40 |
| Parameter 'ctx' is not assigned and could be declared final | 40 |
| publicMethodCommentRequirement Required | 40–80 |
| Avoid variables with short names like et | 46 |
| Avoid variables with short names like et | 46 |
| Avoid variables with short names like st | 47 |
| Avoid variables with short names like st | 47 |
| Found 'DU'-anomaly for variable 'scnl' (lines '48'-'80'). | 48–80 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 48 |
| Found 'DU'-anomaly for variable 'scnl' (lines '48'-'80'). | 48–80 |
| Found 'DU'-anomaly for variable 'heli' (lines '56'-'80'). | 56–80 |
| Found 'DU'-anomaly for variable 'heli' (lines '56'-'80'). | 56–80 |
| Parameter 'winston' is not assigned and could be declared final | 58 |
| publicMethodCommentRequirement Required | 58–61 |
| Local variable 'data' could be declared final | 59 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 63 |
| New exception is thrown in catch block, original stack trace may be lost | 64 |
| Avoid variables with short names like bb | 67 |
| Avoid variables with short names like bb | 67 |
| Avoid using if statements without curly braces | 71–72 |
| Avoid using Literals in Conditional Statements | 71 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 34 |
| Parameter 'ctx' is not assigned and could be declared final | 44 |
| Parameter 'cmd' is not assigned and could be declared final | 44 |
| publicMethodCommentRequirement Required | 44–122 |
| Avoid using if statements without curly braces | 46–47 |
| Avoid variables with short names like id | 49 |
| Avoid variables with short names like id | 49 |
| Found 'DU'-anomaly for variable 'startTime' (lines '53'-'122'). | 53–122 |
| Found 'DU'-anomaly for variable 'startTime' (lines '53'-'122'). | 53–122 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 54 |
| Found 'DU'-anomaly for variable 'endTime' (lines '54'-'122'). | 54–122 |
| Found 'DU'-anomaly for variable 'endTime' (lines '54'-'122'). | 54–122 |
| A method should have only one exit point, and that should be the last statement in the method | 59 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '62'-'122'). | 62–122 |
| Found 'DU'-anomaly for variable 'timeSpan' (lines '62'-'122'). | 62–122 |
| Found 'DU'-anomaly for variable 'hdrPreamble' (lines '64'-'122'). | 64–122 |
| Local variable 'hdrPreamble' could be declared final | 64 |
| Found 'DU'-anomaly for variable 'hdrPreamble' (lines '64'-'122'). | 64–122 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'69'). | 65–69 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'69'). | 65–69 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'71'). | 65–71 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'67'). | 65–67 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'71'). | 65–71 |
| Found 'DD'-anomaly for variable 'errorString' (lines '65'-'67'). | 65–67 |
| A method should have only one exit point, and that should be the last statement in the method | 76 |
| Avoid using final local variables, turn them into fields | 79 |
| Found 'DU'-anomaly for variable 'bufs' (lines '81'-'122'). | 81–122 |
| Found 'DU'-anomaly for variable 'bufs' (lines '81'-'122'). | 81–122 |
| publicMethodCommentRequirement Required | 82–86 |
| Parameter 'winston' is not assigned and could be declared final | 82 |
| Avoid variables with short names like st | 83 |
| Avoid variables with short names like st | 83 |
| Local variable 'st' could be declared final | 83 |
| Avoid variables with short names like et | 84 |
| Local variable 'et' could be declared final | 84 |
| Avoid variables with short names like et | 84 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 88 |
| New exception is thrown in catch block, original stack trace may be lost | 89 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 92 |
| Avoid using final local variables, turn them into fields | 98 |
| Avoid using final local variables, turn them into fields | 99 |
| New exception is thrown in catch block, original stack trace may be lost | 104 |
| Local variable 'hdr' could be declared final | 112–113 |
| Avoid variables with short names like bb | 116 |
| Avoid variables with short names like bb | 116 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 32 |
| Avoid unnecessary constructors - the compiler will generate these for you | 37–39 |
| Parameter 'ctx' is not assigned and could be declared final | 41 |
| Parameter 'cmd' is not assigned and could be declared final | 41 |
| publicMethodCommentRequirement Required | 41–78 |
| Avoid variables with short names like t1 | 48 |
| Avoid variables with short names like t1 | 48 |
| Avoid variables with short names like t2 | 49 |
| Avoid variables with short names like t2 | 49 |
| Avoid variables with short names like ds | 50 |
| Avoid variables with short names like ds | 50 |
| Useless parentheses. | 52 |
| Found 'DU'-anomaly for variable 'rsam' (lines '56'-'78'). | 56–78 |
| Found 'DU'-anomaly for variable 'rsam' (lines '56'-'78'). | 56–78 |
| Parameter 'winston' is not assigned and could be declared final | 57 |
| publicMethodCommentRequirement Required | 57–59 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 62 |
| New exception is thrown in catch block, original stack trace may be lost | 63 |
| Avoid variables with short names like bb | 66 |
| Avoid variables with short names like bb | 66 |
| Avoid using if statements without curly braces | 67–68 |
| Avoid using Literals in Conditional Statements | 70 |
| Avoid using if statements without curly braces | 70–71 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 31 |
| Avoid unused private fields such as 'LOGGER'. | 31 |
| Avoid unnecessary constructors - the compiler will generate these for you | 36–38 |
| Parameter 'cmd' is not assigned and could be declared final | 40 |
| Parameter 'ctx' is not assigned and could be declared final | 40 |
| publicMethodCommentRequirement Required | 40–102 |
| Avoid using if statements without curly braces | 43–44 |
| Avoid variables with short names like et | 46 |
| Avoid variables with short names like et | 46 |
| Avoid variables with short names like st | 47 |
| Avoid variables with short names like st | 47 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 48 |
| Found 'DU'-anomaly for variable 'scnl' (lines '48'-'102'). | 48–102 |
| Found 'DU'-anomaly for variable 'scnl' (lines '48'-'102'). | 48–102 |
| Found 'DU'-anomaly for variable 'winston' (lines '54'-'102'). | 54–102 |
| Found 'DU'-anomaly for variable 'winston' (lines '54'-'102'). | 54–102 |
| Avoid unused local variables such as 'winston'. | 54 |
| Local variable 'winston' could be declared final | 54 |
| Found 'DU'-anomaly for variable 'wave' (lines '57'-'102'). | 57–102 |
| Found 'DU'-anomaly for variable 'wave' (lines '57'-'102'). | 57–102 |
| Parameter 'winston' is not assigned and could be declared final | 59 |
| publicMethodCommentRequirement Required | 59–62 |
| Local variable 'data' could be declared final | 60 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 64 |
| New exception is thrown in catch block, original stack trace may be lost | 65 |
| Avoid variables with short names like bb | 85 |
| Avoid variables with short names like bb | 85 |
| Avoid using if...else statements without curly braces | 87 |
| Avoid using if...else statements without curly braces | 89 |
| Avoid variables with short names like id | 91 |
| Local variable 'id' could be declared final | 91 |
| Avoid variables with short names like id | 91 |
| Avoid using if statements without curly braces | 93–94 |
| Avoid using Literals in Conditional Statements | 93 |
| Avoid if (x != y) ..; else ..; | 96–101 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 37 |
| Avoid unnecessary constructors - the compiler will generate these for you | 42–44 |
| publicMethodCommentRequirement Required | 46–76 |
| Parameter 'cmd' is not assigned and could be declared final | 46 |
| Parameter 'ctx' is not assigned and could be declared final | 46 |
| Found 'DD'-anomaly for variable 'isScnl' (lines '49'-'53'). | 49–53 |
| Found 'DD'-anomaly for variable 'isScnl' (lines '49'-'53'). | 49–53 |
| Found 'DU'-anomaly for variable 'isScnl' (lines '49'-'76'). | 49–76 |
| Found 'DU'-anomaly for variable 'isScnl' (lines '49'-'76'). | 49–76 |
| Avoid using Literals in Conditional Statements | 51 |
| Found 'DU'-anomaly for variable 'isScnl' (lines '53'-'76'). | 53–76 |
| Found 'DU'-anomaly for variable 'isScnl' (lines '53'-'76'). | 53–76 |
| Avoid using Literals in Conditional Statements | 55 |
| Found 'DU'-anomaly for variable 'channels' (lines '63'-'76'). | 63–76 |
| Found 'DU'-anomaly for variable 'channels' (lines '63'-'76'). | 63–76 |
| Parameter 'winston' is not assigned and could be declared final | 65 |
| publicMethodCommentRequirement Required | 65–67 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 70 |
| New exception is thrown in catch block, original stack trace may be lost | 71 |
| Found 'UR'-anomaly for variable 'chan' (lines '86'-'98'). | 86–98 |
| Parameter 'isScnl' is not assigned and could be declared final | 86 |
| Parameter 'channels' is not assigned and could be declared final | 86 |
| A method should have only one exit point, and that should be the last statement in the method | 90 |
| Local variable 'decimalFormat' could be declared final | 93 |
| Found 'DU'-anomaly for variable 'decimalFormat' (lines '93'-'119'). | 93–119 |
| Found 'DD'-anomaly for variable 'ss' (lines '98'-'98'). | 98 |
| Avoid variables with short names like ss | 98 |
| Found 'DU'-anomaly for variable 'ss' (lines '98'-'119'). | 98–119 |
| Avoid variables with short names like ss | 98 |
| Avoid variables with short names like ts | 99 |
| Avoid variables with short names like ts | 99 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 34 |
| Avoid excessively long variable names like connectionStatistics | 34 |
| Avoid excessively long variable names like connectionStatistics | 34 |
| Perhaps 'connectionStatistics' could be replaced by a local variable. | 34 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 36 |
| Avoid excessively long variable names like connectionStatsKey | 36 |
| Variables that are final and static should be all capitals, 'connectionStatsKey' is not all capitals. | 36 |
| Avoid excessively long variable names like connectionStatsKey | 36 |
| fieldCommentRequirement Required | 36 |
| Avoid unnecessary constructors - the compiler will generate these for you | 45–47 |
| Parameter 'ctx' is not assigned and could be declared final | 49 |
| Parameter 'cmd' is not assigned and could be declared final | 49 |
| publicMethodCommentRequirement Required | 49–93 |
| Found 'DU'-anomaly for variable 'ageThreshold' (lines '52'-'93'). | 52–93 |
| Found 'DU'-anomaly for variable 'ageThreshold' (lines '52'-'93'). | 52–93 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 52 |
| Found 'DU'-anomaly for variable 'now' (lines '53'-'93'). | 53–93 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 53 |
| Found 'DU'-anomaly for variable 'now' (lines '53'-'93'). | 53–93 |
| Avoid variables with short names like sb | 55 |
| Avoid variables with short names like sb | 55 |
| Found 'DD'-anomaly for variable 'lines' (lines '56'-'60'). | 56–60 |
| Found 'DD'-anomaly for variable 'lines' (lines '56'-'60'). | 56–60 |
| Found 'DU'-anomaly for variable 'lines' (lines '60'-'93'). | 60–93 |
| Found 'DU'-anomaly for variable 'lines' (lines '60'-'93'). | 60–93 |
| Found 'DU'-anomaly for variable 'sts' (lines '64'-'93'). | 64–93 |
| Found 'DU'-anomaly for variable 'sts' (lines '64'-'93'). | 64–93 |
| Parameter 'winston' is not assigned and could be declared final | 65 |
| publicMethodCommentRequirement Required | 65–67 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 69 |
| New exception is thrown in catch block, original stack trace may be lost | 70 |
| Avoid using for statements without curly braces | 77–79 |
| Avoid using if statements without curly braces | 78–79 |
| Avoid using if statements without curly braces | 81–82 |
| Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 81 |
| Avoid variables with short names like d | 84 |
| Avoid variables with short names like d | 84 |
| Violation | Line |
|---|---|
| fieldCommentRequirement Required | 23 |
| Avoid unnecessary constructors - the compiler will generate these for you | 28–30 |
| publicMethodCommentRequirement Required | 32–36 |
| Parameter 'ctx' is not assigned and could be declared final | 32 |
| Parameter 'cmd' is not assigned and could be declared final | 32 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 11–50 |
| enumCommentRequirement Required | 13–15 |
| fieldCommentRequirement Required | 17 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 20 |
| Perhaps 'fileB' could be replaced by a local variable. | 20 |
| Avoid variables with short names like fc | 21 |
| fieldCommentRequirement Required | 21 |
| Avoid variables with short names like fc | 21 |
| Avoid variables with short names like t | 23 |
| Avoid variables with short names like t | 23 |
| publicMethodCommentRequirement Required | 23–41 |
| Avoid variables with short names like e | 30 |
| publicMethodCommentRequirement Required | 30–36 |
| Avoid variables with short names like e | 30 |
| Avoid using if...else statements without curly braces | 32 |
| Avoid using if...else statements without curly braces | 34 |
| publicMethodCommentRequirement Required | 43–45 |
| Avoid variables with short names like fn | 47 |
| publicMethodCommentRequirement Required | 47–49 |
| Avoid variables with short names like fn | 47 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 6–57 |
| fieldCommentRequirement Required | 8 |
| fieldCommentRequirement Required | 10 |
| fieldCommentRequirement Required | 11 |
| fieldCommentRequirement Required | 12 |
| fieldCommentRequirement Required | 13 |
| publicMethodCommentRequirement Required | 15–26 |
| publicMethodCommentRequirement Required | 28–34 |
| Avoid variables with short names like s | 28 |
| Avoid variables with short names like s | 28 |
| publicMethodCommentRequirement Required | 36–43 |
| Avoid variables with short names like c | 36 |
| Avoid variables with short names like c | 36 |
| Avoid variables with short names like s | 37 |
| Avoid variables with short names like s | 37 |
| Avoid variables with short names like l | 38 |
| Avoid variables with short names like l | 38 |
| Position literals first in String comparisons | 39 |
| Position literals first in String comparisons | 39 |
| Avoid using if...else statements without curly braces | 40 |
| A method should have only one exit point, and that should be the last statement in the method | 40 |
| Avoid using if...else statements without curly braces | 42 |
| publicMethodCommentRequirement Required | 45–52 |
| Avoid variables with short names like c | 45 |
| Avoid variables with short names like c | 45 |
| Avoid variables with short names like s | 46 |
| Avoid variables with short names like s | 46 |
| Avoid variables with short names like l | 47 |
| Avoid variables with short names like l | 47 |
| Position literals first in String comparisons | 48 |
| Avoid using if statements without curly braces | 48–49 |
| publicMethodCommentRequirement Required | 54–56 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 27–202 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| Avoid variables with short names like d | 37 |
| fieldCommentRequirement Required | 37 |
| Avoid variables with short names like d | 37 |
| fieldCommentRequirement Required | 38 |
| Avoid variables with short names like o | 59 |
| Avoid variables with short names like o | 59 |
| publicMethodCommentRequirement Required | 64–66 |
| publicMethodCommentRequirement Required | 68–70 |
| Avoid variables with short names like b | 68 |
| Avoid variables with short names like b | 68 |
| Avoid variables with short names like t | 73 |
| Avoid variables with short names like t | 73 |
| Avoid variables with short names like p | 87 |
| Avoid variables with short names like p | 87 |
| publicMethodCommentRequirement Required | 90–92 |
| Avoid variables with short names like e | 90 |
| Avoid variables with short names like e | 90 |
| Avoid variables with short names like e | 97 |
| publicMethodCommentRequirement Required | 97–100 |
| Avoid variables with short names like e | 97 |
| Avoid variables with short names like e | 107 |
| Avoid variables with short names like e | 107 |
| publicMethodCommentRequirement Required | 107–109 |
| Avoid variables with short names like a | 117 |
| publicMethodCommentRequirement Required | 117–119 |
| Avoid variables with short names like a | 117 |
| Avoid variables with short names like b | 121 |
| Avoid variables with short names like b | 121 |
| publicMethodCommentRequirement Required | 121–124 |
| publicMethodCommentRequirement Required | 126–130 |
| headerCommentRequirement Required | 132–154 |
| Use explicit scoping instead of the default package private level | 133 |
| fieldCommentRequirement Required | 133 |
| Avoid variables with short names like ta | 133 |
| Avoid variables with short names like ta | 133 |
| publicMethodCommentRequirement Required | 135–137 |
| Avoid variables with short names like t | 135 |
| Avoid variables with short names like t | 135 |
| Avoid variables with short names like e | 139 |
| Avoid variables with short names like e | 139 |
| publicMethodCommentRequirement Required | 139–142 |
| Avoid using if statements without curly braces | 140–141 |
| Avoid variables with short names like e | 144 |
| publicMethodCommentRequirement Required | 144–147 |
| Avoid variables with short names like e | 144 |
| Avoid using if statements without curly braces | 145–146 |
| Avoid variables with short names like e | 149 |
| publicMethodCommentRequirement Required | 149–152 |
| Avoid variables with short names like e | 149 |
| Avoid using if statements without curly braces | 150–151 |
| headerCommentRequirement Required | 156–201 |
| fieldCommentRequirement Required | 157 |
| fieldCommentRequirement Required | 158 |
| publicMethodCommentRequirement Required | 160–164 |
| Avoid variables with short names like d | 160 |
| Avoid variables with short names like d | 160 |
| publicMethodCommentRequirement Required | 167–175 |
| Avoid variables with short names like i | 167 |
| Avoid variables with short names like i | 167 |
| Avoid using if statements without curly braces | 168–169 |
| Avoid empty catch blocks | 173–174 |
| publicMethodCommentRequirement Required | 178–193 |
| Avoid variables with short names like b | 178 |
| Avoid variables with short names like b | 178 |
| Avoid using if statements without curly braces | 179–180 |
| Avoid using if statements without curly braces | 182–183 |
| Avoid throwing null pointer exceptions. | 183 |
| Avoid using if statements without curly braces | 184–186 |
| Avoid empty catch blocks | 191–192 |
| publicMethodCommentRequirement Required | 196–199 |
| Assigning an Object to null is a code smell. Consider refactoring. | 197 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 28–128 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| Possible unsafe assignment to a non-final static field in a constructor. | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 39 |
| publicMethodCommentRequirement Required | 39–44 |
| Avoid unused constructor parameters such as 'args'. | 39 |
| Avoid variables with short names like p | 47 |
| publicMethodCommentRequirement Required | 47–55 |
| Avoid variables with short names like p | 47 |
| Avoid variables with short names like b | 57 |
| Avoid variables with short names like b | 57 |
| Avoid using if statements without curly braces | 61–62 |
| Avoid variables with short names like p | 107 |
| Avoid variables with short names like p | 107 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 116 |
| publicMethodCommentRequirement Required | 116–127 |
| Avoid empty catch blocks | 122–123 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 10–29 |
| fieldCommentRequirement Required | 12 |
| Perhaps 'dismiss' could be replaced by a local variable. | 13 |
| fieldCommentRequirement Required | 13 |
| publicMethodCommentRequirement Required | 15–28 |
| publicMethodCommentRequirement Required | 20–22 |
| Avoid variables with short names like e | 20 |
| Avoid variables with short names like e | 20 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 18–60 |
| fieldCommentRequirement Required | 19 |
| fieldCommentRequirement Required | 21 |
| Use explicit scoping instead of the default package private level | 21 |
| Use explicit scoping instead of the default package private level | 22 |
| fieldCommentRequirement Required | 22 |
| publicMethodCommentRequirement Required | 25–42 |
| Avoid variables with short names like p | 25 |
| Avoid variables with short names like p | 25 |
| publicMethodCommentRequirement Required | 35–37 |
| Avoid variables with short names like e | 35 |
| Avoid variables with short names like e | 35 |
| Avoid variables with short names like s | 44 |
| Avoid variables with short names like s | 44 |
| Found 'DD'-anomaly for variable 'editorPane' (lines '48'-'50'). | 48–50 |
| Avoid empty catch blocks | 54–55 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 14–78 |
| fieldCommentRequirement Required | 15 |
| fieldCommentRequirement Required | 16 |
| fieldCommentRequirement Required | 17 |
| publicMethodCommentRequirement Required | 19–24 |
| publicMethodCommentRequirement Required | 26–37 |
| Avoid variables with short names like p | 26 |
| Avoid variables with short names like p | 26 |
| Avoid variables with short names like i | 27 |
| Avoid variables with short names like i | 27 |
| publicMethodCommentRequirement Required | 29–32 |
| Avoid variables with short names like e | 29 |
| Avoid variables with short names like e | 29 |
| Avoid variables with short names like d | 30 |
| Avoid variables with short names like d | 30 |
| Avoid variables with short names like i | 44 |
| Avoid variables with short names like i | 44 |
| publicMethodCommentRequirement Required | 46–49 |
| Avoid variables with short names like e | 46 |
| Avoid variables with short names like e | 46 |
| Avoid variables with short names like d | 47 |
| Avoid variables with short names like d | 47 |
| Avoid variables with short names like e | 61 |
| publicMethodCommentRequirement Required | 61–63 |
| Avoid variables with short names like e | 61 |
| publicMethodCommentRequirement Required | 70–72 |
| Avoid variables with short names like e | 70 |
| Avoid variables with short names like e | 70 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 5–38 |
| Abstract classes should be named AbstractXXX | 5–38 |
| Abstract classes should be named AbstractXXX | 5–38 |
| fieldCommentRequirement Required | 7 |
| Variables that are final and static should be all capitals, 'helpFileLocation' is not all capitals. | 8 |
| fieldCommentRequirement Required | 8 |
| Variables that are final and static should be all capitals, 'helpFileLocation' is not all capitals. | 8 |
| fieldCommentRequirement Required | 10 |
| fieldCommentRequirement Required | 11 |
| publicMethodCommentRequirement Required | 13 |
| protectedMethodCommentRequirement Required | 15 |
| protectedMethodCommentRequirement Required | 17 |
| Avoid variables with short names like s | 19 |
| publicMethodCommentRequirement Required | 19–27 |
| Avoid variables with short names like s | 19 |
| Avoid variables with short names like i | 25 |
| Avoid variables with short names like i | 25 |
| publicMethodCommentRequirement Required | 30–32 |
| publicMethodCommentRequirement Required | 35–37 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 4–26 |
| headerCommentRequirement Required | 4–26 |
| Abstract classes should be named AbstractXXX | 4–26 |
| fieldCommentRequirement Required | 6 |
| Avoid using short method names | 8 |
| Avoid using short method names | 8 |
| protectedMethodCommentRequirement Required | 8 |
| publicMethodCommentRequirement Required | 10–12 |
| Avoid variables with short names like s | 10 |
| Avoid variables with short names like s | 10 |
| protectedMethodCommentRequirement Required | 14–25 |
| Avoid variables with short names like p | 15 |
| Avoid variables with short names like p | 15 |
| publicMethodCommentRequirement Required | 17–21 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 7–22 |
| Abstract classes should be named AbstractXXX | 7–22 |
| headerCommentRequirement Required | 7–22 |
| fieldCommentRequirement Required | 9 |
| publicMethodCommentRequirement Required | 11 |
| publicMethodCommentRequirement Required | 13–21 |
| Avoid variables with short names like s | 13 |
| Avoid variables with short names like s | 13 |
| Avoid variables with short names like e | 17 |
| publicMethodCommentRequirement Required | 17–19 |
| Avoid variables with short names like e | 17 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 19–85 |
| fieldCommentRequirement Required | 21 |
| Avoid variables with short names like ug | 22 |
| Use explicit scoping instead of the default package private level | 22 |
| Avoid variables with short names like ug | 22 |
| fieldCommentRequirement Required | 22 |
| fieldCommentRequirement Required | 23 |
| Use explicit scoping instead of the default package private level | 23 |
| Avoid excessively long variable names like upgradeDescription | 24 |
| fieldCommentRequirement Required | 24 |
| Use explicit scoping instead of the default package private level | 24 |
| Avoid excessively long variable names like upgradeDescription | 24 |
| Use explicit scoping instead of the default package private level | 25 |
| fieldCommentRequirement Required | 25 |
| publicMethodCommentRequirement Required | 27–29 |
| protectedMethodCommentRequirement Required | 32–53 |
| protectedMethodCommentRequirement Required | 56–72 |
| publicMethodCommentRequirement Required | 68–70 |
| Avoid variables with short names like e | 68 |
| Avoid variables with short names like e | 68 |
| protectedMethodCommentRequirement Required | 75–79 |
| Avoid using short method names | 75 |
| Avoid using short method names | 75 |
| publicMethodCommentRequirement Required | 82–84 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 27–214 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| fieldCommentRequirement Required | 31 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 31 |
| Avoid excessively long variable names like DEFAULT_CHUNK_SIZE | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| fieldCommentRequirement Required | 37 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| publicMethodCommentRequirement Required | 44–46 |
| protectedMethodCommentRequirement Required | 49–83 |
| protectedMethodCommentRequirement Required | 86–120 |
| Local variable 'dateF' could be declared final | 87 |
| When instantiating a SimpleDateFormat object, specify a Locale | 87 |
| Avoid variables with short names like e | 116 |
| publicMethodCommentRequirement Required | 116–118 |
| Avoid variables with short names like e | 116 |
| protectedMethodCommentRequirement Required | 123–161 |
| Avoid using short method names | 123 |
| Avoid using short method names | 123 |
| Avoid variables with short names like cs | 131 |
| Avoid variables with short names like cs | 131 |
| Found 'DD'-anomaly for variable 'cs' (lines '133'-'135'). | 133–135 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 134 |
| Avoid variables with short names like wt | 138 |
| Avoid variables with short names like wt | 138 |
| Found 'DD'-anomaly for variable 'wt' (lines '140'-'142'). | 140–142 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 141 |
| Found 'DU'-anomaly for variable 'wt' (lines '142'-'161'). | 142–161 |
| Avoid variables with short names like d | 146 |
| Avoid variables with short names like d | 146 |
| System.out.println is used | 150 |
| Avoid using if...else statements without curly braces | 152 |
| Avoid using if...else statements without curly braces | 154 |
| Avoid empty catch blocks | 155–156 |
| System.out.println is used | 158 |
| publicMethodCommentRequirement Required | 164–166 |
| headerCommentRequirement Required | 168–185 |
| fieldCommentRequirement Required | 169 |
| Use explicit scoping instead of the default package private level | 169 |
| fieldCommentRequirement Required | 170 |
| Use explicit scoping instead of the default package private level | 170 |
| Avoid variables with short names like t | 172 |
| Avoid variables with short names like v | 172 |
| Avoid variables with short names like v | 172 |
| publicMethodCommentRequirement Required | 172–175 |
| Avoid variables with short names like t | 172 |
| publicMethodCommentRequirement Required | 178–180 |
| publicMethodCommentRequirement Required | 182–184 |
| headerCommentRequirement Required | 187–213 |
| fieldCommentRequirement Required | 189 |
| Use explicit scoping instead of the default package private level | 189 |
| Avoid variables with short names like f | 189 |
| Avoid variables with short names like f | 189 |
| Avoid variables with short names like f | 191 |
| Avoid variables with short names like f | 191 |
| publicMethodCommentRequirement Required | 191–193 |
| Avoid variables with short names like e | 195 |
| publicMethodCommentRequirement Required | 195–197 |
| Avoid variables with short names like e | 195 |
| Avoid variables with short names like e | 199 |
| Avoid variables with short names like e | 199 |
| publicMethodCommentRequirement Required | 199–201 |
| Avoid variables with short names like e | 203 |
| Avoid variables with short names like e | 203 |
| Document empty method body | 203 |
| publicMethodCommentRequirement Required | 203 |
| A method should have only one exit point, and that should be the last statement in the method | 208 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 22–105 |
| fieldCommentRequirement Required | 24 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| enumCommentRequirement Required | 31–52 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| publicMethodCommentRequirement Required | 44–46 |
| publicMethodCommentRequirement Required | 48–50 |
| publicMethodCommentRequirement Required | 54–56 |
| protectedMethodCommentRequirement Required | 59–76 |
| protectedMethodCommentRequirement Required | 79–92 |
| An empty statement (semicolon) not part of a loop | 83 |
| Avoid variables with short names like e | 87 |
| publicMethodCommentRequirement Required | 87–89 |
| Avoid variables with short names like e | 87 |
| Avoid using short method names | 95 |
| protectedMethodCommentRequirement Required | 95–98 |
| Avoid using short method names | 95 |
| publicMethodCommentRequirement Required | 101–103 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 26–114 |
| fieldCommentRequirement Required | 28 |
| Avoid variables with short names like is | 29 |
| fieldCommentRequirement Required | 29 |
| Avoid variables with short names like is | 29 |
| Perhaps 'is' could be replaced by a local variable. | 29 |
| fieldCommentRequirement Required | 31 |
| fieldCommentRequirement Required | 32 |
| fieldCommentRequirement Required | 33 |
| fieldCommentRequirement Required | 34 |
| fieldCommentRequirement Required | 35 |
| publicMethodCommentRequirement Required | 37–39 |
| protectedMethodCommentRequirement Required | 42–67 |
| protectedMethodCommentRequirement Required | 70–84 |
| Avoid variables with short names like e | 80 |
| publicMethodCommentRequirement Required | 80–82 |
| Avoid variables with short names like e | 80 |
| Avoid using short method names | 87 |
| protectedMethodCommentRequirement Required | 87–107 |
| Avoid using short method names | 87 |
| Avoid variables with short names like as | 89 |
| Avoid variables with short names like as | 89 |
| This call to Collection.toArray() may be optimizable | 101 |
| publicMethodCommentRequirement Required | 110–112 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 23–92 |
| fieldCommentRequirement Required | 25 |
| fieldCommentRequirement Required | 26 |
| Use explicit scoping instead of the default package private level | 26 |
| Avoid variables with short names like is | 26 |
| Avoid variables with short names like is | 26 |
| fieldCommentRequirement Required | 27 |
| fieldCommentRequirement Required | 28 |
| fieldCommentRequirement Required | 29 |
| fieldCommentRequirement Required | 30 |
| publicMethodCommentRequirement Required | 32–34 |
| protectedMethodCommentRequirement Required | 37–60 |
| protectedMethodCommentRequirement Required | 63–75 |
| Avoid variables with short names like e | 71 |
| Avoid variables with short names like e | 71 |
| publicMethodCommentRequirement Required | 71–73 |
| Avoid using short method names | 78 |
| protectedMethodCommentRequirement Required | 78–86 |
| Avoid using short method names | 78 |
| Avoid variables with short names like f | 83 |
| Avoid variables with short names like f | 83 |
| publicMethodCommentRequirement Required | 89–91 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 33–277 |
| fieldCommentRequirement Required | 35 |
| fieldCommentRequirement Required | 36 |
| Avoid variables with short names like ws | 38 |
| Avoid variables with short names like ws | 38 |
| fieldCommentRequirement Required | 38 |
| fieldCommentRequirement Required | 39 |
| fieldCommentRequirement Required | 40 |
| fieldCommentRequirement Required | 41 |
| fieldCommentRequirement Required | 42 |
| fieldCommentRequirement Required | 43 |
| fieldCommentRequirement Required | 44 |
| fieldCommentRequirement Required | 45 |
| fieldCommentRequirement Required | 46 |
| fieldCommentRequirement Required | 47 |
| fieldCommentRequirement Required | 48 |
| fieldCommentRequirement Required | 49 |
| fieldCommentRequirement Required | 50 |
| fieldCommentRequirement Required | 51 |
| publicMethodCommentRequirement Required | 53–55 |
| protectedMethodCommentRequirement Required | 58–99 |
| protectedMethodCommentRequirement Required | 102–156 |
| Local variable 'dateF' could be declared final | 126 |
| When instantiating a SimpleDateFormat object, specify a Locale | 126 |
| publicMethodCommentRequirement Required | 152–154 |
| Avoid variables with short names like e | 152 |
| Avoid variables with short names like e | 152 |
| Avoid using short method names | 159 |
| Avoid using short method names | 159 |
| protectedMethodCommentRequirement Required | 159–189 |
| Avoid variables with short names like s | 160 |
| Avoid variables with short names like s | 160 |
| Useless parentheses. | 170 |
| publicMethodCommentRequirement Required | 193–195 |
| publicMethodCommentRequirement Required | 199–201 |
| Avoid variables with short names like s | 204 |
| Avoid variables with short names like s | 204 |
| Local variable 'dateF' could be declared final | 205 |
| When instantiating a SimpleDateFormat object, specify a Locale | 205 |
| Found 'DU'-anomaly for variable 'dateF' (lines '205'-'214'). | 205–214 |
| Avoid using if...else statements without curly braces | 207 |
| Prefer StringBuffer over += for concatenating strings | 210 |
| headerCommentRequirement Required | 216–233 |
| Use explicit scoping instead of the default package private level | 217 |
| fieldCommentRequirement Required | 217 |
| fieldCommentRequirement Required | 218 |
| Use explicit scoping instead of the default package private level | 218 |
| publicMethodCommentRequirement Required | 220–223 |
| Avoid variables with short names like t | 220 |
| Avoid variables with short names like v | 220 |
| Avoid variables with short names like t | 220 |
| Avoid variables with short names like v | 220 |
| publicMethodCommentRequirement Required | 226–228 |
| publicMethodCommentRequirement Required | 230–232 |
| headerCommentRequirement Required | 235–248 |
| Use explicit scoping instead of the default package private level | 237 |
| Avoid variables with short names like b | 237 |
| Avoid variables with short names like b | 237 |
| fieldCommentRequirement Required | 237 |
| Avoid variables with short names like b | 239 |
| Avoid variables with short names like b | 239 |
| publicMethodCommentRequirement Required | 243–245 |
| Avoid variables with short names like e | 243 |
| Avoid variables with short names like e | 243 |
| Avoid variables with short names like e | 247 |
| Avoid variables with short names like e | 247 |
| Document empty method body | 247 |
| publicMethodCommentRequirement Required | 247 |
| headerCommentRequirement Required | 250–276 |
| Avoid variables with short names like f | 252 |
| fieldCommentRequirement Required | 252 |
| Use explicit scoping instead of the default package private level | 252 |
| Avoid variables with short names like f | 252 |
| Avoid variables with short names like f | 254 |
| Avoid variables with short names like f | 254 |
| publicMethodCommentRequirement Required | 254–256 |
| publicMethodCommentRequirement Required | 258–260 |
| Avoid variables with short names like e | 258 |
| Avoid variables with short names like e | 258 |
| Avoid variables with short names like e | 262 |
| publicMethodCommentRequirement Required | 262–264 |
| Avoid variables with short names like e | 262 |
| Document empty method body | 266 |
| Avoid variables with short names like e | 266 |
| Avoid variables with short names like e | 266 |
| publicMethodCommentRequirement Required | 266 |
| A method should have only one exit point, and that should be the last statement in the method | 271 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 42–53 |
| Each class should declare at least one constructor | 42–53 |
| Avoid variables with short names like e | 43 |
| publicMethodCommentRequirement Required | 43–52 |
| Avoid variables with short names like e | 43 |
| Avoid variables with short names like sn | 44 |
| Avoid variables with short names like sn | 44 |
| Avoid variables with short names like i | 45 |
| Avoid variables with short names like i | 45 |
| Prefer StringBuffer over += for concatenating strings | 50 |
| headerCommentRequirement Required | 54–80 |
| Use explicit scoping instead of the default package private level | 56 |
| Avoid variables with short names like f | 56 |
| fieldCommentRequirement Required | 56 |
| Avoid variables with short names like f | 56 |
| Avoid variables with short names like f | 58 |
| publicMethodCommentRequirement Required | 58–60 |
| Avoid variables with short names like f | 58 |
| Avoid variables with short names like e | 62 |
| Document empty method body | 62 |
| publicMethodCommentRequirement Required | 62 |
| Avoid variables with short names like e | 62 |
| Avoid variables with short names like e | 64 |
| Avoid variables with short names like e | 64 |
| publicMethodCommentRequirement Required | 64–66 |
| Avoid variables with short names like e | 68 |
| Avoid variables with short names like e | 68 |
| publicMethodCommentRequirement Required | 68–70 |
| A method should have only one exit point, and that should be the last statement in the method | 75 |
| headerCommentRequirement Required | 82–99 |
| fieldCommentRequirement Required | 83 |
| Use explicit scoping instead of the default package private level | 83 |
| fieldCommentRequirement Required | 84 |
| Use explicit scoping instead of the default package private level | 84 |
| Avoid variables with short names like t | 86 |
| publicMethodCommentRequirement Required | 86–89 |
| Avoid variables with short names like v | 86 |
| Avoid variables with short names like v | 86 |
| Avoid variables with short names like t | 86 |
| publicMethodCommentRequirement Required | 91–93 |
| publicMethodCommentRequirement Required | 96–98 |
| Variables that are final and static should be all capitals, 'chunkValues' is not all capitals. | 101 |
| Variables that are final and static should be all capitals, 'chunkValues' is not all capitals. | 101 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 101 |
| fieldCommentRequirement Required | 101 |
| fieldCommentRequirement Required | 103 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 103 |
| fieldCommentRequirement Required | 104 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 104 |
| fieldCommentRequirement Required | 106 |
| Avoid excessively long variable names like DEFAULT_CLIP_VALUE | 106 |
| Avoid excessively long variable names like DEFAULT_CLIP_VALUE | 106 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 106 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 107 |
| fieldCommentRequirement Required | 107 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 108 |
| fieldCommentRequirement Required | 108 |
| fieldCommentRequirement Required | 109 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 109 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 111 |
| fieldCommentRequirement Required | 111 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 112 |
| fieldCommentRequirement Required | 112 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 114 |
| fieldCommentRequirement Required | 114 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 115 |
| fieldCommentRequirement Required | 115 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 116 |
| fieldCommentRequirement Required | 116 |
| Variables that are final and static should be all capitals, 'spanValues' is not all capitals. | 117 |
| fieldCommentRequirement Required | 117–118 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 117–118 |
| Variables that are final and static should be all capitals, 'spanValues' is not all capitals. | 117 |
| fieldCommentRequirement Required | 119 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 119 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 120 |
| fieldCommentRequirement Required | 120 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 121 |
| fieldCommentRequirement Required | 121 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 122 |
| fieldCommentRequirement Required | 122 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 123 |
| fieldCommentRequirement Required | 123 |
| fieldCommentRequirement Required | 124 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 124 |
| fieldCommentRequirement Required | 125 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 125 |
| fieldCommentRequirement Required | 126 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 126 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 127 |
| fieldCommentRequirement Required | 127 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 128 |
| fieldCommentRequirement Required | 128 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 129 |
| fieldCommentRequirement Required | 129 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 130 |
| fieldCommentRequirement Required | 130 |
| fieldCommentRequirement Required | 131 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 131 |
| fieldCommentRequirement Required | 132 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 132 |
| fieldCommentRequirement Required | 135 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 135 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 137 |
| fieldCommentRequirement Required | 137 |
| fieldCommentRequirement Required | 139 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 139 |
| publicMethodCommentRequirement Required | 141–143 |
| Found 'UR'-anomaly for variable 'ft' (lines '146'-'165'). | 146–165 |
| Found 'UR'-anomaly for variable 'ft' (lines '146'-'165'). | 146–165 |
| Found 'UR'-anomaly for variable 'ft' (lines '146'-'165'). | 146–165 |
| protectedMethodCommentRequirement Required | 146–229 |
| When instantiating a SimpleDateFormat object, specify a Locale | 156 |
| Local variable 'dateF' could be declared final | 156 |
| Avoid variables with short names like b | 165 |
| Avoid instantiating new objects inside loops | 165 |
| Avoid variables with short names like b | 165 |
| Avoid instantiating new objects inside loops | 166 |
| Use equals() to compare object references. | 170 |
| Do not add empty strings | 180 |
| Do not add empty strings | 184 |
| Do not add empty strings | 188 |
| Do not add empty strings | 192 |
| Do not add empty strings | 200 |
| Do not add empty strings | 202 |
| Avoid variables with short names like e | 213 |
| publicMethodCommentRequirement Required | 213–215 |
| Avoid variables with short names like e | 213 |
| publicMethodCommentRequirement Required | 224–226 |
| Avoid variables with short names like e | 224 |
| Avoid variables with short names like e | 224 |
| protectedMethodCommentRequirement Required | 232–276 |
| Avoid using short method names | 279 |
| protectedMethodCommentRequirement Required | 279–337 |
| Avoid using short method names | 279 |
| When instantiating a SimpleDateFormat object, specify a Locale | 287 |
| Found 'DD'-anomaly for variable 'date' (lines '288'-'290'). | 288–290 |
| Avoid printStackTrace(); use a logger call instead. | 292 |
| Do not add empty strings | 311 |
| Do not add empty strings | 329 |
| This call to Collection.toArray() may be optimizable | 333 |
| System.out.println is used | 334 |
| publicMethodCommentRequirement Required | 340–342 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 37–75 |
| fieldCommentRequirement Required | 39 |
| publicMethodCommentRequirement Required | 41–60 |
| publicMethodCommentRequirement Required | 48–50 |
| Document empty method body | 53 |
| Avoid variables with short names like e | 53 |
| Avoid variables with short names like e | 53 |
| publicMethodCommentRequirement Required | 53 |
| Avoid variables with short names like e | 55 |
| Avoid variables with short names like e | 55 |
| publicMethodCommentRequirement Required | 55–57 |
| Avoid variables with short names like o | 62 |
| publicMethodCommentRequirement Required | 62–66 |
| Avoid variables with short names like o | 62 |
| Avoid variables with short names like d | 63 |
| Avoid variables with short names like d | 63 |
| Avoid variables with short names like s | 68 |
| Avoid variables with short names like s | 68 |
| publicMethodCommentRequirement Required | 68–74 |
| headerCommentRequirement Required | 76–114 |
| fieldCommentRequirement Required | 78 |
| publicMethodCommentRequirement Required | 80–97 |
| publicMethodCommentRequirement Required | 86–88 |
| Avoid variables with short names like e | 91 |
| Document empty method body | 91 |
| Avoid variables with short names like e | 91 |
| publicMethodCommentRequirement Required | 91 |
| Avoid variables with short names like e | 93 |
| Avoid variables with short names like e | 93 |
| publicMethodCommentRequirement Required | 93–95 |
| Avoid variables with short names like o | 99 |
| publicMethodCommentRequirement Required | 99–102 |
| Avoid variables with short names like o | 99 |
| Do not add empty strings | 100 |
| publicMethodCommentRequirement Required | 104–113 |
| Avoid variables with short names like s | 104 |
| Avoid variables with short names like s | 104 |
| Local variable 'dateF' could be declared final | 105 |
| When instantiating a SimpleDateFormat object, specify a Locale | 105 |
| Avoid variables with short names like d | 106 |
| Avoid variables with short names like d | 106 |
| headerCommentRequirement Required | 115–155 |
| fieldCommentRequirement Required | 117 |
| publicMethodCommentRequirement Required | 119–138 |
| publicMethodCommentRequirement Required | 125–127 |
| publicMethodCommentRequirement Required | 130 |
| Document empty method body | 130 |
| Avoid variables with short names like e | 130 |
| Avoid variables with short names like e | 130 |
| publicMethodCommentRequirement Required | 132–134 |
| Avoid variables with short names like e | 132 |
| Avoid variables with short names like e | 132 |
| Avoid variables with short names like o | 140 |
| Avoid variables with short names like o | 140 |
| publicMethodCommentRequirement Required | 140–144 |
| Avoid variables with short names like d | 141 |
| Avoid variables with short names like d | 141 |
| Avoid variables with short names like s | 146 |
| publicMethodCommentRequirement Required | 146–153 |
| Avoid variables with short names like s | 146 |
| headerCommentRequirement Required | 156–192 |
| fieldCommentRequirement Required | 158 |
| publicMethodCommentRequirement Required | 160–177 |
| publicMethodCommentRequirement Required | 165–167 |
| publicMethodCommentRequirement Required | 170 |
| Document empty method body | 170 |
| Avoid variables with short names like e | 170 |
| Avoid variables with short names like e | 170 |
| Avoid variables with short names like e | 172 |
| publicMethodCommentRequirement Required | 172–174 |
| Avoid variables with short names like e | 172 |
| Avoid variables with short names like o | 179 |
| publicMethodCommentRequirement Required | 179–182 |
| Avoid variables with short names like o | 179 |
| Do not add empty strings | 180 |
| publicMethodCommentRequirement Required | 184–191 |
| Avoid variables with short names like s | 184 |
| Avoid variables with short names like s | 184 |
| When instantiating a SimpleDateFormat object, specify a Locale | 185 |
| Local variable 'dateF' could be declared final | 185 |
| Avoid empty catch blocks | 189–190 |
| headerCommentRequirement Required | 194–228 |
| fieldCommentRequirement Required | 196 |
| Use explicit scoping instead of the default package private level | 196 |
| publicMethodCommentRequirement Required | 198–200 |
| It is a good practice to call super() in a constructor | 198–200 |
| Overridable method 'setDate' called during object construction | 199 |
| publicMethodCommentRequirement Required | 203–205 |
| Unnecessary use of fully qualified name 'gov.usgs.volcanoes.core.time.Ew.fromEpoch' due to existing import 'gov.usgs.volcanoes.core.time.Ew' | 204 |
| publicMethodCommentRequirement Required | 207–209 |
| publicMethodCommentRequirement Required | 211–213 |
| publicMethodCommentRequirement Required | 215–217 |
| publicMethodCommentRequirement Required | 219–221 |
| Avoid variables with short names like d | 223 |
| Avoid variables with short names like d | 223 |
| publicMethodCommentRequirement Required | 223–227 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 230 |
| fieldCommentRequirement Required | 230 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 231 |
| fieldCommentRequirement Required | 231 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 232 |
| Variables that are final and static should be all capitals, 'timeFormatter' is not all capitals. | 232 |
| Variables that are final and static should be all capitals, 'timeFormatter' is not all capitals. | 232 |
| fieldCommentRequirement Required | 232 |
| fieldCommentRequirement Required | 233 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 233 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 234 |
| fieldCommentRequirement Required | 234 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 236 |
| fieldCommentRequirement Required | 236 |
| fieldCommentRequirement Required | 238 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 238 |
| fieldCommentRequirement Required | 240 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 240 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 242 |
| fieldCommentRequirement Required | 242 |
| Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 244 |
| fieldCommentRequirement Required | 244 |
| publicMethodCommentRequirement Required | 246–248 |
| protectedMethodCommentRequirement Required | 251–268 |
| Avoid variables with short names like e | 264 |
| Avoid variables with short names like e | 264 |
| publicMethodCommentRequirement Required | 264–266 |
| protectedMethodCommentRequirement Required | 271–293 |
| publicMethodCommentRequirement Required | 296–298 |
| Violation | Line |
|---|---|
| headerCommentRequirement Required | 20–86 |
| fieldCommentRequirement Required | 22 |
| Use explicit scoping instead of the default package private level | 23 |
| Avoid variables with short names like ug | 23 |
| Avoid variables with short names like ug | 23 |
| fieldCommentRequirement Required | 23 |
| Use explicit scoping instead of the default package private level | 24 |
| fieldCommentRequirement Required | 24 |
| Avoid excessively long variable names like upgradeDescription | 25 |
| Use explicit scoping instead of the default package private level | 25 |
| Avoid excessively long variable names like upgradeDescription | 25 |
| fieldCommentRequirement Required | 25 |
| Use explicit scoping instead of the default package private level | 26 |
| fieldCommentRequirement Required | 26 |
| publicMethodCommentRequirement Required | 28–30 |
| protectedMethodCommentRequirement Required | 33–54 |
| protectedMethodCommentRequirement Required | 57–73 |
| Avoid variables with short names like e | 69 |
| Avoid variables with short names like e | 69 |
| publicMethodCommentRequirement Required | 69–71 |
| Avoid using short method names | 76 |
| protectedMethodCommentRequirement Required | 76–80 |
| Avoid using short method names | 76 |
| publicMethodCommentRequirement Required | 83–85 |
